Re: Syntax coloring mystery solved!!

2017-01-15 Thread 'Terry Brown' via leo-editor
On Sun, 15 Jan 2017 06:18:53 -0500 "Edward K. Ream" wrote: > Terry, please test this branch for a day or so and report any > problems. I'll follow this with interest on my travels. If all seem > well, feel free to merge the branch. Initial look I'm not seeing anything but

Re: Syntax coloring mystery solved!!

2017-01-15 Thread Edward K. Ream
On Sat, Jan 14, 2017 at 11:52 PM, 'Terry Brown' via leo-editor < leo-editor@googlegroups.com> wrote: Branch is there in the correct place. > ​Thanks for the confirmation.​ ​Rev 0a2a983 fixes all known colorizer bugs, and rev fa3d41e is a bit of make-work while eating my own dog food. Terry,

Re: Syntax coloring mystery solved!!

2017-01-14 Thread 'Terry Brown' via leo-editor
On Sat, 14 Jan 2017 18:22:26 -0800 (PST) "Edward K. Ream" wrote: > Done, and pushed, I think. It's called fast-colorizing, rev > 2beba78b5. Let me know if the branch doesn't show up. This is my > first branch... Branch is there in the correct place. Safe travels. Cheers

Re: Syntax coloring mystery solved!!

2017-01-14 Thread Edward K. Ream
On Saturday, January 14, 2017 at 9:01:37 PM UTC-5, Edward K. Ream wrote: Rebecca and I are leaving tomorrow for Madison. We will be on the road > about a week. I would like to up what I have for reference, but I > probably can't in the trunk. Time to create a branch :-) > Done, and pushed, I

Re: Syntax coloring mystery solved!!

2017-01-14 Thread Edward K. Ream
On Saturday, January 14, 2017 at 9:52:59 AM UTC-5, Edward K. Ream wrote: > > On Sat, Jan 14, 2017 at 7:23 AM, Edward K. Ream > wrote: > > ​> ​ > Calling QTextDocument.markContentsDirty > ​ ​ > ​[in the legacy code]​ > does not cause a recoloring. > > ​Hurray! Counts show

Re: Syntax coloring mystery solved!!

2017-01-14 Thread Edward K. Ream
On Sat, Jan 14, 2017 at 7:23 AM, Edward K. Ream wrote: ​> ​ Calling QTextDocument.markContentsDirty ​ ​ ​[in the legacy code]​ does not cause a recoloring. ​Hurray! Counts show that leo_h.highlightBlock *is* being called the expected number of times. But nothing happens. A

Re: Syntax coloring mystery solved!!

2017-01-14 Thread Edward K. Ream
​​ ​​ On Fri, Jan 13, 2017 at 5:25 PM, 'Terry Brown' via leo-editor < leo-editor@googlegroups.com> wrote: ​> ​ Congrats on finding the culprit. ​Thank you. ​ ​Strangely, the performance bug *remain*s (sometimes) in the legacy coloring code. I allude to this in this morning's announcement

Re: Syntax coloring mystery solved!!

2017-01-13 Thread 'Terry Brown' via leo-editor
code, some time ago, and really can't remember the details.  So don't know if this is hard or trivial. Cheers -Terry From: Edward K. Ream <edream...@gmail.com> To: leo-editor <leo-editor@googlegroups.com> Sent: Friday, January 13, 2017 12:23 PM Subject: Syntax coloring my

Syntax coloring mystery solved!!

2017-01-13 Thread Edward K. Ream
*tl;dr:* Calling doc.markContentsDirty(0, len(p.b)) suffices to recolor a node! This should be done *instead of* calling highlighter.rehighlight explicitly. I could never have found this bug if I hadn't seen how fast pyzo colorizing code was within pyzo itself compared to the *same* code