Re: launching unit tests

2017-11-26 Thread Edward K. Ream
On Thursday, November 16, 2017 at 10:14:58 AM UTC-6, Edward K. Ream wrote: > > On Wed, Nov 15, 2017 at 10:51 AM, Terry Brown > wrote: > > ​​ >> for example a test of paragraph rejustification might be easier to >> write if you didn't have to account for different user

Re: launching unit tests

2017-11-16 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 10:51 AM, Terry Brown wrote: ​​ > for example a test of paragraph rejustification might be easier to > write if you didn't have to account for different user preferences on > text width - that sort of thing. > ​I agree​. Happily, there is a

Re: launching unit tests

2017-11-15 Thread Terry Brown
On Wed, 15 Nov 2017 08:52:43 -0600 "Edward K. Ream" wrote: > ​Afaik, all tests run regardless of personal settings.  Let me know > if that isn't true for a particular test. Well it's definitely not true for some values of the the @enabled-plugins setting - but of course

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 8:13 AM, Terry Brown wrote: > On Wed, 15 Nov 2017 08:02:37 -0600 > "Edward K. Ream" wrote: > > > Sounds like this is all fixed now, but I wonder if the failure you > > were seeing implies that you run the unit tests with your

Re: launching unit tests

2017-11-15 Thread Terry Brown
On Wed, 15 Nov 2017 08:02:37 -0600 "Edward K. Ream" wrote: > Sounds like this is all fixed now, but I wonder if the failure you > were seeing implies that you run the unit tests with your personal > myLeoSettings in effect and if it would be better to run them without >

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 7:34 AM, Terry Brown wrote: Sounds like this is all fixed now, but I wonder if the failure you were > seeing implies that you run the unit tests with your personal > myLeoSettings in effect and if it would be better to run them without > that? >

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wednesday, November 15, 2017 at 6:57:17 AM UTC-6, Edward K. Ream wrote: This uses the new gcm.myLeoSettingsValueOfSetting method. > I've changed the name to valueInMyLeoSettings so that it sounds like it was named by a native speaker of English ;-) Edward -- You received this message

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 6:09 AM, Edward K. Ream wrote: ​Rev 0f03006 carefully checks the value of @bool scripting-at-script-nodes in myLeoSettings.leo and restores that value after issuing the security warning. This uses the new gcm.myLeoSettingsValueOfSetting method. As

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 5:47 AM, Edward K. Ream wrote: > On Sun, Nov 12, 2017 at 11:47 AM, Terry Brown > wrote: > > > As you say, enabling @script nodes in unitTest.leo is intended to >> > generate a warning. >> >> Sure, but it could do that without

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Sun, Nov 12, 2017 at 11:47 AM, Terry Brown wrote: > As you say, enabling @script nodes in unitTest.leo is intended to > > generate a warning. > > Sure, but it could do that without overriding the setting in > myLeoSettings.leo. Currently it seems that setting it True

Re: launching unit tests

2017-11-12 Thread Terry Brown
On Sun, 12 Nov 2017 11:17:18 -0600 "Edward K. Ream" wrote: > As you say, enabling @script nodes in unitTest.leo is intended to > generate a warning. Sure, but it could do that without overriding the setting in myLeoSettings.leo. Currently it seems that setting it True in

Re: launching unit tests

2017-11-12 Thread Edward K. Ream
On Sun, Nov 12, 2017 at 9:59 AM, Terry Brown wrote: So with one of those two options I think there's a much more > automateable / less intrusive way to run tests, at least on > multi-tasking OSes like Linux where a VNC server doesn't take over the > only display ;-) > ​We

Re: launching unit tests

2017-11-12 Thread Edward K. Ream
On Sun, Nov 12, 2017 at 8:20 AM, Terry Brown wrote: > I guess I'm dubious about how this tests anything other than the string / > null gui. > ​As you say, using the string gui won't test everything. However, it should test a lot. The string gui should emulate *all* of

Re: launching unit tests

2017-11-12 Thread Terry Brown
I tried this script using --script: path = g.os_path_join(g.computeLeoDir(), 'tests', 'unitTest.leo') c2 = g.openWithFileName(path) c2.k.simulateCommand("run-selected-unit-tests-locally") but it doesn't work because --script runs with the dummy gui. This @script node in unitTests.leo

Re: launching unit tests

2017-11-12 Thread Terry Brown
I guess I'm dubious about how this tests anything other than the string / null gui. For instance edit pane code will probably just not load in a non-gui context. So any breakage it causes to the test of the Qt gui will go unseen. I'll look into --script, but if course windowless VNC only works

Re: launching unit tests

2017-11-12 Thread Edward K. Ream
On Sat, Nov 11, 2017 at 12:41 PM, Terry Brown wrote: > One impediment to routinely running unit tests is that they seem to be > render your computer unusable for the time they take to run. ​As I've just said in another thread, I think this is an important issue. I am

Re: launching unit tests

2017-11-11 Thread Edward K. Ream
On Saturday, November 11, 2017 at 12:41:34 PM UTC-6, Terry Brown wrote: > > One impediment to routinely running unit tests is that they seem to be > render your computer unusable for the time they take to run. True, but that shouldn't be a good enough excuse for not running unit tests. #503:

launching unit tests

2017-11-11 Thread Terry Brown
One impediment to routinely running unit tests is that they seem to be render your computer unusable for the time they take to run. Even when I have enough screen real-estate to run them out the way, I'm worried they'll grab focus while I'm working on something else and (a) I'll cause a test to