Re: tree icons

On Thu, Mar 22, 2018 at 5:22 PM, Edward K. Ream wrote: Arrrgh. The present code does not handle --theme correctly, nor does it > handle double-clicking, say, > ​​ > BreezeDarkTheme.leo. The stylesheet is computed correctly, but not the > icons (in general). > ​Oh joy.

Re: tree icons

On Thu, 22 Mar 2018 15:22:50 -0700 (PDT) "Edward K. Ream" wrote: > Arrrgh. The present code does not handle --theme correctly, nor does > it handle double-clicking, say, BreezeDarkTheme.leo. The stylesheet > is computed correctly, but not the icons (in general). Instead, >

Re: tree icons

On Thursday, March 22, 2018 at 1:23:34 PM UTC-5, Edward K. Ream wrote: Imo, the only safe thing to do is to to add *both *getString('theme-name') > and getString('color-theme') to the theme paths. That shouldn't cause > problems, because in practice only one of these sets of directories will

Re: tree icons

On Thu, Mar 22, 2018 at 12:53 PM, Terry Brown wrote: appendImageDictToList() in qt_tree.py needs re-education. > ​I agree with your suggestion to revise the calling sequence. Changing the API will likely have no consequences. Edward -- You received this message because

Re: tree icons

On Thursday, March 22, 2018 at 12:40:04 PM UTC-5, Terry Brown wrote: > > On Thu, 22 Mar 2018 11:49:36 -0500 > "Edward K. Ream" wrote: > > > 2. Terry's code uses g.os_path_join instead of > > g.os_path_finalize_join. The differences are obscure. Terry, does > > the code

Re: tree icons

appendImageDictToList() in qt_tree.py needs re-education. It takes an icon dir. computed by the client and tacks the clients requested icon path on to it. So it's working in the declutter code, because the icon path comes from g.app.gui.getImageFinder() and so is absolute so the icon dir.

Re: tree icons

On Thu, 22 Mar 2018 11:49:36 -0500 "Edward K. Ream" wrote: > 2. Terry's code uses g.os_path_join instead of > g.os_path_finalize_join. The differences are obscure. Terry, does > the code work for you using g.os_path_finalize_join? Results are the same. > 4. The most

Re: tree icons

On Thu, Mar 22, 2018 at 11:48 AM, Xavier G. Domingo (xgid) < xgdomi...@gmail.com> wrote: ... the "home" variable is pointing to "g.app.*homeLeoDir*" > ​Good catch. Rev 81fb131 fixes this.​ ​I fixed this blunder yesterday in several other places, but not this one. Edward. -- You received

Re: tree icons

On Thu, Mar 22, 2018 at 11:25 AM, Edward K. Ream wrote: This code finds the right icons: >> https://gist.github.com/tbnorth/4dab3ef67060731024b44b772feb0f0a >> >> But I'm sure I'm missing something ;-) >> > ​Rev 77d0be5 uses Terry's code in qt_gui.getImageFinder. To repeat,

Re: tree icons

On Thursday, March 22, 2018 at 12:21:08 PM UTC-3, Terry Brown wrote: > > Yep, now I've worked with it a bit more it's definitely not finding the > same icons, and using light versions of icons used by the todo plugin > for example. So really it just looked somewhat better because it was >

Re: tree icons

On Thu, Mar 22, 2018 at 10:21 AM, Terry Brown wrote: > On Thu, 22 Mar 2018 06:18:55 -0500 > "Edward K. Ream" wrote: > > > On Wed, Mar 21, 2018 at 10:41 PM, Terry Brown > > wrote: > > This code finds the right icons: >

Re: tree icons

On Thu, 22 Mar 2018 06:18:55 -0500 "Edward K. Ream" wrote: > On Wed, Mar 21, 2018 at 10:41 PM, Terry Brown > wrote: > > > 6c71e872c1c8 is very close to working, could even be considered to > > be working, it's showing dark icons etc. Not sure if

Re: tree icons

On Wed, Mar 21, 2018 at 10:41 PM, Terry Brown wrote: > 6c71e872c1c8 is very close to working, could even be considered to be > working, it's showing dark icons etc. Not sure if they're the same ones > as before or perhaps transparent icons on a dark background, but they >

Re: tree icons

6c71e872c1c8 is very close to working, could even be considered to be working, it's showing dark icons etc. Not sure if they're the same ones as before or perhaps transparent icons on a dark background, but they look ok. -- You received this message because you are subscribed to the Google

Re: tree icons

Without the --theme command line option, I get the following: getImageFinder ... @string color_theme: dark @string theme_name: StaticTheme @string theme_path: None home: /home/chris leo: /home/chris/leo-editor/leo directory table... [

Re: tree icons

commit 3d8564 This still looks odd to me: getImageFinder ... @string color_theme: leo_dark_0 @string theme_name: leo_dark_0 @string theme_path: None home: C:/Users/tbrown02 leo: D:/local/leo-editor/leo directory table... [

Re: tree icons

Using ./launchLeo.py --trace-startup --theme /home/chris/leo-editor/leo/themes/BreezeDarkTheme.leo getImageFinder box01.png is in /home/chris/leo-editor/leo/themes/dark/Icons getImageFinder box05.png is in /home/chris/leo-editor/leo/themes/dark/Icons Perfect behaviour. It loads the tree

Re: tree icons

On Wednesday, March 21, 2018 at 1:22:28 PM UTC-5, Edward K. Ream wrote: The --theme option requires the name of a .leo file. > But the .leo file extension is optional. The new code will warn if the given file can't be found in the expected places. I'm adding a lot of new code, but the

Re: tree icons

On Wed, 21 Mar 2018 12:15:37 -0500 "Edward K. Ream" wrote: > Rev 79b8101 fixes another home-directory bug in ​ no obvious change this end, sorry -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this

Re: tree icons

On Wed, 21 Mar 2018 11:42:43 -0500 "Edward K. Ream" wrote: > I am hoping that this fix will explain lots of mysteries. still not working here I invoked Leo like this: python.exe launchLeo.py --no-splash --trace-startup --theme=leo_dark_0 >log 2>&1 getImageFinder ...

Re: tree icons

On Wed, Mar 21, 2018 at 12:11 PM, Chris George wrote: > A search for g.app.theme_color > ​[yields]: > > # Replace .color_theme ivar by g.app.theme_color global. > > > There is no code in this node to support the comment. Or I am missing > something which is also entirely

Re: tree icons

On Wed, Mar 21, 2018 at 11:59 AM, Chris George wrote: > > This code is working fine to pull images for stylesheets. > > resolve_urls Search paths... > [ > '/home/chris/leo-editor/leo/themes', > '/home/chris/leo-editor/leo/Icons', > '/home/chris/.leo' > ] > >

Re: tree icons

A search for g.app.theme_color (as seen in @file ../plugins/qt_gui.py-->class LeoQtGui(leoGui.LeoGui)-->qt_gui.Icons-->qt_gui.getImageFinder) leads to @file ../plugins/qt_gui.py-->class LeoQtGui(leoGui.LeoGui)--> qt_gui.__init__ & reloadSettings where it appears in a comment: # Replace

Re: tree icons

Leo 5.8 devel, build 20180319100646, Mon, Mar 19, 2018 10:06:46 AM Git repo info: branch = devel, commit = b27dd907710a Python 3.6.4, PyQt version 5.6.2 linux ** isPython3: True ** caching enabled getImageFinder box01.png not in /home/chris/leo-editor/leo/themes getImageFinder box01.png is in

Re: tree icons

On Wed, Mar 21, 2018 at 11:30 AM, Chris George wrote: > Here is the relevant bit from my set-up. > ​.. > > Which explains why I get my icons only from ../leo/Icons and not > ..leo/themes/dark. > ​Thanks for this. b27dd9 corrects a difficult-to-see blunder in the recent

Re: tree icons

Here is the relevant bit from my set-up. getImageFinder box01.png not in /home/chris/leo-editor/leo/themes getImageFinder box01.png is in /home/chris/leo-editor/leo/Icons getImageFinder box05.png not in /home/chris/leo-editor/leo/themes getImageFinder box05.png is in

Re: tree icons

On Wed, 21 Mar 2018 05:42:42 -0700 (PDT) "Edward K. Ream" wrote: > On Wednesday, March 21, 2018 at 6:47:27 AM UTC-5, Edward K. Ream > wrote: > > Where do icons reside when they load correctly? > > In an ENB I am writing I predict that either of the following might > solve

Re: tree icons

On Wednesday, March 21, 2018 at 6:47:27 AM UTC-5, Edward K. Ream wrote: Where do icons reside when they load correctly? > In an ENB I am writing I predict that either of the following might solve your problem. If so, it would be an important clue: - Use --theme= on the command line. -

Re: tree icons

On Tue, Mar 20, 2018 at 7:36 PM, Terry Brown wrote: > Please do a git bisect to discover the exact rev that causes the > > problems. Thanks. > > 852d8e40 > ​Thanks. Where do icons reside when they load correctly? Edward -- You received this message because you are

Re: tree icons

On Tue, 20 Mar 2018 16:15:12 -0700 (PDT) "Edward K. Ream" <edream...@gmail.com> wrote: > On Tuesday, March 20, 2018 at 1:04:54 PM UTC-5, Terry Brown wrote: > > > > Doh, my theme had survived unscathed until just now, now my tree > > icons are

Re: tree icons

On Tuesday, March 20, 2018 at 1:04:54 PM UTC-5, Terry Brown wrote: > > Doh, my theme had survived unscathed until just now, now my tree icons > are light in a dark theme. How do I fix that? > Please do a git bisect to discover the exact rev that causes the problems. Tha

Re: tree icons

On Tue, Mar 20, 2018 at 3:50 PM, Edward K. Ream wrote: Clearly, something *did* break your theme, and that's a bug. > ​Rev 7f44cb4 enables tracing in ssm.resolve_urls. That should tell you a lot. ​ ​As I suggested to Chris, you might also want to enable tracing in

Re: tree icons

On Tue, Mar 20, 2018 at 2:10 PM, Terry Brown wrote: I always had @string color_theme set. It might be partly not searching > ~/.leo/themes, possibly dropping an implicit Icons somewhere - haven't > really diagnosed. Not opposed to changing my theme if that's easy. >

Re: tree icons

t; > > Doh, my theme had survived unscathed until just now, now my tree > > icons > >> are light in a dark theme. How do I fix that? > > > > Try > > ​​ > > @string color_theme = name, where leo/themes/name or leo/Icons/name > > contains the d

Re: tree icons

On Tue, Mar 20, 2018 at 1:16 PM, Edward K. Ream <edream...@gmail.com> wrote: On Tue, Mar 20, 2018 at 1:04 PM, Terry Brown <terrynbr...@gmail.com> wrote: > > Doh, my theme had survived unscathed until just now, now my tree icons >> are light in a dark theme. How d

Re: tree icons

On Tue, Mar 20, 2018 at 1:04 PM, Terry Brown <terrynbr...@gmail.com> wrote: Doh, my theme had survived unscathed until just now, now my tree icons > are light in a dark theme. How do I fix that? > Try @string color_theme = name, where leo/themes/name or leo/Icons/name contains the d

Re: tree icons

On Tue, 20 Mar 2018 13:04:51 -0500 Terry Brown <terrynbr...@gmail.com> wrote: > Doh, my theme had survived unscathed until just now, now my tree icons > are light in a dark theme. How do I fix that? Also seeing can not load image: /home/tbrown/local/leo-editor/leo/Icons/file_

tree icons

Doh, my theme had survived unscathed until just now, now my tree icons are light in a dark theme. How do I fix that? Thanks, Terry -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving e