Re: MD or RST?

2016-03-28 Thread 'Terry Brown' via leo-editor 
On Mon, 28 Mar 2016 03:51:38 -0700 (PDT)
Peter Mills  wrote:

> Sorry for the late reply.
> 
> I agree Edward, although rather than having VR2 based on VR, I think
> there should only be *one* viewrendered-type plugin. Having two must
> confuse a lot of users!

I think all Peter's comments are on target, really the existence of two
VR plugins was only historical accident, and what we want is the union
of features from both implementations.  Peter's recollection of the
ability to have multiple VR panes matches mine.

Best wishes on the thumb, Edward.

Cheers -Terry

> A few comments:
> 
>- 
>
>There was a proposal in 2015 to merge VR2 and VR2 - 
>
> https://groups.google.com/forum/?hl=en-GB#!searchin/leo-editor/VR2/leo-editor/cgmkazlacxg/YDrBKCyUBFMJ
>- 
>
>As I mentioned in that thread:
>
>“.. it was always intended to be merged with VR later on because
> of all the common code that remained and the confusion caused by the
> multiple VR plugins. Also, when installed, VR2 masquerades as VR
> anyway, to retain compatibility with the pane management etc.”
>- 
>
>(re Jake’s comment) Multiple VR2 panes was not only possible but 
>incorporated into the design and GUI. VR2’s “Lock to node” option
> allowed a VR2 pane to stay rendering the nominated node, even when
> another VR2 pane was opened (using freelayout) and followed the
> highlighted node. This could in theory be extended to several VR2
> panes locked to their own nodes. Alas, this “lock to node” feature
> broke somewhere in the very necessary conversion to Python3 code (the
> fix is not that hard though). 
>Now that I test this (not having had multiple VR2 panes open for a
> long while), I find that a second VR2 pane refuses to open. It
> definitely used to work well. Similarly, with a VR2 pane open,
> getting help on a plugin would open a second VR2 pane (which also
> doesn’t work now).
>- 
>
>As Edward points out, VR2 is essentially a modified copy of VR
> that uses the QWebView renderer and a little GUI. This makes
> maintenance of both a chore because updates to the VR code has to be
> redone on VR2 in order to keep them in sync.
>- 
>
>I still use only VR2 (in fact this post has had it's html copied
> and pasted out of VR2) so I know it still does most of the things it
> was intended for, although I do sometimes patch in some fixes, like
> for the above “lock to node” bug.
>
> In summary, I’d suggest (depending on how well VR2 has kept up with
> VR’s updates) that VR2 is essentially a superset of VR functionality,
> and should become the *only* VR plugin. If there is something that
> the VR renderer has that VR2’s QWebview pane cannot reproduce, then
> incorporating that would be good. It must be a superset of VR
> functionality to allow us to drop VR. Worst case, if necessary, would
> be to have a configuration item to choose which renderer the *only*
> VR plugin uses.
> 
> Of course we would need to fix some bugs in VR2 too ;-). I think I
> have a bit better handle on “git” these days, so I could probably be
> able to successfully submit a pull request as Edward suggested in the
> earlier discussion ;-)
> 
> Peter
> 
> On Saturday, 26 March 2016 10:53:24 UTC+10, Edward K. Ream wrote:
> >
> > On Fri, Mar 25, 2016 at 7:47 PM, gatesphere  > > wrote:
> >
> >> On 3/25/2016 8:25 PM, Edward K. Ream wrote:
> >>
> >> On Fri, Mar 25, 2016 at 4:14 PM, 'Terry Brown' via leo-editor < 
> >> leo-e...@googlegroups.com > wrote:
> >> Furthermore, why not have the "id" be 
> >> WhateverProvider.__class__.__name__?  This works provided that
> >> each Provider class actually has a distinct name.
> >>
> >> What do you think?  Would it be somehow inconvenient to dispense
> >> with the Provider classes?
> >>
> >> The details are murky now, but I remember a while back fixing a
> >> few bugs when viewrendered2 came about -- IIRC, the various
> >> help/docstring/plugin docs commands pretty much expect there to be
> >> a single vr pane.  I have no idea if that's still the case.
> >
> > ​It sure looks that way to me.
> >
> > BTW, the subtle differences between VR and VR2 are making ​my head
> > spin. I'm thinking that one way forward would be to base VR2 on
> > VR.  That is, VR2 would use import leo.plugins.viewrendered and use
> > the VR version of ViewRenderedController, perhaps with a mode bit,
> > or just monkey patching the VR html_class ivar.
> >
> > In other words, I would really like the only difference between the
> > VR and VR2 plugins to be the value of the html_class ivar.  I'm not
> > sure that makes sense, but it sure doesn't make sense to have two
> > different almost-but-not-quite-identical ViewRenderedController
> > classes!
> >
> > Peter Mills, if you are following this, I'd like your comments.
> >
> > Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from

Re: Taking a break

2016-03-28 Thread Offray Vladimir Luna Cárdenas 
Take care and good rest. Recently my left thumb was trembling and a good 
approach was to change the mouse for a while. It could help after your 
brake.


Cheers,

Offray

On 28/03/16 06:50, Edward K. Ream wrote:

I'll be taking an enforced break for a few days. My left thumb hurts.

Yesterday I completed the import-jupyter-notebook and 
export-jupyter-notebook commands. They will be more fully integrated 
into Leo later, but they seem to be complete as they stand. Please 
give them a look and report any problems.


Edward
--
You received this message because you are subscribed to the Google 
Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to leo-editor+unsubscr...@googlegroups.com 
.
To post to this group, send email to leo-editor@googlegroups.com 
.

Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.


--
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Taking a break

2016-03-28 Thread john lunzer 
Go for it. No burn out. Got it, no burn out!

On Monday, March 28, 2016 at 7:50:21 AM UTC-4, Edward K. Ream wrote:
>
> I'll be taking an enforced break for a few days. My left thumb hurts.
>
> Yesterday I completed the import-jupyter-notebook and 
> export-jupyter-notebook commands. They will be more fully integrated into 
> Leo later, but they seem to be complete as they stand. Please give them a 
> look and report any problems.
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Taking a break

2016-03-28 Thread Edward K. Ream 
I'll be taking an enforced break for a few days. My left thumb hurts.

Yesterday I completed the import-jupyter-notebook and 
export-jupyter-notebook commands. They will be more fully integrated into 
Leo later, but they seem to be complete as they stand. Please give them a 
look and report any problems.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: MD or RST?

2016-03-28 Thread Peter Mills 


Sorry for the late reply.


I agree Edward, although rather than having VR2 based on VR, I think there 
should only be *one* viewrendered-type plugin. Having two must confuse a 
lot of users!

A few comments:

   - 
   
   There was a proposal in 2015 to merge VR2 and VR2 - 
   
https://groups.google.com/forum/?hl=en-GB#!searchin/leo-editor/VR2/leo-editor/cgmkazlacxg/YDrBKCyUBFMJ
   - 
   
   As I mentioned in that thread:
   
   “.. it was always intended to be merged with VR later on because of all 
   the common code that remained and the confusion caused by the multiple VR 
   plugins. Also, when installed, VR2 masquerades as VR anyway, to retain 
   compatibility with the pane management etc.”
   - 
   
   (re Jake’s comment) Multiple VR2 panes was not only possible but 
   incorporated into the design and GUI. VR2’s “Lock to node” option allowed a 
   VR2 pane to stay rendering the nominated node, even when another VR2 pane 
   was opened (using freelayout) and followed the highlighted node. This could 
   in theory be extended to several VR2 panes locked to their own nodes. Alas, 
   this “lock to node” feature broke somewhere in the very necessary 
   conversion to Python3 code (the fix is not that hard though).
   
   Now that I test this (not having had multiple VR2 panes open for a long 
   while), I find that a second VR2 pane refuses to open. It definitely used 
   to work well. Similarly, with a VR2 pane open, getting help on a plugin 
   would open a second VR2 pane (which also doesn’t work now).
   - 
   
   As Edward points out, VR2 is essentially a modified copy of VR that uses 
   the QWebView renderer and a little GUI. This makes maintenance of both a 
   chore because updates to the VR code has to be redone on VR2 in order to 
   keep them in sync.
   - 
   
   I still use only VR2 (in fact this post has had it's html copied and 
   pasted out of VR2) so I know it still does most of the things it was 
   intended for, although I do sometimes patch in some fixes, like for the 
   above “lock to node” bug.
   
In summary, I’d suggest (depending on how well VR2 has kept up with VR’s 
updates) that VR2 is essentially a superset of VR functionality, and should 
become the *only* VR plugin. If there is something that the VR renderer has 
that VR2’s QWebview pane cannot reproduce, then incorporating that would be 
good. It must be a superset of VR functionality to allow us to drop VR. 
Worst case, if necessary, would be to have a configuration item to choose 
which renderer the *only* VR plugin uses.


Of course we would need to fix some bugs in VR2 too ;-). I think I have a 
bit better handle on “git” these days, so I could probably be able to 
successfully submit a pull request as Edward suggested in the earlier 
discussion ;-)


Peter

On Saturday, 26 March 2016 10:53:24 UTC+10, Edward K. Ream wrote:
>
> On Fri, Mar 25, 2016 at 7:47 PM, gatesphere  > wrote:
>
>> On 3/25/2016 8:25 PM, Edward K. Ream wrote:
>>
>> On Fri, Mar 25, 2016 at 4:14 PM, 'Terry Brown' via leo-editor < 
>> leo-e...@googlegroups.com > wrote:
>> Furthermore, why not have the "id" be 
>> WhateverProvider.__class__.__name__?  This works provided that each 
>> Provider class actually has a distinct name.
>>
>> What do you think?  Would it be somehow inconvenient to dispense with the 
>> Provider classes?
>>
>> The details are murky now, but I remember a while back fixing a few bugs 
>> when viewrendered2 came about -- IIRC, the various help/docstring/plugin 
>> docs commands pretty much expect there to be a single vr pane.  I have no 
>> idea if that's still the case.
>>
>
> ​It sure looks that way to me.
>
> BTW, the subtle differences between VR and VR2 are making ​my head spin.  
> I'm thinking that one way forward would be to base VR2 on VR.  That is, VR2 
> would use import leo.plugins.viewrendered and use the VR version of 
> ViewRenderedController, perhaps with a mode bit, or just monkey patching 
> the VR html_class ivar.
>
> In other words, I would really like the only difference between the VR and 
> VR2 plugins to be the value of the html_class ivar.  I'm not sure that 
> makes sense, but it sure doesn't make sense to have two different 
> almost-but-not-quite-identical ViewRenderedController classes!
>
> Peter Mills, if you are following this, I'd like your comments.
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.