Re: A new possible approach to importing python source files

2021-12-06 Thread Edward K. Ream
On Mon, Dec 6, 2021 at 2:31 AM vitalije wrote: > I am trying to catch up with new testing and your work on importers so > far. What is the proper way to run tests in Leo, now? > Use the test-all or test-import commands. I have also defined (in my local leoPy.leo file) the following @command

For Vitalije: About unit tests for the python importer

2021-12-06 Thread Edward K. Ream
In this thread I'll discuss issues related to unit tests for the python importer. *The unit tests will change* I've said that the new importer must pass all existing unit tests, but that's not exactly true, for the following reasons: 1. The new importer won't necessarily generate the same

Re: For Vitalije: About unit tests for the python importer

2021-12-06 Thread Edward K. Ream
On Monday, December 6, 2021 at 10:35:03 AM UTC-6 Edward K. Ream wrote: > I shall soon convert all tests so that they use check_headlines rather than the more verbose equivalent. Done in devel at rev c65459. In the tests I have marked headlines that should not be generated, or have poor

Re: For Vitalije: About unit tests for the python importer

2021-12-06 Thread vitalije
Sorry, I've missed your two posts. I've been working on new branch `importers` today. While looking at the importer pipeline, I've noticed several conversion text to lines and backwards. First split is in checking tabs and spaces, if there are mixed tabs and spaces, again text is turned into

Re: For Vitalije: About unit tests for the python importer

2021-12-06 Thread tbp1...@gmail.com
I just imported a Python file using the current devel branch (so not Vitaije's new code). The file has a if __name__ == '__main__': section. This section is located at the end of the imported file. I have no problem with that location even though the older importer put it near the top. But

Re: A new possible approach to importing python source files

2021-12-06 Thread vitalije
I am trying to catch up with new testing and your work on importers so far. What is the proper way to run tests in Leo, now? On Monday, December 6, 2021 at 12:15:47 AM UTC+1 Edward K. Ream wrote: > On Sunday, December 5, 2021 at 5:09:30 PM UTC-6 Edward K. Ream wrote: > > You are in complete