Re: The big PR did remove some gui-related code
On Saturday, July 8, 2023 at 8:10:10 AM UTC-5 Edward K. Ream wrote: On Friday, July 7, 2023 at 7:14:56 PM UTC-5 Edward K. Ream wrote: I now see that the *full_match* helper function (internal to g.findUNL) *did* contain gui code. Imo removing that code was correct, but there is a chance that doing so created problems. FYI: both the convert_unl_list and the full_match helpers will go away when g.findUNL no longer supports old-style unl lists. Oops. The full_match helper function resolves legacy unls. It must remain :-) Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/57cb1910-8289-4e12-8a0a-adffc0451167n%40googlegroups.com.
Re: The big PR did remove some gui-related code
On Friday, July 7, 2023 at 7:14:56 PM UTC-5 Edward K. Ream wrote: I now see that the *full_match* helper function (internal to g.findUNL) *did* contain gui code. Imo removing that code was correct, but there is a chance that doing so created problems. FYI: both the convert_unl_list and the full_match helpers will go away when g.findUNL no longer supports old-style unl lists. It's not clear whether any code or plugins now use such lists. Removing support for old-style unl lists is scheduled for Leo 6.7.5. It's way too late for such a change now. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/6d9dda9d-e026-43dd-a951-65df936f8cb1n%40googlegroups.com.
Re: The big PR did remove some gui-related code
On Sat, Jul 8, 2023 at 1:07 AM jkn wrote: > I mentioned it, in the thread "Ctrl-Click on gnx fails if the node is > dirty?" > Thanks for the reminder :-) I've just followed the recipe you gave in that thread. Everything works. And even if everything didn't work, putting gui code in full_match is wrong :-) Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS3PYx3pedfJNdhe783_0i4kHuowPdDpDZK67OYRjygwCw%40mail.gmail.com.
Re: The big PR did remove some gui-related code
I mentioned it, in the thread "Ctrl-Click on gnx fails if the node is dirty? " On Saturday, July 8, 2023 at 1:14:56 AM UTC+1 Edward K. Ream wrote: > There was some discussion (I don't remember where) about a weird edge > case: changing a clickable link and then undoing the change *without* saving > the file caused Leo not to find the clickable link. > > I dismissed this nit as likely unrelated to the big PR. However, I now see > that the *full_match* helper function (internal to g.findUNL) *did* > contain gui code. Imo removing that code was correct, but there is a chance > that doing so created problems. > > *Summary* > > This post sets the record straight, but I have no intention of restoring > the old code. > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/b006e8c5-b7c3-4d74-849f-c4d0551ca505n%40googlegroups.com.
The big PR did remove some gui-related code
There was some discussion (I don't remember where) about a weird edge case: changing a clickable link and then undoing the change *without* saving the file caused Leo not to find the clickable link. I dismissed this nit as likely unrelated to the big PR. However, I now see that the *full_match* helper function (internal to g.findUNL) *did* contain gui code. Imo removing that code was correct, but there is a chance that doing so created problems. *Summary* This post sets the record straight, but I have no intention of restoring the old code. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/6b2b466a-e2d9-42a4-b10b-910d750aba55n%40googlegroups.com.
