Re: fast-color branch now merged with the trunk

2009-02-12 Thread Ville M. Vainio
On Feb 10, 6:31 pm, Edward K. Ream edream...@gmail.com wrote: Rev 1538 of the trunk disables the colorizer if not hasattr(highlighter,'currentBlock') I have only tested that the code works if the highlighter *does* have the currentBlock method.  Please verify that coloring is disabled if

Re: fast-color branch now merged with the trunk

2009-02-12 Thread Edward K. Ream
On Thu, Feb 12, 2009 at 3:43 AM, Ville M. Vainio vivai...@gmail.com wrote: On Feb 10, 6:31 pm, Edward K. Ream edream...@gmail.com wrote: Rev 1538 of the trunk disables the colorizer if not hasattr(highlighter,'currentBlock') I have only tested that the code works if the highlighter

Re: fast-color branch now merged with the trunk

2009-02-11 Thread Edward K. Ream
On Tue, Feb 10, 2009 at 9:56 PM, Ville M. Vainio vivai...@gmail.com wrote: Haha. It looks like the hack of prepending the restart string to the text to be searched is going to be a problem. all_s[offset:] can be very large. True, in most cases restartString will almost always be empty,

Re: fast-color branch now merged with the trunk

2009-02-11 Thread Ville M. Vainio
On Wed, Feb 11, 2009 at 2:54 PM, Edward K. Ream edream...@gmail.com wrote: I disagree. I think it is essential to allocate a small number of strings. Imo, once the colorizer allocates on the order of 60,000 strings, each of the order of 100,000 bytes, it is going to encounter a massive

Re: fast-color branch now merged with the trunk

2009-02-11 Thread Edward K. Ream
On Wed, Feb 11, 2009 at 9:23 AM, Ville M. Vainio vivai...@gmail.com wrote: On Wed, Feb 11, 2009 at 2:54 PM, Edward K. Ream edream...@gmail.com wrote: I disagree. I think it is essential to allocate a small number of strings. Imo, once the colorizer allocates on the order of 60,000

Re: fast-color branch now merged with the trunk

2009-02-11 Thread Ville M. Vainio
On Wed, Feb 11, 2009 at 7:22 PM, Edward K. Ream edream...@gmail.com wrote: It was not possible to use onTextChanged because it gets called after incremental recoloring happens. Instead, the w.insert, w.delete and Yeah, I thought you could *reset* the cache there. But either way is fine, I

Re: fast-color branch now merged with the trunk

2009-02-11 Thread Edward K. Ream
On Feb 11, 11:22 am, Edward K. Ream edream...@gmail.com wrote: Rev 1546 of the fast-color branch now contains a synthesis of the older (big-state) and newer (string-state) approaches.  States are bunches, not strings, but traces uses state names that are the same as the old string states.  

Re: fast-color branch now merged with the trunk

2009-02-11 Thread Edward K. Ream
On Wed, Feb 11, 2009 at 11:48 AM, Ville M. Vainio vivai...@gmail.comwrote: Yeah. And at least it's fast enough that running it through profiler makes sense :-). Here is a typical profiler run: Ordered by: file name, call count, internal time, function name List reduced from 2603 to

fast-color branch now merged with the trunk

2009-02-10 Thread Edward K. Ream
Rev 1537 of the trunk contains the merge of the fast-color branch into the trunk. All unit tests pass. Actually, this was a straight copy of qtGui.py from the fast-color branch into the trunk, but I was careful: - I made sure to get the latest trunk sources first. - I carefully checked the

Re: fast-color branch now merged with the trunk

2009-02-10 Thread vitalije
On Feb 10, 2:43 pm, Edward K. Ream edream...@gmail.com wrote: Rev 1537 of the trunk contains the merge of the fast-color branch into Please report any problem immediately. Thanks. Hi. I have just tried new qt plug-in and found out that when I select any node that has some characters from

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Ville M. Vainio
On Tue, Feb 10, 2009 at 4:48 PM, Ville M. Vainio vivai...@gmail.com wrote: AttributeError: currentBlock This ubuntu has qt version 4.3.3-2ubuntu4.1 Would it be possible to disable syntax highlighter globally if qt doesn't have that method? I'd rather have leo *launchable*, even if we

Re: fast-color branch now merged with the trunk

2009-02-10 Thread vitalije
Actually this bug was introduced in revision 1447 if this information would be helpful. Vitalije. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to

Re: fast-color branch now merged with the trunk

2009-02-10 Thread vitalije
Rev 1537 of the trunk contains the merge of the fast-color branch into Please report any problem immediately. Thanks. Hi. I have just tried new qt plug-in and found out that when I select any node that has some characters from unicode range, for the first time it is displayed correct, but

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Ville M. Vainio
On Tue, Feb 10, 2009 at 3:43 PM, Edward K. Ream edream...@gmail.com wrote: Please report any problem immediately. Thanks. Try pasting e.g. qtGui.py file contents in a node. It hangs indefinitely. Apart from that, editing is very snappy now. -- Ville M. Vainio http://tinyurl.com/vainio

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Edward K. Ream
On Tue, Feb 10, 2009 at 12:18 PM, Ville M. Vainio vivai...@gmail.comwrote: Try pasting e.g. qtGui.py file contents in a node. It hangs indefinitely. Oops. I'll look into this soon. Edward --~--~-~--~~~---~--~~ You received this message because you are

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Ville M. Vainio
On Tue, Feb 10, 2009 at 8:18 PM, Ville M. Vainio vivai...@gmail.com wrote: On Tue, Feb 10, 2009 at 3:43 PM, Edward K. Ream edream...@gmail.com wrote: Please report any problem immediately. Thanks. Try pasting e.g. qtGui.py file contents in a node. It hangs indefinitely. And pretty much

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Edward K. Ream
On Tue, Feb 10, 2009 at 12:29 PM, Ville M. Vainio vivai...@gmail.comwrote: It seems it's not all that fast to do getAllText every time. Good catch. For large text (as in a large paste) the reallocation of the entire string will surely stress the gc greatly. The big payoff is when calling

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Ville M. Vainio
On Tue, Feb 10, 2009 at 8:55 PM, Edward K. Ream edream...@gmail.com wrote: On Tue, Feb 10, 2009 at 12:29 PM, Ville M. Vainio vivai...@gmail.com wrote: It seems it's not all that fast to do getAllText every time. Good catch. For large text (as in a large paste) the reallocation of the

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Edward K. Ream
On Tue, Feb 10, 2009 at 12:59 PM, Ville M. Vainio vivai...@gmail.comwrote: You can clear the cache on textChanged () signal. The text will never change behind your back if you follow that signal. Be sure to implement the cache so that all of leo should benefit from this, so that there is

Re: fast-color branch now merged with the trunk

2009-02-10 Thread Ville M. Vainio
On Wed, Feb 11, 2009 at 5:56 AM, Ville M. Vainio vivai...@gmail.com wrote: No hacks so actual thought should be needed. Just add caching and .. hacks OR actual thought... -- Ville M. Vainio http://tinyurl.com/vainio --~--~-~--~~~---~--~~ You received this