Re: run pylint in leo-editor UnicodeDecodeError

2016-10-16 Thread zhaohe wang
Would you tell me which line like plain ascii? error == [], when I run your script both wiht pylint-leo-rc.txt and my py file. 在 2016年10月16日星期日 UTC+8上午9:10:38,Edward K. Ream写道: > > > On Fri, Oct 14, 2016 at 6:16 AM, zhaohe wang > > wrote: >> >>> Leo 5.4-devel, build

Proposal: remove commit_timestamp.json

2016-10-16 Thread Edward K. Ream
At present, leoVersion.py gets version info by parsing leo/core/commit_timestamp.json. There are at least two unacceptable problems with this approach: 1. The dates don't get updated if a developer (like me!) forgets to install the git hooks. Just today I noticed that the last update was

Please hold all commits until Leo 5.4b1 goes out the door

2016-10-16 Thread Edward K. Ream
Expect b1 to be released later today. There is lots of testing involved, which I would have to redo if I pulled any changes. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Edward K. Ream
On Sunday, October 16, 2016 at 11:18:02 AM UTC-5, Edward K. Ream wrote: p = subprocess.Popen( > ["git", "log" , '-1', '--date=default-local'], > stdout=subprocess.PIPE, > shell=True) > Testing on Linux shows that the shell argument should be set as follows:

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Edward K. Ream
On Sunday, October 16, 2016 at 11:50:00 AM UTC-5, Edward K. Ream wrote: > > On Sunday, October 16, 2016 at 11:18:02 AM UTC-5, Edward K. Ream wrote: > > p = subprocess.Popen( >> ["git", "log" , '-1', '--date=default-local'], >> stdout=subprocess.PIPE, >> shell=True) >> > When this code

Re: run pylint in leo-editor UnicodeDecodeError

2016-10-16 Thread Edward K. Ream
On Sunday, October 16, 2016 at 10:16:04 AM UTC-5, zhaohe wang wrote: Would you tell me which line like plain ascii? > error == [], when I run your script both wiht pylint-leo-rc.txt and my py > file. > Hmm. It looks like all the lines of these two files are ascii. So it's even more of a

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread 'Terry Brown' via leo-editor
On Sun, 16 Oct 2016 09:18:02 -0700 (PDT) "Edward K. Ream" wrote: > At present, leoVersion.py gets version info by parsing > leo/core/commit_timestamp.json. There are at least two unacceptable > problems with this approach: > > 1. The dates don't get updated if a developer

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Edward K. Ream
On Sun, Oct 16, 2016 at 4:08 PM, 'Terry Brown' via leo-editor So I'd argue for leaving commit_timestamp.json as is and living with > the two shortcomings you identified. But if it's not bearable, we can > do something like you suggest. > ​I've already done what I suggested, and it works fine,

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Edward K. Ream
On Sunday, October 16, 2016 at 1:15:56 PM UTC-5, Edward K. Ream wrote: When this code is run outside a git repo, git log will issue a "fatal" > [sic] error. This will typically be true when the user is running an > "official" release. We can suppress such irrelevant messages by adding this >

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Edward K. Ream
On Sun, Oct 16, 2016 at 5:13 PM, Edward K. Ream wrote: But I see your point: the daily builds won't have detailed version info. > ​[snip]​ > What to do about daily snapshots? Maybe the script that creates the > snapshot could create commit_timestamp.json. > ​Heh. The zip

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Mike Hodson
On Sun, Oct 16, 2016 at 7:12 PM, Edward K. Ream wrote: > Here's an example. I downloaded > leo-editor-281522323a89c27b7c58338b1eaa624cbd383078.zip > from two days ago. How? I mean I must be missing something horribly wrong if I'm going to the same URL posted by Terry and

Re: run pylint in leo-editor UnicodeDecodeError

2016-10-16 Thread zhaohe wang
Found it !!! Line 207 in pylint-leo-rc-ref.txt You committed on 29 Feb. I changed the test py codes below. Add codecs.utf_8_decode(line),

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread 'Terry Brown' via leo-editor
On Sun, 16 Oct 2016 20:12:26 -0500 "Edward K. Ream" wrote: > On Sun, Oct 16, 2016 at 7:49 PM, Mike Hodson > wrote: > > > On Sun, Oct 16, 2016 at 4:24 PM, Edward K. Ream > > wrote: > > > The zip file's name contains the commit

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Mike Hodson
On Sun, Oct 16, 2016 at 4:24 PM, Edward K. Ream wrote: > The zip file's name contains the commit hash, so the user can find out the > exact version. Isn't that enough? I don't want write any more code to deal > with this issue. > I just tried downloading the master.zip from

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Edward K. Ream
On Sun, Oct 16, 2016 at 7:49 PM, Mike Hodson wrote: > On Sun, Oct 16, 2016 at 4:24 PM, Edward K. Ream > wrote: > > The zip file's name contains the commit hash, so the user can find out > the > ​ ​ > exact version. > > Where exactly am I supposed to be

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread Mike Hodson
And, there is no hash in the filename. The filename it downloads is either "master" "master.zip" or "leo-editor-master.zip" depending on Chrome, Curl, or Wget naming the file (and/or after following the redirect manually with curl) Thanks, Mike On Sun, Oct 16, 2016 at 6:49 PM, Mike Hodson

Re: Proposal: remove commit_timestamp.json

2016-10-16 Thread 'Terry Brown' via leo-editor
On Sun, 16 Oct 2016 19:20:23 -0600 Mike Hodson wrote: > That said, I did more digging. Seems that the full hash is contained > -as a comment- in the zip file... > With >2000 files in the zip file, infozip at the commandline shows the > comment -at the top- and in 1 second flat