Re: Matt, how do I review your docs?
On Mon, Feb 26, 2018 at 8:18 PM, Matt Wilkiewrote: > > What is the status of your install-docs branches? >> > > I believe these branches have now past their best-before date and it's > time to turn them into compost. If you have no further use for them I'll > delete them now? > Please do. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Matt, how do I review your docs?
> What is the status of your install-docs branches? > I believe these branches have now past their best-before date and it's time to turn them into compost. If you have no further use for them I'll delete them now? Matt -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Matt, how do I review your docs?
On Tuesday, February 13, 2018 at 2:20:51 AM UTC-6, Edward K. Ream wrote: > > > Also on the list for today is generalizing diff-marked-nodes so that it > compares arbitrarily many nodes, two at a time. Here is the code to do this > from diff_list_of_files: > > self.root = self.create_root(aList) > while len(aList) > 1: > self.path1 = aList[0] > aList = aList[1:] > for path2 in aList: > self.path2 = path2 > self.diff_two_files(self.path1, self.path2) > Heh. Documentation suggests further improvements. The code above should be: self.root = self.create_root(aList) while len(aList) > 1: path1 = aList[0] aList = aList[1:] for path2 in aList: self.diff_two_files(path1, path2) This is clearer, and avoids the question (different in 2 and 3!) of the scope of path2. diff_two_files can set the ivars in one line: self.path1, self.path2 = fn1, fn2 Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Matt, how do I review your docs?
On Monday, February 12, 2018 at 11:42:32 PM UTC-6, Matt Wilkie wrote: > > > Leo's diff-marked-nodes command only compares two outlines at a time. >> > > Ahh, thank you for that. There's so much about Leo I've yet to discover! > You're welcome. Also on the list for today is generalizing diff-marked-nodes so that it compares arbitrarily many nodes, two at a time. Here is the code to do this from diff_list_of_files: self.root = self.create_root(aList) while len(aList) > 1: self.path1 = aList[0] aList = aList[1:] for path2 in aList: self.path2 = path2 self.diff_two_files(self.path1, self.path2) Adapting this for diff-marked nodes will be straightforward. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Matt, how do I review your docs?
> Leo's diff-marked-nodes command only compares two outlines at a time. > Ahh, thank you for that. There's so much about Leo I've yet to discover! -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Matt, how do I review your docs?
On Thu, Feb 8, 2018 at 1:55 AM, Matt Wilkiewrote: >> it's extremely hard to see what the actual changes are/were in Leo. > I was hoping you had some magic here! I'll copy the corresponding outline from master and your two branches to ekr.leo, my personal outline. Leo's diff-marked-nodes command only compares two outlines at a time. This may not be good enough. If not, I'll create some new commands, probably based on Leo's git-diff command. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Matt, how do I review your docs?
> Am I correct in assuming that the only changed docs are in this tree: > > LeoDocs.leo#Leo's Documentation-->Installing & running Leo-->@rst > html/installing.html > Yes > I can see, via diffs on the branch pages, that checking out your branches > probably shows me the new words, but it's extremely hard to see what the > actual changes are/were in Leo. > Umm. I was hoping you had some magic here! Having problems visualizing the changes in Leo is what led me to create branches. Let me see if I can get exporting to html working. matt -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.