Re: log pane colors

On Thursday, March 8, 2018 at 9:04:55 AM UTC-6, Edward K. Ream wrote: One more tweak. Rev b9b4ccf treats None and 'black' differently. > For the first time the following may produce different colors, depending on theme and settings: g.es('test') # Prefer the log_text_foreground_color "role".

Re: log pane colors

On Thursday, March 8, 2018 at 8:53:22 AM UTC-6, Terry Brown wrote: > > Great, thanks for all that. > You're welcome. These were good changed. > I did need to add > > @color log_red_color = @log_error_color > @color log_blue_color = @log_warning_color > > to make those consistent, but I

Re: log pane colors

On Thu, 8 Mar 2018 04:19:07 -0800 (PST) "Edward K. Ream" wrote: > > ​I have just reopened #​788 > > to handle > > this. > > Fixed and closed at acd8f99. Great, thanks for all that. I did need to add @color

Re: log pane colors

On Thursday, March 8, 2018 at 4:29:35 AM UTC-6, Edward K. Ream wrote: ​​ >> Until recent changes, these settings worked: >> >> @color log_text_foreground_color = #93a1a1 >> @color log_text_background_color = #073642 >> @color log_error_color = #dc322f >> @color log_warning_color = #268bd2 >> > >

Re: log pane colors

On Thursday, March 8, 2018 at 4:29:35 AM UTC-6, Edward K. Ream wrote: In e4e0b81ad91e >> >> g.error('error') >> g.warning('warning') >> >> and >> >> g.blue('blue') >> g.red('red') >> >> give different results > > > ​That depends on the theme and defaults in leoSettings.leo. I'll add > defaults

Re: log pane colors

On Thursday, March 8, 2018 at 4:29:35 AM UTC-6, Edward K. Ream wrote: > I'll make g.log a synonym for g.es, and rename the existing g.log to [g.log_to_file]. Done at 3727ec1. All tests pass ;-) Edward -- You received this message because you are subscribed to the Google Groups "leo-editor"

Re: log pane colors

​​ On Wed, Mar 7, 2018 at 11:14 PM, Terry Brown wrote: > g.log is a completely separate function.​ It should not be changed. > > Yes it's completely separate. It appears to > ​ ​ > be used exactly zero times in the code base > ​... > > You could say that "hello > ​ ​ >

Re: log pane colors

On Wed, 7 Mar 2018 18:18:21 -0800 (PST) "Edward K. Ream" wrote: > ​On Wed, Mar 7, 2018 at 6:30 PM, Terry Brown > wrote: > > > I really don't understand the disconnect here. I want to log a > > warning to > the log pane. > ​​ > At present, Leo has

Re: log pane colors

On Wednesday, March 7, 2018 at 8:18:21 PM UTC-6, Edward K. Ream wrote: Rev 629c350 defines g.error, g.note and g.warning this way: def error(*args, **keys): g.es_print(color='error', *args, **keys) def note(*args, **keys): g.es_print(color='note', *args, **keys) def warning(*args,

Re: log pane colors

​On Wed, Mar 7, 2018 at 6:30 PM, Terry Brown wrote: > I really don't understand the disconnect here. I want to log a warning to the log pane. ​​ At present, Leo has the following definitions in leoGlobals​: def error(*args, **keys):

Re: log pane colors

On Wed, 7 Mar 2018 18:30:47 -0600 Terry Brown wrote: > Also if you don't > want the visual miscue of syntax highlighting on `type` we could call > it `role`, although I prefer type. Or better yet level, which matches the Python logging terminology. Cheers -Terry -- You

Re: log pane colors

On Wed, 7 Mar 2018 15:00:42 -0800 (PST) "Edward K. Ream" wrote: > On Wednesday, March 7, 2018 at 2:19:03 PM UTC-6, Terry Brown wrote: > > Looks like support for log_error_color, log_warning_color, and > > log_text_foreground_color was dropped here: > > > > > >

Re: log pane colors

On Wednesday, March 7, 2018 at 2:19:03 PM UTC-6, Terry Brown wrote: Looks like support for log_error_color, log_warning_color, and > log_text_foreground_color was dropped here: > > > https://github.com/leo-editor/leo-editor/commit/de0dcfa6c61#diff-e21cdd51aaf19b4a9e614b5f2ee9e97aL6129 Ah.

Re: log pane colors

On Wed, 7 Mar 2018 14:04:11 -0600 Terry Brown wrote: > On Wed, 7 Mar 2018 11:19:51 -0600 > "Edward K. Ream" wrote: > > > the present scheme doesn't use @color log_text_foreground_color. > > Seems like it should - it's unclear, in a world of dark and

Re: log pane colors

On Wed, 7 Mar 2018 11:19:51 -0600 "Edward K. Ream" wrote: > On Wed, Mar 7, 2018 at 10:08 AM, Terry Brown > wrote: > > > I have the following in myLeoSettings.leo > > > > ​​ > > @color log_text_foreground_color = #93a1a1 > > @color

Re: log pane colors

On Wed, Mar 7, 2018 at 10:08 AM, Terry Brown wrote: > I have the following in myLeoSettings.leo > > ​​ > @color log_text_foreground_color = #93a1a1 > @color log_text_background_color = #073642 > @color log_error_color = #dc322f > @color log_warning_color = #268bd2 > ​This

Re: log pane colors

On Wed, Mar 7, 2018 at 10:08 AM, Terry Brown wrote: > I have the following in myLeoSettings.leo > > @color log_text_foreground_color = #93a1a1 > @color log_text_background_color = #073642 > @color log_error_color = #dc322f > @color log_warning_color = #268bd2 > > The