Re: Bug Report on lftp with AUTH TLS

2004-04-30 Thread Alexander V. Lukyanov
On Fri, Apr 30, 2004 at 04:26:21AM +0200, Benjamin wrote:
 --- FEAT
 --- 211-Features:
 --- 211-MDTM
 --- 211-REST STREAM
 --- 211-SIZE
 --- 211-AUTH TLS
 --- 211-PBSZ
 --- 211-PROT
 --- 211 End
 --- QUIT
  Closing control socket
 ls: Login failed: ftp:ssl-force is set and server does not support or allow SSL

This is an RFC-2389 violation - wrong FEAT reply format. I'll add a
work-around for it.

For now, use:

set use-feat/this.server.com off

-- 
   Alexander.


Re: Bug Report on lftp with AUTH TLS

2004-04-30 Thread Alexander V. Lukyanov
On Fri, Apr 30, 2004 at 10:08:47AM +0400, Alexander V. Lukyanov wrote:
 On Fri, Apr 30, 2004 at 04:26:21AM +0200, Benjamin wrote:
  --- FEAT
  --- 211-Features:
  --- 211-MDTM
  --- 211-REST STREAM
  --- 211-SIZE
  --- 211-AUTH TLS
  --- 211-PBSZ
  --- 211-PROT
  --- 211 End
  --- QUIT
   Closing control socket
  ls: Login failed: ftp:ssl-force is set and server does not support or allow SSL

 This is an RFC-2389 violation - wrong FEAT reply format. I'll add a
 work-around for it.

Please try this patch.

--
   Alexander.  | http://www.yars.free.net/~lav/  
Index: ftpclass.cc
===
RCS file: /home/lav/cvsroot/lftp/src/ftpclass.cc,v
retrieving revision 1.316
diff -u -p -r1.316 ftpclass.cc
--- ftpclass.cc 29 Apr 2004 06:36:14 -  1.316
+++ ftpclass.cc 30 Apr 2004 06:37:51 -
@@ -3439,8 +3439,11 @@ void Ftp::CheckFEAT(char *reply)
{
   if(!strncmp(f,211 ,4))
 break;   // last line
+  if(!strncmp(f,211-,4))
+f+=4;// workaround for broken servers, RFC2389 does not allow it.
   if(*f==' ')
 f++;
+
   if(!strcasecmp(f,UTF8))
 conn-utf8_supported=true;
   else if(!strncasecmp(f,LANG ,5))