On Thu, Apr 28, 2011 at 05:09:31AM +, Ronald S. Bultje wrote:
Hi,
On Tue, Apr 26, 2011 at 2:07 PM, Diego Biurrun di...@biurrun.de wrote:
---
libavcodec/acelp_vectors.c | 10
Vitor is on the list. Vitor, opinions?
libavcodec/adxenc.c | 23
See below
While deprecated, they're totally useless as long as their values
are different from the AVIO_FLAG values that are used internally.
Currently, this leads to old libav applications still compiling
correctly (since we haven't removed the fallback wrappers), but
failing since the functions internally
From: Anssi Hannula anssi.hann...@iki.fi
As per issue2629, most 23.976fps matroska H.264 files are incorrectly
detected as 24fps, as the matroska timestamps usually have only
millisecond precision.
Fix that by doubling the amount of timestamps inspected for frame rate
for streams that have
On Thu, Apr 28, 2011 at 08:35:46AM +0400, Kirill Gavrilov wrote:
Just notice. I don't think that usage of class_ name is stupid.
class is a keyword in C++ and you can not use it as a name for variables.
However while this name appear in source file (.c, not a header, because
appearing in
On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓex Converse wrote:
It's a little ugly but without chain demux it isn't something we can
do particularly cleanly. This is similar to how we do LATM.
Let me know if you think the git metadata should be different.
Ported-by: Alex Converse
---
libavcodec/vorbisdec.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
index a9ddc7d..4bd842e 100644
--- a/libavcodec/vorbisdec.c
+++ b/libavcodec/vorbisdec.c
@@ -735,8 +735,8 @@ static int
On Thu, 28 Apr 2011, Diego Biurrun wrote:
---
libavcodec/vorbisdec.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
index a9ddc7d..4bd842e 100644
--- a/libavcodec/vorbisdec.c
+++ b/libavcodec/vorbisdec.c
@@
On 4/28/11 10:20 AM, Reinhard Tartler wrote:
From: Anssi Hannulaanssi.hann...@iki.fi
As per issue2629, most 23.976fps matroska H.264 files are incorrectly
detected as 24fps, as the matroska timestamps usually have only
millisecond precision.
Fix that by doubling the amount of timestamps
On 4/28/11 9:41 AM, Martin Storsjö wrote:
These should be removed at some point, but they aren't removed yet.
The intent is to be able to recompile an old application against
the new ABI without modifying the code, and this doesn't work
currently.
Ok.
On 4/22/11 5:17 PM, Vittorio Giovara wrote:
/As you know in h264 videos you can specify any crop values in any
direction; normally only the bottom part is used because 1080 is not
multiple of 16, however Libav supports cropping only partially.
Currently it ignores the left and top values but
2011/4/28 Aℓex Converse aconve...@google.com:
Why don't you use 'git send-email'? Or at least put the patches line.
--
Felipe Contreras
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On Thu, Apr 28, 2011 at 1:30 AM, Diego Biurrun di...@biurrun.de wrote:
On Tue, Apr 26, 2011 at 03:05:14PM +, Ronald S. Bultje wrote:
On Tue, Apr 26, 2011 at 2:56 PM, Luca Barbato lu_z...@gentoo.org wrote:
On 4/26/11 4:47 PM, Diego Biurrun wrote:
I am confused whether or not I should
On 4/28/11 10:20 AM, Reinhard Tartler wrote:
From: Anssi Hannulaanssi.hann...@iki.fi
As per issue2629, most 23.976fps matroska H.264 files are incorrectly
detected as 24fps, as the matroska timestamps usually have only
millisecond precision.
Fix that by doubling the amount of timestamps
On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote:
On Thu, Apr 28, 2011 at 1:30 AM, Diego Biurrun di...@biurrun.de wrote:
On Tue, Apr 26, 2011 at 03:05:14PM +, Ronald S. Bultje wrote:
On Tue, Apr 26, 2011 at 2:56 PM, Luca Barbato lu_z...@gentoo.org wrote:
On 4/26/11
The number of streams in the Ogg context is well set to 0 but not in the
a/v format context, so the number of stream is incremented in
av_new_stream and leads to a leak (and maybe worst). The attached patch
fix this.
--
Clément B.
From ec643696bd0bae8221eb5483cecebacc19e8db57 Mon Sep 17 00:00:00
Ronald S. Bultje rsbul...@gmail.com writes:
Yeah it's still interesting, I like this patch a lot more. :-).
I'm glad it's better now, since there aren't other comments yet I send
another version, c-indentation-style had to be c-file-style.
I also added a couple more variables and commented much
On Thu, Apr 28, 2011 at 12:14:43PM +0300, Martin Storsjö wrote:
On Thu, 28 Apr 2011, Diego Biurrun wrote:
--- a/libavcodec/vorbisdec.c
+++ b/libavcodec/vorbisdec.c
@@ -753,7 +753,7 @@ static int
vorbis_parse_setup_hdr_mappings(vorbis_context *vc)
if
On Thu, Apr 28, 2011 at 01:14:17PM +0200, Diego Biurrun wrote:
On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote:
On Thu, Apr 28, 2011 at 1:30 AM, Diego Biurrun di...@biurrun.de wrote:
On Tue, Apr 26, 2011 at 03:05:14PM +, Ronald S. Bultje wrote:
On Tue, Apr 26, 2011
On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote:
On 04/27/2011 03:25 PM, Reinhard Tartler wrote:
From: Michael Niedermayer michae...@gmx.at
Reported-at: Thu, 21 Apr 2011 14:38:25 +
Reported-by: Dominic Chell dominic.ch...@ngssecure.com
Signed-off-by: Michael
On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote:
I prefer to always s-o-b patches.
Think of this scenario; a person sends a patch, it is modified by
somebody else, and then applied. Did the original author agree to
those changes? If the s-o-b is there, yes, otherwise not.
Luca Barbato lu_z...@gentoo.org writes:
On 4/28/11 10:20 AM, Reinhard Tartler wrote:
From: Anssi Hannulaanssi.hann...@iki.fi
As per issue2629, most 23.976fps matroska H.264 files are incorrectly
detected as 24fps, as the matroska timestamps usually have only
millisecond precision.
Fix
Reinhard Tartler siret...@tauware.de writes:
On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote:
On 04/27/2011 03:25 PM, Reinhard Tartler wrote:
From: Michael Niedermayer michae...@gmx.at
Reported-at: Thu, 21 Apr 2011 14:38:25 +
Reported-by: Dominic Chell
Aℓex Converse aconve...@google.com writes:
There is most likely a performance hit here but the current code is
*undefined.*
Haters are welcome to send suggestions on how to do this without an if.
From 554be95192ad9803f51f00fec18bf6db9a562779 Mon Sep 17 00:00:00 2001
From: Alex Converse
Aℓex Converse aconve...@google.com writes:
From ae62aa2fca3b2cf45a98dc2f9777065bcb452797 Mon Sep 17 00:00:00 2001
From: Alex Converse aconve...@google.com
Date: Tue, 26 Apr 2011 09:08:26 -0700
Subject: [PATCH 3/4] bitstream: Properly promote av_reverse values before
shifting.
MIME-Version:
On 4/28/11 1:19 PM, Clément Bœsch wrote:
The number of streams in the Ogg context is well set to 0 but not in the
a/v format context, so the number of stream is incremented in
av_new_stream and leads to a leak (and maybe worst). The attached patch
fix this.
Could you please give us more
On Thu, Apr 28, 2011 at 02:23:59PM +0200, Luca Barbato wrote:
On 4/28/11 1:19 PM, Clément Bœsch wrote:
The number of streams in the Ogg context is well set to 0 but not in the
a/v format context, so the number of stream is incremented in
av_new_stream and leads to a leak (and maybe worst). The
On Thu, Apr 28, 2011 at 07:48:46AM -0700, Alex Converse wrote:
On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun di...@biurrun.de wrote:
On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓex Converse wrote:
--- /dev/null
+++ b/libavcodec/s302m.c
@@ -0,0 +1,142 @@
+/*
+ * SMPTE 302M decoder
+
On Thu, Apr 28, 2011 at 5:08 AM, Måns Rullgård m...@mansr.com wrote:
Aℓex Converse aconve...@google.com writes:
From ae62aa2fca3b2cf45a98dc2f9777065bcb452797 Mon Sep 17 00:00:00 2001
From: Alex Converse aconve...@google.com
Date: Tue, 26 Apr 2011 09:08:26 -0700
Subject: [PATCH 3/4]
On Thu, Apr 28, 2011 at 7:59 AM, Diego Biurrun di...@biurrun.de wrote:
On Thu, Apr 28, 2011 at 07:48:46AM -0700, Alex Converse wrote:
On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun di...@biurrun.de wrote:
On Wed, Apr 27, 2011 at 05:19:25PM -0700, Aℓex Converse wrote:
--- /dev/null
+++
On Thu, Apr 28, 2011 at 5:04 AM, Måns Rullgård m...@mansr.com wrote:
Aℓex Converse aconve...@google.com writes:
There is most likely a performance hit here but the current code is
*undefined.*
Haters are welcome to send suggestions on how to do this without an if.
From
On Wed, Apr 27, 2011 at 9:35 PM, Kirill Gavrilov gavr.m...@gmail.com wrote:
Just notice. I don't think that usage of class_ name is stupid.
class is a keyword in C++ and you can not use it as a name for variables.
However while this name appear in source file (.c, not a header, because
On Thu, Apr 28, 2011 at 10:14 AM, Mike Scheutzow
mike.scheut...@alcatel-lucent.com wrote:
This problem was more difficult to solve than I expected. I've attached a
patch which takes a different approach than Tony's patch.
One of the causes of this bug is that the h264 parser defaults
On Thu, Apr 28, 2011 at 03:10:03PM +, Ronald S. Bultje wrote:
Hi,
On Thu, Apr 28, 2011 at 3:05 PM, Clément Bœsch ubi...@gmail.com wrote:
This patch allows users to be notified about track switch on a continuous
audio stream. The A-V statusbar mess up a bit the printing sometimes, I
On Thu, Apr 28, 2011 at 08:11:37AM -0700, Alex Converse wrote:
On Thu, Apr 28, 2011 at 7:59 AM, Diego Biurrun di...@biurrun.de wrote:
On Thu, Apr 28, 2011 at 07:48:46AM -0700, Alex Converse wrote:
On Thu, Apr 28, 2011 at 1:32 AM, Diego Biurrun di...@biurrun.de wrote:
On Wed, Apr 27, 2011
On 04/28/2011 02:35 PM, Clément Bœsch wrote:
Sure. The best way to notice the issue is changing the modified line in
the patch with av_dump_format(s, 0, s-filename, 0) and you'll notice that
kind of stuff after a few track switches (if it's a continuous bitstream):
Stream #0.1: Invalid
---
libavfilter/vf_fieldorder.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavfilter/vf_fieldorder.c b/libavfilter/vf_fieldorder.c
index 59ca778..b55640b 100644
--- a/libavfilter/vf_fieldorder.c
+++ b/libavfilter/vf_fieldorder.c
@@ -1,20 +1,20 @@
/*
*
Hi,
On Thu, Apr 28, 2011 at 1:00 PM, Diego Biurrun di...@biurrun.de wrote:
---
libavfilter/vf_fieldorder.c | 8
1 files changed, 4 insertions(+), 4 deletions(-)
OK.
Ronald
___
libav-devel mailing list
libav-devel@libav.org
On Thu, Apr 28, 2011 at 7:35 AM, Justin Ruggles
justin.rugg...@gmail.com wrote:
Hi,
On 04/27/2011 08:19 PM, Aℓex Converse wrote:
+ frame_size = (h 16) 0x;
+ channels = 2 + 2*((h 14) 0x03);
+ id = (h 6) 0xff;
+ bits = 16 + 4*((h 4) 0x03);
This would be easier to
On Thu, Apr 28, 2011 at 4:32 AM, Reinhard Tartler siret...@tauware.de wrote:
On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote:
On 04/27/2011 03:25 PM, Reinhard Tartler wrote:
From: Michael Niedermayer michae...@gmx.at
Reported-at: Thu, 21 Apr 2011 14:38:25 +
2011/4/28 Aℓex Converse aconve...@google.com:
On Thu, Apr 28, 2011 at 7:35 AM, Justin Ruggles
justin.rugg...@gmail.com wrote:
Hi,
On 04/27/2011 08:19 PM, Aℓex Converse wrote:
+ frame_size = (h 16) 0x;
+ channels = 2 + 2*((h 14) 0x03);
+ id = (h 6) 0xff;
+ bits = 16
From: Baptiste Coudurier baptiste.coudur...@gmail.com
Ported-by: Alex Converse aconve...@google.com
---
Changelog |2 +
doc/general.texi |1 +
libavcodec/Makefile|1 +
libavcodec/allcodecs.c |1 +
libavcodec/avcodec.h |1 +
libavcodec/s302m.c |
Hi everyone --
I might be missing something, but it doesn't appear that the PTS field in
AVPacket is preserved when decoding an h.264 frame. The AVFrame that gets
returned has PTS set to AV_NOPTS_VALUE. Is this the desired behavior? If I
put together a patch that preserved the PTS field,
2011/4/28 Aℓex Converse aconve...@google.com:
2011/4/28 Aℓex Converse aconve...@google.com:
On Thu, Apr 28, 2011 at 7:35 AM, Justin Ruggles
justin.rugg...@gmail.com wrote:
Hi,
On 04/27/2011 08:19 PM, Aℓex Converse wrote:
+ frame_size = (h 16) 0x;
+ channels = 2 + 2*((h 14)
From: Baptiste Coudurier baptiste.coudur...@gmail.com
Ported-by: Alex Converse aconve...@google.com
---
This includes all review comments so far, plus a documentation entry
and random prettyprinting.
Changelog |2 +
doc/general.texi |1 +
libavcodec/Makefile|
On Thu, Apr 28, 2011 at 11:08 AM, Diego Biurrun di...@biurrun.de wrote:
From: Baptiste Coudurier baptiste.coudur...@gmail.com
Ported-by: Alex Converse aconve...@google.com
---
This includes all review comments so far, plus a documentation entry
and random prettyprinting.
Changelog
Hi,
On 04/28/2011 02:08 PM, Diego Biurrun wrote:
+if (*data_size 4 * buf_size * 8 / (avctx-bits_per_coded_sample + 4))
+return -1;
I think this can cause invalid writes if buf_size INT_MAX/32
-Justin
___
libav-devel mailing list
On Thu, Apr 28, 2011 at 11:25 AM, Justin Ruggles
justin.rugg...@gmail.com wrote:
Hi,
On 04/28/2011 02:08 PM, Diego Biurrun wrote:
+ if (*data_size 4 * buf_size * 8 / (avctx-bits_per_coded_sample + 4))
+ return -1;
I think this can cause invalid writes if buf_size INT_MAX/32
On 04/28/2011 01:20 PM, Aℓex Converse wrote:
On Thu, Apr 28, 2011 at 4:32 AM, Reinhard Tartler siret...@tauware.de wrote:
On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote:
On 04/27/2011 03:25 PM, Reinhard Tartler wrote:
From: Michael Niedermayer michae...@gmx.at
Reported-at:
On Wed, Apr 27, 2011 at 14:18:56 (CEST), Diego Biurrun wrote:
On Wed, Apr 27, 2011 at 08:28:19AM +0200, Reinhard Tartler wrote:
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
IIUC you can remove $LIBM from libswscale as well, since that one would
pick up the -lm
On Thu, Apr 28, 2011 at 02:36:45PM -0400, Justin Ruggles wrote:
On 04/28/2011 01:20 PM, Aℓex Converse wrote:
On Thu, Apr 28, 2011 at 4:32 AM, Reinhard Tartler siret...@tauware.de
wrote:
On Wed, Apr 27, 2011 at 03:37:27PM -0400, Justin Ruggles wrote:
On 04/27/2011 03:25 PM, Reinhard
Hi.
On Thu, Apr 28, 2011 at 2:36 PM, Justin Ruggles
justin.rugg...@gmail.com wrote:
The EMU_EDGE part looks correct. We should go ahead and commit that.
Did you confirm that it does not introduce valgrind errors when
running ffmpeg -flags emu_edge -i file.amv -f null -?
Ronald
On Apr 28, 2011, at 1:35 PM, Dennis Munsie wrote:
Hi everyone --
I might be missing something, but it doesn't appear that the PTS field in
AVPacket is preserved when decoding an h.264 frame. The AVFrame that gets
returned has PTS set to AV_NOPTS_VALUE. Is this the desired behavior? If
On Thu, Apr 28, 2011 at 11:08 AM, Diego Biurrun di...@biurrun.de wrote:
From: Baptiste Coudurier baptiste.coudur...@gmail.com
Ported-by: Alex Converse aconve...@google.com
--- /dev/null
+++ b/libavcodec/s302m.c
@@ -0,0 +1,141 @@
+/*
+ * SMPTE 302M decoder
+ * Copyright (c) 2008 Laurent
On Thu, 28 Apr 2011, Luca Barbato wrote:
On 4/28/11 9:41 AM, Martin Storsjö wrote:
These should be removed at some point, but they aren't removed yet.
The intent is to be able to recompile an old application against
the new ABI without modifying the code, and this doesn't work
currently.
On 04/23/2011 04:32 PM, Ronald S. Bultje wrote:
From: Ronald S. Bultje rbul...@google.com
Tested on a Mac Pro, 2 CPUs, 2 cores each, OSX 10.6.6:
time ./ffmpeg -v 0 -vsync 0 -threads [1234] -i \
~/Downloads/sintel_trailer_1080p_vp8_vorbis.webm \
-f null -vcodec rawvideo -an -
1:
On Thu, Apr 28, 2011 at 2:40 PM, Diego Biurrun di...@biurrun.de wrote:
On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote:
I prefer to always s-o-b patches.
Think of this scenario; a person sends a patch, it is modified by
somebody else, and then applied. Did the original
On 04/28/2011 02:00 PM, Måns Rullgård wrote:
And meanwhile startup overhead will be twice the already insane amount.
I'm afraid fixing the issue could require few weekends with at least 3-4
people banging their heads on the code to understand what the code tries
to do, write a clean replacement
Hi,
On Thu, Apr 28, 2011 at 5:35 PM, Dennis Munsie dmun...@gmail.com wrote:
I might be missing something, but it doesn't appear that the PTS field in
AVPacket is preserved when decoding an h.264 frame. The AVFrame that gets
returned has PTS set to AV_NOPTS_VALUE. Is this the desired
58 matches
Mail list logo
