[libav-devel] Small side data related fix

Two patches, 1 is for general safety, while the second is possibly stable-worthy. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 2/2] avcodec: Do not access the side data of flush packets

A flush packet is documented as an AVPacket with data and size set to 0. Reported-By: Bernd Pfrommer --- libavcodec/utils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index c9ae19b..aee7ea2 100644 --- a/libavcodec/utils.c +++

[libav-devel] [PATCH 1/2] doc: Document that in order to flush an empty packet is needed

Just setting data to NULL and size to 0 is not safe because of side data. Reported-By: Bernd Pfrommer --- libavcodec/avcodec.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3440126..f7320fa 100644 ---

Re: [libav-devel] [PATCH 1/2] doc: Document that in order to flush an empty packet is needed

On 14/05/15 19:47, wm4 wrote: On Thu, 14 May 2015 19:30:57 +0200 Luca Barbato lu_z...@gentoo.org wrote: Just setting data to NULL and size to 0 is not safe because of side data. Reported-By: Bernd Pfrommer --- libavcodec/avcodec.h | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [libav-devel] [PATCH] hevc: make avcodec_decode_video2() fail if get_format() fails

On 14/05/15 19:23, wm4 wrote: Personally, I need the decoder to back out if get_format() returns no usable pixel format. This didn't work because the error code was not propagated down the call chain. This in turn happened because the variable declaration removed in this patch shadowed the

[libav-devel] [PATCH] hevc: make avcodec_decode_video2() fail if get_format() fails

Personally, I need the decoder to back out if get_format() returns no usable pixel format. This didn't work because the error code was not propagated down the call chain. This in turn happened because the variable declaration removed in this patch shadowed the variable, whose value is returned at

Re: [libav-devel] [PATCH 1/2] doc: Document that in order to flush an empty packet is needed

On Thu, 14 May 2015 19:30:57 +0200 Luca Barbato lu_z...@gentoo.org wrote: Just setting data to NULL and size to 0 is not safe because of side data. Reported-By: Bernd Pfrommer --- libavcodec/avcodec.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [libav-devel] [PATCH] lavfi: Move avcodec header to the only filter needing it

On 15/05/15 00:37, Vittorio Giovara wrote: af_ashowinfo, due to the enum AVAudioServiceType use. --- libavfilter/af_ashowinfo.c | 2 ++ libavfilter/avfilter.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) Ok. ___ libav-devel mailing

[libav-devel] [PATCH] lavfi: Move avcodec header to the only filter needing it

af_ashowinfo, due to the enum AVAudioServiceType use. --- libavfilter/af_ashowinfo.c | 2 ++ libavfilter/avfilter.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_ashowinfo.c b/libavfilter/af_ashowinfo.c index a91d7ac..5f0e254 100644 ---

Re: [libav-devel] [PATCH 13/17] lavc: Check memory allocation

On 12/05/2015 17:15, Diego Biurrun wrote: On Tue, May 12, 2015 at 05:55:38PM +0200, Luca Barbato wrote: --- a/libavcodec/ratecontrol.c +++ b/libavcodec/ratecontrol.c @@ -932,6 +934,11 @@ static int init_pass2(MpegEncContext *s) qscale = av_malloc(sizeof(double) *

[libav-devel] [PATCH] ratecontrol: do not leak rc_eq_val and rc_entry, use av_free

--- On top of 13/17. Vittorio libavcodec/ratecontrol.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/ratecontrol.c b/libavcodec/ratecontrol.c index 6fe174a..eafe97d 100644 --- a/libavcodec/ratecontrol.c +++ b/libavcodec/ratecontrol.c @@ -212,8 +212,10 @@

Re: [libav-devel] [PATCH 08/17] lavc: Check memory allocation

On 12/05/2015 17:09, Luca Barbato wrote: On 12/05/15 17:55, Luca Barbato wrote: From: Vittorio Giovara vittorio.giov...@gmail.com --- libavcodec/libtheoraenc.c | 6 ++ 1 file changed, 6 insertions(+) Missing capability? capability is only for init/close, this is in decode(). What

[libav-devel] [PATCH] eatgv: use reallocp

--- On top of 4/17. Reallocp takes care of freeing memory on failure. Vittorio libavcodec/eatgv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/eatgv.c b/libavcodec/eatgv.c index 5df4301..a73a1d3 100644 --- a/libavcodec/eatgv.c +++ b/libavcodec/eatgv.c @@

[libav-devel] [PATCH] svq1enc: free buffers on failure

--- On top of 14/17. Cannot use the cap since it is on decode_frame. Vittorio libavcodec/svq1enc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 7620332..c93f696 100644 --- a/libavcodec/svq1enc.c +++

Re: [libav-devel] [PATCH] doc: Add $branch to FATE config template

On 14/05/15 01:46, Timothy Gu wrote: --- doc/fate.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/fate.texi b/doc/fate.texi index 1d6d1d1..d6beaa5 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -128,6 +128,7 @@ can be passed. @example slot=

Re: [libav-devel] [PATCH 07/10] ppc: Restrict altivec to Big Endian

On 14/05/15 01:19, Luca Barbato wrote: In Little Endian the vec_ld/vec_st operations work as expected only for byte-vectors. --- libavcodec/ppc/apedsp_altivec.c | 4 ++-- libavcodec/ppc/audiodsp.c | 4 ++-- libavcodec/ppc/dct-test.c | 2 +-

Re: [libav-devel] [PATCH 01/10] ppc: avutil: Drop a potentially dangerous workaround

On 14/05/15 01:19, Luca Barbato wrote: The compiler is free to optimize in any sort of way such expression. --- libavutil/ppc/intreadwrite.h | 14 -- 1 file changed, 14 deletions(-) This is also for stable. ___ libav-devel mailing list