Re: [libav-devel] [PATCH] x86inc: Various minor backports from x264

2015-08-12 Thread Anton Khirnov
Quoting Henrik Gramner (2015-08-11 20:56:24) --- libavutil/x86/x86inc.asm | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) Thanks, all except 7 now pushed. -- Anton Khirnov ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/5] xiph: Const correct avpriv_split_xiph_headers arguments

2015-08-12 Thread Anton Khirnov
Quoting Luca Barbato (2015-08-11 12:01:05) On 11/08/15 10:12, Anton Khirnov wrote: Quoting Luca Barbato (2015-08-03 22:51:48) And fix the callers accordingly. Address 1 clang warning. --- libavcodec/vorbis_parser.c | 2 +- libavcodec/vorbisdec.c | 2 +- libavcodec/vp3.c

Re: [libav-devel] [PATCH 5/5] avcodec: Drop a spurious const from avframe_fill_audio_frame

2015-08-12 Thread Anton Khirnov
Quoting Luca Barbato (2015-08-11 12:03:08) On 11/08/15 10:15, Anton Khirnov wrote: Quoting Luca Barbato (2015-08-03 22:51:52) The resulting mapped array is used as non-const. Again, no -- the function does not modify buf. Shall we drop that warning for those specific functions

Re: [libav-devel] [PATCH 4/6] avcodec: delay removal of avcodec_*_frame

2015-08-12 Thread Anton Khirnov
Quoting Andreas Cadhalpun (2015-08-11 23:56:10) On 11.08.2015 11:34, Anton Khirnov wrote: This API is dangerous -- it manipulates AVFrame internals from libavcodec, even though AVFrame now lives in libavutil. It can break badly if AVFrame is extended in libavutil, but libavcodec is not

Re: [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-12 Thread Martin Storsjö
On Sun, 9 Aug 2015, Martin Storsjö wrote: On Sat, 8 Aug 2015, Andreas Cadhalpun wrote: On 08.08.2015 18:40, Martin Storsjö wrote: As Hendrik said, public data symbols are problematic from a portability point of view (they behave differently than public functions in DLLs and require jumping

[libav-devel] [PATCH] configure: Allow manually overriding the float ABI mode

2015-08-12 Thread Martin Storsjö
The current automatic detection might not always succeed. On Xcode 7 with -fembed-bitcode, the current detection fails. In this case, the detection is to try to compile and link a file containing '__asm__ (.eabi_attribute 28, 1);' With -fembed-bitcode, the assembler does print an error, but the

Re: [libav-devel] [PATCH] configure: Allow manually overriding the float ABI mode

2015-08-12 Thread Luca Barbato
On 12/08/15 12:12, Martin Storsjö wrote: The current automatic detection might not always succeed. On Xcode 7 with -fembed-bitcode, the current detection fails. In this case, the detection is to try to compile and link a file containing '__asm__ (.eabi_attribute 28, 1);' With

Re: [libav-devel] [PATCH] configure: Allow manually overriding the float ABI mode

2015-08-12 Thread Martin Storsjö
On Wed, 12 Aug 2015, Luca Barbato wrote: On 12/08/15 12:12, Martin Storsjö wrote: The current automatic detection might not always succeed. On Xcode 7 with -fembed-bitcode, the current detection fails. In this case, the detection is to try to compile and link a file containing '__asm__

Re: [libav-devel] [PATCH 4/6] avcodec: delay removal of avcodec_*_frame

2015-08-12 Thread Luca Barbato
On 12/08/15 08:09, Anton Khirnov wrote: I don't quite see what's the urgent need to fix everything before the bump. On the contrary, I think it will be less work for us (especially for you) to bump ASAP and let the downstreams fix their code. That should resolve the majority of problems with

[libav-devel] [RFC/PATCH 11/11] qsvdec: postpone initializing the decoder until after get_buffer()

2015-08-12 Thread Anton Khirnov
This allows use to export the required frame pool size to the caller in get_buffer(), before the decoder is initialized. --- This is an API break, since previously get_buffer() was always called after MFXVideoDECODE_Init() (and therefore after user's custom frame allocation callback invoked by

[libav-devel] [PATCH 04/11] qsvenc: mark the encoders as INIT_CLEANUP

2015-08-12 Thread Anton Khirnov
Should fix some leaks on init failure. --- libavcodec/qsvenc_h264.c | 1 + libavcodec/qsvenc_hevc.c | 1 + libavcodec/qsvenc_mpeg2.c | 1 + 3 files changed, 3 insertions(+) diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c index 7399dc7..93a3b1a 100644 ---

[libav-devel] [PATCH 06/11] qsv: document AVQSVContext members

2015-08-12 Thread Anton Khirnov
--- libavcodec/qsv.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/qsv.h b/libavcodec/qsv.h index 6532594..922b858 100644 --- a/libavcodec/qsv.h +++ b/libavcodec/qsv.h @@ -23,10 +23,29 @@ #include mfx/mfxvideo.h +/** + * This struct is used for

[libav-devel] [PATCH 09/11] examples/qsvdec: free the lavc decoder before closing MFX/VAAPI

2015-08-12 Thread Anton Khirnov
lavc expects MFX to still be in a usable state on close. --- doc/examples/qsvdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/examples/qsvdec.c b/doc/examples/qsvdec.c index 2f26f41..fd934be 100644 --- a/doc/examples/qsvdec.c +++ b/doc/examples/qsvdec.c @@

[libav-devel] [PATCH 03/11] qsvenc: do not try to close the encoder if the session is NULL

2015-08-12 Thread Anton Khirnov
--- libavcodec/qsvenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 752777b..d6a731f 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -482,7 +482,8 @@ int ff_qsv_enc_close(AVCodecContext *avctx, QSVEncContext

[libav-devel] [PATCH 10/11] qsvdec: make ff_qsv_decode_init() static

2015-08-12 Thread Anton Khirnov
It is not used outside of qsvdec.c anymore. --- libavcodec/qsvdec.c | 4 ++-- libavcodec/qsvdec.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index 2b81688..ca6f781 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@

[libav-devel] [PATCH 01/11] lavfi: do not exclude hwaccel formats from ff_all_formats()

2015-08-12 Thread Anton Khirnov
It should be possible to pass hwaccel frames through lavfi. --- libavfilter/formats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 4b6b3aa..7b5a93c 100644 --- a/libavfilter/formats.c +++ b/libavfilter/formats.c @@ -222,8

[libav-devel] [RFC/PATCH 05/11] qsvenc: postpone initializing the encoder if possible

2015-08-12 Thread Anton Khirnov
If the caller has not requested the global header, then we can wait with initializing the encoder until the first packet is submitted. This will allow us to export information like the size of the encoding frame pool to the caller. --- Callers who do want global headers (which in current API means

[libav-devel] [RFC/PATCH 02/11] qsvdec: list supported pixel formats

2015-08-12 Thread Anton Khirnov
This is useful for detecting QSV-enabled decoders. --- This is rather hacky. Can anyone think of a better solution? --- libavcodec/qsvdec_h2645.c | 6 ++ libavcodec/qsvdec_mpeg2.c | 3 +++ 2 files changed, 9 insertions(+) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c

[libav-devel] [PATCH 08/11] examples/qsvdec: do not free the surfaces in the frame_free() callback

2015-08-12 Thread Anton Khirnov
Even though libmfx might not need them anymore, avcodec might still access the surfaces. So free them separately at the end. --- doc/examples/qsvdec.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/doc/examples/qsvdec.c b/doc/examples/qsvdec.c index

[libav-devel] [PATCH 07/11] qsvdec: close the MFX decoder on uninit

2015-08-12 Thread Anton Khirnov
--- libavcodec/qsvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index 44693d2..2b81688 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -309,6 +309,9 @@ int ff_qsv_decode_close(QSVContext *q) { QSVFrame *cur =

Re: [libav-devel] [PATCH 09/11] examples/qsvdec: free the lavc decoder before closing MFX/VAAPI

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: lavc expects MFX to still be in a usable state on close. --- doc/examples/qsvdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 01/11] lavfi: do not exclude hwaccel formats from ff_all_formats()

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: It should be possible to pass hwaccel frames through lavfi. --- libavfilter/formats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 4b6b3aa..7b5a93c 100644 ---

Re: [libav-devel] [RFC/PATCH 02/11] qsvdec: list supported pixel formats

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: This is useful for detecting QSV-enabled decoders. --- This is rather hacky. Can anyone think of a better solution? It is not hacky as long it is acceptable to have 1 pixel format for each hwaccel. So it is fine for me now. The flexible way is to add a

Re: [libav-devel] [PATCH 03/11] qsvenc: do not try to close the encoder if the session is NULL

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: --- libavcodec/qsvenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 752777b..d6a731f 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -482,7 +482,8 @@ int

Re: [libav-devel] [PATCH 04/11] qsvenc: mark the encoders as INIT_CLEANUP

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: Should fix some leaks on init failure. --- libavcodec/qsvenc_h264.c | 1 + libavcodec/qsvenc_hevc.c | 1 + libavcodec/qsvenc_mpeg2.c | 1 + 3 files changed, 3 insertions(+) Ok. ___ libav-devel mailing

Re: [libav-devel] [PATCH 07/11] qsvdec: close the MFX decoder on uninit

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: --- libavcodec/qsvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index 44693d2..2b81688 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -309,6 +309,9 @@ int

Re: [libav-devel] [PATCH 08/11] examples/qsvdec: do not free the surfaces in the frame_free() callback

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: Even though libmfx might not need them anymore, avcodec might still access the surfaces. So free them separately at the end. --- doc/examples/qsvdec.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) Sure.

Re: [libav-devel] [PATCH 10/11] qsvdec: make ff_qsv_decode_init() static

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: It is not used outside of qsvdec.c anymore. --- libavcodec/qsvdec.c | 4 ++-- libavcodec/qsvdec.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) Ok. ___ libav-devel mailing list

Re: [libav-devel] [PATCH 06/11] qsv: document AVQSVContext members

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: --- libavcodec/qsv.h | 19 +++ 1 file changed, 19 insertions(+) Fine. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [RFC/PATCH 11/11] qsvdec: postpone initializing the decoder until after get_buffer()

2015-08-12 Thread Luca Barbato
On 12/08/15 15:07, Anton Khirnov wrote: This allows use to export the required frame pool size to the caller in get_buffer(), before the decoder is initialized. --- This is an API break, since previously get_buffer() was always called after MFXVideoDECODE_Init() (and therefore after user's