Quoting Mark Thompson (2016-03-10 18:54:30)
> On 10/03/16 16:16, Anton Khirnov wrote:
> > Quoting Mark Thompson (2016-03-10 16:56:21)
> +++avfc->nb_surfaces;
> +if (avfc->nb_surfaces == 1) {
> +// Test whether vaDeriveImage() works for this type of surface.
> +
On 10/03/16 16:16, Anton Khirnov wrote:
> Quoting Mark Thompson (2016-03-10 16:56:21)
+++avfc->nb_surfaces;
+if (avfc->nb_surfaces == 1) {
+// Test whether vaDeriveImage() works for this type of surface.
+VAImageFormat *expected_format;
+
Quoting Mark Thompson (2016-03-10 16:56:21)
> >> +++avfc->nb_surfaces;
> >> +if (avfc->nb_surfaces == 1) {
> >> +// Test whether vaDeriveImage() works for this type of surface.
> >> +VAImageFormat *expected_format;
> >> +VAImage test_image;
> >> +int err;
>
On 10/03/16 14:27, Anton Khirnov wrote:
> Quoting Mark Thompson (2016-03-08 00:21:45)
>> ---
>> configure | 4 +
>> libavutil/Makefile | 3 +
>> libavutil/hwcontext.c | 3 +
>> libavutil/hwcontext.h | 1 +
>>
Quoting Mark Thompson (2016-03-08 00:21:45)
> ---
> configure | 4 +
> libavutil/Makefile | 3 +
> libavutil/hwcontext.c | 3 +
> libavutil/hwcontext.h | 1 +
> libavutil/hwcontext_internal.h | 1 +
> libavutil/hwcontext_vaapi.c|
Quoting Mark Thompson (2016-03-08 10:56:40)
> On 08/03/16 09:25, Diego Biurrun wrote:
> > On Mon, Mar 07, 2016 at 11:21:45PM +, Mark Thompson wrote:
> >> --- /dev/null
> >> +++ b/libavutil/hwcontext_vaapi.c
> >> @@ -0,0 +1,822 @@
> >> +
> >> +// On current Intel drivers, derive gives you
Quoting Mark Thompson (2016-03-08 00:20:14)
> ---
> libavfilter/Makefile| 2 +
> libavfilter/allfilters.c| 2 +
> libavfilter/avfilter.c | 2 +
> libavfilter/avfilter.h | 9 ++
> libavfilter/vf_hwdownload.c | 212 +++
>
Quoting Mark Thompson (2016-03-08 00:19:37)
> ---
> libavutil/hwcontext.c | 45 +++
> libavutil/hwcontext.h | 69
> ++
> libavutil/hwcontext_internal.h | 10 ++
> 3 files changed, 124 insertions(+)
>
LGTM
--
On 10/03/16 00:37, Timothy Gu wrote:
> On Mon, Mar 07, 2016 at 11:20:14PM +, Mark Thompson wrote:
>> +AVFilter ff_vf_hwdownload = {
>> +.name = "hwdownload",
>> +.description = NULL_IF_CONFIG_SMALL("Upload a normal frame to a
>> hardware frame"),
>
> ahem...
>
> Timothy