Re: [libav-devel] [PATCH] Revert "avprobe: Zero the allocated avio buffer memory"

On 21/07/16 21:45, Vittorio Giovara wrote: > This reverts commit 0e0538aefc75958ded49f5d075c99a81cf6b2bbb. > > The valgrind warning was a false positive due to OSX implementation of > printf (invoking a strlen), while this code is actually fine, since the > format specifier %.*s guarantes that no

Re: [libav-devel] [PATCH] Revert "avprobe: Zero the allocated avio buffer memory"

On Thu, 21 Jul 2016, Vittorio Giovara wrote: This reverts commit 0e0538aefc75958ded49f5d075c99a81cf6b2bbb. The valgrind warning was a false positive due to OSX implementation of printf (invoking a strlen), while this code is actually fine, since the strNlen format specifier %.*s guarantes

[libav-devel] [PATCH] Revert "avprobe: Zero the allocated avio buffer memory"

This reverts commit 0e0538aefc75958ded49f5d075c99a81cf6b2bbb. The valgrind warning was a false positive due to OSX implementation of printf (invoking a strlen), while this code is actually fine, since the format specifier %.*s guarantes that no more than buf_size bytes from buf will be printed.

Re: [libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

On Thu, Jul 21, 2016 at 8:35 PM, Martin Storsjö wrote: > On Thu, 21 Jul 2016, Martin Storsjö wrote: > >> On Thu, 21 Jul 2016, Vittorio Giovara wrote: >> >>> On Wed, Jul 20, 2016 at 9:35 PM, Martin Storsjö wrote: On Wed, 20 Jul 2016, Vittorio Giovara

Re: [libav-devel] [PATCH] lavf: Fix stream codec context memory leak

On Thu, Jul 21, 2016 at 8:48 PM, Vittorio Giovara wrote: > st->codec is allocated with avcodec_alloc_context3(), > so it needs to be free'd properly. > --- > libavformat/utils.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

[libav-devel] [PATCH] lavf: Fix stream codec context memory leak

st->codec is allocated with avcodec_alloc_context3(), so it needs to be free'd properly. --- libavformat/utils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 6df1a32..b50f230 100644 --- a/libavformat/utils.c +++

Re: [libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

On Thu, 21 Jul 2016, Martin Storsjö wrote: On Thu, 21 Jul 2016, Vittorio Giovara wrote: On Wed, Jul 20, 2016 at 9:35 PM, Martin Storsjö wrote: On Wed, 20 Jul 2016, Vittorio Giovara wrote: Fixes valgrind warning "Conditional jump or move depends on uninitialised

Re: [libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

On Thu, 21 Jul 2016, Vittorio Giovara wrote: On Wed, Jul 20, 2016 at 9:35 PM, Martin Storsjö wrote: On Wed, 20 Jul 2016, Vittorio Giovara wrote: Fixes valgrind warning "Conditional jump or move depends on uninitialised value(s)." from avio_flush(). --- avprobe.c | 2 +- 1

Re: [libav-devel] [PATCH 1/2 v2] x86/hevc: add add_residual

On 7/21/2016 9:01 AM, Anton Khirnov wrote: > Quoting Josh de Kock (2016-07-21 02:48:31) >> diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c >> index f754038..b97f4c8 100644 >> --- a/libavcodec/x86/hevcdsp_init.c >> +++ b/libavcodec/x86/hevcdsp_init.c >> @@ -78,6 +78,23 @@

Re: [libav-devel] [PATCH 1/2 v2] x86/hevc: add add_residual

Quoting Diego Biurrun (2016-07-21 14:34:35) > On Thu, Jul 21, 2016 at 02:01:59PM +0200, Anton Khirnov wrote: > > Quoting Josh de Kock (2016-07-21 02:48:31) > > > --- a/libavcodec/x86/hevcdsp_init.c > > > +++ b/libavcodec/x86/hevcdsp_init.c > > > @@ -78,6 +78,23 @@ IDCT_FUNCS(32x32, sse2); > > >

Re: [libav-devel] [PATCH 12/12] lavfi: add a QSV deinterlacing filter

On 15/07/16 07:19, Anton Khirnov wrote: > --- > Changelog| 2 +- > configure| 1 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_deinterlace_qsv.c | 580 >

[libav-devel] [PATCH] checkasm: add HEVC test for testing IDCT DC

--- remove unused headers, reorder the remaining ones order hevc_idct in checkasm.h properly tests/checkasm/Makefile| 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_idct.c | 73 ++ 4 files changed,

[libav-devel] [PATCH] avprobe: Fix memory leak

After init_opts() there needs to be an uninit_opts() call to free swscales context and other buffers. --- avprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avprobe.c b/avprobe.c index 5b9a7ec..cf357bc 100644 --- a/avprobe.c +++ b/avprobe.c @@ -1089,7 +1089,7 @@ int

Re: [libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

On Wed, Jul 20, 2016 at 9:35 PM, Martin Storsjö wrote: > On Wed, 20 Jul 2016, Vittorio Giovara wrote: > >> Fixes valgrind warning "Conditional jump or move depends on >> uninitialised value(s)." from avio_flush(). >> --- >> avprobe.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [libav-devel] [PATCH] lavc: Document in/out AVCodecParameters ownership in AVBSFContext

On Thu, Jul 21, 2016 at 10:49 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-07-20 21:26:26) >> --- >> More compact and typo-free. >> Vittorio >> >> libavcodec/avcodec.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/avcodec.h

Re: [libav-devel] [PATCH 1/2 v2] x86/hevc: add add_residual

On Thu, Jul 21, 2016 at 02:01:59PM +0200, Anton Khirnov wrote: > Quoting Josh de Kock (2016-07-21 02:48:31) > > --- a/libavcodec/x86/hevcdsp_init.c > > +++ b/libavcodec/x86/hevcdsp_init.c > > @@ -78,6 +78,23 @@ IDCT_FUNCS(32x32, sse2); > > IDCT_FUNCS(16x16, avx2); > > IDCT_FUNCS(32x32, avx2); >

Re: [libav-devel] [PATCH 1/2 v2] x86/hevc: add add_residual

Quoting Josh de Kock (2016-07-21 02:48:31) > diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c > index f754038..b97f4c8 100644 > --- a/libavcodec/x86/hevcdsp_init.c > +++ b/libavcodec/x86/hevcdsp_init.c > @@ -78,6 +78,23 @@ IDCT_FUNCS(32x32, sse2); > IDCT_FUNCS(16x16,

Re: [libav-devel] [PATCH] checkasm: add HEVC test for testing IDCT DC

>> --- a/tests/checkasm/checkasm.h >> +++ b/tests/checkasm/checkasm.h >> @@ -38,6 +38,7 @@ void checkasm_check_h264dsp(void); >> void checkasm_check_h264qpel(void); >> void checkasm_check_hevc_mc(void); >> +void checkasm_check_hevc_idct(void); >> void checkasm_check_synth_filter(void); >> void

[libav-devel] [PATCH] hpeldsp: Explain why put_no_rnd_pixels_tab is larger than necessary

--- libavcodec/hpeldsp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/hpeldsp.h b/libavcodec/hpeldsp.h index d037cba..62dee68 100644 --- a/libavcodec/hpeldsp.h +++ b/libavcodec/hpeldsp.h @@ -76,6 +76,8 @@ typedef struct HpelDSPContext { * @param pixels source *

Re: [libav-devel] [PATCH] checkasm: add HEVC test for testing IDCT DC

On Thu, 21 Jul 2016, Diego Biurrun wrote: On Thu, Jul 21, 2016 at 12:57:36PM +0200, Alexandra Hájková wrote: --- /dev/null +++ b/tests/checkasm/hevc_idct.c @@ -0,0 +1,75 @@ + +#include + +#include "checkasm.h" + +#include "libavcodec/avcodec.h" +#include "libavcodec/hevcdsp.h" + +#include

Re: [libav-devel] [PATCH] checkasm: add HEVC test for testing IDCT DC

On Thu, Jul 21, 2016 at 12:57:36PM +0200, Alexandra Hájková wrote: > --- a/tests/checkasm/Makefile > +++ b/tests/checkasm/Makefile > @@ -9,7 +9,7 @@ AVCODECOBJS-$(CONFIG_VP8DSP)+= vp8dsp.o > > # decoders/encoders > AVCODECOBJS-$(CONFIG_DCA_DECODER) += dcadsp.o synth_filter.o

Re: [libav-devel] [PATCH 1/2 v2] x86/hevc: add add_residual

On Thu, Jul 21, 2016 at 2:48 AM, Josh de Kock wrote: > +cglobal hevc_add_residual_16_8, 3, 5, 7, dst, coeffs, stride > +pxorm0, m0 > +lea r3, [strideq * 3] > +RES_ADD_SSE_16_32_8 0, dstq, dstq + strideq > +RES_ADD_SSE_16_32_8 64,

Re: [libav-devel] [PATCH 12/12] lavfi: add a QSV deinterlacing filter

ping -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] checkasm: add HEVC test for testing IDCT DC

--- tests/checkasm/Makefile| 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_idct.c | 75 ++ 4 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/hevc_idct.c diff --git

Re: [libav-devel] [PATCH 1/2 v2] lavf: add libopenmpt demuxer

On Thu, Jul 21, 2016 at 02:04:30AM +0100, Josh de Kock wrote: > --- /dev/null > +++ b/libavformat/libopenmpt.c > @@ -0,0 +1,209 @@ > +/* > + * Tracker file demuxer (libopenmpt) > + * Copyright (c) 2016 Josh de Kock > + * > + * This file is part of libav. > + * > + * Libav is free software; you can

Re: [libav-devel] [PATCH 2/2] docs/demuxers: add libopenmpt section

On Thu, Jul 21, 2016 at 02:04:31AM +0100, Josh de Kock wrote: > --- > doc/demuxers.texi | 27 +++ > 1 file changed, 27 insertions(+) This should be squashed into the patch that adds the libopenmpt demuxer. > --- a/doc/demuxers.texi > +++ b/doc/demuxers.texi > @@ -110,4

Re: [libav-devel] [PATCH] avprobe: Zero the allocated avio buffer memory

On Wed, Jul 20, 2016 at 10:35:43PM +0300, Martin Storsjö wrote: > On Wed, 20 Jul 2016, Vittorio Giovara wrote: > > Fixes valgrind warning "Conditional jump or move depends on > > uninitialised value(s)." from avio_flush(). > > --- a/avprobe.c > > +++ b/avprobe.c > > @@ -1039,7 +1039,7 @@ static

Re: [libav-devel] [PATCH] lavc: Document in/out AVCodecParameters ownership in AVBSFContext

Quoting Vittorio Giovara (2016-07-20 21:26:26) > --- > More compact and typo-free. > Vittorio > > libavcodec/avcodec.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index ace761d..72665ba 100644 > --- a/libavcodec/avcodec.h > +++

Re: [libav-devel] [PATCH 1/2 v2] lavf: add libopenmpt demuxer

On 21/07/16 03:04, Josh de Kock wrote: > +openmpt->module = openmpt_module_create_from_memory(buf, size, > openmpt_logfunc, s, NULL); > +av_freep(); > +if (!openmpt->module) > +return AVERROR_INVALIDDATA; > + > +layout= av_get_channel_layout(openmpt->layout); >