Re: [libav-devel] [PATCH 02/14] intrax8: Change type of array stride parameters to ptrdiff_t

On 20/09/16 19:36, Diego Biurrun wrote: > ptrdiff_t is the correct type for array strides and similar. I can't say I looked at the detail with extreme care, but I didn't see anything else in the series which looked fishy. Aside: Seeing a lot of little functions like (picking a random one): >

Re: [libav-devel] [PATCH 09/14] svq3: Change type of array stride parameters to ptrdiff_t

On 20/09/16 22:07, Diego Biurrun wrote: > On Tue, Sep 20, 2016 at 09:22:06PM +0100, Mark Thompson wrote: >> On 20/09/16 19:36, Diego Biurrun wrote: >>> ptrdiff_t is the correct type for array strides and similar. >>> --- a/libavcodec/svq3.c >>> +++ b/libavcodec/svq3.c >>> @@ -118,8 +118,8 @@

Re: [libav-devel] [PATCH 2/3] rscc: Support palette formate

On Tue, Sep 20, 2016 at 3:07 PM, Anton Khirnov wrote: > typo in the commite message > > Quoting Vittorio Giovara (2016-09-19 22:33:43) >> From: Carl Eugen Hoyos >> >> Signed-off-by: Vittorio Giovara >> --- >> libavcodec/rscc.c |

Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

On Tue, Sep 20, 2016 at 3:05 PM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-09-19 22:33:42) >> --- >> libavcodec/avcodec.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index c863e53..840222c 100644 >>

Re: [libav-devel] [PATCH 09/14] svq3: Change type of array stride parameters to ptrdiff_t

On Tue, Sep 20, 2016 at 09:22:06PM +0100, Mark Thompson wrote: > On 20/09/16 19:36, Diego Biurrun wrote: > > ptrdiff_t is the correct type for array strides and similar. > > --- a/libavcodec/svq3.c > > +++ b/libavcodec/svq3.c > > @@ -118,8 +118,8 @@ typedef struct SVQ3Context { > > int mb_x,

Re: [libav-devel] [PATCH 2/3] vaapi_encode: Check packed header capabilities

Quoting Mark Thompson (2016-09-18 20:35:40) > This improves behaviour with drivers which do not support packed > headers, such as AMD VCE on mesa/gallium. > --- > libavcodec/vaapi_encode.c | 36 +--- > libavcodec/vaapi_encode.h | 3 +++ >

Re: [libav-devel] [PATCH 09/14] svq3: Change type of array stride parameters to ptrdiff_t

On 20/09/16 19:36, Diego Biurrun wrote: > ptrdiff_t is the correct type for array strides and similar. > --- > libavcodec/svq3.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c > index aa85e7c..bd83731 100644 > ---

Re: [libav-devel] [Libav-devel][Patch] hwupload_cuda - Add P010 and YUV444P16 pixel format

On 19/09/16 15:38, Yogender Gupta wrote: > Added support for P010 and YUV444P16 pixel formats to hwupload_cuda. While it adds support usable from hwupload_cuda, the patch is to hwcontext_cuda - the title and commit message probably want to be corrected. Patch itself LGTM. Thanks, - Mark

Re: [libav-devel] [PATCH 1/3] vaapi_encode: Refactor initialisation

Quoting Mark Thompson (2016-09-18 20:34:35) > This allows better checking of capabilities and will make it easier > to add more functionality later. > > It also commonises some duplicated code around rate control setup > and adds more comments explaining the internals. > --- >

Re: [libav-devel] [PATCH] avconv: fix guessed channel layout being lost during stream copy

Quoting James Almer (2016-09-18 19:07:52) > The guessed layout was being stored in the decoder context, which in the case > of > stream copy is unused. > > Signed-off-by: James Almer > --- > Didn't run FATE after this patch, but aside from guess_input_channel_layout() >

Re: [libav-devel] [Libav-devel][Patch] hwupload_cuda - Add P010 and YUV444P16 pixel format

Quoting Yogender Gupta (2016-09-19 16:38:37) > Added support for P010 and YUV444P16 pixel formats to hwupload_cuda. > Are you going to add support for those to scale_npp as well? Should be fairly trivial. -- Anton Khirnov ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/3] rscc: Support palette formate

typo in the commite message Quoting Vittorio Giovara (2016-09-19 22:33:43) > From: Carl Eugen Hoyos > > Signed-off-by: Vittorio Giovara > --- > libavcodec/rscc.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > >

Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

Quoting Vittorio Giovara (2016-09-19 22:33:42) > --- > libavcodec/avcodec.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index c863e53..840222c 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -1190,6 +1190,9 @@

Re: [libav-devel] [PATCH] pixfmt: Document alternative names for smpte 431 and 432

On Tue, Sep 20, 2016 at 03:00:31PM -0400, Vittorio Giovara wrote: > --- > libavutil/pixfmt.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) probably OK Diego ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] pixfmt: Document alternative names for smpte 431 and 432

--- libavutil/pixfmt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index 8a8d624..e653652 100644 --- a/libavutil/pixfmt.h +++ b/libavutil/pixfmt.h @@ -304,8 +304,8 @@ enum AVColorPrimaries { AVCOL_PRI_BT2020 = 9, ///<

[libav-devel] [PATCH 08/14] hevc: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- libavcodec/hevc.c | 12 ++-- libavcodec/hevc_filter.c | 4 ++-- libavcodec/hevcdsp_template.c | 36 ++-- tests/checkasm/hevc_mc.c | 16 4 files changed,

[libav-devel] [PATCH 11/14] mss*: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- libavcodec/mss12.c| 15 --- libavcodec/mss12.h| 6 +++--- libavcodec/mss2.c | 6 +++--- libavcodec/mss2dsp.c | 28 ++-- libavcodec/mss2dsp.h | 22 --

[libav-devel] [PATCH 09/14] svq3: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- libavcodec/svq3.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index aa85e7c..bd83731 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -118,8

[libav-devel] [PATCH 06/14] rv34: Change type of array stride parameters to ptrdiff_t

This avoids SIMD-optimized functions having to sign-extend their stride argument manually to be able to do pointer arithmetic. --- libavcodec/arm/rv34dsp_neon.S | 4 +-- libavcodec/arm/rv40dsp_neon.S | 4 +-- libavcodec/rv30.c | 4 +-- libavcodec/rv30dsp.c | 64

[libav-devel] [PATCH 12/14] mpegaudiodsp: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- libavcodec/aarch64/mpegaudiodsp_neon.S | 1 - libavcodec/mpegaudiodsp.h | 16 ++-- libavcodec/mpegaudiodsp_template.c | 4 ++-- libavcodec/ppc/mpegaudiodsp_altivec.c | 2 +-

[libav-devel] [PATCH 10/14] ea: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- libavcodec/eacmv.c | 4 ++-- libavcodec/eaidct.c | 3 ++- libavcodec/eaidct.h | 3 ++- libavcodec/eamad.c | 4 ++-- libavcodec/eatgq.c | 6 +++--- libavcodec/eatgv.c | 2 +- libavcodec/eatqi.c | 2 +- 7 files changed, 13

[libav-devel] [PATCH 04/14] idct: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- doc/optimization.txt| 2 +- libavcodec/arm/idct.h | 13 libavcodec/arm/idctdsp_arm.S| 2 +- libavcodec/arm/idctdsp_init_arm.c | 15 ++ libavcodec/arm/idctdsp_init_armv6.c |

[libav-devel] [PATCH 13/14] checkasm: vp8dsp: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- tests/checkasm/vp8dsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/vp8dsp.c b/tests/checkasm/vp8dsp.c index 40e4061..ac0a788 100644 --- a/tests/checkasm/vp8dsp.c +++

[libav-devel] [PATCH 14/14] hpeldsp: arm: Update comments left behind in 25841dfe806a13de526ae09c11149ab1f83555a8

--- libavcodec/arm/hpeldsp_arm.S | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/arm/hpeldsp_arm.S b/libavcodec/arm/hpeldsp_arm.S index 0f8092e..6eb4837 100644 --- a/libavcodec/arm/hpeldsp_arm.S +++ b/libavcodec/arm/hpeldsp_arm.S @@ -90,7 +90,7 @@

[libav-devel] [PATCH 07/14] vc1: Change type of array stride parameters to ptrdiff_t

This avoids SIMD-optimized functions having to sign-extend their stride argument manually to be able to do pointer arithmetic. Also rename all such parameters to "stride" for consistency. --- libavcodec/arm/vc1dsp_init_neon.c | 2 +- libavcodec/vc1.c | 11 ++-

[libav-devel] [PATCH 02/14] intrax8: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. Also rename all such parameters to "stride" for consistency. --- libavcodec/intrax8.c| 8 +++--- libavcodec/intrax8dsp.c | 67 + libavcodec/intrax8dsp.h | 13 ++ 3 files

[libav-devel] [PATCH 03/14] blockdsp: Change type of array stride parameters to ptrdiff_t

ptrdiff_t is the correct type for array strides and similar. --- libavcodec/blockdsp.c | 6 -- libavcodec/blockdsp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/blockdsp.c b/libavcodec/blockdsp.c index e3d2ca1..92a1f17 100644 --- a/libavcodec/blockdsp.c

[libav-devel] [PATCH 05/14] h264chroma: Change type of stride parameters to ptrdiff_t

This avoids SIMD-optimized functions having to sign-extend their stride argument manually to be able to do pointer arithmetic. --- libavcodec/aarch64/h264chroma_init_aarch64.c | 12 ++-- libavcodec/aarch64/h264cmc_neon.S| 7 ++- libavcodec/aarch64/rv40dsp_init_aarch64.c

[libav-devel] [PATCH 01/14] x86: fpel: Remove unnecessary sign extend

--- libavcodec/x86/fpel.asm | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/x86/fpel.asm b/libavcodec/x86/fpel.asm index b581471..b1be289 100644 --- a/libavcodec/x86/fpel.asm +++ b/libavcodec/x86/fpel.asm @@ -35,7 +35,6 @@ INIT_MMX mmxext %define OP mova %endif cglobal

Re: [libav-devel] [Libav-devel][Patch] hwupload_cuda - Add P010 and YUV444P16 pixel format

On 19/09/16 16:38, Yogender Gupta wrote: > Added support for P010 and YUV444P16 pixel formats to hwupload_cuda. > It seems fine to me. Thank you! ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

On 19/09/16 22:33, Vittorio Giovara wrote: > --- > libavcodec/avcodec.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index c863e53..840222c 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -1190,6 +1190,9 @@

Re: [libav-devel] [PATCH 3/3] fate: Add test for rscc palette

On 19/09/16 22:33, Vittorio Giovara wrote: > --- > tests/fate/screen.mak| 3 +++ > tests/ref/fate/rscc-8bit | 2 ++ > 2 files changed, 5 insertions(+) > create mode 100644 tests/ref/fate/rscc-8bit > > diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak > index 7e91f19..a386fd3 100644

Re: [libav-devel] [PATCH 2/3] rscc: Support palette formate

On 19/09/16 22:33, Vittorio Giovara wrote: > From: Carl Eugen Hoyos > > Signed-off-by: Vittorio Giovara > --- > libavcodec/rscc.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > Seems fine.