Re: [libav-devel] [PATCH 2/2] swscale: Add GRAY12

2016-11-03 Thread Vittorio Giovara
On Thu, Nov 3, 2016 at 4:45 PM, Luca Barbato wrote: > --- > libswscale/input.c | 2 ++ > libswscale/swscale_internal.h | 2 ++ > libswscale/swscale_unscaled.c | 1 + > libswscale/utils.c | 2 ++ >

Re: [libav-devel] [PATCH 5/5] [RFC] configure: more fine-grained link-time dependency settings

2016-11-03 Thread Janne Grunau
On 2016-10-25 23:30:50 +0200, Diego Biurrun wrote: > On Fri, Sep 09, 2016 at 08:08:55PM +0200, Janne Grunau wrote: > > On 2016-09-05 20:31:39 +0200, Diego Biurrun wrote: > > > Previously all external library dependencies were added as link-time > > > dependencies to all components. This adds bogus

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Martin Storsjö
On Thu, 3 Nov 2016, Janne Grunau wrote: On 2016-11-02 14:58:41 +0200, Martin Storsjö wrote: --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/vp9dsp_init_aarch64.c | 139 ++ libavcodec/aarch64/vp9mc_neon.S | 733 +++

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Janne Grunau
On 2016-11-03 23:36:08 +0200, Martin Storsjö wrote: > On Thu, 3 Nov 2016, Diego Biurrun wrote: > > >On Thu, Nov 03, 2016 at 11:02:17PM +0200, Martin Storsjö wrote: > >>On Thu, 3 Nov 2016, Diego Biurrun wrote: > >>>On Thu, Nov 03, 2016 at 09:42:44PM +0100, Janne Grunau wrote: > On 2016-11-03

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Janne Grunau
On 2016-11-02 14:58:41 +0200, Martin Storsjö wrote: > --- > libavcodec/aarch64/Makefile | 2 + > libavcodec/aarch64/vp9dsp_init_aarch64.c | 139 ++ > libavcodec/aarch64/vp9mc_neon.S | 733 > +++ > libavcodec/vp9.h |

Re: [libav-devel] [PATCH] ppc: pixblockdsp: do unaligned block accesses correctly again

2016-11-03 Thread Andreas Cadhalpun
On 03.11.2016 22:06, Luca Barbato wrote: > On 03/11/2016 21:35, Andreas Cadhalpun wrote: >> On 03.11.2016 09:36, Luca Barbato wrote: >>> The patch makes sense only if line_size is not a multiple of 16 and >>> normally AVFrames have their linesizes multiple of 32 ... >> >> Yes, but this limitation

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Martin Storsjö
On Thu, 3 Nov 2016, Diego Biurrun wrote: On Thu, Nov 03, 2016 at 11:02:17PM +0200, Martin Storsjö wrote: On Thu, 3 Nov 2016, Diego Biurrun wrote: >On Thu, Nov 03, 2016 at 09:42:44PM +0100, Janne Grunau wrote: >>On 2016-11-03 20:38:11 +0100, Diego Biurrun wrote: >>> On Wed, Nov 02, 2016 at

Re: [libav-devel] [PATCH 2/3] avconv_opt: Rework hwaccels array iteration to avoid a warning on empty array

2016-11-03 Thread Luca Barbato
On 03/11/2016 18:32, Diego Biurrun wrote: > -for (i = 0; i < FF_ARRAY_ELEMS(hwaccels) - 1; i++) { > +while (hwaccels[i++].name) for (i = 0; hwaccels[i].name; i++) { Is how it is used everywhere else. Alternatively we can drop `-Wtype-limits` and use the FF_ARRAY_ELEMS() everywhere.

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Diego Biurrun
On Thu, Nov 03, 2016 at 11:02:17PM +0200, Martin Storsjö wrote: > On Thu, 3 Nov 2016, Diego Biurrun wrote: > >On Thu, Nov 03, 2016 at 09:42:44PM +0100, Janne Grunau wrote: > >>On 2016-11-03 20:38:11 +0100, Diego Biurrun wrote: > >>> On Wed, Nov 02, 2016 at 07:24:03PM +0100, Janne Grunau wrote: >

Re: [libav-devel] [PATCH] ppc: pixblockdsp: do unaligned block accesses correctly again

2016-11-03 Thread Luca Barbato
On 03/11/2016 21:35, Andreas Cadhalpun wrote: > On 03.11.2016 09:36, Luca Barbato wrote: >> On 02/11/2016 21:34, Andreas Cadhalpun wrote: >>> Tested with qemu on ppc32be and ppc64be. >> >> How did you configure it? > > I used qemu-ppc64-static for ppc64be and > 'export QEMU_CPU=7400_v2.9;

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Martin Storsjö
On Thu, 3 Nov 2016, Diego Biurrun wrote: On Thu, Nov 03, 2016 at 09:42:44PM +0100, Janne Grunau wrote: On 2016-11-03 20:38:11 +0100, Diego Biurrun wrote: > On Wed, Nov 02, 2016 at 07:24:03PM +0100, Janne Grunau wrote: > > On 2016-11-02 15:29:34 +0100, Diego Biurrun wrote: > > > On Wed, Nov 02,

[libav-devel] [PATCH 2/2] swscale: Add GRAY12

2016-11-03 Thread Luca Barbato
--- libswscale/input.c | 2 ++ libswscale/swscale_internal.h | 2 ++ libswscale/swscale_unscaled.c | 1 + libswscale/utils.c | 2 ++ tests/ref/fate/filter-pixdesc-gray12be | 1 + tests/ref/fate/filter-pixdesc-gray12le | 1 +

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Diego Biurrun
On Thu, Nov 03, 2016 at 09:42:44PM +0100, Janne Grunau wrote: > On 2016-11-03 20:38:11 +0100, Diego Biurrun wrote: > > On Wed, Nov 02, 2016 at 07:24:03PM +0100, Janne Grunau wrote: > > > On 2016-11-02 15:29:34 +0100, Diego Biurrun wrote: > > > > On Wed, Nov 02, 2016 at 04:00:38PM +0200, Martin

[libav-devel] [PATCH 1/2] pixfmt: Add GRAY12

2016-11-03 Thread Luca Barbato
--- libavutil/pixdesc.c | 22 ++ libavutil/pixfmt.h | 4 2 files changed, 26 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 7987f29..db90229 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -493,6 +493,27 @@ static const

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Janne Grunau
On 2016-11-03 20:38:11 +0100, Diego Biurrun wrote: > On Wed, Nov 02, 2016 at 07:24:03PM +0100, Janne Grunau wrote: > > On 2016-11-02 15:29:34 +0100, Diego Biurrun wrote: > > > On Wed, Nov 02, 2016 at 04:00:38PM +0200, Martin Storsjö wrote: > > > > On Wed, 2 Nov 2016, Diego Biurrun wrote: > > > >

Re: [libav-devel] [PATCH] ppc: pixblockdsp: do unaligned block accesses correctly again

2016-11-03 Thread Andreas Cadhalpun
On 03.11.2016 09:36, Luca Barbato wrote: > On 02/11/2016 21:34, Andreas Cadhalpun wrote: >> Tested with qemu on ppc32be and ppc64be. > > How did you configure it? I used qemu-ppc64-static for ppc64be and 'export QEMU_CPU=7400_v2.9; qemu-ppc-static' for ppc32be. On 03.11.2016 10:21, Luca

Re: [libav-devel] [RFC] [PATCH] configure: Make sure config.h isn't accidentally included in builds for the host

2016-11-03 Thread Martin Storsjö
On Thu, 3 Nov 2016, Diego Biurrun wrote: On Thu, Nov 03, 2016 at 02:32:10PM +0200, Martin Storsjö wrote: In aacps_tablegen.h, only include libm.h if building for the target. If actual fallbacks are needed here (in practice, sinf and cosf, which are missing on Plan 9 - they are present even on

Re: [libav-devel] [PATCH] Drop unreachable break and return statements

2016-11-03 Thread Vittorio Giovara
On Thu, Nov 3, 2016 at 4:12 PM, Diego Biurrun wrote: > On Thu, Nov 03, 2016 at 04:04:54PM -0400, Vittorio Giovara wrote: >> On Thu, Nov 3, 2016 at 1:25 PM, Diego Biurrun wrote: >> > --- >> > >> > Dropped the cmdutils.c part, which is a tad more complicated, as

Re: [libav-devel] [PATCH] Drop unreachable break and return statements

2016-11-03 Thread Diego Biurrun
On Thu, Nov 03, 2016 at 04:04:54PM -0400, Vittorio Giovara wrote: > On Thu, Nov 3, 2016 at 1:25 PM, Diego Biurrun wrote: > > --- > > > > Dropped the cmdutils.c part, which is a tad more complicated, as noticed by > > Luca. > > > > libavcodec/bmvvideo.c | 1 - > >

Re: [libav-devel] [PATCH 2/3] avconv_opt: Rework hwaccels array iteration to avoid a warning on empty array

2016-11-03 Thread Vittorio Giovara
On Thu, Nov 3, 2016 at 3:42 PM, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-11-03 18:32:35) >> avconv_opt.c:188:19: warning: comparison of unsigned expression < 0 is >> always false [-Wtype-limits] >> --- >> avconv_opt.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3

Re: [libav-devel] [PATCH] Drop unreachable break and return statements

2016-11-03 Thread Vittorio Giovara
On Thu, Nov 3, 2016 at 1:25 PM, Diego Biurrun wrote: > --- > > Dropped the cmdutils.c part, which is a tad more complicated, as noticed by > Luca. > > libavcodec/bmvvideo.c | 1 - > libavcodec/hevc_sei.c | 1 - > libavcodec/indeo3.c| 2 -- > libavcodec/sanm.c | 3

Re: [libav-devel] [PATCH 1/3] mov: Change MOVTrack.entry to unsigned

2016-11-03 Thread Diego Biurrun
On Thu, Nov 03, 2016 at 08:41:10PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-11-03 18:32:34) > > libavformat/movenc.c:3170:12: warning: assuming signed overflow does not > > occur when assuming that (X - c) > X is always false [-Wstrict-overflow] > > This is not sufficient

Re: [libav-devel] [PATCH 2/3] avconv_opt: Rework hwaccels array iteration to avoid a warning on empty array

2016-11-03 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-03 18:32:35) > avconv_opt.c:188:19: warning: comparison of unsigned expression < 0 is always > false [-Wtype-limits] > --- > avconv_opt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/avconv_opt.c b/avconv_opt.c > index

Re: [libav-devel] [PATCH 1/3] mov: Change MOVTrack.entry to unsigned

2016-11-03 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-03 18:32:34) > libavformat/movenc.c:3170:12: warning: assuming signed overflow does not > occur when assuming that (X - c) > X is always false [-Wstrict-overflow] This is not sufficient explanation for the commit. Just the fact that some compiler warns about some

Re: [libav-devel] [PATCHv2] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Diego Biurrun
On Wed, Nov 02, 2016 at 07:24:03PM +0100, Janne Grunau wrote: > On 2016-11-02 15:29:34 +0100, Diego Biurrun wrote: > > On Wed, Nov 02, 2016 at 04:00:38PM +0200, Martin Storsjö wrote: > > > On Wed, 2 Nov 2016, Diego Biurrun wrote: > > > >On Wed, Nov 02, 2016 at 03:23:14PM +0200, Martin Storsjö

Re: [libav-devel] [RFC] [PATCH] configure: Make sure config.h isn't accidentally included in builds for the host

2016-11-03 Thread Diego Biurrun
On Thu, Nov 03, 2016 at 02:32:10PM +0200, Martin Storsjö wrote: > In aacps_tablegen.h, only include libm.h if building for the target. > > If actual fallbacks are needed here (in practice, sinf and cosf, > which are missing on Plan 9 - they are present even on MSVC), we need > to include libm.h,

Re: [libav-devel] [PATCH] Drop unreachable break and return statements

2016-11-03 Thread Luca Barbato
On 03/11/2016 18:25, Diego Biurrun wrote: > --- > > Dropped the cmdutils.c part, which is a tad more complicated, as noticed by > Luca. > This subset looks safe. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 3/3] x86: Drop stray semicolons after function definitions

2016-11-03 Thread Luca Barbato
On 03/11/2016 18:32, Diego Biurrun wrote: > libavcodec/x86/rv40dsp_init.c:97:2: warning: ISO C does not allow extra ‘;’ > outside of a function [-Wpedantic] > libavcodec/x86/vp9dsp_init.c:94:40: warning: ISO C does not allow extra ‘;’ > outside of a function [-Wpedantic] > --- >

[libav-devel] [PATCH 3/3] x86: Drop stray semicolons after function definitions

2016-11-03 Thread Diego Biurrun
libavcodec/x86/rv40dsp_init.c:97:2: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic] libavcodec/x86/vp9dsp_init.c:94:40: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic] --- libavcodec/x86/rv40dsp_init.c | 2 +- libavcodec/x86/vp9dsp_init.c

[libav-devel] [PATCH 1/3] mov: Change MOVTrack.entry to unsigned

2016-11-03 Thread Diego Biurrun
libavformat/movenc.c:3170:12: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Wstrict-overflow] --- libavformat/movenc.c | 2 +- libavformat/movenc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c

[libav-devel] [PATCH 2/3] avconv_opt: Rework hwaccels array iteration to avoid a warning on empty array

2016-11-03 Thread Diego Biurrun
avconv_opt.c:188:19: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] --- avconv_opt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/avconv_opt.c b/avconv_opt.c index 1064cf4..a3fd3dd 100644 --- a/avconv_opt.c +++ b/avconv_opt.c @@ -187,12

[libav-devel] [PATCH] Drop unreachable break and return statements

2016-11-03 Thread Diego Biurrun
--- Dropped the cmdutils.c part, which is a tad more complicated, as noticed by Luca. libavcodec/bmvvideo.c | 1 - libavcodec/hevc_sei.c | 1 - libavcodec/indeo3.c| 2 -- libavcodec/sanm.c | 3 --- libavformat/rtpproto.c | 1 - libavformat/rtspdec.c | 1 - libavformat/smush.c|

Re: [libav-devel] [PATCH 8/9] Use avpriv_report_missing_feature() where appropriate

2016-11-03 Thread Diego Biurrun
On Mon, Oct 31, 2016 at 07:36:14PM +0100, Diego Biurrun wrote: > On Thu, Oct 27, 2016 at 08:54:59PM +0200, Diego Biurrun wrote: > > --- > > libavcodec/aacdec.c | 3 +-- > > libavcodec/alac.c | 8 > > libavcodec/bmp.c| 3 ++- > > libavcodec/fraps.c

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-03 Thread Diego Biurrun
On Wed, Nov 02, 2016 at 08:15:01AM +, Ruta Gadkari wrote: > >> --- a/libavcodec/Makefile > >> +++ b/libavcodec/Makefile > > >As I said before, you do not add all the necessary entries. > > >See also > >https://www.libav.org/documentation/developer.html#New-codecs-or-formats-checklist > > I

Re: [libav-devel] [PATCH] vf_hwupload_cuda: Fix build error

2016-11-03 Thread Diego Biurrun
On Thu, Nov 03, 2016 at 04:33:25PM +, Mark Thompson wrote: > Broken by e3fb74f7f9a8f1895381355f40c92cac3c1023d9. > --- > libavfilter/vf_hwupload_cuda.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/2] mov: Export spherical information

2016-11-03 Thread Diego Biurrun
On Wed, Nov 02, 2016 at 02:15:07PM -0400, Vittorio Giovara wrote: > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -3154,6 +3155,242 @@ static int mov_read_elst(MOVContext *c, AVIOContext > *pb, MOVAtom atom) > > +static int mov_read_st3d(MOVContext *c, AVIOContext *pb, MOVAtom atom) >

[libav-devel] [PATCH] vf_hwupload_cuda: Fix build error

2016-11-03 Thread Mark Thompson
Broken by e3fb74f7f9a8f1895381355f40c92cac3c1023d9. --- libavfilter/vf_hwupload_cuda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c index 94d5013..b5631c2 100644 --- a/libavfilter/vf_hwupload_cuda.c +++

Re: [libav-devel] [PATCH 3/5] pixblockdsp: Have function pointer prototype match implementation

2016-11-03 Thread Diego Biurrun
On Tue, Nov 01, 2016 at 05:51:16PM +0100, Diego Biurrun wrote: > libavcodec/pixblockdsp.c(58) : warning C4028: formal parameter 1 different > from declaration > libavcodec/pixblockdsp.c(63) : warning C4028: formal parameter 1 different > from declaration > libavcodec/pixblockdsp.c(66) : warning

Re: [libav-devel] [PATCH 5/5] float_dsp: Have implementation match function pointer prototype

2016-11-03 Thread Diego Biurrun
On Tue, Nov 01, 2016 at 05:51:18PM +0100, Diego Biurrun wrote: > libavutil/x86/float_dsp_init.c(144) : warning C4028: formal parameter 1 > different from declaration > libavutil/x86/float_dsp_init.c(144) : warning C4028: formal parameter 2 > different from declaration > --- >

Re: [libav-devel] [PATCH 2/5] ituh263dec: Have function signature match across declaration and definition

2016-11-03 Thread Diego Biurrun
On Tue, Nov 01, 2016 at 05:51:15PM +0100, Diego Biurrun wrote: > libavcodec/ituh263dec.c(215) : warning C4028: formal parameter 1 different > from declaration > libavcodec/ituh263dec.c(215) : warning C4028: formal parameter 2 different > from declaration > --- > libavcodec/h263.h | 6 +- >

Re: [libav-devel] [PATCH] configure: Silence lld-link when getting the version number

2016-11-03 Thread Luca Barbato
On 03/11/2016 13:15, Martin Storsjö wrote: > In recent lld-link versions, this command prints the version to > stdout, but also prints an error to stderr: > > $ lld-link -flavor gnu --version > LLD 4.0.0 (trunk 285641) > lld-link: error: no input files > lld-link: error: target emulation unknown:

[libav-devel] [RFC] [PATCH] configure: Make sure config.h isn't accidentally included in builds for the host

2016-11-03 Thread Martin Storsjö
In aacps_tablegen.h, only include libm.h if building for the target. If actual fallbacks are needed here (in practice, sinf and cosf, which are missing on Plan 9 - they are present even on MSVC), we need to include libm.h, but this relies on configure test results for the target. These test

[libav-devel] [PATCH] configure: Silence lld-link when getting the version number

2016-11-03 Thread Martin Storsjö
In recent lld-link versions, this command prints the version to stdout, but also prints an error to stderr: $ lld-link -flavor gnu --version LLD 4.0.0 (trunk 285641) lld-link: error: no input files lld-link: error: target emulation unknown: -m or at least one .o file required --- configure | 2

Re: [libav-devel] [PATCH] ppc: pixblockdsp: do unaligned block accesses correctly again

2016-11-03 Thread Luca Barbato
On 02/11/2016 21:34, Andreas Cadhalpun wrote: > @@ -67,10 +67,10 @@ static void get_pixels_altivec(int16_t *restrict block, > const uint8_t *pixels, > ptrdiff_t line_size) > { The patch makes sense only if line_size is not a multiple of 16 and normally AVFrames

Re: [libav-devel] [PATCH] options_table: Remove a now unnecessary include of config.h

2016-11-03 Thread Martin Storsjö
On Thu, 3 Nov 2016, Martin Storsjö wrote: The include of config.h was added in 2012 in 1d9c2dc8, due to the use of CONFIG_SHOW_ENCODER ifdefs within options_table.h. CONFIG_SNOW_ENCODER, of course. Amended locally. // Martin ___ libav-devel mailing

Re: [libav-devel] [PATCH] options_table: Remove a now unnecessary include of config.h

2016-11-03 Thread Luca Barbato
On 03/11/2016 09:58, Martin Storsjö wrote: > The include of config.h was added in 2012 in 1d9c2dc8, due to > the use of CONFIG_SHOW_ENCODER ifdefs within options_table.h. > When the snow codec was dropped later (in a0c5917f8 in 2013), > this include no longer served any purpose. Ok with

Re: [libav-devel] [PATCH 3.5/8] qsvdec: Only warn about unconsumed data if it happens more than once

2016-11-03 Thread Luca Barbato
On 02/11/2016 23:23, Mark Thompson wrote: > --- > To fit into the middle of the qsv set, before VC-1. > > Mitigates the spam output from the vc1_qsv decoder - a single failure like > this is probably just a residual fragment of a packet, not a real problem. > Should also mitigate the spam in

[libav-devel] [PATCH] options_table: Remove a now unnecessary include of config.h

2016-11-03 Thread Martin Storsjö
The include of config.h was added in 2012 in 1d9c2dc8, due to the use of CONFIG_SHOW_ENCODER ifdefs within options_table.h. When the snow codec was dropped later (in a0c5917f8 in 2013), this include no longer served any purpose. options_table.h is included in builds for the host as well, when

Re: [libav-devel] [PATCHv4] arm: vp9: Add NEON optimizations of VP9 MC functions

2016-11-03 Thread Janne Grunau
On 2016-11-02 23:14:28 +0200, Martin Storsjö wrote: > On Wed, 2 Nov 2016, Martin Storsjö wrote: > > I'll push the arm version tomorrow unless there's more comments on it. patch ok. push when you want. Janne ___ libav-devel mailing list

Re: [libav-devel] [PATCH] ppc: pixblockdsp: do unaligned block accesses correctly again

2016-11-03 Thread Luca Barbato
On 02/11/2016 21:34, Andreas Cadhalpun wrote: > Tested with qemu on ppc32be and ppc64be. How did you configure it? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel