Re: [libav-devel] [PATCH] examples/decode_audio: Add missing header for av_free()

2016-11-08 Thread Luca Barbato
On 09/11/2016 06:11, Diego Biurrun wrote: > --- > > This fixes the build after the next version bump. > Anton, the stab counter will have to be reset... > > doc/examples/decode_audio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/examples/decode_audio.c b/do

[libav-devel] [PATCH] examples/decode_audio: Add missing header for av_free()

2016-11-08 Thread Diego Biurrun
--- This fixes the build after the next version bump. Anton, the stab counter will have to be reset... doc/examples/decode_audio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index 647893c..b56a5ee 100644 ---

Re: [libav-devel] [PATCH 3/7] configure: Do not unconditionally check for (and enable) xlib

2016-11-08 Thread Luca Barbato
On 08/11/2016 20:35, Diego Biurrun wrote: > This avoids unnecessarily linking against xlib. > --- > > The relevant Anton has already been appropriately stabbed. > > configure | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) vaapi should be tested using pkg-config. The res

Re: [libav-devel] [PATCH 4/7] configure: Log correct test name and use correct filter when testing objective C flags

2016-11-08 Thread Luca Barbato
On 08/11/2016 20:35, Diego Biurrun wrote: > --- > > The relevant Luca has already been appropriately stabbed. > > configure | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https:

[libav-devel] [PATCH] fate: Add h264 and hevc extradata reload tests

2016-11-08 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- tests/fate/h264.mak | 5 + tests/fate/hevc.mak | 5 + tests/ref/fate/h264-extradata-reload | 5 + tests/ref/fate/hevc-extradata-reload | 5 + 4 files changed, 20 insertions(+) create mode 100644 tests/ref/fate/

Re: [libav-devel] [FFmpeg-devel] [PATCH] mpegts: prevent division by zero

2016-11-08 Thread Andreas Cadhalpun
On 08.11.2016 21:09, Michael Niedermayer wrote: > On Tue, Nov 08, 2016 at 07:47:02PM +0100, Andreas Cadhalpun wrote: >> On 08.11.2016 00:54, Michael Niedermayer wrote: >>> On Mon, Nov 07, 2016 at 11:49:52PM +0100, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavf

Re: [libav-devel] [PATCH 7/7] configure: Move license checks directly after command line parsing

2016-11-08 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 2:35 PM, Diego Biurrun wrote: > This will allow to error out immediately if incompatible options are > passed on the command line instead of running time-consuming tests. > --- > configure | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > d

Re: [libav-devel] [PATCH 6/7] configure: Log name and parameters of all helper functions where it makes sense

2016-11-08 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 2:35 PM, Diego Biurrun wrote: > --- > configure | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure b/configure > index 422036b..70a0d95 100755 > --- a/configure > +++ b/configure > @@ -1027,6 +1027,7 @@ check_exec(){ > } > > check_exec_crash(){ > +l

Re: [libav-devel] [PATCH 5/7] configure: Use check_cpp in CPP flags tests

2016-11-08 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 2:35 PM, Diego Biurrun wrote: > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 4cfa066..422036b 100755 > --- a/configure > +++ b/configure > @@ -865,7 +865,7 @@ check_code(){ > > check_cppflags(){

Re: [libav-devel] [PATCH 2/7] configure: Print list of enabled programs

2016-11-08 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 2:35 PM, Diego Biurrun wrote: > Also drop a related and now redundant informative output line. > --- > configure | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7dda871..a6617b5 100755 > --- a/configure > +++ b/conf

Re: [libav-devel] [PATCH 1/7] configure: Improve output wording

2016-11-08 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 2:35 PM, Diego Biurrun wrote: > Also drop a redundant output line. > --- > configure | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/configure b/configure > index e862757..7dda871 100755 > --- a/configure > +++ b/configure > @@ -79,7 +79,7

Re: [libav-devel] [RFC] avpacket: Mark src pointer as constant

2016-11-08 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 1:35 PM, Luca Barbato wrote: > --- > > libavcodec/avcodec.h | 2 +- > libavcodec/avpacket.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 88e6c62..a770cf2 100644 > --- a/libavcodec/avcodec.h

[libav-devel] [PATCH 1/7] configure: Improve output wording

2016-11-08 Thread Diego Biurrun
Also drop a redundant output line. --- configure | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configure b/configure index e862757..7dda871 100755 --- a/configure +++ b/configure @@ -79,7 +79,7 @@ Help options: Standard options: --logfile=FILE log tests

[libav-devel] [PATCH 6/7] configure: Log name and parameters of all helper functions where it makes sense

2016-11-08 Thread Diego Biurrun
--- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 422036b..70a0d95 100755 --- a/configure +++ b/configure @@ -1027,6 +1027,7 @@ check_exec(){ } check_exec_crash(){ +log check_exec_crash "$@" code=$(cat) # exit() is not async signal

[libav-devel] [PATCH 7/7] configure: Move license checks directly after command line parsing

2016-11-08 Thread Diego Biurrun
This will allow to error out immediately if incompatible options are passed on the command line instead of running time-consuming tests. --- configure | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 70a0d95..acc74f2 100755 ---

[libav-devel] [PATCH 5/7] configure: Use check_cpp in CPP flags tests

2016-11-08 Thread Diego Biurrun
--- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 4cfa066..422036b 100755 --- a/configure +++ b/configure @@ -865,7 +865,7 @@ check_code(){ check_cppflags(){ log check_cppflags "$@" -check_cc "$@"

[libav-devel] [PATCH 4/7] configure: Log correct test name and use correct filter when testing objective C flags

2016-11-08 Thread Diego Biurrun
--- The relevant Luca has already been appropriately stabbed. configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 93edc99..4cfa066 100755 --- a/configure +++ b/configure @@ -884,15 +884,15 @@ check_cflags(){ } test_objcflags(){ -

[libav-devel] [PATCH 3/7] configure: Do not unconditionally check for (and enable) xlib

2016-11-08 Thread Diego Biurrun
This avoids unnecessarily linking against xlib. --- The relevant Anton has already been appropriately stabbed. configure | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/configure b/configure index a6617b5..93edc99 100755 --- a/configure +++ b/configure @@ -477

[libav-devel] [PATCH 2/7] configure: Print list of enabled programs

2016-11-08 Thread Diego Biurrun
Also drop a related and now redundant informative output line. --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 7dda871..a6617b5 100755 --- a/configure +++ b/configure @@ -5177,7 +5177,6 @@ echo "shared${shared-no

Re: [libav-devel] [FFmpeg-devel] [PATCH] mpegts: prevent division by zero

2016-11-08 Thread Andreas Cadhalpun
On 08.11.2016 00:54, Michael Niedermayer wrote: > On Mon, Nov 07, 2016 at 11:49:52PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/mpegts.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c >> in

[libav-devel] [RFC] avpacket: Mark src pointer as constant

2016-11-08 Thread Luca Barbato
--- libavcodec/avcodec.h | 2 +- libavcodec/avpacket.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 88e6c62..a770cf2 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -3986,7 +3986,7 @@ void av_packet_free_

[libav-devel] [PATCH] mpegaudiodsp: aarch64: Adjust function prototype after 2caa93b813adc5dbb7771dfe615da826a2947d18

2016-11-08 Thread Diego Biurrun
--- libavcodec/aarch64/mpegaudiodsp_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/aarch64/mpegaudiodsp_init.c b/libavcodec/aarch64/mpegaudiodsp_init.c index a8b2baf..849e310 100644 --- a/libavcodec/aarch64/mpegaudiodsp_init.c +++ b/libavcodec/aarch64/m

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Anton Khirnov
Hi, I had some comments in a mail from 2016-11-02, message id 20161102083330.15572.40655@localhost They don't seem to have been addressed. Also, could you please do one of: - send new patches as replies in one thread - number the new threads (such as v2, v3 etc.) so that it's simpler to find the l

[libav-devel] [PATCH] avconv: Drop stray leftover debug output

2016-11-08 Thread Diego Biurrun
--- avconv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/avconv.c b/avconv.c index 769b9e0..97166d9 100644 --- a/avconv.c +++ b/avconv.c @@ -206,7 +206,6 @@ static void avconv_cleanup(int ret) if (ost->muxing_queue) { while (av_fifo_size(ost->muxing_queue)) {

Re: [libav-devel] [PATCH] avconv: Drop stray leftover debug output

2016-11-08 Thread Vittorio Giovara
On Tue, Nov 8, 2016 at 11:49 AM, Diego Biurrun wrote: > --- > avconv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/avconv.c b/avconv.c > index 769b9e0..97166d9 100644 > --- a/avconv.c > +++ b/avconv.c > @@ -206,7 +206,6 @@ static void avconv_cleanup(int ret) > if (ost->muxing

Re: [libav-devel] [PATCH 8/9] Use avpriv_report_missing_feature() where appropriate

2016-11-08 Thread Diego Biurrun
On Thu, Oct 27, 2016 at 08:54:59PM +0200, Diego Biurrun wrote: > --- > libavcodec/aacdec.c | 3 +-- > libavcodec/alac.c | 8 > libavcodec/bmp.c| 3 ++- > libavcodec/fraps.c | 4 +--- > libavcodec/g2meet.c | 11 +-- > libavcodec/g7

Re: [libav-devel] [PATCH 2/2] hevc: Support extradata changes

2016-11-08 Thread Vittorio Giovara
On Mon, Nov 7, 2016 at 5:44 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > This version avoids fiddling with freeing/allocating context extradata. > I'm not a 100% sure it is needed, but I recall having some problems when > reallocating the extradata buffer from context and

Re: [libav-devel] [PATCH 1/2] h264_qpel: x86: Move function with only one instance out of template macro

2016-11-08 Thread Diego Biurrun
On Tue, Nov 01, 2016 at 05:51:53PM +0100, Diego Biurrun wrote: > libavcodec/x86/h264_qpel.c:392:785: warning: unused function > 'ff_avg_h264_qpel8or16_hv1_lowpass_mmxext' [-Wunused-function] > --- > libavcodec/x86/h264_qpel.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deleti

Re: [libav-devel] [PATCH] mov: Read multiple stsd from DV

2016-11-08 Thread Vittorio Giovara
On Mon, Nov 7, 2016 at 10:30 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > libavformat/mov.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index e9318bd..475a9ef 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Diego Biurrun
On Tue, Nov 08, 2016 at 02:28:44PM +, Ruta Gadkari wrote: > On 11/08/2016 03:47 PM, Diego Biurrun wrote: > > This duplicates the AVHWaccel declaration and breaks in interesting ways. > Since HWACCEL is not used as a stand-alone, reverted to ff_cuvid_hwaccel > being defined only when correspond

[libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Ruta Gadkari
Please review patch to add support for CUVID decode in Libav. On 11/08/2016 03:47 PM, Diego Biurrun wrote: > This does not work like you think it does. When cuvid was requested you check > whether or not libnvcuvid is available. Settle on one name and use that > throughout. Corrected. Used 'c

Re: [libav-devel] [PATCH] xiph: const correctness for avpriv_split_xiph_headers()

2016-11-08 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-07 20:47:22) > On Mon, Nov 07, 2016 at 03:22:03PM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-11-05 13:00:21) > > > diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c > > > index 2fef74a..f00cd3e 100644 > > > --- a/libavformat/oggenc.c > > > +++

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Diego Biurrun
On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: > From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 > From: Timo Rothenpieler > Date: Tue, 8 Nov 2016 14:13:23 +0530 > Subject: [PATCH 1/1] CUVID: Add support for CUVID decode > > --- /dev/null > +++ b/libavcodec/c

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Diego Biurrun
On Tue, Nov 08, 2016 at 11:38:43AM +0100, Hendrik Leppkes wrote: > On Tue, Nov 8, 2016 at 11:16 AM, Diego Biurrun wrote: > > On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: > >> From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 > >> From: Timo Rothenpieler > >>

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Hendrik Leppkes
On Tue, Nov 8, 2016 at 11:16 AM, Diego Biurrun wrote: > On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: >> From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 >> From: Timo Rothenpieler >> Date: Tue, 8 Nov 2016 14:13:23 +0530 >> Subject: [PATCH 1/1] CUVID: Add sup

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Diego Biurrun
On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: > From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 > From: Timo Rothenpieler > Date: Tue, 8 Nov 2016 14:13:23 +0530 > Subject: [PATCH 1/1] CUVID: Add support for CUVID decode > > --- a/configure > +++ b/configure

Re: [libav-devel] [PATCH 2/2] fate: checkasm: Split monolithic test into individual components

2016-11-08 Thread Martin Storsjö
On Sat, 5 Nov 2016, Diego Biurrun wrote: --- And yes, this gives a speedup with parallel make. tests/fate/checkasm.mak | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) Well, "speedup", the checkasm test is so fast anyway compared to launching more processes.

Re: [libav-devel] [PATCH 1/2] checkasm: Add --test parameter to check only specific components

2016-11-08 Thread Martin Storsjö
On Sat, 5 Nov 2016, Diego Biurrun wrote: Inspired by a patch from Martin Storsjö . --- I'm not really happy with "--test" as parameter name. Maybe "--component" is better? Other suggestions welcome... tests/checkasm/checkasm.c | 28 ++-- 1 file changed, 18 insertions(+),

[libav-devel] [PATCH] Add support for CUVID decode

2016-11-08 Thread Ruta Gadkari
Please review patch to add support for CUVID decode in Libav. On 11/05/2016 04:17 PM, Diego Biurrun wrote: > This patch has grown. Now it adds cuvid support to avconv. Did Timo write > that? It's still under his name. If you create new functionality, do so in > separate patches. Patches should

Re: [libav-devel] [PATCH 3/3] mov: Export spherical information

2016-11-08 Thread Diego Biurrun
On Mon, Nov 07, 2016 at 04:14:13PM -0500, Vittorio Giovara wrote: > --- a/libavformat/isom.h > +++ b/libavformat/isom.h > @@ -28,6 +28,9 @@ > #include "internal.h" > #include "dv.h" > > +#include "libavutil/spherical.h" > +#include "libavutil/stereo3d.h" These should go above the libavformat h

Re: [libav-devel] [PATCH 2/3] lavc: Add spherical packet side data API

2016-11-08 Thread Diego Biurrun
On Mon, Nov 07, 2016 at 04:14:12PM -0500, Vittorio Giovara wrote: > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -13,6 +13,10 @@ libavutil: 2015-08-28 > > API changes, most recent first: > > +2016-xx-xx - xxx - lavc 57.30.0 - avcodec.h > + Add AV_PKT_DATA_SPHERICAL packet side dat

Re: [libav-devel] [PATCH 1/3] lavu: Add AVSphericalMapping type and frame side data

2016-11-08 Thread Diego Biurrun
On Mon, Nov 07, 2016 at 04:14:11PM -0500, Vittorio Giovara wrote: > --- /dev/null > +++ b/libavutil/spherical.c > @@ -0,0 +1,29 @@ > + > +#include > + > +#include "mem.h" > +#include "spherical.h" > + > +AVSphericalMapping *av_spherical_alloc(void) > +{ > +return av_mallocz(sizeof(AVSphericalM

Re: [libav-devel] [FFmpeg-devel] [PATCH] mpegts: prevent division by zero

2016-11-08 Thread Marton Balint
On Mon, 7 Nov 2016, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavformat/mpegts.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index fad10c6..77d63f2 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2692