[libav-devel] [PATCH] matroskaenc: fix writing ProjectionPrivate element on Cubemap projections

2017-04-06 Thread James Almer
Calling put_ebml_binary() with sizeof(private) as argument is currently only valid for Equirectangular projections. Signed-off-by: James Almer --- Please, be more careful when making cosmetic changes to make sure they don't also change how the code works. Not only this was writing invalid Cubemap

Re: [libav-devel] [PATCH 1/3] avutil/spherical: add functions to retrieve and request projection names

2017-04-06 Thread Vittorio Giovara
On Tue, Apr 4, 2017 at 10:24 PM, James Almer wrote: > Signed-off-by: James Almer > --- > doc/APIchanges| 4 > libavutil/spherical.c | 28 > libavutil/spherical.h | 18 ++ > libavutil/version.h | 2 +- > 4 files changed, 51 insertions(

Re: [libav-devel] [PATCH] configure: Escape elements being filtered

2017-04-06 Thread Diego Biurrun
On Thu, Apr 06, 2017 at 06:14:29PM +0200, Luca Barbato wrote: > The function is used to filter out ldflags arguments that may contain $. > Update filter() as well to be consistent. > --- > > Ping in form of updated patch. > > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

[libav-devel] [PATCH] configure: Escape elements being filtered

2017-04-06 Thread Luca Barbato
The function is used to filter out ldflags arguments that may contain $. Update filter() as well to be consistent. --- Ping in form of updated patch. configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ecc7784..4458df3 100755 --- a/config

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Steve Lhomme
On Thu, Apr 6, 2017 at 1:08 PM, Hendrik Leppkes wrote: > On Thu, Apr 6, 2017 at 11:35 AM, Steve Lhomme wrote: >> On Thu, Apr 6, 2017 at 11:08 AM, Hendrik Leppkes wrote: >>> On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: Hi, As I am progressing in proper HDR10 support in VLC

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Hendrik Leppkes
On Thu, Apr 6, 2017 at 11:35 AM, Steve Lhomme wrote: > On Thu, Apr 6, 2017 at 11:08 AM, Hendrik Leppkes wrote: >> On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: >>> Hi, >>> >>> As I am progressing in proper HDR10 support in VLC, I am facing an >>> issue. The mastering (and lighting pending

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Vittorio Giovara
On Thu, Apr 6, 2017 at 12:22 PM, wm4 wrote: > On Thu, 6 Apr 2017 11:48:54 +0200 > Steve Lhomme wrote: > >> On Thu, Apr 6, 2017 at 11:38 AM, wm4 wrote: >> > On Thu, 6 Apr 2017 11:08:24 +0200 >> > Hendrik Leppkes wrote: >> > >> >> On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: >> >> > Hi,

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Luca Barbato
On 06/04/2017 12:22, wm4 wrote: > I think these AVCodecContext fields should be removed. You need to split decoding context from encoding context to do that... lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinf

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread wm4
On Thu, 6 Apr 2017 11:48:54 +0200 Steve Lhomme wrote: > On Thu, Apr 6, 2017 at 11:38 AM, wm4 wrote: > > On Thu, 6 Apr 2017 11:08:24 +0200 > > Hendrik Leppkes wrote: > > > >> On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: > >> > Hi, > >> > > >> > As I am progressing in proper HDR10 su

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Steve Lhomme
On Thu, Apr 6, 2017 at 11:38 AM, wm4 wrote: > On Thu, 6 Apr 2017 11:08:24 +0200 > Hendrik Leppkes wrote: > >> On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: >> > Hi, >> > >> > As I am progressing in proper HDR10 support in VLC, I am facing an >> > issue. The mastering (and lighting pending

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Steve Lhomme
On Thu, Apr 6, 2017 at 11:38 AM, Luca Barbato wrote: > On 06/04/2017 11:01, Steve Lhomme wrote: >> I CC'ed libav as they have opinions on possible API changes, even >> though there is no mastering metadata support in there yet. > > You should send over those changes otherwise here isn't much we ca

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Luca Barbato
On 06/04/2017 11:01, Steve Lhomme wrote: > I CC'ed libav as they have opinions on possible API changes, even > though there is no mastering metadata support in there yet. You should send over those changes otherwise here isn't much we can say :) It should be a side-data like many other from what

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread wm4
On Thu, 6 Apr 2017 11:08:24 +0200 Hendrik Leppkes wrote: > On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: > > Hi, > > > > As I am progressing in proper HDR10 support in VLC, I am facing an > > issue. The mastering (and lighting pending patch) metadata are set on > > the AVFrame but not ava

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Steve Lhomme
On Thu, Apr 6, 2017 at 11:08 AM, Hendrik Leppkes wrote: > On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: >> Hi, >> >> As I am progressing in proper HDR10 support in VLC, I am facing an >> issue. The mastering (and lighting pending patch) metadata are set on >> the AVFrame but not available

[libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Steve Lhomme
Hi, As I am progressing in proper HDR10 support in VLC, I am facing an issue. The mastering (and lighting pending patch) metadata are set on the AVFrame but not available to the ff_get_format() receiver. That means when we configure our vout and decoder we don't know if it's going to have HDR met

Re: [libav-devel] ff_thread_get_format and metadata

2017-04-06 Thread Hendrik Leppkes
On Thu, Apr 6, 2017 at 11:01 AM, Steve Lhomme wrote: > Hi, > > As I am progressing in proper HDR10 support in VLC, I am facing an > issue. The mastering (and lighting pending patch) metadata are set on > the AVFrame but not available to the ff_get_format() receiver. > > That means when we configur