[libav-devel] [PATCH v3 1/2] lavc, lavu: move frame cropping to a convenience function

2017-07-22 Thread wm4
--- doc/APIchanges | 3 ++ libavcodec/decode.c | 89 ++ libavutil/frame.c | 100 libavutil/frame.h | 34 ++ libavutil/version.h | 2 +- 5 files changed, 140

[libav-devel] [PATCH v3 2/2] imgutils: add function to clear an image to black

2017-07-22 Thread wm4
Black isn't always just memset(ptr, 0, size). Limited YUV in particular requires relatively non-obvious values, and filling a frame with repeating 0 bytes is disallowed in some contexts. With component sizes larger than 8 or packed YUV, this can become relatively complicated. So having a generic

Re: [libav-devel] [PATCH 08/15] lavc: Add trace_headers bitstream filter

2017-07-22 Thread Anton Khirnov
Quoting Mark Thompson (2017-06-24 01:39:14) > +static int trace_headers(AVBSFContext *bsf, AVPacket *out) > +{ > +TraceHeadersContext *ctx = bsf->priv_data; > +CodedBitstreamFragment au; > +AVPacket *in; > +int err; > + > +err = ff_bsf_get_packet(bsf, ); > +if (err < 0) > +

Re: [libav-devel] [PATCH 03/15] hevc: Validate the number of long term reference pictures

2017-07-22 Thread Anton Khirnov
Quoting Mark Thompson (2017-06-24 01:39:09) > This would overflow if the stream contained a value greater than the > maximum allowed by the standard (32). > --- > libavcodec/hevc_ps.c | 6 ++ > 1 file changed, 6 insertions(+) > Looks ok and should go into stable. -- Anton Khirnov

Re: [libav-devel] [PATCH 02/15] hevc: Improve stream constraint values in common header

2017-07-22 Thread Anton Khirnov
Quoting Mark Thompson (2017-06-24 01:39:08) > Add comments to describe the sources of the constraint values expressed here, > and add some more related values which will be used in following patches. > > Fix the incorrect values for SPS and PPS count (they are not the same as those > used for

Re: [libav-devel] [PATCH 01/15] h264: Add stream constraint values to the common header

2017-07-22 Thread Anton Khirnov
Quoting Mark Thompson (2017-06-24 01:39:07) > With comments describing the derivation of each value. > --- > libavcodec/h264.h | 45 + > 1 file changed, 45 insertions(+) > No objections from me. An enum is a bit unusual, but I don't see it as a

Re: [libav-devel] [PATCH 08/25] libavfilter changes for the new channel layout API

2017-07-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-06-29 00:10:52) > This patch contains the following commits: > > avtools: Use the new channel layout API in libavfilter Again, this does not belong here. The libraries should be converted separately from their users, and FATE should pass both before and after. That

Re: [libav-devel] [PATCH 07/25] lavfi, buffersrc: switch to the new channel layout API

2017-07-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-06-29 00:10:51) > Signed-off-by: Vittorio Giovara > --- > libavfilter/audio.c | 17 +-- > libavfilter/avfilter.c | 9 > libavfilter/avfilter.h | 13 ++- > libavfilter/avfiltergraph.c | 35

Re: [libav-devel] [PATCH 06/25] lavr: switch to the new channel layout API

2017-07-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-06-29 00:10:50) > diff --git a/libavresample/utils.c b/libavresample/utils.c > index bab2153b4b..15c827efbe 100644 > --- a/libavresample/utils.c > +++ b/libavresample/utils.c > @@ -18,6 +18,7 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA

Re: [libav-devel] [PATCH 05/25] avtools: Use the new channel layout API in AVFrame

2017-07-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-06-29 00:10:49) > --- > avtools/avconv.c| 2 +- > avtools/avconv_filter.c | 2 +- > avtools/avplay.c| 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > Again, seems premature. The switch should be done at the end. If it needs to be done

Re: [libav-devel] [PATCH 04/25] avframe: switch to the new channel layout API

2017-07-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-06-29 00:10:48) > From: Anton Khirnov > > Signed-off-by: Vittorio Giovara > --- > libavcodec/decode.c | 67 > libavcodec/encode.c | 9 ++ > libavutil/frame.c | 88 >

Re: [libav-devel] [PATCH 04/25] avframe: switch to the new channel layout API

2017-07-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-06-29 00:10:48) > From: Anton Khirnov > > Signed-off-by: Vittorio Giovara > --- > libavcodec/decode.c | 67 > libavcodec/encode.c | 9 ++ Why are there lavc changes in

Re: [libav-devel] [PATCH] Add a new channel layout API

2017-07-22 Thread Anton Khirnov
Quoting wm4 (2017-07-05 20:53:54) > On Fri, 30 Jun 2017 12:51:16 -0400 > Vittorio Giovara wrote: > > > On Fri, Jun 30, 2017 at 4:38 AM, wm4 wrote: > > > On Thu, 29 Jun 2017 17:28:51 -0400 > > > Vittorio Giovara

Re: [libav-devel] [PATCH 01/25] Add a new channel layout API

2017-07-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-06-29 00:10:45) > + > +enum AVChannelOrder { > +/** > + * The native channel order, i.e. the channels are in the same order in > + * which they are defined in the AVChannel enum. This supports up to 63 > + * different channels. > + */ > +

Re: [libav-devel] [PATCH 5/5] h264dec: add a CUVID hwaccel

2017-07-22 Thread Anton Khirnov
Quoting Luca Barbato (2017-07-21 19:28:29) > On 21/07/2017 15:19, Anton Khirnov wrote: > > Some parts of the code are based on a patch by > > Timo Rothenpieler > > --- > > Seems fine, once I manage to boot the desktop I can test it. > > lu > > PS: Do you have plans for