Re: [libav-devel] [PATCH] avutil: make AV_NOPTS_VALUE signed negative

2017-11-05 Thread Vittorio Giovara
On Sun, Nov 5, 2017 at 6:21 AM, Rémi Denis-Courmont wrote: > libav generally uses int64_t to represent timestamps, and thus > AV_NOPTS_VALUE has to fit witin the range of int64_t. > > The current definition of AV_NOPTS_VALUE results in AV_NOPTS_VALUE > having the same type as

[libav-devel] [PATCH 2&3/10] lavc: Add hardware config metadata for decoders supporting hardware output

2017-11-05 Thread Mark Thompson
This includes a pointer to the associated hwaccel for decoders using hwaccels - these will be used later to implement the hwaccel setup without needing a global list. Also added is a new file listing all hwaccels as external declarations - this will be used later to generate the hwaccel list at

Re: [libav-devel] [PATCH 01/10] lavc: Add codec metadata to indicate hardware support

2017-11-05 Thread Mark Thompson
On 05/11/17 19:36, Diego Biurrun wrote: > This is a general remark rather than a review comment, I just happened to > notice > something in this patch that I have been wondering about for a long time. > > On Sun, Nov 05, 2017 at 12:00:00AM +, Mark Thompson wrote: >> ---

Re: [libav-devel] [PATCH 01/10] lavc: Add codec metadata to indicate hardware support

2017-11-05 Thread Diego Biurrun
This is a general remark rather than a review comment, I just happened to notice something in this patch that I have been wondering about for a long time. On Sun, Nov 05, 2017 at 12:00:00AM +, Mark Thompson wrote: > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -2735,6 +2736,61

Re: [libav-devel] [PATCH 02/10] lavc: Add a new file listing all hwaccels as external declarations

2017-11-05 Thread Diego Biurrun
On Sun, Nov 05, 2017 at 12:00:01AM +, Mark Thompson wrote: > These will be used later to generate the hwaccel list at configure time, > but are needed now for the config structures in the following patch. > --- > libavcodec/hwaccels.h | 59 >

Re: [libav-devel] [PATCH] vp9_superframe_bsf: cache packets by creating new references instead of moving pointers

2017-11-05 Thread Luca Barbato
On 05/11/2017 17:44, James Almer wrote: Fixes invalid reads after free. Signed-off-by: James Almer --- libavcodec/vp9_superframe_bsf.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) Sounds good

[libav-devel] [PATCH] vp9_superframe_bsf: cache packets by creating new references instead of moving pointers

2017-11-05 Thread James Almer
Fixes invalid reads after free. Signed-off-by: James Almer --- libavcodec/vp9_superframe_bsf.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp9_superframe_bsf.c b/libavcodec/vp9_superframe_bsf.c index

Re: [libav-devel] [PATCH] avutil: make AV_NOPTS_VALUE signed negative

2017-11-05 Thread Mark Thompson
On 05/11/17 11:21, Rémi Denis-Courmont wrote: > libav generally uses int64_t to represent timestamps, and thus > AV_NOPTS_VALUE has to fit witin the range of int64_t. > > The current definition of AV_NOPTS_VALUE results in AV_NOPTS_VALUE > having the same type as uint64_t, since its value is

Re: [libav-devel] [PATCH] configure: Use right variable and right value for AIX ar flags

2017-11-05 Thread Luca Barbato
On 04/11/2017 20:13, Diego Biurrun wrote: --- .. grmbl .. configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 50e7591b7c..ee13b4db81 100755 --- a/configure +++ b/configure @@ -3895,7 +3895,7 @@ case $target_os in