Re: [libav-devel] [PATCH 098/124] pngdec: convert to refcounted frames.

On 2013-01-08 15:37:50 +0100, Anton Khirnov wrote: --- libavcodec/pngdec.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index c4e7ebc..a5f83c9 100644 --- a/libavcodec/pngdec.c +++

Re: [libav-devel] [PATCH 099/124] escape124: convert to refcounted frames.

On 2013-01-08 15:37:51 +0100, Anton Khirnov wrote: --- libavcodec/escape124.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/libavcodec/escape124.c b/libavcodec/escape124.c index a27ab68..b304dd8 100644 --- a/libavcodec/escape124.c +++

Re: [libav-devel] [PATCH 123/124] vp8: convert to refcounted frames.

On 2013-01-08 15:38:15 +0100, Anton Khirnov wrote: --- libavcodec/vp8.c | 204 ++ libavcodec/vp8.h | 27 2 files changed, 128 insertions(+), 103 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index

[libav-devel] [PATCH 1/1] h264: fix chroma format and bit depth changes after de-MpegEncContext-ize

with these changes to fix chroma format and bit depth changes h264.c looks mostly ok too. Please amend to the original patch. Janne ---8--- --- libavcodec/h264.c | 28 +++- libavcodec/h264.h | 3 ++- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git

Re: [libav-devel] [PATCH] h264: deMpegEncContextize

On 2013-02-13 16:26:43 +0100, Anton Khirnov wrote: On Wed, 13 Feb 2013 15:19:57 +0100, Janne Grunau janne-li...@jannau.net wrote: On 2013-02-13 14:01:07 +0100, Anton Khirnov wrote: diff --git a/libavcodec/h264.h b/libavcodec/h264.h index c4addbe..6d57723 100644 --- a/libavcodec

Re: [libav-devel] [PATCH] lavc decoders: work with refcounted frames.

On 2013-02-13 19:48:32 +0100, Anton Khirnov wrote: --- libavcodec/avcodec.h | 123 +- libavcodec/internal.h | 49 ++-- libavcodec/options.c |4 +- libavcodec/options_table.h |1 + libavcodec/pthread.c |2 - libavcodec/utils.c | 578

Re: [libav-devel] [PATCH 1/2] audio decoders: add a third parameter to ff_get_buffer().

On 2013-02-13 14:33:10 -0500, Justin Ruggles wrote: Hi, The commit message could be a little clearer. I had to look back at other patches to figure out why this patch was needed and what the 3rd parameter was for. I guess the commit is going to be squashed with the commit which actually

Re: [libav-devel] [PATCH 2/2] aacdec: convert to refcounted frames.

On 2013-02-13 20:01:18 +0100, Anton Khirnov wrote: --- libavcodec/aacdec.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 133a557..65129c8 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -180,8 +180,9

Re: [libav-devel] [PATCH 02/19] mpegvideo: change the signature of ff_print_debug_info().

On 2013-02-13 19:51:02 +0100, Anton Khirnov wrote: Take a Picture instead of AVFrame. It is needed because some fields from AVFrame printed by this function will be moved to Picture. --- libavcodec/h261dec.c |2 +- libavcodec/h263dec.c |3 ++- libavcodec/mpeg12.c|4

Re: [libav-devel] [PATCH] h264idct: Replace duplicate scan8 table by appropriate #include

On 2013-02-13 13:51:00 +0100, Diego Biurrun wrote: On Sat, Jan 19, 2013 at 12:37:32AM +0100, Luca Barbato wrote: On 19/01/13 00:01, Diego Biurrun wrote: I think there is some other way to correctly measure binary size that I am forgetting right now. ruby-elf and dwarves. With

Re: [libav-devel] [PATCH] error_resilience: decouple ER from MpegEncContext

On 2013-02-12 20:18:13 +0100, Anton Khirnov wrote: --- * by popular vote, added _pic to last/cur/next variables * removed b_stride and b4_stride * for h264, update last and next picture when corresponding MpegEncContext fields are updated thanks --- libavcodec/error_resilience.c |

Re: [libav-devel] [PATCH] h264: deMpegEncContextize

On 2013-02-13 14:01:07 +0100, Anton Khirnov wrote: Most of the changes are just trivial are just trivial replacements of fields from MpegEncContext with equivalent fields in H264Context. Everything in h264* other than h264.c are those trivial changes. The nontrivial parts are: 1) extracting

Re: [libav-devel] [PATCH] h264: Copy h264chroma dsp context to slice thread copies

On 2013-02-11 20:28:55 +0200, Martin Storsjö wrote: This fixes slice threading which seems to have been broken since 79dad2a93. --- libavcodec/h264.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 464c403..542070b 100644 ---

Re: [libav-devel] [PATCH] arm: Fall back to runtime cpu feature detection via /proc/cpuinfo

On 2013-02-07 11:29:40 +0200, Martin Storsjö wrote: On recent android versions, /proc/self/auxw is unreadable (unless the process is running running under the shell uid or in debuggable mode, which makes it hard to notice). See http://b.android.com/43055 and

Re: [libav-devel] [PATCH] arm: Fall back to runtime cpu feature detection via /proc/cpuinfo

On 2013-02-11 17:07:20 +0200, Martin Storsjö wrote: On recent android versions, /proc/self/auxw is unreadable (unless the process is running running under the shell uid or in debuggable mode, which makes it hard to notice). See http://b.android.com/43055 and

[libav-devel] [PATCH 1/1] arm: h264qpel: use neon h264 qpel functions only if supported

--- libavcodec/arm/h264qpel_init_arm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/arm/h264qpel_init_arm.c b/libavcodec/arm/h264qpel_init_arm.c index b546c2a..097d0b8 100644 --- a/libavcodec/arm/h264qpel_init_arm.c +++ b/libavcodec/arm/h264qpel_init_arm.c

[libav-devel] [PATCH 1/1] h264: copy h264qpel dsp context to slice thread copies

--- libavcodec/h264.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 9e9384b..38a6f5e 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -2556,6 +2556,7 @@ static int h264_slice_header_init(H264Context *h, int reinit) memcpy(c,

Re: [libav-devel] [PATCH 1/1] arm: h264qpel: use neon h264 qpel functions only if supported

On 2013-01-24 16:51:04 +0100, Kostya Shishkov wrote: On Thu, Jan 24, 2013 at 04:47:00PM +0100, Janne Grunau wrote: --- libavcodec/arm/h264qpel_init_arm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/arm/h264qpel_init_arm.c b/libavcodec/arm

[libav-devel] [PATCH 1/1] arm: h264qpel: use neon h264 qpel functions only if supported

--- libavcodec/arm/h264qpel_init_arm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/arm/h264qpel_init_arm.c b/libavcodec/arm/h264qpel_init_arm.c index b546c2a..21eb72f 100644 --- a/libavcodec/arm/h264qpel_init_arm.c +++ b/libavcodec/arm/h264qpel_init_arm.c

Re: [libav-devel] [PATCH] avfilter: allow setpts filter to use wallclock time for calculations

On 2013-01-24 17:09:05 +0100, Vladimir Pantelic wrote: changed to use RTCTIME and RTCSTART From 272d056828858c2adb73511405b107ac805212c8 Mon Sep 17 00:00:00 2001 From: Vladimir Pantelic vlado...@gmail.com Date: Wed, 23 Jan 2013 13:54:08 +0100 Subject: [PATCH] avfilter: allow setpts filter to

Re: [libav-devel] [PATCH] x86: h264qpel: Move a stray comment to the right spot

On 2013-01-24 17:07:11 +0100, Diego Biurrun wrote: --- libavcodec/x86/dsputil_mmx.c |2 -- libavcodec/x86/h264_qpel.c |2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/dsputil_mmx.c b/libavcodec/x86/dsputil_mmx.c index f9da04f..f72500e 100644

[libav-devel] [PATCH 1/1] x86: h264qpel: add cpu flag checks for init function

The code was copied from per cpu extension init function so the checks for supported extensions was overlooked. --- libavcodec/x86/h264_qpel.c | 139 - 1 file changed, 74 insertions(+), 65 deletions(-) diff --git a/libavcodec/x86/h264_qpel.c

[libav-devel] [PATCH 1/1] x86: h264qpel: add cpu flag checks for init function

The code was copied from per cpu extension init function so the checks for supported extensions was overlooked. --- libavcodec/x86/h264_qpel.c | 147 +++-- 1 file changed, 75 insertions(+), 72 deletions(-) diff --git a/libavcodec/x86/h264_qpel.c

[libav-devel] [PATCH 1/1] videodsp_armv5te: remove #if HAVE_ARMV5TE_EXTERNAL

libavutil/arm/asm.S sets '.arch' depending on HAVE_ARMV5TE so that assembling armv5te code will always succeed even if the default -march flag does not support it. HAVE_ARMV5TE_EXTERNAL tests assembling code with the default arch. Fixes the missing symbol ff_prefetch_arm with --cpu= not including

Re: [libav-devel] Memory allocators (overkill solutions to realloc)

On 2013-01-19 14:29:27 +0100, Luca Barbato wrote: Between yesterday and today I started playing and integrating some known memory allocators that provide a mean to have a realigned malloc. Here some numbers from an h264 + ac3 in mkv file ./avconv_normal bench: utime=140.790s

Re: [libav-devel] [PATCH 3/3] fate: vp3: Fix fate-vp3-coeff-level64 test dependencies

On 2012-12-30 14:59:49 +0100, Diego Biurrun wrote: Also rename the test to reflect that the video track is Theora, not VP3. --- tests/fate/vpx.mak |8 .../{vp3-coeff-level64 = theora-coeff-level64}|0 2 files changed, 4 insertions(+), 4

Re: [libav-devel] [PATCH 2/3] fate: cosmetics: Order some test entries

On 2012-12-30 14:59:48 +0100, Diego Biurrun wrote: --- tests/fate/cdxl.mak |6 +++--- tests/fate/lossless-video.mak | 12 ++-- tests/fate/microsoft.mak | 12 ++-- tests/fate/seek.mak | 16 tests/fate/utvideo.mak|

Re: [libav-devel] [PATCH 1/3] fate: Fix fate-siff dependencies and move to a more appropriate file

On 2012-12-30 14:59:47 +0100, Diego Biurrun wrote: The test is not a pure demuxer test, it also tests VB video decoding. care to split it into a pure demuxer and a demuxer+video decoder test? The naming for the tests looks odd after moving it to video.mak Janne

Re: [libav-devel] [PATCH] fate: Split fate-siff test into demuxer and VB video decoder test

On 2013-01-10 16:22:35 +0100, Diego Biurrun wrote: --- I dropped the -t 3 for the demuxer test. Maybe I should drop it for both or keep it for both, not sure... dropping it just for the demuxer test seems fine tests/fate/demux.mak|4 +- tests/fate/video.mak|3 +

Re: [libav-devel] h264: support frame parameter changes during frame-mt

On 2012-12-29 02:06:40 +0100, Rafaël Carré wrote: Le 26/12/2012 01:41, Janne Grunau a écrit : Before the commit it was only probed once? When does it get probed? in the get_format callback? It was probed only once, and you're right, it's done in the get_format callback

[libav-devel] [PATCH 1/1] mpegvideo: initialize videodsp with correct pixel depth

Fixes decoding of 9/10 bit per pixel h264 videos as reported in https://bugzilla.libav.org/show_bug.cgi?id=404 . --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 0fab9af..0b6ddb9 100644 ---

Re: [libav-devel] [PATCH 1/1] mpegvideo: initialize videodsp with correct pixel depth

On 2012-12-25 15:50:30 -0800, Ronald S. Bultje wrote: Hi, On Tue, Dec 25, 2012 at 3:41 PM, Janne Grunau janne-li...@jannau.net wrote: Fixes decoding of 9/10 bit per pixel h264 videos as reported in https://bugzilla.libav.org/show_bug.cgi?id=404 . --- libavcodec/mpegvideo.c | 2 +- 1

Re: [libav-devel] h264: support frame parameter changes during frame-mt

On 2012-12-25 22:51:06 +0100, Rafaël Carré wrote: Hello, Le 18/12/2012 20:01, Janne Grunau a écrit : Module: libav Branch: master Commit: 9e696d2e5ffaa763c564682ec18c3b51b3e5fccc Author:Janne Grunau janne-li...@jannau.net Committer: Janne Grunau janne-li...@jannau.net Date

Re: [libav-devel] [PATCH] alacdec: do not be too strict about the extradata size

On 2012-12-22 01:25:53 -0500, Justin Ruggles wrote: Sometimes the extradata has duplicate atoms, but that shouldn't prevent decoding. Just ensure that it is at least 36 bytes as a sanity check. Checking the known size as validation is not a bad idea, unfortunately it's common for mov demuxers

[libav-devel] [PATCH 1/1] h264: fix sps parsing for SVC and CAVLC 4:4:4 Intra profiles

From: Galland gallan...@gmail.com Fixes bug 396. CC: libav-sta...@libav.org --- libavcodec/h264_ps.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 7eb8726..ff86f64 100644 --- a/libavcodec/h264_ps.c +++

[libav-devel] [PATCH 1/1] mov: handle h263 and flv1 for codec_tag 'H', '2', '6', '3'

The sample in https://bugzilla.libav.org/show_bug.cgi?id=393 and samples/F4V/H263_NM_f.mp4 both have codec_tag H263 for different codecs. H263 is apparently used by Flash Media Server for Sorensen Spark videos. Patch based on commit 5442083b1c541dd166b3adf39131259fc846a62b by Carl Eugen Hoyos.

Re: [libav-devel] [PATCH 03/22] 4xm: simplify code with FFSWAP

On 2012-12-19 10:17:10 +0100, Anton Khirnov wrote: --- libavcodec/4xm.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c index 6f3ec4a..db77c7b 100644 --- a/libavcodec/4xm.c +++ b/libavcodec/4xm.c @@ -760,7 +760,7 @@ static

Re: [libav-devel] [PATCH 18/22] avs: return meaningful error codes.

On 2012-12-19 10:17:25 +0100, Anton Khirnov wrote: --- libavcodec/avs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/avs.c b/libavcodec/avs.c index 98a53f2..71b8b0c 100644 --- a/libavcodec/avs.c +++ b/libavcodec/avs.c @@ -54,14 +54,14 @@

Re: [libav-devel] [PATCH 05/22] 4xm: eliminate a pointless indirection

On 2012-12-19 10:17:12 +0100, Anton Khirnov wrote: --- libavcodec/4xm.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c index 1084f04..07fb155 100644 --- a/libavcodec/4xm.c +++ b/libavcodec/4xm.c @@ -877,16 +877,6

Re: [libav-devel] [PATCH 06/22] 4xm: operate with pointers to AVFrames instead of whole structs.

On 2012-12-19 10:17:13 +0100, Anton Khirnov wrote: This is more correct and avoids the whole extended_data mess. extended_data mess in libavcodec/utils.c? Just asking because the patch doesn't change anything with extended_data. --- libavcodec/4xm.c | 52

Re: [libav-devel] [PATCH 07/22] 8bps: cosmetics

On 2012-12-19 10:17:14 +0100, Anton Khirnov wrote: Remove some pointless comments and empty lines. --- libavcodec/8bps.c | 25 - 1 file changed, 25 deletions(-) diff --git a/libavcodec/8bps.c b/libavcodec/8bps.c index 306fd52..8f0692c 100644 ---

Re: [libav-devel] [PATCH 08/22] 8bps: return meaningful error codes.

On 2012-12-19 10:17:15 +0100, Anton Khirnov wrote: --- libavcodec/8bps.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/8bps.c b/libavcodec/8bps.c index 8f0692c..ceed13f 100644 --- a/libavcodec/8bps.c +++ b/libavcodec/8bps.c @@ -69,15 +69,16

Re: [libav-devel] [PATCH 11/22] anm: return meaningful error codes

On 2012-12-19 10:17:18 +0100, Anton Khirnov wrote: --- libavcodec/anm.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/anm.c b/libavcodec/anm.c index fc328bb..49e925d 100644 --- a/libavcodec/anm.c +++ b/libavcodec/anm.c @@ -44,7 +44,7 @@ static

Re: [libav-devel] [PATCH 1/1] h264: fix sps parsing for SVC and CAVLC 4:4:4 Intra profiles

On 2012-12-19 12:30:15 +0100, Diego Biurrun wrote: On Wed, Dec 19, 2012 at 09:38:02AM +0100, Janne Grunau wrote: From: Galland gallan...@gmail.com Do we have a realname? yes, commit already changed. Forgot to mention that I asked for the name. Janne

Re: [libav-devel] [PATCH 1/1] h264: fix sps parsing for SVC and CAVLC 4:4:4 Intra profiles

On 2012-12-19 09:59:52 +0100, Luca Barbato wrote: On 12/19/12 9:38 AM, Janne Grunau wrote: From: Galland gallan...@gmail.com Would be nice having some defines instead of bare numbers, the patch is ok though. Not sure if defines would be nicer. This is the exact same statement

Re: [libav-devel] [PATCH 06/22] 4xm: operate with pointers to AVFrames instead of whole structs.

On 2012-12-19 13:03:34 +0100, Anton Khirnov wrote: On Wed, 19 Dec 2012 11:11:16 +0100, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-19 10:17:13 +0100, Anton Khirnov wrote: This is more correct and avoids the whole extended_data mess. extended_data mess in libavcodec/utils.c

Re: [libav-devel] [PATCH 1/1] h264: fix sps parsing for SVC and CAVLC 4:4:4 Intra profiles

On 2012-12-19 13:16:14 +0100, Hendrik Leppkes wrote: On Wed, Dec 19, 2012 at 9:38 AM, Janne Grunau janne-li...@jannau.net wrote: From: Galland gallan...@gmail.com Fixes bug 396. CC: libav-sta...@libav.org --- libavcodec/h264_ps.c | 6 +- 1 file changed, 5 insertions(+), 1

[libav-devel] [PATCH 1/1] avconv: use designated initializers consistently in OptionGroupDef

Prevents triggering an assert in c99conv. --- Anton, I know you didn't like this but fixing the converter seems to be non-trivial. avconv_opt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/avconv_opt.c b/avconv_opt.c index 6c70175..d73181e 100644 --- a/avconv_opt.c +++

Re: [libav-devel] [PATCH 1/1] h264: increase dist_scale_factor for up to 32 references

On 2012-12-18 07:30:03 -0800, Ronald S. Bultje wrote: Hi, On Mon, Dec 17, 2012 at 10:55 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-17 18:24:37 -0800, Ronald S. Bultje wrote: Hi, On Dec 17, 2012 1:02 PM, Janne Grunau janne-li...@jannau.net wrote: Compute

Re: [libav-devel] [PATCH 1/1] h264: increase dist_scale_factor for up to 32 references

On 2012-12-18 10:07:59 -0800, Ronald S. Bultje wrote: Hi, On Tue, Dec 18, 2012 at 8:20 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-18 07:30:03 -0800, Ronald S. Bultje wrote: Hi, On Mon, Dec 17, 2012 at 10:55 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12

[libav-devel] [PATCH 1/1] avcodec: bump minor for adaptive h264 frame-mt

Also adds forgotten Changelog entry. --- Changelog| 1 + libavcodec/version.h | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index b4a8e60..8dfffcf 100644 --- a/Changelog +++ b/Changelog @@ -8,6 +8,7 @@ version next: - deprecated the

[libav-devel] [PATCH 1/1] mpegvideo: increase edge_emu_buffer size for VC1

The VC1 decoder uses edge_emu_buffer simultaneously for luma and chroma and needs more space. That was not a problem before f1d8763a02b5fce since the size for edge_emu_buffer was always calculated with 2 byte per pixel since the linesize was not known. Fixes occasionally fate errors in

Re: [libav-devel] [PATCH] Merge latest x86inc.asm fixes with x264.

On 2012-12-18 17:02:31 -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavutil/x86/x86inc.asm | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index

Re: [libav-devel] FATE dependencies

On 2012-12-17 15:18:52 +0100, Diego Biurrun wrote: On Mon, Dec 17, 2012 at 12:43:35AM +0100, Janne Grunau wrote: On 2012-12-16 23:45:06 +0100, Diego Biurrun wrote: There are multiple ways to handle these more general components: - have avconv directly depend on some or all of them

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

On 2012-12-16 14:46:54 -0800, Ronald S. Bultje wrote: Hi, On Sun, Dec 16, 2012 at 1:49 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-16 12:36:56 -0800, Ronald S. Bultje wrote: On Sun, Dec 16, 2012 at 5:52 AM, Janne Grunau janne-li...@jannau.net wrote: Nasm also fails

Re: [libav-devel] [PATCH 1/1] mpegvideo: allocate scratch buffers after linesize is known

On 2012-12-13 17:58:04 +0100, Janne Grunau wrote: Since we can't know which stride a custom get_buffer() implementation is going to use we have to allocate this scratch buffers after the linesize is known. It was pretty safe for 8 bit per pixel pixel formats since we always allocated memory

Re: [libav-devel] [PATCH 13/15] h264: break after error if enough NALs were seen in decode_nal_units

On 2012-12-16 20:21:47 +0200, aviad rozenhek wrote: does this patch also fix the issue where decode_slice_header error message appear when probing a .ts file [or ts udp stream] which does not start with an SPS/PPS ? nope, that would need a better parser interface, although my not so nice, not

Re: [libav-devel] Compilation failure with OpenCV

On 2012-12-17 12:06:32 -0500, mashiat.sar...@gmail.com wrote: Hi Guys I have compiled and installed OpenCV (to the default location, /usr/local/lib and /usr/local/include/opencv) and trying to compile Libav with OpenCV. I get: ERROR: opencv not found pkg_config reports library files

[libav-devel] [PATCH 1/1] h264: use mbaff ref indices in fill_colmap() only for mbaff references

From: Michael Niedermayer michae...@gmx.at Prevents writing beyond array bounds. Signed-off-by: Janne Grunau janne-li...@jannau.net --- This is a correct and better fix than my original hack. libavcodec/h264_direct.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[libav-devel] [PATCH 1/1] ff_h264_direct_ref_list_init: fix B slice check.

From: Michael Niedermayer michae...@gmx.at Fixes null pointer dereference. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind --- libavcodec/h264_direct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_direct.c b/libavcodec/h264_direct.c index

[libav-devel] [PATCH 1/1] h264: increase dist_scale_factor for up to 32 references

Compute dist_scale_factor_field only for MBAFF since that is the only case in which it is used. --- I believe this the correct fix for my original hack. libavcodec/h264.h| 2 +- libavcodec/h264_direct.c | 17 ++--- 2 files changed, 11 insertions(+), 8 deletions(-) diff

[libav-devel] [PATCH 1/1] h264: support frame parameter changes during frame-mt

Fixes CVE-2012-2782. --- mostly a ping, there have been some minor changes though, most noteable is the memset of the reference frame list on reinit. Janne libavcodec/h264.c | 355 +++--- libavcodec/h264.h | 2 + 2 files changed, 230

[libav-devel] [PATCH 1/3] h264: detect and correct invalid short ref state in remove_short

Fixes NULL pointer dereferene in bipbop234.ts_s20131. --- libavcodec/h264_refs.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index 755f115..0b88587 100644 --- a/libavcodec/h264_refs.c +++ b/libavcodec/h264_refs.c @@ -372,6 +372,12 @@

[libav-devel] [PATCH 2/3] h264: clear picture copies when unreferencing them

Copy a neighbouring frame/field from the list as error resilience measure since the decoder assumes frame data pointers of known reference to be valid. Prevents stale references in ref_list in the fuzzed sample bipbop234.ts_s20118 caused by not refreshing the ref lists when required due to slice

[libav-devel] [PATCH 3/3] h264: prevent decoding of slice NALs in extradata

It is not posible to call get_buffer during frame-mt codec initialization. Libavformat might pass huge amounts of data as extradata after parsing broken files. The 'extradata' for the fuzzed sample sample_varPAR_s5374_r001-02.avi is 2.8M large and contains multiple slices. --- libavcodec/h264.c |

Re: [libav-devel] [PATCH 10/15] h264-mt: make slice header decoding errors fatal after size changes

On 2012-12-12 21:30:11 +0100, Janne Grunau wrote: --- libavcodec/h264.c | 10 +- libavcodec/h264.h | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) This patch and Patch 12, 13 and 14 are dropped. The 3 patches set I just sent solve the issues in a cleaner and more direct way

Re: [libav-devel] [PATCH 1/1] h264: increase dist_scale_factor for up to 32 references

On 2012-12-17 18:24:37 -0800, Ronald S. Bultje wrote: Hi, On Dec 17, 2012 1:02 PM, Janne Grunau janne-li...@jannau.net wrote: Compute dist_scale_factor_field only for MBAFF since that is the only case in which it is used. The patch also increases an array size - why? to handle up to 32

Re: [libav-devel] [PATCH 13/15] h264: break after error if enough NALs were seen in decode_nal_units

On 2012-12-17 18:35:09 -0800, Ronald S. Bultje wrote: Hi, On Dec 12, 2012 12:31 PM, Janne Grunau janne-li...@jannau.net wrote: --- libavcodec/h264.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index

Re: [libav-devel] [PATCH 2/3] h264: clear picture copies when unreferencing them

On 2012-12-17 18:27:17 -0800, Ronald S. Bultje wrote: Hi, On Dec 17, 2012 1:41 PM, Janne Grunau janne-li...@jannau.net wrote: Copy a neighbouring frame/field from the list as error resilience measure since the decoder assumes frame data pointers of known reference to be valid

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

On 2012-12-14 17:12:05 -0800, Ronald S. Bultje wrote: Hi, On Fri, Dec 14, 2012 at 8:56 AM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-14 08:32:14 -0800, Ronald S. Bultje wrote: Hi, On Dec 14, 2012 3:30 AM, Janne Grunau janne-li...@jannau.net wrote: Arguments

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

On 2012-12-16 12:36:56 -0800, Ronald S. Bultje wrote: On Sun, Dec 16, 2012 at 5:52 AM, Janne Grunau janne-li...@jannau.net wrote: Nasm also fails on '%1 %+ SUFFIX' with empty SUFFIX in cpuid.asm. It was previously working since it was always followed by ', %2'. Easiest solution I've

Re: [libav-devel] FATE dependencies

On 2012-12-16 23:45:06 +0100, Diego Biurrun wrote: On Fri, Oct 19, 2012 at 07:26:02PM +0200, Diego Biurrun wrote: [...] I'm mostly done with FATE dependencies and have some 50 patches in need of cleaning locally. There are a bunch of parts required by most or a large number of FATE

Re: [libav-devel] [PATCH 2/4] lavr: only save/restore the mixing matrix if mixing is being done

On 2012-12-14 01:31:31 -0500, Justin Ruggles wrote: --- libavresample/resample.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/libavresample/resample.c b/libavresample/resample.c index 381d673..2cd9b7d 100644 --- a/libavresample/resample.c +++

[libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

Arguments on the stack are handled properly and functions can use more than arguments than the 7 registers available on x86_32. Fixes nasm build, yasm would fail too if it would error out on %error instead of just emitting a warning. --- libavutil/x86/x86inc.asm | 1 - 1 file changed, 1

[libav-devel] [PATCH 1/1] h264: handle complementary field pairs in await_references()

On 2012-12-12 16:16:21 -0800, Ronald S. Bultje wrote: On Wed, Dec 12, 2012 at 3:22 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-12 14:39:34 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 12:30 PM, Janne Grunau janne-li...@jannau.net wrote: Fixes hang

Re: [libav-devel] [PATCH 1/1] x86inc: remove wrong assert in X86_32 PROLOGUE macro

On 2012-12-14 08:32:14 -0800, Ronald S. Bultje wrote: Hi, On Dec 14, 2012 3:30 AM, Janne Grunau janne-li...@jannau.net wrote: Arguments on the stack are handled properly and functions can use more than arguments than the 7 registers available on x86_32. Fixes nasm build, yasm would

[libav-devel] [PATCH 1/1] h264: fix memleak on error during SPS parsing

Introduced in d7d6efe42b0d. --- libavcodec/h264_ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 0166ad2..7eb8726 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@ -357,7 +357,7 @@ int

[libav-devel] [PATCH 1/1] h264-mt: handle NAL_DPAs before calling ff_thread_finish_setup

Hi, On 2012-12-12 16:20:50 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 12:30 PM, Janne Grunau janne-li...@jannau.net wrote: --- libavcodec/h264.c | 13 - libavcodec/h264.h | 1 + 2 files changed, 13 insertions(+), 1 deletion(-) In what situation does

[libav-devel] [PATCH 1/1] h264: set parameters from SPS whenever it changes

Fixes a crash in the fuzzed sample sample_varPAR.avi_s26638 with alternating bit depths. --- Fixed Diego's style nits. libavcodec/h264.c| 108 +-- libavcodec/h264.h| 2 + libavcodec/h264_ps.c | 7 +++- 3 files changed, 68 insertions(+),

[libav-devel] [PATCH 1/1] lavc: set frame parameters after decoding only if necessary

Direct rendering capable decoders call get_buffer() which will set the frame parameters. Prevents frames with wrong parameters when a decoder outputs delayed frames after a resolution or pixel format change. --- Using CODEC_CAP_DR1 instead of CODEC_CAP_DELAY. get_buffer() sets the frame

Re: [libav-devel] [PATCH] vp6: properly fail on unsupported feature

On 2012-12-13 16:24:22 +0100, Luca Barbato wrote: Interlacing is not supported at all and mismanaged down the normal codepaths causing possible buffer management issues. CC: libav-sta...@libav.org --- Probably could be worth checking that we wouldn't have other way to trip into a

[libav-devel] [PATCH 1/1] mpegvideo: allocate scratch buffers after linesize is known

On 2012-12-12 16:13:40 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 3:12 PM, Janne Grunau janne-li...@jannau.net wrote: On 2012-12-12 14:30:43 -0800, Ronald S. Bultje wrote: Hi, On Wed, Dec 12, 2012 at 12:30 PM, Janne Grunau janne-li...@jannau.net wrote: cmdutis.c's

Re: [libav-devel] [PATCH] mpeg12: do not decode extradata more than once.

On 2012-12-13 18:50:47 +0100, Anton Khirnov wrote: Fixes CVE-2012-2803. CC: libav-sta...@libav.org --- libavcodec/mpeg12.c |3 ++- libavcodec/mpeg12.h |1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index

[libav-devel] [PATCH 1/1] x86inc: fully concatenate tokens to fix macro expansion for nasm

Fixes build errors with nasm introduced in 6f40e9f070f7 for stack memory alignment. Noticed by BugMaster. --- libavutil/x86/x86inc.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index de0f22c..4561a14 100644 ---

Re: [libav-devel] [PATCH 1/1] h264: set parameters from SPS whenever it changes

On 2012-12-13 10:31:54 +0100, Janne Grunau wrote: Fixes a crash in the fuzzed sample sample_varPAR.avi_s26638 with alternating bit depths. --- Fixed Diego's style nits. pushed Janne ___ libav-devel mailing list libav-devel@libav.org https

Re: [libav-devel] [PATCH 1/1] x86inc: fully concatenate tokens to fix macro expansion for nasm

On 2012-12-13 14:20:44 -0800, Ronald S. Bultje wrote: Hi, On Thu, Dec 13, 2012 at 1:48 PM, Janne Grunau janne-li...@jannau.net wrote: Fixes build errors with nasm introduced in 6f40e9f070f7 for stack memory alignment. Noticed by BugMaster. --- libavutil/x86/x86inc.asm | 4 ++-- 1

Re: [libav-devel] [PATCH 1/2] asyncts: merge two conditions

On 2012-12-13 18:31:05 -0500, Justin Ruggles wrote: --- libavfilter/af_asyncts.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_asyncts.c b/libavfilter/af_asyncts.c index faefdf4..d6d8932 100644 --- a/libavfilter/af_asyncts.c +++

Re: [libav-devel] [PATCH 2/2] asyncts: only disregard min_delta for the first frame if first_pts is set

On 2012-12-13 18:31:06 -0500, Justin Ruggles wrote: --- libavfilter/af_asyncts.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavfilter/af_asyncts.c b/libavfilter/af_asyncts.c index d6d8932..40680c8 100644 --- a/libavfilter/af_asyncts.c +++

[libav-devel] [RFC] h264-frame-mt: handle in-stream frame parameter change

Hi, this is my current patch set for adaptive h264 frame multithreading. It has functional changes and fixes for problems found during fuzzing. It works on all real world samples I've found (bug reports from VLC, MythTV, FFmpeg and us) and more artificial samples I created for the fate-debug

[libav-devel] [PATCH 01/15] h264: set parameters from SPS whenever it changes

Fixes a crash in the fuzzed sample sample_varPAR.avi_s26638 with alternating bit depths. --- libavcodec/h264.c| 107 +-- libavcodec/h264.h| 2 + libavcodec/h264_ps.c | 3 ++ 3 files changed, 65 insertions(+), 47 deletions(-) diff --git

[libav-devel] [PATCH 02/15] lavc: do not overwrite frame parameters of delayed frames

Decoders supporting frame parameter changes can return delayed frames with the old parameters. --- libavcodec/utils.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 1185a35..97fa570 100644 --- a/libavcodec/utils.c

[libav-devel] [PATCH 03/15] mpegvideo: treat delayed pictures as used

This requires to move the avcodec_default_free_buffers() call to ff_MPV_common_end() since otherwise delayed pictures would get freed during a size change. --- libavcodec/h264.h | 6 -- libavcodec/mpegvideo.c | 8 libavcodec/mpegvideo.h | 6 ++ 3 files changed, 10

[libav-devel] [PATCH 04/15] mpegvideo: align width to 32 for scratch buffer sizes

cmdutis.c's alloc_buffer() uses aligned to 32 width plus 2 edges of 32 pixels as linesize. emu_edge_buffer has to work with the same stride. This makes only a difference for 8 bit per pixel bit depths since we always allocate for 16 bit per pixel. Fixes fuzzed sample nasa-8s2.ts_s244342. ---

[libav-devel] [PATCH 05/15] h264: initialize frame-mt context copies properly

--- libavcodec/h264.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index e8a22f8..546b046 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -1125,6 +1125,8 @@ static int decode_init_thread_copy(AVCodecContext *avctx)

[libav-devel] [PATCH 08/15] HACK: h264: limit ref_count to 16 ff_h264_direct_dist_scale_factor

A ref count above 16 which is possible for field pictures causes an out of bounds write into the following ref_cache array. The bogus data results in a negative index for the reference list array during decoding of the fuzzed sample HPCVFL_BRCM_A.264_s18662. --- libavcodec/h264_direct.c | 12

[libav-devel] [PATCH 09/15] h264: support frame parameter changes during frame-mt

--- libavcodec/h264.c | 353 ++ 1 file changed, 224 insertions(+), 129 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index d5a54e2..f7915a2 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -1135,6 +1135,12 @@ static

[libav-devel] [PATCH 10/15] h264-mt: make slice header decoding errors fatal after size changes

--- libavcodec/h264.c | 10 +- libavcodec/h264.h | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index f7915a2..36d0e42 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -1174,6 +1174,7 @@ static int

[libav-devel] [PATCH 11/15] h264: prevent starting new frames after ff_thread_finish_setup()

--- libavcodec/h264.c | 13 - libavcodec/h264.h | 1 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 36d0e42..baeebf1 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -1277,6 +1277,8 @@ static int

[libav-devel] [PATCH 12/15] h264: clean current_picture_ptr before starting a new frame

This avoids deadlocks after non fatal slice header decoding errors. Fixes several files, bipbop234.ts_s20083 for example. --- libavcodec/h264.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index baeebf1..8847f1f 100644 --- a/libavcodec/h264.c +++

[libav-devel] [PATCH 13/15] h264: break after error if enough NALs were seen in decode_nal_units

--- libavcodec/h264.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 8847f1f..35cc800 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -4070,17 +4070,16 @@ again: hx-nal_unit_type,

<    9   10   11   12   13   14   15   16   17   18   >