Re: [libav-devel] Indeo 4 B-frames

2014-06-10 Thread Maxim Polijakowski
Am 08.06.2014 14:15, schrieb Dirk Ausserhaus: On Sun, Jun 8, 2014 at 2:10 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Sun, Jun 08, 2014 at 01:53:49PM +0200, Dirk Ausserhaus wrote: Here's a patch that fixes decoding of Indeo 4 B-frames. Looks correct. I should've done it long time

Re: [libav-devel] [PATCH 2/2] Go2Meeting decoder

2014-03-07 Thread Maxim Polijakowski
Am 07.03.2014 15:31, schrieb Diego Biurrun: From: Maxim Poliakovski max_p...@gmx.de JPEG part decoding and minor improvements for ePIC decoder by Kostya Shishkov. Signed-off-by: Diego Biurrun di...@biurrun.de --- IMHO the code has been shipped abit too soon - there are several issues

Re: [libav-devel] [PATCH] Add ATRAC3+ decoder, 4th try

2014-01-03 Thread Maxim Polijakowski
Am 03.01.2014 16:57, schrieb Justin Ruggles: On 01/02/2014 03:41 PM, Maxim Polijakowski wrote: +static int atrac3p_decode_frame(AVCodecContext *avctx, void *data, +int *got_frame_ptr, AVPacket *avpkt) +{ +ATRAC3PContext *ctx = avctx-priv_data; +AVFrame

Re: [libav-devel] [PATCH] ATRAC3+ decoder, 2nd try

2013-10-19 Thread Maxim Polijakowski
Am 19.10.2013 01:45, schrieb Luca Barbato: On 19/10/13 00:37, Maxim Polijakowski wrote: -- VLC tables have been made static. There is no dynamic allocation and deallocation anymore To initialize static data you might use the init_static_data callback, the rest seems ok to go to me. IIRC

Re: [libav-devel] [PATCH] ATRAC3+ decoder, 2nd try

2013-10-19 Thread Maxim Polijakowski
Am 19.10.2013 13:57, schrieb Luca Barbato: On 19/10/13 13:49, Maxim Polijakowski wrote: Am 19.10.2013 01:45, schrieb Luca Barbato: On 19/10/13 00:37, Maxim Polijakowski wrote: -- VLC tables have been made static. There is no dynamic allocation and deallocation anymore To initialize static

Re: [libav-devel] [PATCH] Add ATRAC3+ decoder

2013-10-18 Thread Maxim Polijakowski
Thank you for your suggestions! Please find the updated patch in my next email [PATCH] ATRAC3+ decoder, 2nd try Below a couple of comments... +/** + * Generate canonical VLC table from given descriptor. + * + * @param[in] cb ptr to codebook descriptor + * @param[in] xlat ptr to

Re: [libav-devel] [PATCH] Add ATRAC3+ decoder

2013-10-18 Thread Maxim Polijakowski
Thank you for your suggestions! Please find the updated patch in my next email [PATCH] ATRAC3+ decoder, 2nd try Below a couple of comments... On Thu, Oct 10, 2013 at 9:14 PM, Maxim Polijakowskimax_p...@gmx.de wrote: Hi crews, the attached patch adds an open-source decoder for Sony's

[libav-devel] [PATCH] More Atrac3 cleanups

2013-10-10 Thread Maxim Polijakowski
@subject Best regards Maxim From f3367f63e06ab0161671fedc907b8445877b48d2 Mon Sep 17 00:00:00 2001 From: Maxim Poliakovski max_p...@gmx.de Date: Thu, 10 Oct 2013 09:59:03 +0200 Subject: [PATCH 1/2] atrac3: Remove unused gain compensation tables Patch by Diego Biurrun. --- libavcodec/atrac3.c |

[libav-devel] [PATCH] Atrac: add missing av_cold

2013-10-03 Thread Maxim Polijakowski
@topic Best regards Maxim From 8b49fdf6d775ef658f474c5126108c5bb05d695e Mon Sep 17 00:00:00 2001 From: Maxim Poliakovski max_p...@gmx.de Date: Thu, 3 Oct 2013 20:49:50 +0200 Subject: [PATCH] atrac: Add missing av_cold --- libavcodec/atrac.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [libav-devel] [PATCH] Generalize ATRAC3 gain compensation code

2013-10-01 Thread Maxim Polijakowski
[...] --- a/libavcodec/atrac3.c +++ b/libavcodec/atrac3.c @@ -417,90 +412,32 @@ static int decode_tonal_components(GetBitContext *gb, static int decode_gain_control(GetBitContext *gb, GainBlock *block, int num_bands) { -int i, cf, num_data; +int i, b;

Re: [libav-devel] [PATCH] Generalize ATRAC3 gain compensation code

2013-10-01 Thread Maxim Polijakowski
[...] --- a/libavcodec/atrac.c +++ b/libavcodec/atrac.c @@ -66,20 +62,8 @@ void ff_atrac_generate_tables(void) -void ff_atrac_iqmf (float *inlo, float *inhi, unsigned int nIn, float *pOut, float *delayBuf, float *temp) +void ff_atrac_iqmf (float *inlo, float *inhi, unsigned int nIn, float

Re: [libav-devel] [PATCH] Generalize ATRAC3 gain compensation code

2013-10-01 Thread Maxim Polijakowski
[...] And I'm helping you by doing all the postprocessing on ATRAC3+ :) Thank you for that once again! I could do all the work myself directly, but I choose to review your patches so that in the future the postprocessing work is reduced while you adapt a bit more to the modern libav style

[libav-devel] [PATCH] Generalize ATRAC3 gain compensation code

2013-09-30 Thread Maxim Polijakowski
Hi crews, the attached patch set delivers a generalized version of the ATRAC3 gain compensation code so it can be reused in the upcoming ATRAC3+ decoder without reinventing the wheel. Moreover, a minor cleanup (improving descriptions and doxygen comments) has been made as well. Please

Re: [libav-devel] [PATCH] Generalize ATRAC3 gain compensation code

2013-09-30 Thread Maxim Polijakowski
@Derek @Diego: Thank you for the review! Please find attached the updated patch. Best regards Maxim From 085cfcbfeada7736c54406573e5fe2c56ab11016 Mon Sep 17 00:00:00 2001 From: Maxim Poliakovski max_p...@gmx.de Date: Mon, 30 Sep 2013 23:14:51 +0200 Subject: [PATCH 1/2] atrac cosmetics: move

Re: [libav-devel] [PATCH] Add support for multichannel ATRAC3+ to OpenMG demuxer

2013-09-27 Thread Maxim Polijakowski
Hi crews, the attached patch adds support for multichannel ATRAC3+ streams to the OpenMG demuxer. It also sets the currently wrong ATRAC3+ frame size to right one of 2048 samples. The patch for ATRAC3+ codec itself is in preparation and will be posted shortly... Please find attached

[libav-devel] [PATCH] Add support for multichannel ATRAC3+ to OpenMG demuxer

2013-09-25 Thread Maxim Polijakowski
Hi crews, the attached patch adds support for multichannel ATRAC3+ streams to the OpenMG demuxer. It also sets the currently wrong ATRAC3+ frame size to right one of 2048 samples. The patch for ATRAC3+ codec itself is in preparation and will be posted shortly... Please review and commit.