Re: [libav-devel] [PATCH] qsvdec: Fix memory leak

2016-12-05 Thread Timothy Gu
On Mon, Dec 5, 2016 at 10:48 AM Vittorio Giovara wrote: > While it's great to hear that it was "found by Coverity in FFmpeg", it > would more useful to mention the CID number. > As you may know, Coverity is able to hash same issues in different > repositories, so by

[libav-devel] [PATCH] qsvdec: Fix memory leak

2016-12-05 Thread Timothy Gu
Found by Coverity in FFmpeg. --- libavcodec/qsvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index b6fead0..b83b0fc 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -306,8 +306,10 @@ static int

[libav-devel] [PATCH] omx: Fix OOM check

2016-12-05 Thread Timothy Gu
Also use av_mallocz_array(). Found by Coverity in FFmpeg. --- libavcodec/omx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index 0c61c2f..05c8743 100644 --- a/libavcodec/omx.c +++ b/libavcodec/omx.c @@ -352,12 +352,12 @@ static

Re: [libav-devel] [PATCH] buffer: fix av_buffer_pool_init2() documentation

2016-08-03 Thread Timothy Gu
On Wed, Aug 3, 2016 at 12:54 AM Anton Khirnov wrote: > A non-existent av_buffer_pool_can_uninit() function is mentioned instead > of av_buffer_pool_uninit(). Also, this function is to be called by the > caller, not the pool itself. > --- > libavutil/buffer.h | 7 --- > 1

Re: [libav-devel] [PATCH 2/9] lavf: generic hardware surface upload and download filters

2016-03-09 Thread Timothy Gu
On Mon, Mar 07, 2016 at 11:20:14PM +, Mark Thompson wrote: > +AVFilter ff_vf_hwdownload = { > +.name = "hwdownload", > +.description = NULL_IF_CONFIG_SMALL("Upload a normal frame to a > hardware frame"), ahem... Timothy ___

Re: [libav-devel] [PATCH 2/2] configure: add missing avx2 support check

2016-01-24 Thread Timothy Gu
Hi, On Sun, Jan 24, 2016 at 08:15:27AM +0100, Luca Barbato wrote: > > Travis seems still unhappy, does it ring any bell? > > libavcodec/x86/v210enc.asm:95: error: undefined symbol > `vinserti128.loop' (first use) It's probably because the v210 patch doesn't use the guards yet. Timothy

Re: [libav-devel] [PATCH 01/12] lavfi: add a frame_rate field to AVFilterLink.

2015-10-27 Thread Timothy Gu
Just so that nobody misses this: On Tue, Oct 27, 2015 at 1:18 PM John Stebbins wrote: > + * It is similar to the r_frae_rate field in AVStream. > r_frame_rate [...] Timothy ___ libav-devel mailing list

Re: [libav-devel] [PATCH] lavu: Deprecate AVFrame.error[]

2015-09-28 Thread Timothy Gu
On Sun, Sep 27, 2015 at 11:42 PM Anton Khirnov wrote: > Quoting Vittorio Giovara (2015-09-27 22:22:27) > > I feel that this new field name could be something more descriptive > > than "error", but I am not really sure which one to pick: > > compression_error, divergence,

Re: [libav-devel] [PATCH] build: Add support for travis CI

2015-08-29 Thread Timothy Gu
On Sat, Aug 29, 2015 at 8:00 AM Luca Barbato lu_z...@gentoo.org wrote: From: Federico Tomassetti feder...@tomassetti.me It is useful to support an eventual staging branch and to have a first layer fate-check on github pull requests. --- Now updated to be much faster, thanks again to

Re: [libav-devel] [PATCH] build: Add support for travis CI

2015-08-29 Thread Timothy Gu
Also… On Sat, Aug 29, 2015 at 8:00 AM Luca Barbato lu_z...@gentoo.org wrote: diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 000..773327e --- /dev/null +++ b/.travis.yml @@ -0,0 +1,19 @@ +language: c + sudo: false This property and all the ones below should be on

[libav-devel] [PATCH] avconv_opt: Add -hwaccels option that lists all supported hwaccels

2015-08-25 Thread Timothy Gu
--- avconv_opt.c| 14 ++ doc/avconv.texi | 4 2 files changed, 18 insertions(+) diff --git a/avconv_opt.c b/avconv_opt.c index 9775416..d538995 100644 --- a/avconv_opt.c +++ b/avconv_opt.c @@ -177,6 +177,18 @@ static double parse_frame_aspect_ratio(const char *arg)

[libav-devel] [PATCH] avconv_opt: Add missing comma

2015-08-25 Thread Timothy Gu
--- avconv_opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avconv_opt.c b/avconv_opt.c index 9775416..b527335 100644 --- a/avconv_opt.c +++ b/avconv_opt.c @@ -2445,7 +2445,7 @@ const OptionDef options[] = { use HW accelerated decoding, hwaccel name }, {

Re: [libav-devel] [PATCH 1/2] aac: Don't fail if channels aren't known yet

2015-06-04 Thread Timothy Gu
On Wed, Jun 3, 2015 at 11:32 PM Luca Barbato lu_z...@gentoo.org wrote: On 04/06/15 07:42, nu774 wrote: (backport from ffmpeg) Proper authorship would be appreciated. --- libavcodec/aacdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/aacdec.c

Re: [libav-devel] [PATCH] x86inc: Clear __SECT__

2015-05-27 Thread Timothy Gu
On Tue, May 26, 2015 at 01:18:34AM +0200, Luca Barbato wrote: Looks nicer indeed. lu Ping. Timothy ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] fft: x86: Clear __SECT__ before declaring a structure

2015-05-25 Thread Timothy Gu
This silences the following warning: libavcodec/x86/fft.asm:93: warning: section flags ignored on section redeclaration The cause of this warning is that because `struc` and `endstruc` attempts to revert to the previous section state [1]. The section state is stored in the macro

[libav-devel] [PATCH] x86inc: Clear __SECT__

2015-05-25 Thread Timothy Gu
This commit silences warning(s) like: libavcodec/x86/fft.asm:93: warning: section flags ignored on section redeclaration The cause of this warning is that because `struc` and `endstruc` attempts to revert to the previous section state [1]. The section state is stored in the macro

[libav-devel] [PATCH] doc: Add $branch to FATE config template

2015-05-13 Thread Timothy Gu
--- doc/fate.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/fate.texi b/doc/fate.texi index 1d6d1d1..d6beaa5 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -128,6 +128,7 @@ can be passed. @example slot= # some unique identifier

Re: [libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Timothy Gu
On Sat, May 09, 2015 at 11:13:09PM +0200, Luca Barbato wrote: On 09/05/15 22:47, Luca Barbato wrote: The pixel format tests work on a single image that I know. Probably reducing the video-filter test to use just 5 frames would get some additional gain. Your suggestion works even better!

Re: [libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Timothy Gu
On May 9, 2015 6:52 AM, Luca Barbato lu_z...@gentoo.org wrote: Reduce greatly the time to test, the coverage remains unchanged. I like this idea, but for some filters that require multiple frames to emit useful output this might disrupt their output. How about using a small number of frames,

Re: [libav-devel] [PATCH 1/4] mpegvideo: Have ff_h263_get_gob_height use AVCodecContext directly

2015-04-27 Thread Timothy Gu
On Mon, Apr 27, 2015 at 2:09 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: -int ff_h263_get_gob_height(MpegEncContext *s){ -if (s-height = 400) +int ff_h263_get_gob_height(AVCodecContext *avctx) +{ +if (avctx-height = 400) return 1; -else if (s-height = 800) +

Re: [libav-devel] [PATCH] tests: Add ATRAC3plus tests

2015-04-24 Thread Timothy Gu
On Thu, Apr 23, 2015 at 5:27 AM Diego Biurrun di...@biurrun.de wrote: On Sun, Apr 19, 2015 at 08:26:15PM -0700, Timothy Gu wrote: 12:25 + Timothy_Gu DonDiego: the first one has a higher bitrate, the second one has a lower one. From the coverage report

Re: [libav-devel] [PATCH] tests: Add ATRAC3plus tests

2015-04-22 Thread Timothy Gu
On Sun, Apr 19, 2015 at 08:26:15PM -0700, Timothy Gu wrote: --- The official name is ATRAC3plus, so that is used. - at3p_sample1.oma is from samples.libav.org - at3p_sample1.pcm is in incoming. - sonateno14op27-2-cut.aa3 is a smaller version of sonateno14op27-2.aa3 in samples.libav.org

Re: [libav-devel] [PATCH] tests: Fix test name for pixfmts tests

2015-04-22 Thread Timothy Gu
On Sun, Apr 19, 2015 at 08:37:43PM -0700, Timothy Gu wrote: The last pixel format gets leaked as `$test` further down the pipeline. See for example https://fate.libav.org/x86_32-netbsd-clang-no-inline-asm/20150420020104 Note the odd test names like “yuvj444p.” --- tests/fate-run.sh | 3

[libav-devel] [PATCH] tests: Add ATRAC3plus tests

2015-04-19 Thread Timothy Gu
--- The official name is ATRAC3plus, so that is used. - at3p_sample1.oma is from samples.libav.org - at3p_sample1.pcm is in incoming. - sonateno14op27-2-cut.aa3 is a smaller version of sonateno14op27-2.aa3 in samples.libav.org, and is in incoming. - sonateno14op27-2-cut.pcm is in incoming.

[libav-devel] [PATCH] tests: Fix test name for pixfmts tests

2015-04-19 Thread Timothy Gu
The last pixel format gets leaked as `$test` further down the pipeline. See for example https://fate.libav.org/x86_32-netbsd-clang-no-inline-asm/20150420020104 Note the odd test names like “yuvj444p.” --- tests/fate-run.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/fate-run.sh

Re: [libav-devel] [PATCH] tests: Do not include stdout/stderr or diff if the test passed

2015-04-18 Thread Timothy Gu
On Wed, Apr 15, 2015 at 12:18 AM Luca Barbato lu_z...@gentoo.org wrote: On 14/04/15 22:05, Timothy Gu wrote: No. Consider three tests, the first one succeeds without any output, the second one outputs some debug information, and the third fails. Before: test1:0:: test2:0

Re: [libav-devel] [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2015-04-16 Thread Timothy Gu
On Thu, Apr 16, 2015 at 10:41 AM Claudio Freire klaussfre...@gmail.com wrote: It should be if band-thr 0.0f, all divisions by zero return something that casts into an ~1: Isn't division by zero undefined behavior? Timothy ___ libav-devel mailing

Re: [libav-devel] [PATCH] tests: Do not include stdout/stderr or diff if the test passed

2015-04-14 Thread Timothy Gu
On Tue, Apr 14, 2015 at 3:43 AM Diego Biurrun di...@biurrun.de wrote: On Fri, Apr 10, 2015 at 10:36:03AM -0700, Timothy Gu wrote: FATE currently discards this information anyway, so why waste the disk space? --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -211,7 +211,13 @@ else

Re: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API

2015-03-09 Thread Timothy Gu
On Mon, Mar 9, 2015 at 4:02 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: Subject: [libav-devel] [PATCH] mp3: Properly use AVCodecContext API Can you make this a little more specific: mp3: Properly allocate AVCodecContext Can't comment on the rest. Timothy

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Timothy Gu
On Sun Feb 22 2015 at 12:33:29 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: Since not all systems need the libraw1394 dependency, …for example? let pkg-config provide the list of libraries actually needed. The libdc1394-2.pc file has been included since version 2, so it

Re: [libav-devel] [PATCH] hqx: vlc initialization and src bound check

2015-02-12 Thread Timothy Gu
On Thu Feb 12 2015 at 9:40:13 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/hqx.c| 26 +++--- libavcodec/hqxvlc.c | 8 +--- libavcodec/hqxvlc.h | 3 ++- 3 files changed, 14 insertions(+), 23 deletions(-) diff --git a/libavcodec/hqx.c

Re: [libav-devel] [PATCH] hqx: vlc initialization and src bound check

2015-02-12 Thread Timothy Gu
(Sorry about the empty mail) On Thu Feb 12 2015 at 9:40:13 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/hqx.c| 26 +++--- libavcodec/hqxvlc.c | 8 +--- libavcodec/hqxvlc.h | 3 ++- 3 files changed, 14 insertions(+), 23 deletions(-)

Re: [libav-devel] [PATCH] flacenc: Change 'return -1' lines to return proper error codes

2015-02-07 Thread Timothy Gu
On Sat Feb 07 2015 at 8:32:29 PM Justin Ruggles justin.rugg...@gmail.com wrote: On 02/07/2015 08:15 PM, Timothy Gu wrote: On Sat Feb 07 2015 at 4:45:55 PM Rohit Kumar Singh rohit91.2...@gmail.com wrote: -if (channels 1 || channels FLAC_MAX_CHANNELS) -return -1

Re: [libav-devel] [PATCH] flacenc: Change 'return -1' lines to return proper error codes

2015-02-07 Thread Timothy Gu
On Sat Feb 07 2015 at 4:45:55 PM Rohit Kumar Singh rohit91.2...@gmail.com wrote: --- libavcodec/flacenc.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index 1160da2..4db9099 100644 ---

Re: [libav-devel] [PATCH] qdm2: Return meaningful error codes

2015-02-05 Thread Timothy Gu
On Thu Feb 05 2015 at 10:17:57 AM Himangi Saraogi himangi...@gmail.com wrote: @@ -1991,7 +1991,7 @@ static int qdm2_decode_frame(AVCodecContext *avctx, void *data, for (i = 0; i 16; i++) { if (qdm2_decode(s, buf, out) 0) -return -1; +return

Re: [libav-devel] [PATCH 1/5] g722: Split out g722_qmf_apply() function into g722dsp.c

2015-01-29 Thread Timothy Gu
Hi, On Thu Jan 29 2015 at 4:22:00 PM Peter Meerwald pme...@pmeerw.net wrote: diff --git a/libavcodec/g722.h b/libavcodec/g722.h index 71d03fc..4830170 100644 --- a/libavcodec/g722.h +++ b/libavcodec/g722.h @@ -27,6 +27,7 @@ #include stdint.h #include avcodec.h +#include g722dsp.h

Re: [libav-devel] [PATCH 2/5] g722: Reduce number of pointers passed to g722_apply_qmf() function

2015-01-29 Thread Timothy Gu
On Thu Jan 29 2015 at 4:21:59 PM Peter Meerwald pme...@pmeerw.net wrote: Signed-off-by: Peter Meerwald pme...@pmeerw.net --- libavcodec/g722dec.c | 9 - libavcodec/g722dsp.c | 10 +- libavcodec/g722dsp.h | 2 +- libavcodec/g722enc.c | 8 4 files changed, 14

Re: [libav-devel] [PATCH] ituh263dec: use macro instead of ifdef

2015-01-28 Thread Timothy Gu
On Wed Jan 28 2015 at 7:43:23 AM Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/ituh263dec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) OK. [...] Timothy ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/3] dnxhddec: More verbose error messages

2015-01-27 Thread Timothy Gu
Hi, On Tue, Jan 27, 2015 at 10:35 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/dnxhddec.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c index ca67990..fea6fc5 100644 ---

Re: [libav-devel] [PATCH 2/4] doc: Add documentation about the OpenH264 encoder wrapper

2015-01-08 Thread Timothy Gu
On Thu Jan 08 2015 at 2:59:15 AM Martin Storsjö mar...@martin.st wrote: On Thu, 8 Jan 2015, Martin Storsjö wrote: On Thu, 8 Jan 2015, Timothy Gu wrote: Hi, On Wed Jan 07 2015 at 2:08:19 PM Martin Storsjö mar...@martin.st wrote: +Go to @url{http://www.openh264.org/} and follow

Re: [libav-devel] [PATCH 2/4] doc: Add documentation about the OpenH264 encoder wrapper

2015-01-07 Thread Timothy Gu
Hi, On Wed Jan 07 2015 at 2:08:19 PM Martin Storsjö mar...@martin.st wrote: --- doc/general.texi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) Any chance of a full documentation in doc/encoders.texi? diff --git a/doc/general.texi b/doc/general.texi index

Re: [libav-devel] [PATCH 1/4] libavcodec: Prefer x264 over openh264 if both are available

2015-01-07 Thread Timothy Gu
On Wed Jan 07 2015 at 4:42:03 PM Luca Barbato lu_z...@gentoo.org wrote: On 08/01/15 00:27, Vittorio Giovara wrote: Hadn't thought of that, yes twolame should definitely get priority Twolame fdk-aac and x264 should go in a group with higher priority, then native, then external lower

[libav-devel] [PATCH 1/9] Remove sourceMappingURL in CSS

2015-01-06 Thread Timothy Gu
We are not using minified CSS so this is not needed. Plus they generate noise on JavaScript console. --- htdocs/css/bootstrap-theme.css | 2 -- htdocs/css/bootstrap.css | 1 - 2 files changed, 3 deletions(-) diff --git a/htdocs/css/bootstrap-theme.css b/htdocs/css/bootstrap-theme.css index

[libav-devel] [PATCH 6/9] Fix footer badge alignment

2015-01-06 Thread Timothy Gu
Also convert to unordered list which is better fit for this purpose. --- htdocs/css/bootstrap-theme.css | 7 ++- src/template_footer| 11 +++ 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/htdocs/css/bootstrap-theme.css b/htdocs/css/bootstrap-theme.css

[libav-devel] [PATCH 9/9] Remove accidentally added `/li`

2015-01-06 Thread Timothy Gu
--- src/news | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/news b/src/news index 86dadfb..753e516 100644 --- a/src/news +++ b/src/news @@ -14,7 +14,7 @@ and share their patches against our release branches. p See the -a

[libav-devel] [PATCH 8/9] Use unordered list for the latest release panel

2015-01-06 Thread Timothy Gu
That's what unordered list is for, and how the Bootstrap example is like. Also removes clearly unintentional/copy/pasted div href. The clearfix unfortunately is still required. --- htdocs/css/bootstrap-theme.css | 6 +++ src/index | 112

[libav-devel] [PATCH 2/9] Remove width setting in .footer

2015-01-06 Thread Timothy Gu
This is causing the page to have a x-scrollbar, and the page looks fine without it. --- htdocs/css/bootstrap-theme.css | 2 -- 1 file changed, 2 deletions(-) diff --git a/htdocs/css/bootstrap-theme.css b/htdocs/css/bootstrap-theme.css index db3ebfa..8ed8b74 100644 ---

[libav-devel] [PATCH 5/9] Remove obsolete `xmlns` attribute

2015-01-06 Thread Timothy Gu
This is HTML5, not XHTML. --- src/template_head1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/template_head1 b/src/template_head1 index 1e5c8a8..adc03d5 100644 --- a/src/template_head1 +++ b/src/template_head1 @@ -1,5 +1,5 @@ !DOCTYPE html -html

[libav-devel] [PATCH 7/9] Use nav for navigation bar

2015-01-06 Thread Timothy Gu
The navigation role is not allowed in header. --- src/template_head2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/template_head2 b/src/template_head2 index fa85166..3195d86 100644 --- a/src/template_head2 +++ b/src/template_head2 @@ -5,7 +5,7 @@ body -header

[libav-devel] [PATCH 3/9] Increase the line-height of the page header caption

2015-01-06 Thread Timothy Gu
This makes the page a lot more comfortable to look at. --- htdocs/css/bootstrap-theme.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/css/bootstrap-theme.css b/htdocs/css/bootstrap-theme.css index 8ed8b74..a08f304 100644 --- a/htdocs/css/bootstrap-theme.css +++

[libav-devel] [PATCH 4/9] Remove default.css

2015-01-06 Thread Timothy Gu
It's not used any more. --- htdocs/default.css | 173 - 1 file changed, 173 deletions(-) delete mode 100644 htdocs/default.css diff --git a/htdocs/default.css b/htdocs/default.css deleted file mode 100644 index 371414f..000 ---

Re: [libav-devel] [PATCH 3/3] Allow loading the OpenH264 library dynamically

2014-12-31 Thread Timothy Gu
On Wed, Dec 31, 2014 at 9:03 AM, Martin Storsjö mar...@martin.st wrote: It would probably indeed make sense to add a separate enable-item (so you don't need to check individually for dlopen and LoadLibrary, but just for the generic dynamic-loading feature) and a separate header that does this.

Re: [libav-devel] [PATCH] fate: Use bitexact conversions in the dpxparser test

2014-12-28 Thread Timothy Gu
On Sun Dec 28 2014 at 2:20:51 PM Martin Storsjö mar...@martin.st wrote: This fixes fate on e.g. ppc. --- tests/fate/image.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 3864896..3d8f6a8 100644 ---

Re: [libav-devel] [PATCH] Fix read-after-free in matroska_read_seek()

2014-12-09 Thread Timothy Gu
On Tue, Dec 9, 2014 at 10:09 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Tue, Dec 9, 2014 at 5:55 PM, Luca Barbato lu_z...@gentoo.org wrote: On 09/12/14 15:53, Vittorio Giovara wrote: From: Xiaohan Wangxhw...@chromium.org Date: Thu, 6 Nov 2014 12:59:54 -0800 Subject: [PATCH]

Re: [libav-devel] [PATCH] doc: Use the correct @subsection tag

2014-12-07 Thread Timothy Gu
On Sunday, December 7, 2014, Luca Barbato lu_z...@gentoo.org wrote: makeinfo would otherwise refuse to build it. --- doc/decoders.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) OK. […] Timothy ___ libav-devel mailing list

Re: [libav-devel] [PATCH] svq1dec: Call av_fast_malloc() correctly

2014-12-05 Thread Timothy Gu
On Fri, Dec 5, 2014 at 3:48 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Fri, Dec 5, 2014 at 8:21 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: HuiHi, 2014-12-04 21:00 GMT+01:00 Nicolas Dufresne nicolas.dufre...@collabora.com : av_fast_malloc() signature is void*,

Re: [libav-devel] [PATCH 3/3] fate: Add tests for DSS

2014-11-23 Thread Timothy Gu
On Sun, Nov 23, 2014 at 2:59 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Using the test the author provided. They are going to be tested on oracle too before pushing. Vittorio tests/fate/audio.mak | 4 + tests/ref/fate/dss-lp | 737

Re: [libav-devel] [PATCH 2/5] lavc: Move AVPacketList to avcodec

2014-10-10 Thread Timothy Gu
On Thu, Oct 9, 2014 at 7:52 AM, Timothy Gu timothyg...@gmail.com wrote: On Thu, Oct 9, 2014 at 7:49 AM, Luca Barbato lu_z...@gentoo.org wrote: Users using it from avformat still will get it since avformat.h must include avcodec.h Yes, that's why it is an ABI break and not an API one

Re: [libav-devel] [PATCH 2/5] lavc: Move AVPacketList to avcodec

2014-10-09 Thread Timothy Gu
On Thu, Oct 9, 2014 at 2:21 AM, Luca Barbato lu_z...@gentoo.org wrote: Add a private API to manipulate AVPacketLists. --- doc/APIchanges | 4 libavcodec/avcodec.h | 5 + libavcodec/avpacket.c | 56 ++

Re: [libav-devel] [PATCH 2/5] lavc: Move AVPacketList to avcodec

2014-10-09 Thread Timothy Gu
On Thu, Oct 9, 2014 at 7:49 AM, Luca Barbato lu_z...@gentoo.org wrote: Users using it from avformat still will get it since avformat.h must include avcodec.h Yes, that's why it is an ABI break and not an API one. The AVPacketList symbol is removed from libavformat, and programs compiled with

Re: [libav-devel] [PATCH 1/2] compat/w32pthreads: use the CONDITION_VARIABLE typedef if available

2014-10-08 Thread Timothy Gu
On Wed, Oct 8, 2014 at 7:03 PM, James Almer jamr...@gmail.com wrote: This silences warnings about passing arguments from incompatible pointer type when targeting Windows Vista or newer. Signed-off-by: James Almer jamr...@gmail.com --- Sent the wrong version earlier, my bad. The request for

Re: [libav-devel] VDD meeting notes

2014-09-23 Thread Timothy Gu
On Tue, Sep 23, 2014 at 4:22 PM, Diego Biurrun di...@biurrun.de wrote: On Tue, Sep 23, 2014 at 11:27:28PM +0100, Vittorio Giovara wrote: On Sun, Sep 21, 2014 at 12:43 PM, Andrew Kelley superjo...@gmail.com wrote: more things to remove? is there any reason to keep lavf/gopher.c besides

Re: [libav-devel] [PATCH] oss_audio: use a macro to simplify ioctl() error checking

2014-09-17 Thread Timothy Gu
On Sep 17, 2014 9:42 PM, Luca Barbato lu_z...@gentoo.org wrote: On 18/09/14 06:35, Reinhard Tartler wrote: -/* select format : favour native format */ +#define CHECK_IOCTL_ERROR(event) \ +if (err 0) { \ +av_log(s1, AV_LOG_ERROR, #event : %s\n,

Re: [libav-devel] Libav compilation issue on Windows phone 8.1

2014-09-12 Thread Timothy Gu
On Sep 12, 2014 6:19 AM, Mirko Puliafito mirko.puliaf...@gmail.com wrote: Yes, a kind of the same, just some tuning about armasm. Compilation is fine also with me. The problem is when I try to link libs in an ARM Visual Studio Project (Windows Phone app). Can you posted the log of the failed

Re: [libav-devel] Libav compilation issue on Windows phone 8.1

2014-09-12 Thread Timothy Gu
On Fri, Sep 12, 2014 at 6:56 AM, Luca Barbato lu_z...@gentoo.org wrote: - threads support missing (what does window phone use for threads?) Windows Phone has CreateSemaphoreExW and other Unicode functions, but no ANSI which Libav uses. - log support requires non-standard support Windows Phone

Re: [libav-devel] [PATCH 7/9] Drop dead links to Open Embedded recipes

2014-09-10 Thread Timothy Gu
On Wed, Sep 10, 2014 at 12:49 PM, Diego Biurrun di...@biurrun.de wrote: --- src/download | 6 -- src/news | 4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) They are now at http://git.openembedded.org/openembedded-core/tree/meta/recipes-multimedia/libav [...] Timothy

Re: [libav-devel] [PATCH 4/9] download: Remove obsolete developer repository links

2014-09-10 Thread Timothy Gu
On Wed, Sep 10, 2014 at 12:49 PM, Diego Biurrun di...@biurrun.de wrote: --- src/download | 14 -- 1 file changed, 14 deletions(-) I would remove all the personal repos. IMO it is unlikely for a website visitor to be wanting to download developer trees. [...] Timothy

Re: [libav-devel] [PATCH] Announce releases 10.5, 9.17, and 0.8.16

2014-09-10 Thread Timothy Gu
On Wed, Sep 10, 2014 at 3:39 PM, Diego Biurrun di...@biurrun.de wrote: On Thu, Sep 11, 2014 at 12:19:47AM +0200, Diego Biurrun wrote: --- a/src/news +++ b/src/news @@ -1,5 +1,32 @@ h1News/h1 +a name=10.5_9.17_0.8.16/ah3September 11, 2014/h3 +p +We are happy to update three release

Re: [libav-devel] [PATCH 9/9] Prefer https links over http where sensibly possible

2014-09-10 Thread Timothy Gu
On Wed, Sep 10, 2014 at 12:49 PM, Diego Biurrun di...@biurrun.de wrote: --- src/about | 13 +++-- src/bugreports | 4 +- src/contact| 2 +- src/download | 18 +++ src/legal | 8 +-- src/news | 168 -

Re: [libav-devel] [PATCH] Fix a bunch of broken links

2014-09-10 Thread Timothy Gu
On Wed, Sep 10, 2014 at 2:57 PM, Diego Biurrun di...@biurrun.de wrote: --- Now also fixing the OpenEmbedded links. src/contact | 2 +- src/download| 6 +++--- src/news| 44 ++-- src/template_footer | 6 +++--- 4 files

Re: [libav-devel] [PATCH 9/9] Prefer https links over http where sensibly possible

2014-09-10 Thread Timothy Gu
On Wed, Sep 10, 2014 at 3:56 PM, Diego Biurrun di...@biurrun.de wrote: Yes; in order to force https, or because some sites (like gnu.org or freenode.net) redirect all http traffic to https anyway. Why would you force HTTPS? IMO you should leave this to the website reader and the third party

Re: [libav-devel] [PATCH 2/2] ismindex: Avoid writing ismf files if no base name has been specified

2014-09-05 Thread Timothy Gu
On Fri, Sep 5, 2014 at 12:58 PM, Martin Storsjö mar...@martin.st wrote: Previously, this could create files named (null).ismf, if the -ismf parameter is specified (before an input file name), but without specifying any base name. --- tools/ismindex.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [libav-devel] [PATCH 4/6] avconv: Support QSV HWAccel

2014-08-31 Thread Timothy Gu
On Sun, Aug 31, 2014 at 12:24 PM, Luca Barbato lu_z...@gentoo.org wrote: --- Makefile | 1 + avconv.h | 2 ++ avconv_opt.c | 3 +++ avconv_qsv.c | 55 + 4 files changed, 61 insertions(+) create mode 100644 avconv_qsv.c This patch should go after

Re: [libav-devel] [PATCH] ppc: Support little endian intreadwrite

2014-08-30 Thread Timothy Gu
On Aug 30, 2014 6:32 AM, Luca Barbato lu_z...@gentoo.org wrote: --- I tested with recent compilers and the problem mentioned is actual only for -O0. libavutil/ppc/intreadwrite.h | 48 ++-- 1 file changed, 33 insertions(+), 15 deletions(-) diff

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Timothy Gu
On Fri, Aug 29, 2014 at 7:43 AM, Diego Biurrun di...@biurrun.de wrote: On Fri, Aug 29, 2014 at 11:33:19AM +0200, wm4 wrote: On Fri, 29 Aug 2014 01:00:45 +0200 Diego Biurrun di...@biurrun.de wrote: On Sun, Aug 24, 2014 at 12:28:56AM +0200, Clément Bœsch wrote: Kieran suggested tonight on

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Timothy Gu
On Fri, Aug 29, 2014 at 9:06 AM, Diego Biurrun di...@biurrun.de wrote: On Fri, Aug 29, 2014 at 05:26:32PM +0200, Diego Biurrun wrote: On Fri, Aug 29, 2014 at 08:19:55AM -0700, Timothy Gu wrote: http://lists.libav.org/pipermail/libav-devel/2014-August/062391.html: the first more important

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Timothy Gu
On Fri, Aug 29, 2014 at 8:55 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: Timothy, if throwing out of context links at each other is your definition of sane communication, maybe it's better to end this straight away. If you think pointing out some points of improvement is not sane

Re: [libav-devel] [PATCH 3/7] mpeg4videodec: Fix low_delay error message

2014-08-29 Thread Timothy Gu
On Aug 29, 2014 7:45 PM, Gabriel Dume gabriel.dd...@gmail.com wrote: --- libavcodec/mpeg4videodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index effbf6d..3adf0cf 100644 --- a/libavcodec/mpeg4videodec.c

Re: [libav-devel] [PATCH] rdt: check memory allocations

2014-08-28 Thread Timothy Gu
On Thu, Aug 28, 2014 at 8:16 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Jun 24, 2014 at 12:05:39PM +0530, Nidhi Makhijani wrote: --- libavformat/rdt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/rdt.c b/libavformat/rdt.c index 304f4cf..f1ad815 100644 ---

Re: [libav-devel] [PATCH] ppc: Support little endian intreadwrite

2014-08-28 Thread Timothy Gu
On Aug 28, 2014 4:22 PM, Luca Barbato lu_z...@gentoo.org wrote: --- should fix the problem reported on irc on ppc64le, tomorrow hopefully will be tested. libavutil/ppc/intreadwrite.h | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Timothy Gu
On Aug 24, 2014 5:18 AM, Luca Barbato lu_z...@gentoo.org wrote: Feature matching x11grab. --- configure| 11 + libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/xcbgrab.c| 646 +++ 4 files

Re: [libav-devel] [PATCH] libxvid: Check return value of write()

2014-08-26 Thread Timothy Gu
On Tue, Aug 26, 2014 at 10:32 AM, Diego Biurrun di...@biurrun.de wrote: libxvid_rc.c:103:14: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result --- Maybe more elaborate cleanup should be done, dunno ... Don't you need to close() it before returning?

Re: [libav-devel] [PATCH 6/6] xcbgrab: xcb-based screen capture

2014-08-26 Thread Timothy Gu
On Aug 26, 2014 8:08 PM, Luca Barbato lu_z...@gentoo.org wrote: Didn't benchmark, the code is cleaner and it _should_ address the flickering issue reported with x11grab though. That's nice. And also this commit needs a minor bump. Sure. Thx Timothy

Re: [libav-devel] [PATCH] xcbgrab: xcb-based screen capture

2014-08-26 Thread Timothy Gu
On Tue, Aug 26, 2014 at 9:12 PM, Luca Barbato lu_z...@gentoo.org wrote: Matches the x11grab screen capture by features. --- * Added an the x,y avoptions * Not require shm-xcb if shm doesn't exist to begin with * Reworked the pixel format * Addressed some nits configure|

Re: [libav-devel] [PATCH] xcbgrab: xcb-based screen capture

2014-08-26 Thread Timothy Gu
On Tue, Aug 26, 2014 at 9:12 PM, Luca Barbato lu_z...@gentoo.org wrote: +static int xcbgrab_frame_shm(AVFormatContext *s, AVPacket *pkt) +{ +XCBGrabContext *c = s-priv_data; +xcb_shm_get_image_cookie_t iq; +xcb_shm_get_image_reply_t *img; +xcb_drawable_t drawable =

Re: [libav-devel] [PATCH] doc: fix a typo

2014-08-25 Thread Timothy Gu
On Mon, Aug 25, 2014 at 12:28 PM, Gabriel Dume gabriel.dd...@gmail.com wrote: Subject: [libav-devel] [PATCH] doc: fix a typo APIChanges: fix a typo --- doc/APIchanges | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM. [...] Timothy

Re: [libav-devel] [PATCH 03/16] riffenc: do not fall back on AVCodecContext.frame_size for mp3/mp2

2014-08-24 Thread Timothy Gu
On Aug 24, 2014 6:01 AM, Anton Khirnov an...@khirnov.net wrote: It will not be set unless the codec context is used as the encoding context, which is discouraged. Instead set the frame size explicitly. --- libavformat/riffenc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

Re: [libav-devel] [PATCH] doc: Update Changelog

2014-08-20 Thread Timothy Gu
On Wed, Aug 20, 2014 at 9:01 AM, Anton Khirnov an...@khirnov.net wrote: On Sun, 17 Aug 2014 19:58:30 +0200, Luca Barbato lu_z...@gentoo.org wrote: --- Changelog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index ea9d721..a737254 100644 --- a/Changelog +++

Re: [libav-devel] [PATCH 3/4] setpts: Add missing inttypes.h #include for PRId64

2014-08-20 Thread Timothy Gu
On Wed, Aug 20, 2014 at 1:41 PM, Diego Biurrun di...@biurrun.de wrote: Also convert a debug av_log() to av_dlog(). --- libavfilter/setpts.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) OK. [...] Timothy ___ libav-devel

Re: [libav-devel] [PATCH 2/3] alacenc: fix extra bits extraction

2014-08-18 Thread Timothy Gu
On Mon, Aug 18, 2014 at 8:12 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: The raw coded bits are extracted prior to decorrelation, as is correctly performed by the decoder, and not after. Fixes ticket #2768. That is the FFmpeg ticket number, not the Libav one. [...] Timothy

Re: [libav-devel] [PATCH 3/3] alac: add option to decode incorrect ALAC

2014-08-18 Thread Timothy Gu
On Mon, Aug 18, 2014 at 8:12 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: Prior to 56.1.100, incorrect ALAC files for 24bps content were produced, in particular not decoding losslessly. That is the FFmpeg libavcodec version number. Add the codec option extra_bits_bug to allow

Re: [libav-devel] [PATCH 1/2] deshake/stabilisation filters

2014-08-15 Thread Timothy Gu
On Fri, Aug 15, 2014 at 4:55 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: From: Georg Martius mart...@mis.mpg.de vid.stab support for libav consists of two filters: vidstabdetect and vidstabtransform Signed-off-by: Vittorio Giovara vittorio.giov...@gmail.com --- You need to

Re: [libav-devel] [PATCH 08/17] vfwcap: Drop fallback VfW defines

2014-08-15 Thread Timothy Gu
On Fri, Aug 15, 2014 at 1:13 PM, Diego Biurrun di...@biurrun.de wrote: The defines were added long ago when MinGW still lacked them. --- libavdevice/vfwcap.c | 8 1 file changed, 8 deletions(-) OK. [...] Timothy ___ libav-devel mailing

Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

2014-08-15 Thread Timothy Gu
On Fri, Aug 15, 2014 at 1:13 PM, Diego Biurrun di...@biurrun.de wrote: This avoids a number of redefinition warnings on MinGW64. --- I'm assuming that they are not defined to anything silly, which I hope is safe to do. It's not safe at all. libavformat/os_support.h | 6 ++ 1 file

Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

2014-08-15 Thread Timothy Gu
On Fri, Aug 15, 2014 at 1:54 PM, Timothy Gu timothyg...@gmail.com wrote: Just undef it first if it is defined. See https://github.com/FFmpeg/FFmpeg/commit/ef122ff5072463366c020157f0a27aad7e6610db for example. Timothy ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/2] KR formatting cosmetics

2014-08-13 Thread Timothy Gu
On Wed, Aug 13, 2014 at 4:32 PM, Gabriel Dume gabriel.dd...@gmail.com wrote: From: gabriel gabriel.dd...@gmail.com change all if (p == NULL) into if (!p) --- avconv.c | 2 +- avconv_opt.c | 2 +- avplay.c | 2 +-

Re: [libav-devel] [PATCH 1/2] KR formatting cosmetics

2014-08-13 Thread Timothy Gu
On Wed, Aug 13, 2014 at 8:03 PM, Luca Barbato lu_z...@gentoo.org wrote: On 14/08/14 04:42, Timothy Gu wrote: This does not make the code any easier to read, It does actually. Sure, if you really think so; but things like plus it pollutes git blame and makes debugging harder than necessary

Re: [libav-devel] [PATCH] doc: Add more information in the README

2014-08-12 Thread Timothy Gu
On Aug 12, 2014 12:27 PM, Luca Barbato lu_z...@gentoo.org wrote: And convert it to Markdown. --- README| 13 + README.md | 40 2 files changed, 41 insertions(+), 12 deletions(-) mode change 100644 = 12 README Why don't you

Re: [libav-devel] [PATCH] mpegts: Define the section lenght with a constant

2014-08-03 Thread Timothy Gu
On Aug 3, 2014 2:42 PM, Luca Barbato lu_z...@gentoo.org wrote: The specification says the value is expressed in 10bit including, the 4bytes crc. --- Now with the correct value, hopefully. libavformat/mpegtsenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

Re: [libav-devel] [PATCH] mpeg4video: doxygen comments

2014-08-01 Thread Timothy Gu
On Aug 1, 2014 12:09 PM, Nidhi Makhijani nidhim...@gmail.com wrote: --- libavcodec/mpeg4video.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) You're de-doxygenizing. The commit message is wrong [...] Timothy ___

  1   2   >