[libav-devel] [PATCH 18/25] intrax8: Add a local BlockDSPContext and initialize it

2016-03-19 Thread Vittorio Giovara
Helps in decoupling this code from mpegvideo. --- configure| 2 +- libavcodec/intrax8.c | 3 ++- libavcodec/intrax8.h | 2 ++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 493bbc7..1c2ac71 100755 --- a/configure +++ b/configure @@ -1860,7

[libav-devel] [PATCH 1/2] lavf: Raw G.729 demuxer

2016-03-19 Thread Vittorio Giovara
From: Vladimir Voroshilov <voros...@gmail.com> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/g729dec.c| 105 ++

[libav-devel] [PATCH 2/2] GIF demuxer

2016-03-19 Thread Vittorio Giovara
From: Vitaliy E Sugrobov <vsug...@hotmail.com> This demuxer is capable of extracting multiple frames from gif file. In conjunction with gif decoder it implements support for reading animated gifs. Signed-off-by: Vitaliy E Sugrobov <vsug...@hotmail.com> Signed-off-by: Vitt

[libav-devel] [PATCH 06/25] intrax8: Move documentation from implementation to header files

2016-03-19 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 20 libavcodec/intrax8.h | 22 ++ 2 files changed, 22 insertions(+), 20 deletions(-) Unchanged. diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 851c434..3ab2faa 100644 --- a/libavcodec/intrax8.c +++

[libav-devel] [PATCH 02/25] intrax8: Move error resilience out of intrax8

2016-03-19 Thread Vittorio Giovara
The intrax8 decoding process does not imply any kind of error correction, and the only call present is more related to how mpegvideo works rather than anything else. Therefore have the parent decoders carried out er when actually needed. Drop two variables that were initialized but never used.

[libav-devel] [PATCH 09/25] vc1dec: wmv2dec: Validate ff_intrax8_common_init return value

2016-03-19 Thread Vittorio Giovara
--- libavcodec/vc1dec.c | 8 +--- libavcodec/wmv2dec.c | 4 +--- 2 files changed, 6 insertions(+), 6 deletions(-) Unchanged. diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 51f5c42..76f3591 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -314,7 +314,7 @@ static

[libav-devel] [PATCH 03/25] intrax8: Wrap multiline macros in do{}while(0) clauses

2016-03-19 Thread Vittorio Giovara
These macros are treated like functions, the wrapping simplifies error checking and avoids deep nested if in the following commit. --- libavcodec/intrax8.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) Unchanged. Vittorio diff --git a/libavcodec/intrax8.c

[libav-devel] [PATCH 12/25] intrax8: Keep a reference to the context idctdsp

2016-03-19 Thread Vittorio Giovara
Use it instead of the embedded mpegvideo one. Update init function signature to load it directly from the callers. --- configure| 1 + libavcodec/intrax8.c | 14 -- libavcodec/intrax8.h | 6 +- libavcodec/vc1dec.c | 2 +- libavcodec/wmv2dec.c | 2 +- 5 files

[libav-devel] [PATCH 11/25] intrax8: Make x8_init_block_index not use mpegvideo fields

2016-03-19 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 3993c57..bb2ee8f 100644 --- a/libavcodec/intrax8.c +++ b/libavcodec/intrax8.c @@ -725,22 +725,21 @@ block_placed: } // FIXME

[libav-devel] [PATCH 04/25] intrax8: Split one comment on multiple lines where it applies

2016-03-19 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) Taken out of the k patch. diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 4887643..b951684 100644 --- a/libavcodec/intrax8.c +++ b/libavcodec/intrax8.c @@ -152,11 +152,11 @@ static inline

[libav-devel] [PATCH 10/25] intrax8: Use local destination buffers

2016-03-19 Thread Vittorio Giovara
These buffers are just a way to store frame pointers and be able to modify them without touching the original ones. The two dependent decoders (WMV2 and VC1) do not need special care for these fields: the former does not seem to use the dest buffers, while the latter reinits them every time to

[libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

2016-03-19 Thread Vittorio Giovara
--- tests/fate/microsoft.mak| 3 + tests/ref/fate/wmv8-intrax8 | 475 2 files changed, 478 insertions(+) create mode 100644 tests/ref/fate/wmv8-intrax8 This test breaks on an oracle box with gcc-4.4. I carried out a minimum investigation and

[libav-devel] [PATCH 16/25] intrax8: Keep a reference to the GetBitContext reader

2016-03-19 Thread Vittorio Giovara
Helps in decoupling this code from mpegvideo. --- libavcodec/intrax8.c | 35 --- libavcodec/intrax8.h | 4 +++- libavcodec/vc1_block.c | 2 +- libavcodec/wmv2dec.c | 2 +- 4 files changed, 21 insertions(+), 22 deletions(-) diff --git

[libav-devel] [PATCH] indeo4: Rework stream analysis report

2016-03-19 Thread Vittorio Giovara
* Change log level from error to debug * Print report after the first decoded frame, not at the end of decoding * Drop macro guard and use a context variable instead Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/indeo4.c | 11 +-- libavcodec/ivi.c

Re: [libav-devel] [PATCH 2/2] vda_h264: Use av_buffer to manage buffers

2016-03-19 Thread Vittorio Giovara
On Tue, Mar 4, 2014 at 7:30 PM, Luca Barbato wrote: > From: Sebastien Zwickert > > Fix a buffer leak when seeking occurs. > > Signed-off-by: Luca Barbato > --- > libavcodec/vda_h264.c | 25 - >

Re: [libav-devel] [PATCH] matroskaenc: Don't set language to empty string, use "und"

2016-03-19 Thread Vittorio Giovara
On Wed, Jul 23, 2014 at 7:03 AM, Anton Khirnov wrote: > > On Tue, 22 Jul 2014 09:38:42 +0200, j...@v2v.cc wrote: >> On 07/21/2014 09:35 PM, Anton Khirnov wrote: >> > >> > On Sun, 20 Jul 2014 15:28:36 +0200, j...@v2v.cc wrote: >> >> On 07/20/2014 03:13 PM, Anton Khirnov wrote:

Re: [libav-devel] [PATCH 2/2] mpegts: use av_islang before setting language

2016-03-19 Thread Vittorio Giovara
On Thu, Jul 24, 2014 at 3:55 AM, Jan Gerber wrote: > --- > libavformat/mpegts.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c > index 5d8b08c..fa784ac 100644 > --- a/libavformat/mpegts.c > +++

Re: [libav-devel] [PATCH 1/2] avlanguage: add av_islang

2016-03-19 Thread Vittorio Giovara
On Thu, Jul 24, 2014 at 3:55 AM, Jan Gerber wrote: > --- > libavformat/avlanguage.c | 14 ++ > libavformat/avlanguage.h | 5 + > 2 files changed, 19 insertions(+) > > diff --git a/libavformat/avlanguage.c b/libavformat/avlanguage.c > index e606ef2..a4b916f 100644 >

Re: [libav-devel] [RFC] no longer marking native aac encoder as experimental

2016-03-19 Thread Vittorio Giovara
On Sun, Nov 30, 2014 at 6:06 PM, Luca Barbato wrote: > On 30/11/14 23:43, Andreas Cadhalpun wrote: >> >> On 20.11.2014 17:59, Andreas Cadhalpun wrote: >>> >>> Hi, >>> >>> currently the native aac encoder is marked as experimental, while the >>> libvo_aacenc encoder is not. >>>

Re: [libav-devel] [FFmpeg-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

2016-03-19 Thread Vittorio Giovara
On Tue, Apr 21, 2015 at 12:50 PM, Andreas Cadhalpun wrote: > On 21.04.2015 02:20, Claudio Freire wrote: >> On Mon, Apr 20, 2015 at 9:13 PM, Michael Niedermayer >> wrote: >>> On Mon, Apr 20, 2015 at 09:07:14PM -0300, Claudio Freire wrote:

Re: [libav-devel] [PATCH] takdec: ensure chan2 is a valid channel index

2016-03-19 Thread Vittorio Giovara
On Tue, Jun 9, 2015 at 8:26 PM, Luca Barbato wrote: > On 10/06/15 00:12, Andreas Cadhalpun wrote: >> If chan2 is not smaller than the number of channels, it can cause >> segmentation faults due to dereferencing a NULL pointer. >> >> Signed-off-by: Andreas Cadhalpun

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2016-03-19 Thread Vittorio Giovara
On Sun, Jun 7, 2015 at 1:07 PM, Luca Barbato wrote: > On 07/06/15 16:30, Andreas Cadhalpun wrote: >> It seems Luca accidentally pushed an old version of this patch. >> The pushed version still has the ffio_read_size name and Luca's >> comment about the error handling is also

Re: [libav-devel] [PATCH] img2: Provide an option take the path verbatim

2016-03-19 Thread Vittorio Giovara
On Sat, Feb 7, 2015 at 8:22 AM, Luca Barbato wrote: > On 02/02/15 01:36, Luca Barbato wrote: >> There can be valid files path sporting %-sequences or have >> files ending with .V in the the same directory but not related. >> --- >> >> Mainly an rfc and pro-memoria. >> > >

Re: [libav-devel] [PATCH] lavf: add a format flag for separate carriers, and an event for detecting carrier presence.

2016-03-19 Thread Vittorio Giovara
On Mon, Jun 8, 2015 at 5:28 AM, John Högberg wrote: > Luca Barbato wrote: >> Please do. I thought about the alternative to support your scenario (beside >> having a callback API that I'll blog about soonish) and another way to do >> that >> is to have an

Re: [libav-devel] [FFmpeg-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2016-03-19 Thread Vittorio Giovara
On Tue, Jun 16, 2015 at 3:55 PM, Andreas Cadhalpun wrote: > On 16.06.2015 00:37, Luca Barbato wrote: >> On 16/06/15 00:14, Andreas Cadhalpun wrote: I wonder if the sanity check in the decoder would be enough to not have other problems down the line. >>>

Re: [libav-devel] [PATCH] x86: Add SSSE3_SLOW CPU flag and related convenience macros

2016-03-19 Thread Vittorio Giovara
On Tue, Jan 19, 2016 at 7:55 AM, Diego Biurrun wrote: > --- > > Fixed FAST_SLOW typo. > > doc/APIchanges | 3 +++ > libavutil/cpu.h | 1 + > libavutil/version.h | 2 +- > libavutil/x86/cpu.h | 6 ++ > 4 files changed, 11 insertions(+), 1 deletion(-) > > diff --git

Re: [libav-devel] [PATCH] movenc: check for the error in the AVIOContext and write

2016-03-19 Thread Vittorio Giovara
On Thu, Aug 27, 2015 at 7:20 AM, Luca Barbato wrote: > On 27/08/15 13:10, Martin Storsjö wrote: >> On Thu, 27 Aug 2015, Alexandra Hájková wrote: >> >>> the error message if there is some error. MOV has its header >>> at the end of the file so the output will be corrupted if

Re: [libav-devel] [PATCH] hevc: Parse the encoder info SEI

2016-03-19 Thread Vittorio Giovara
On Sat, Oct 17, 2015 at 6:25 PM, Luca Barbato wrote: > On 16/10/15 19:46, Anton Khirnov wrote: >> >> If the block above got executed, won't it attemp to skip it again? > > > it starts skipping from whenever `i` was before, alternatively I can just > process all the buffer and

Re: [libav-devel] [PATCH] asfdec: hadle invalid Object size properly

2016-03-19 Thread Vittorio Giovara
On Mon, Feb 8, 2016 at 3:12 PM, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > On Tue, Jun 30, 2015 at 5:19 AM, Luca Barbato <lu_z...@gentoo.org> wrote: >> On 30/06/15 11:35, Alexandra Hájková wrote: >>> --- >>> libavformat/asfdec.c | 12

Re: [libav-devel] [PATCH] libavcodec/util: Fix timebase overflow check

2016-03-19 Thread Vittorio Giovara
On Wed, Jan 27, 2016 at 5:19 PM, Derek Buitenhuis wrote: > On 1/27/2016 10:16 PM, Luca Barbato wrote: >> When it is zero? (isn't there a check before to sanitize the time_base ?) > > I only see a check for audio. What happened to this patch? -- Vittorio

Re: [libav-devel] [PATCH] avconv: Move the reporting in a separate thread

2016-03-19 Thread Vittorio Giovara
On Thu, Feb 4, 2016 at 7:07 AM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 04/02/16 12:52, Vittorio Giovara wrote: >> is this still needed? > > Yes, I'll send and update on this Friday. > > lu I might have forgotten to check, and couldn't find it in the tre

Re: [libav-devel] [PATCH] diracdec: Move strides to bytes, and pointer types to uint8_t.

2016-03-19 Thread Vittorio Giovara
On Sun, Dec 6, 2015 at 8:57 AM, Diego Biurrun wrote: > On Sun, Dec 06, 2015 at 12:36:24PM +, Kieran Kunhya wrote: >> Start templating functions for move to support 10-bit >> Parts of this patch were written by Rostislav Pehlivanov >> --- a/libavcodec/diracdec.c >> +++

Re: [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2016-03-19 Thread Vittorio Giovara
On Sat, Mar 19, 2016 at 4:44 PM, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > On Tue, Dec 15, 2015 at 4:41 PM, Andreas Cadhalpun > <andreas.cadhal...@googlemail.com> wrote: >> On 15.12.2015 08:17, Anton Khirnov wrote: >>> Can you share the sample that

Re: [libav-devel] [PATCH] avio: Add avio_check2

2016-03-19 Thread Vittorio Giovara
On Thu, Feb 4, 2016 at 6:56 AM, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > On Sun, Nov 8, 2015 at 5:12 PM, Luca Barbato <lu_z...@gentoo.org> wrote: >> On 08/11/15 16:43, Anton Khirnov wrote: >>> Ok, now that sounds like a real use case. But that's real

Re: [libav-devel] [PATCH 1/3] x264: Optionally forward the input frame type

2016-03-19 Thread Vittorio Giovara
On Sat, Feb 6, 2016 at 6:02 AM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 04/02/16 13:09, Vittorio Giovara wrote: >> On Tue, Sep 1, 2015 at 12:50 AM, Luca Barbato <lu_z...@gentoo.org> wrote: >>> On 31/08/15 20:55, Anton Khirnov wrote: >>>> Looks lik

Re: [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2016-03-19 Thread Vittorio Giovara
On Tue, Dec 15, 2015 at 4:41 PM, Andreas Cadhalpun wrote: > On 15.12.2015 08:17, Anton Khirnov wrote: >> Can you share the sample that shows the problem? > > I could, but it's of no use for comparing with libopus, because their > decoder errors out in an

Re: [libav-devel] [PATCH] rtsp: Factor out the rtp stream opening

2016-03-19 Thread Vittorio Giovara
On Thu, Feb 4, 2016 at 7:08 AM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 04/02/16 12:54, Vittorio Giovara wrote: > >> is this still needed? >> > > Yes. so.. any reason it's not pushed? -- Vittorio ___ libav-devel mail

Re: [libav-devel] [PATCH 6/7] avio: Disable incompatible pointer type warnings

2016-03-19 Thread Vittorio Giovara
On Sat, Feb 6, 2016 at 6:09 AM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 04/02/16 13:04, Vittorio Giovara wrote: >> On Thu, Nov 26, 2015 at 5:17 PM, Luca Barbato <lu_z...@gentoo.org> wrote: >>> --- >>> libavformat/avio.c | 3 +++ >>> 1

Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-03-19 Thread Vittorio Giovara
On Sat, Feb 6, 2016 at 3:22 PM, Luca Barbato wrote: > On 06/02/16 19:39, Henrik Gramner wrote: >> On Sat, Feb 6, 2016 at 7:34 PM, Luca Barbato wrote: >>> Give how this function is used it is not really important, its purpose >>> is to not break the

Re: [libav-devel] [PATCH] mpegts: Forward the errors on mpeg4 objects parsing

2016-03-19 Thread Vittorio Giovara
On Tue, Feb 16, 2016 at 8:23 PM, Luca Barbato wrote: > --- > libavformat/mpegts.c | 25 - > 1 file changed, 16 insertions(+), 9 deletions(-) This patch is approved but not applied, what's the hold up? -- Vittorio

Re: [libav-devel] [PATCH 4/8] opt: Add const to av_opt_next in the next major bump

2016-03-19 Thread Vittorio Giovara
On Sat, Mar 19, 2016 at 11:14 AM, Anton Khirnov wrote: > Quoting Martin Storsjö (2016-03-18 13:01:38) >> From: Lukasz Marek >> >> Also add const to pointers in static functions within opt.c where >> possible. >> --- >> Or can we freely add const here

Re: [libav-devel] [PATCH 2/9] lavf: generic hardware surface upload and download

2016-03-19 Thread Vittorio Giovara
On Tue, Mar 15, 2016 at 6:57 PM, Mark Thompson wrote: > --- > libavfilter/Makefile| 2 + > libavfilter/allfilters.c| 2 + > libavfilter/avfilter.c | 2 + > libavfilter/avfilter.h | 9 ++ > libavfilter/vf_hwdownload.c | 212

Re: [libav-devel] [PATCH] qsv: Fix loading multiple plugins

2016-03-15 Thread Vittorio Giovara
On Tue, Mar 15, 2016 at 9:10 AM, Luca Barbato wrote: > av_get_token does not strip the trailing separator. > --- > libavcodec/qsv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > index 3e892e8..e08518b 100644 > ---

Re: [libav-devel] [PATCH] mov: Check the entries value when parsing dref boxes

2016-03-09 Thread Vittorio Giovara
On Wed, Mar 9, 2016 at 9:42 PM, Luca Barbato wrote: > On 08/03/16 12:05, Luca Barbato wrote: >> And properly reset the entries count when resetting the entries. >> >> CC: libav-sta...@libav.org >> >> Bug-Id: 929 >> --- >> > > CVE-2016-3062 ok i think -- Vittorio

Re: [libav-devel] [PATCH] hwcontext_vdpau: Use correct array member in comparison

2016-03-08 Thread Vittorio Giovara
On Tue, Mar 8, 2016 at 3:22 PM, Diego Biurrun wrote: > libavutil/hwcontext_vdpau.c:305:37: warning: cast from pointer to integer of > different size > --- > libavutil/hwcontext_vdpau.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [libav-devel] [PATCH] h264: Add missing ff_ prefix to public h264_init_dequant_tables()

2016-03-08 Thread Vittorio Giovara
On Tue, Mar 8, 2016 at 11:55 AM, Diego Biurrun wrote: > --- > libavcodec/h264.c | 2 +- > libavcodec/h264.h | 2 +- > libavcodec/h264_slice.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) I'd use "internally public function" to avoid confusion with

Re: [libav-devel] [PATCH 6/6] lavc: deprecate old functions

2016-03-07 Thread Vittorio Giovara
On Mon, Mar 7, 2016 at 3:12 PM, wm4 wrote: > And replace some doxygen references to them. > --- > libavcodec/avcodec.h | 12 +--- > libavformat/avformat.h | 4 ++-- > 2 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/avcodec.h

Re: [libav-devel] [PATCH 1/2] configure: Support msan as toolchain

2016-03-07 Thread Vittorio Giovara
On Mon, Mar 7, 2016 at 2:52 AM, Luca Barbato wrote: > --- > configure | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/configure b/configure > index d8b8c07..f0c4f0a 100755 > --- a/configure > +++ b/configure > @@ -2701,6 +2701,11 @@ case "$toolchain" in >

Re: [libav-devel] [PATCH 2/2] configure: Add support for clang llvm-cov

2016-03-07 Thread Vittorio Giovara
On Mon, Mar 7, 2016 at 2:52 AM, Luca Barbato wrote: > --- > configure | 4 > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index f0c4f0a..9ffb679 100755 > --- a/configure > +++ b/configure > @@ -2778,6 +2778,10 @@ case "$toolchain" in >

Re: [libav-devel] [PATCH] avcodec/cfhd: Fixes cfhd_odd.mov which has a resolution of 496x241

2016-03-05 Thread Vittorio Giovara
owpass_height * lowpass_width], > -- Confirmed to work with the sample. Here is an addendum to avoid displaying garbage (untested with other samples) commit 658fdd157f12633006533bc67ffb3b0d44a198df Author: Vittorio Giovara <vittorio.giov...@gmail.com> Date: Sat Mar 5 13:32:54 2016 -0

[libav-devel] [PATCH][Release/11] asfenc: Check pts leading to integer overflow

2016-03-03 Thread Vittorio Giovara
From: Michael Niedermayer Bug-Id: CVE-2016-2326 Sample-Id: 0063df8be3aaa30dd6d76f59c8f818c8/signal_sigsegv_7b7b59_3634_bf418b6822bbfa68734411d96b667be3.mov Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer

Re: [libav-devel] [PATCH] mov: check atom nesting depth and limit it to 10

2016-03-02 Thread Vittorio Giovara
On Tue, Feb 9, 2016 at 5:45 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 09/02/16 23:23, Vittorio Giovara wrote: >> From: Michael Niedermayer <michae...@gmx.at> >> >> Fixes call stack overflow >> Fixes: case1_call_stack_overflow.mp4 >> Found-by: Mi

Re: [libav-devel] [PATCH] mov: Trim dref absolute path

2016-03-02 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 5:16 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 24/02/16 18:23, Vittorio Giovara wrote: >> Which way? Patch as is or the other version that trims by 1 character only? >> > > As is, it is fine. Adding this to the push queue, any more commen

[libav-devel] [PATCH 2/3] mpegvideo_motion: Fix undefined negative shifts in mpeg_motion_internal

2016-03-02 Thread Vittorio Giovara
From: Michael Niedermayer <michae...@gmx.at> Found-by: Clang -fsanitize=shift Reported-by: Thierry Foucu <tfo...@google.com> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/mpegvideo_motion.c | 8 +--- 1 file changed, 5 insertions(+), 3 deleti

[libav-devel] [PATCH 1/3] mpegvideo: Fix undefined negative shifts in ff_init_block_index

2016-03-02 Thread Vittorio Giovara
From: Luca Barbato <lu_z...@gentoo.org> Found-by: gcc5-ubsan. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/mpegvideo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index e078

[libav-devel] [PATCH 3/3] idct8x8: Fix undefined negative shifts

2016-03-02 Thread Vittorio Giovara
From: Katerina Barone-Adesi The original code left-shifts negative values, which is undefined in the C99 specification (the one used during normal Libav compilation). This change multiplies by (1 << shift), which is functionally equivalent, but has defined behavior. With

[libav-devel] [PATCH] vdpau: Add missing deprecation guards

2016-03-01 Thread Vittorio Giovara
--- libavcodec/vdpau.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vdpau.c b/libavcodec/vdpau.c index dd48c04..bf5f8d9 100644 --- a/libavcodec/vdpau.c +++ b/libavcodec/vdpau.c @@ -317,6 +317,7 @@ int ff_vdpau_add_buffer(struct vdpau_picture_context *pic_ctx, return 0;

Re: [libav-devel] [PATCH 2/2] fate: Add separate target for all indeo3 tests

2016-03-01 Thread Vittorio Giovara
On Tue, Mar 1, 2016 at 7:52 AM, Diego Biurrun wrote: > --- > tests/fate/indeo.mak| 11 +++ > tests/ref/fate/{indeo3 => indeo3-1} | 0 > 2 files changed, 7 insertions(+), 4 deletions(-) > rename tests/ref/fate/{indeo3 => indeo3-1} (100%) > > diff --git

Re: [libav-devel] [PATCH 1/6] lavu: improve documentation of some AVFrame functions

2016-02-27 Thread Vittorio Giovara
On Sat, Feb 27, 2016 at 9:15 AM, wm4 wrote: > --- > libavutil/frame.h | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/libavutil/frame.h b/libavutil/frame.h > index 5a04177..6f5d733 100644 > --- a/libavutil/frame.h > +++

Re: [libav-devel] [PATCH] Update changelog for v11.6

2016-02-26 Thread Vittorio Giovara
On Fri, Feb 26, 2016 at 5:46 PM, Sean McGovern wrote: > --- > Changelog |8 > RELEASE |2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Changelog b/Changelog > index 08bb70b..6bb13ea 100644 > --- a/Changelog > +++ b/Changelog > @@

[libav-devel] [PATCH] avcodec/eatqi: print error on mb decode failure

2016-02-25 Thread Vittorio Giovara
From: Michael Niedermayer Reviewed-by: Derek Buitenhuis Signed-off-by: Michael Niedermayer --- libavcodec/eatqi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/eatqi.c

Re: [libav-devel] [PATCH 19/25] intrax8: Use the generic horizband function

2016-02-24 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 2:53 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 23/02/16 02:17, Vittorio Giovara wrote: >> This is assuming that intrax8 has no support for interlacing >> (hence PICT_FRAME is set and last_frame is NULL). >> --- >> libavcodec/intra

[libav-devel] [PATCH] fate: Add test for indeo2 with delta frames

2016-02-24 Thread Vittorio Giovara
Rename to keep indeo2 target separate. --- tests/fate/indeo.mak| 12 +++- tests/ref/fate/indeo2-delta | 115 tests/ref/fate/{indeo2 => indeo2-intra} | 0 3 files changed, 124 insertions(+), 3 deletions(-) create mode 100644

[libav-devel] [PATCH 4/4] vc1dec: Check group allocations separatedly

2016-02-24 Thread Vittorio Giovara
This avoids summing offsets to NULL pointers in case of error. --- libavcodec/vc1dec.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 5c2cf9f..67c14c2 100644 --- a/libavcodec/vc1dec.c +++

[libav-devel] [PATCH 2/4] vc1dec: Properly call deinit function on error

2016-02-24 Thread Vittorio Giovara
This functions allocates tons of buffers, free on error in a separate one. --- libavcodec/vc1dec.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 2cd7a03..104c3a3 100644 --- a/libavcodec/vc1dec.c +++

Re: [libav-devel] [PATCH 2/3] idct: Only build prores IDCT if ProRes decoder is enabled

2016-02-24 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 1:13 PM, Diego Biurrun wrote: > --- > libavcodec/simple_idct.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/simple_idct.c b/libavcodec/simple_idct.c > index f61e9e6..6ee1320 100644 > --- a/libavcodec/simple_idct.c > +++

Re: [libav-devel] [PATCH] qsv: Move down the implementation query

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 9:14 AM, Luca Barbato wrote: > The plugin loaded may not match the general implementation capability > wise. > --- > libavcodec/qsv.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git

[libav-devel] [PATCH 3/4] vc1dec: Fix leak on error for array allocations

2016-02-24 Thread Vittorio Giovara
The deinit function in the 'error' section will correctly free everything. --- libavcodec/vc1dec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 104c3a3..5c2cf9f 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c

[libav-devel] [PATCH 1/4] vc1dec: Drop commented out cruft

2016-02-24 Thread Vittorio Giovara
--- libavcodec/vc1dec.c | 8 1 file changed, 8 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index d65c68a..2cd7a03 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -352,14 +352,6 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v)

[libav-devel] [PATCH] lavf: Handle query parameters when checking extensions

2016-02-24 Thread Vittorio Giovara
-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Here is the correct patch I had in mind. Cheers, Vittorio libavformat/format.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavformat/format.c b/libavformat/format.c index 24b7205..7

Re: [libav-devel] [PATCH] img2dec: Handle query parameters when checking extensions

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 1:43 PM, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > A webserver omits the Content-Type or if mime-magic fails for unexpected > reasons, probing an image HTTP URL with query parameters will fail in > the extension match. > > So check the

[libav-devel] [PATCH] img2dec: Handle query parameters when checking extensions

2016-02-24 Thread Vittorio Giovara
-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- This should be the less hack-y version, even though it does not fully address the image2 decoder. Vittorio libavformat/img2.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/im

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

2016-02-24 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 3:36 PM, Derek Buitenhuis <derek.buitenh...@gmail.com> wrote: > On 2/23/2016 1:17 AM, Vittorio Giovara wrote: >> --- >> The test sample is already on FATE strangely enough. >> Vittorio >> >> tests/fate/microsoft.mak| 3

Re: [libav-devel] [PATCH] mov: Trim dref absolute path

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 17, 2016 at 2:41 AM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 16/02/16 22:26, Vittorio Giovara wrote: >> On Tue, Feb 16, 2016 at 2:19 AM, Luca Barbato <lu_z...@gentoo.org> wrote: >>> On 16/02/16 03:44, Vittorio Giovara wrote: >>>> S

Re: [libav-devel] [PATCH 4/4] avprobe: switch to codecpar

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > --- > avprobe.c | 107 > ++ > 1 file changed, 65 insertions(+), 42 deletions(-) lgtm thanks -- Vittorio ___

Re: [libav-devel] [PATCH 3/4] avprobe: add local per-stream state

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > This will be useful in the following commits. > --- > avprobe.c | 20 > 1 file changed, 20 insertions(+) probably ok -- Vittorio ___ libav-devel mailing

Re: [libav-devel] [PATCH 2/4] avprobe: add local per-file state

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > Do not pass just a bare AVFormatContext pointer around, wrap it in > struct. This will be useful in the following commits. > --- > avprobe.c | 38 +++--- > 1 file changed, 23

Re: [libav-devel] [PATCH 1/4] mpegvideo_enc: use avcodec_free_context() instead of av_free()

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 10:36 AM, Anton Khirnov wrote: > --- > libavcodec/mpegvideo_enc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index d16e408..96f49ef 100644 > ---

Re: [libav-devel] [PATCH 2/2] APIchanges: add missing hashes and dates

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 5:01 AM, Anton Khirnov wrote: > Also, remove a stray line (apparently fallout from conflict resolution). > --- > doc/APIchanges | 72 > -- > 1 file changed, 35 insertions(+), 37 deletions(-)

Re: [libav-devel] [PATCH 1/2] lavf: add a missing bump and APIchanges for the codecpar switch

2016-02-24 Thread Vittorio Giovara
On Wed, Feb 24, 2016 at 5:01 AM, Anton Khirnov wrote: > --- > doc/APIchanges| 3 +++ > libavformat/version.h | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 70fce18..2db39de 100644 > ---

[libav-devel] [RFC] [PATCH 2/2] img2dec: Handle query parameters when checking extensions

2016-02-23 Thread Vittorio Giovara
-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- This fixes http://url/path.jpg?query=1 not being detected at all. Video streams do not seem to need a similar solution, since they use more ways to probe data before falling back to extensions. I'm open to other solutions/ideas/sugges

[libav-devel] [PATCH 1/2] img2: Drop av_ prefix for a static function

2016-02-23 Thread Vittorio Giovara
This prefix is reserved for public functions only. --- libavformat/img2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/img2.c b/libavformat/img2.c index 9f462d0..3cfc08e 100644 --- a/libavformat/img2.c +++ b/libavformat/img2.c @@ -82,7 +82,7 @@ static const

Re: [libav-devel] [PATCH 20/25] intrax8: Keep a reference to the decoder blocks

2016-02-23 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 10:51 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Mon, Feb 22, 2016 at 08:17:44PM -0500, Vittorio Giovara wrote: >> --- >> NOTE: both these elements are not actually used by the decoders: >> vc1 modifies them only for intra (non-j

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

2016-02-23 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 10:37 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Tue, Feb 23, 2016 at 10:20:56AM -0500, Vittorio Giovara wrote: >> On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun <di...@biurrun.de> wrote: >> > On Mon, Feb 22, 2016 at 08:17:25PM

Re: [libav-devel] [PATCH 13/25] intrax8: Use a local buffer instead of a ScratchpadContext

2016-02-23 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 8:22 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote: >> Sustain possible size changes via av_fast_malloc(). > > Sustain? That's not the right word, but I'm a tad unsure what you are

Re: [libav-devel] [PATCH 07/25] vc1dec: wmv2dec: Validate ff_intrax8_common_init return value

2016-02-23 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 6:09 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Mon, Feb 22, 2016 at 08:17:31PM -0500, Vittorio Giovara wrote: >> --- a/libavcodec/vc1dec.c >> +++ b/libavcodec/vc1dec.c >> @@ -360,7 +360,7 @@ av_cold int ff_vc1_decode_init_all

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

2016-02-23 Thread Vittorio Giovara
On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote: >> --- a/tests/fate/microsoft.mak >> +++ b/tests/fate/microsoft.mak >> @@ -38,6 +38,9 @@ fate-wmv8-drm-nodec

[libav-devel] [PATCH 12/25] intrax8: Pass the output frame to the decoding function

2016-02-22 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 21 +++-- libavcodec/intrax8.h | 7 +-- libavcodec/vc1_block.c | 4 +++- libavcodec/wmv2dec.c | 3 ++- 4 files changed, 21 insertions(+), 14 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index d9c156c..d0e7e93 100644

[libav-devel] [PATCH 10/25] intrax8: Keep a reference to the context idctdsp

2016-02-22 Thread Vittorio Giovara
Use it instead of the embedded mpegvideo one. Update init function signature to load it directly from the callers. --- configure| 2 +- libavcodec/intrax8.c | 14 -- libavcodec/intrax8.h | 6 +- libavcodec/vc1dec.c | 2 +- libavcodec/wmv2dec.c | 2 +- 5 files

[libav-devel] [PATCH 22/25] intrax8: Keep a reference to the error resilience context

2016-02-22 Thread Vittorio Giovara
--- This one bugs me since intrax8 decoding process requires no error resilience whatsoever, and it's only there to make things work with mpegvideo. I'd really really like to remove error resilience altogether, but that would require adding two er function calls to the dependent decoders. Would

[libav-devel] [PATCH 02/25] intrax8: Wrap multiline macros in do{}while(0) clauses

2016-02-22 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 3cd84dc..509a8d2 100644 --- a/libavcodec/intrax8.c +++ b/libavcodec/intrax8.c @@ -62,7 +62,7 @@ static av_cold void x8_vlc_init(void){

[libav-devel] [PATCH 04/25] intrax8: Move documentation from implementation to header files

2016-02-22 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 20 libavcodec/intrax8.h | 24 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 8b6de0d..9e9479b 100644 --- a/libavcodec/intrax8.c +++ b/libavcodec/intrax8.c

[libav-devel] [PATCH 24/25] intrax8: Remove mpegvideo dependency

2016-02-22 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 7 +-- libavcodec/intrax8.h | 10 +- libavcodec/vc1dec.c | 3 +-- libavcodec/wmv2dec.c | 2 +- 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 9c82ef9..c289dd4 100644 ---

[libav-devel] [PATCH 25/25] build: Add a formal dependency to intrax8

2016-02-22 Thread Vittorio Giovara
intrax8 needs tables from msmpeg4, which are normally supplied by either VC1 or WMV2. --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 256dee3..ea47273 100644 --- a/libavcodec/Makefile +++

[libav-devel] [PATCH 19/25] intrax8: Use the generic horizband function

2016-02-22 Thread Vittorio Giovara
This is assuming that intrax8 has no support for interlacing (hence PICT_FRAME is set and last_frame is NULL). --- libavcodec/intrax8.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index b3b1331..44cf141 100644 ---

[libav-devel] [PATCH 15/25] intrax8: Reference the currect AVCodecContext decoder

2016-02-22 Thread Vittorio Giovara
It will be needed in later commits. --- libavcodec/intrax8.c | 4 +++- libavcodec/intrax8.h | 5 - libavcodec/vc1dec.c | 2 +- libavcodec/wmv2dec.c | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 7675d06..b03da68 100644

[libav-devel] [PATCH 18/25] intrax8: Carry over lowdelay value in ff_intrax8_decode_picture

2016-02-22 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 3 ++- libavcodec/intrax8.h | 3 ++- libavcodec/vc1_block.c | 2 +- libavcodec/wmv2dec.c | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index 8ac3417..b3b1331 100644 --- a/libavcodec/intrax8.c +++

[libav-devel] [PATCH 17/25] intrax8: Pass macroblock size to ff_intrax8_common_init

2016-02-22 Thread Vittorio Giovara
--- libavcodec/intrax8.c | 65 ++-- libavcodec/intrax8.h | 7 ++ libavcodec/vc1dec.c | 4 +++- libavcodec/wmv2dec.c | 3 ++- 4 files changed, 44 insertions(+), 35 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index

[libav-devel] [PATCH 07/25] vc1dec: wmv2dec: Validate ff_intrax8_common_init return value

2016-02-22 Thread Vittorio Giovara
--- libavcodec/vc1dec.c | 6 +++--- libavcodec/wmv2dec.c | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index d65c68a..e60a084 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -314,7 +314,7 @@ static void

[libav-devel] [PATCH 21/25] intrax8: Drop two unused variables

2016-02-22 Thread Vittorio Giovara
These are not changed in the function, nor in the dependent decoders. --- libavcodec/intrax8.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/intrax8.c b/libavcodec/intrax8.c index ffb40b6..2613bf7 100644 --- a/libavcodec/intrax8.c +++ b/libavcodec/intrax8.c @@

<    7   8   9   10   11   12   13   14   15   16   >