Re: [libav-devel] [PATCH] dca: Validate the channel map

2017-03-14 Thread Luca Barbato
On 24/02/2017 15:21, Luca Barbato wrote: > Bug-Id: 1016 > > CC: libav-sta...@libav.org > --- > > This is the possibly less ugly and still working. > Ping. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] dca: Validate the channel map

2017-02-27 Thread Luca Barbato
On 24/02/2017 19:24, Anton Khirnov wrote: > Quoting Luca Barbato (2017-02-24 15:21:01) >> Bug-Id: 1016 >> >> CC: libav-sta...@libav.org >> --- >> >> This is the possibly less ugly and still working. >> >> libavcodec/dcadec.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git

Re: [libav-devel] [PATCH] dca: Validate the channel map

2017-02-25 Thread Luca Barbato
On 25/02/2017 18:13, Diego Biurrun wrote: > Extending the log message with that info would be appreciated. Sure, is the patch ok? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] dca: Validate the channel map

2017-02-25 Thread Diego Biurrun
On Fri, Feb 24, 2017 at 07:59:13PM +0100, Luca Barbato wrote: > On 24/02/2017 19:24, Anton Khirnov wrote: > > It's very much non-obvious what exactly does this fix and how, and why > > this specific fix is the right way to do it. > > Having a mismatch between the number of channels in the stream

Re: [libav-devel] [PATCH] dca: Validate the channel map

2017-02-24 Thread Luca Barbato
On 24/02/2017 19:24, Anton Khirnov wrote: > It's very much non-obvious what exactly does this fix and how, and why > this specific fix is the right way to do it. Having a mismatch between the number of channels in the stream and those in the channel map will lead to a segfault or worse. lu

Re: [libav-devel] [PATCH] dca: Validate the channel map

2017-02-24 Thread Anton Khirnov
Quoting Luca Barbato (2017-02-24 15:21:01) > Bug-Id: 1016 > > CC: libav-sta...@libav.org > --- > > This is the possibly less ugly and still working. > > libavcodec/dcadec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c > index

[libav-devel] [PATCH] dca: Validate the channel map

2017-02-24 Thread Luca Barbato
Bug-Id: 1016 CC: libav-sta...@libav.org --- This is the possibly less ugly and still working. libavcodec/dcadec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index be277d2..fa2a240 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c

[libav-devel] [PATCH] dca: Validate the channel map

2017-02-24 Thread Luca Barbato
Bug-Id: 1016 CC: libav-sta...@libav.org --- Probably there is a smarter way. libavcodec/dcadec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index be277d2..689dfa9 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -1299,6