Re: [libav-devel] [PATCH] matroskaenc: fix writing ProjectionPrivate element on Cubemap projections

2017-04-07 Thread Vittorio Giovara
On Fri, Apr 7, 2017 at 11:54 AM, Hendrik Leppkes wrote: > On Fri, Apr 7, 2017 at 11:32 AM, Vittorio Giovara > wrote: >> On Thu, Apr 6, 2017 at 10:45 PM, James Almer wrote: >>> Calling put_ebml_binary() with sizeof(private) as

Re: [libav-devel] [PATCH] matroskaenc: fix writing ProjectionPrivate element on Cubemap projections

2017-04-07 Thread Hendrik Leppkes
On Fri, Apr 7, 2017 at 11:32 AM, Vittorio Giovara wrote: > On Thu, Apr 6, 2017 at 10:45 PM, James Almer wrote: >> Calling put_ebml_binary() with sizeof(private) as argument is currently >> only valid for Equirectangular projections. >> >>

Re: [libav-devel] [PATCH] matroskaenc: fix writing ProjectionPrivate element on Cubemap projections

2017-04-07 Thread Vittorio Giovara
On Thu, Apr 6, 2017 at 10:45 PM, James Almer wrote: > Calling put_ebml_binary() with sizeof(private) as argument is currently > only valid for Equirectangular projections. > > Signed-off-by: James Almer > --- > Please, be more careful when making cosmetic

Re: [libav-devel] [PATCH] matroskaenc: fix writing ProjectionPrivate element on Cubemap projections

2017-04-07 Thread Luca Barbato
On 06/04/2017 22:45, James Almer wrote: > Calling put_ebml_binary() with sizeof(private) as argument is currently > only valid for Equirectangular projections. > > Signed-off-by: James Almer > --- > Please, be more careful when making cosmetic changes to make sure they > don't

[libav-devel] [PATCH] matroskaenc: fix writing ProjectionPrivate element on Cubemap projections

2017-04-06 Thread James Almer
Calling put_ebml_binary() with sizeof(private) as argument is currently only valid for Equirectangular projections. Signed-off-by: James Almer --- Please, be more careful when making cosmetic changes to make sure they don't also change how the code works. Not only this was