Re: [libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-16 Thread Luca Barbato
On 15/03/2017 22:53, Vittorio Giovara wrote: > On Wed, Mar 15, 2017 at 5:52 PM, Luca Barbato wrote: >> On 15/03/2017 22:38, Vittorio Giovara wrote: >>> These values are defined to be 32bit in the specification, >>> so it makes more sense to store them as fixed width. >>> >>>

Re: [libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Vittorio Giovara
On Wed, Mar 15, 2017 at 5:52 PM, Luca Barbato wrote: > On 15/03/2017 22:38, Vittorio Giovara wrote: >> These values are defined to be 32bit in the specification, >> so it makes more sense to store them as fixed width. >> >> Signed-off-by: Vittorio Giovara

Re: [libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Luca Barbato
On 15/03/2017 22:38, Vittorio Giovara wrote: > These values are defined to be 32bit in the specification, > so it makes more sense to store them as fixed width. > > Signed-off-by: Vittorio Giovara > --- > Updated commit message, changed a couple of internal types. >

[libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Vittorio Giovara
These values are defined to be 32bit in the specification, so it makes more sense to store them as fixed width. Signed-off-by: Vittorio Giovara --- Updated commit message, changed a couple of internal types. Vittorio libavformat/dump.c| 2 +-

Re: [libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread wm4
On Wed, 15 Mar 2017 11:31:48 -0400 Vittorio Giovara wrote: > On Wed, Mar 15, 2017 at 10:54 AM, Anton Khirnov wrote: > > > > I'm not against this change, but as this is an ABI break, it should be > > done during the major bump (which should be

Re: [libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Vittorio Giovara
On Wed, Mar 15, 2017 at 10:54 AM, Anton Khirnov wrote: > > I'm not against this change, but as this is an ABI break, it should be > done during the major bump (which should be happening around now anyway). > It should also be mentioned in apichages. I am aware that this is an

Re: [libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-15 Thread Anton Khirnov
Quoting Vittorio Giovara (2017-03-14 22:59:35) > These types better reflect the ones described in the specification and > avoid any platform-specific implementation issues. What "platform specific implementation issues" would those be? There's no need to invent such weasel words when the reason

Re: [libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-14 Thread wm4
On Tue, 14 Mar 2017 17:59:35 -0400 Vittorio Giovara wrote: > These types better reflect the ones described in the specification and > avoid any platform-specific implementation issues. > > Signed-off-by: Vittorio Giovara > --- >

[libav-devel] [PATCH] spherical: Change types of bounding and pad to uint32_t

2017-03-14 Thread Vittorio Giovara
These types better reflect the ones described in the specification and avoid any platform-specific implementation issues. Signed-off-by: Vittorio Giovara --- libavformat/dump.c| 2 +- libavutil/spherical.h | 10 +- 2 files changed, 6 insertions(+), 6