Re: [libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-24 Thread Diego Biurrun
On Wed, Nov 23, 2016 at 09:12:08AM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-11-18 10:46:05) > > --- a/libavformat/ape.c > > +++ b/libavformat/ape.c > > @@ -94,9 +94,9 @@ static int ape_probe(AVProbeData * p) > > > > +#ifdef DEBUG > > static void ape_dumpinfo(AVFormatContext *

Re: [libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-23 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-18 10:46:05) > --- > libavformat/ape.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/ape.c b/libavformat/ape.c > index 80e3372..d917815 100644 > --- a/libavformat/ape.c > +++ b/libavformat/ape.c > @@ -94,9 +94,9 @@

Re: [libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-22 Thread Diego Biurrun
On Mon, Nov 21, 2016 at 03:57:08PM +0100, Diego Biurrun wrote: > --- > > Now with 'do {} while(0)' as suggested by Luca. > > libavformat/ape.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Set OKed by Luca on IRC. Diego ___

[libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-21 Thread Diego Biurrun
--- Now with 'do {} while(0)' as suggested by Luca. libavformat/ape.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/ape.c b/libavformat/ape.c index 80e3372..010b795 100644 --- a/libavformat/ape.c +++ b/libavformat/ape.c @@ -94,9 +94,9 @@ static int

Re: [libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-18 Thread Diego Biurrun
On Fri, Nov 18, 2016 at 10:10:19AM -0500, Vittorio Giovara wrote: > On Fri, Nov 18, 2016 at 4:46 AM, Diego Biurrun wrote: > > --- a/libavformat/ape.c > > +++ b/libavformat/ape.c > > @@ -94,9 +94,9 @@ static int ape_probe(AVProbeData * p) > > > > +#ifdef DEBUG > > static void

Re: [libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-18 Thread Vittorio Giovara
On Fri, Nov 18, 2016 at 4:46 AM, Diego Biurrun wrote: > --- > libavformat/ape.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/ape.c b/libavformat/ape.c > index 80e3372..d917815 100644 > --- a/libavformat/ape.c > +++

[libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-18 Thread Diego Biurrun
--- libavformat/ape.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/ape.c b/libavformat/ape.c index 80e3372..d917815 100644 --- a/libavformat/ape.c +++ b/libavformat/ape.c @@ -94,9 +94,9 @@ static int ape_probe(AVProbeData * p) return 0; } +#ifdef