Re: [libav-devel] [PATCH 1/5] targaenc: Move size check to initialization function

2016-06-27 Thread Vittorio Giovara
On Mon, Jun 27, 2016 at 8:22 AM, Diego Biurrun wrote: > On Sun, Jun 26, 2016 at 08:08:53PM -0400, Vittorio Giovara wrote: >> --- >> libavcodec/targaenc.c | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) > > Why? To make it fail early rather than after codec is open. I'll add th

Re: [libav-devel] [PATCH 1/5] targaenc: Move size check to initialization function

2016-06-27 Thread Diego Biurrun
On Sun, Jun 26, 2016 at 08:08:53PM -0400, Vittorio Giovara wrote: > --- > libavcodec/targaenc.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Why? Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailm

Re: [libav-devel] [PATCH 1/5] targaenc: Move size check to initialization function

2016-06-26 Thread Luca Barbato
On 27/06/16 02:08, Vittorio Giovara wrote: > --- > libavcodec/targaenc.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/targaenc.c b/libavcodec/targaenc.c > index 204ecfe..f0cee38 100644 > --- a/libavcodec/targaenc.c > +++ b/libavcodec/targaenc.c > @@

Re: [libav-devel] [PATCH 1/5] targaenc: Move size check to initialization function

2016-06-26 Thread Luca Barbato
On 27/06/16 02:08, Vittorio Giovara wrote: > --- > libavcodec/targaenc.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/targaenc.c b/libavcodec/targaenc.c > index 204ecfe..f0cee38 100644 > --- a/libavcodec/targaenc.c > +++ b/libavcodec/targaenc.c > @@

[libav-devel] [PATCH 1/5] targaenc: Move size check to initialization function

2016-06-26 Thread Vittorio Giovara
--- libavcodec/targaenc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/targaenc.c b/libavcodec/targaenc.c index 204ecfe..f0cee38 100644 --- a/libavcodec/targaenc.c +++ b/libavcodec/targaenc.c @@ -89,10 +89,6 @@ static int targa_encode_frame(AVCodecContext