Re: [libav-devel] [PATCH 2/5] swscale: move away x86 specific code from rgb2rgb

2011-04-14 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 10:01:07PM +0200, Luca Barbato wrote: > Keep only the plain C code in the main rgb2rgb.c > Change a little the init pattern so some of it can be factorized in > order to behave like dsputils. > > --- a/libswscale/rgb2rgb.c > +++ b/libswscale/rgb2rgb.c > @@ -199,20 +116,14 @

Re: [libav-devel] [PATCH 2/5] swscale: move away x86 specific code from rgb2rgb

2011-04-12 Thread Ronald S. Bultje
Hi, minor comments only. Please fix and apply directly afterwards, this is a massive and useful patch and I want to get it out of the way. On Mon, Apr 11, 2011 at 4:01 PM, Luca Barbato wrote: > @@ -199,20 +116,14 @@ DECLARE_ASM_CONST(8, uint64_t, blue_15mask)  = > 0x001f001fULL; >  32-b