Re: [libav-devel] [PATCH 3/7] x265: Use the framerate information instead of the timebase

2018-02-18 Thread Luca Barbato
On 16/02/2018 18:28, Diego Biurrun wrote: On Fri, Feb 16, 2018 at 06:02:05PM +0100, Luca Barbato wrote: Unbreaks the rate-control behaviour. How does this unbreak what? Locally amended adding: The API expects an average framerate, the timebase is often 1/1000 while the reported average

Re: [libav-devel] [PATCH 3/7] x265: Use the framerate information instead of the timebase

2018-02-16 Thread Vittorio Giovara
On Fri, Feb 16, 2018 at 9:15 PM, Luca Barbato wrote: > On 17/02/2018 00:57, wm4 wrote: > >> On Fri, 16 Feb 2018 18:02:05 +0100 >> Luca Barbato wrote: >> >> Unbreaks the rate-control behaviour. >>> >> Would be nice that the commit message is expanded,

Re: [libav-devel] [PATCH 3/7] x265: Use the framerate information instead of the timebase

2018-02-16 Thread Luca Barbato
On 17/02/2018 00:57, wm4 wrote: On Fri, 16 Feb 2018 18:02:05 +0100 Luca Barbato wrote: Unbreaks the rate-control behaviour. --- libavcodec/libx265.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index

Re: [libav-devel] [PATCH 3/7] x265: Use the framerate information instead of the timebase

2018-02-16 Thread wm4
On Fri, 16 Feb 2018 18:02:05 +0100 Luca Barbato wrote: > Unbreaks the rate-control behaviour. > --- > libavcodec/libx265.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index fd5452193b..73aff2caef

Re: [libav-devel] [PATCH 3/7] x265: Use the framerate information instead of the timebase

2018-02-16 Thread Luca Barbato
On 16/02/2018 18:28, Diego Biurrun wrote: On Fri, Feb 16, 2018 at 06:02:05PM +0100, Luca Barbato wrote: Unbreaks the rate-control behaviour. How does this unbreak what? If your timebase is 1/1000 and your actual frame rate is 30, it gets extra creative in deciding how many bits allocate

Re: [libav-devel] [PATCH 3/7] x265: Use the framerate information instead of the timebase

2018-02-16 Thread Diego Biurrun
On Fri, Feb 16, 2018 at 06:02:05PM +0100, Luca Barbato wrote: > Unbreaks the rate-control behaviour. How does this unbreak what? Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 3/7] x265: Use the framerate information instead of the timebase

2018-02-16 Thread Luca Barbato
Unbreaks the rate-control behaviour. --- libavcodec/libx265.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index fd5452193b..73aff2caef 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -116,8 +116,8 @@ static