Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread Rémi Denis-Courmont
On Sun, 3 Nov 2013 23:27:48 +0100, Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. Should this not take a pix_fmt parameter and support all hwaccels? Or should there be one of these for each hwaccel? Or

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread Rémi Denis-Courmont
On Mon, 4 Nov 2013 01:03:22 +0100, wm4 nfx...@googlemail.com wrote: Completely arbitrary API changes out of the blue? How nice. At this point, it remains backward compatible. In any case, the VDPAU hwaccel has not been in any libav release, hasn't it? So I don't mind breaking the ABI as yet. In

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread Anton Khirnov
On Mon, 04 Nov 2013 12:08:06 +0100, Rémi Denis-Courmont r...@remlab.net wrote: On Sun, 3 Nov 2013 23:27:48 +0100, Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. Should this not take a pix_fmt

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread wm4
On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. --- doc/APIchanges |2 ++ libavcodec/vdpau.c |5 + libavcodec/vdpau.h | 11 +++ 3 files

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread Anton Khirnov
On Mon, 4 Nov 2013 21:02:02 +0100, wm4 nfx...@googlemail.com wrote: On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. --- doc/APIchanges |2 ++

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread wm4
On Mon, 04 Nov 2013 21:35:45 +0100 Anton Khirnov an...@khirnov.net wrote: On Mon, 4 Nov 2013 21:02:02 +0100, wm4 nfx...@googlemail.com wrote: On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread Luca Barbato
On 04/11/13 21:52, wm4 wrote: I don't think having public fields in structs ever worked out well in libav*. It's an endless cycle of deprecations, ABI hacks, and working around bad ABI properties of structs (like adding a constructor function). That's why we are trying to seal when makes

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-04 Thread Anton Khirnov
On Mon, 4 Nov 2013 21:52:17 +0100, wm4 nfx...@googlemail.com wrote: On Mon, 04 Nov 2013 21:35:45 +0100 Anton Khirnov an...@khirnov.net wrote: On Mon, 4 Nov 2013 21:02:02 +0100, wm4 nfx...@googlemail.com wrote: On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-03 Thread wm4
On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. --- doc/APIchanges |2 ++ libavcodec/vdpau.c |5 + libavcodec/vdpau.h | 11 +++ 3 files

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-03 Thread Luca Barbato
On 04/11/13 01:03, wm4 wrote: On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. --- doc/APIchanges |2 ++ libavcodec/vdpau.c |5 +

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-03 Thread wm4
On Mon, 04 Nov 2013 01:20:35 +0100 Luca Barbato lu_z...@gentoo.org wrote: On 04/11/13 01:03, wm4 wrote: On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. ---

Re: [libav-devel] [PATCH 4/6] vdpau: add a constructor for AVVDPAUContext.

2013-11-03 Thread Anton Khirnov
On Mon, 4 Nov 2013 01:03:22 +0100, wm4 nfx...@googlemail.com wrote: On Sun, 3 Nov 2013 23:27:48 +0100 Anton Khirnov an...@khirnov.net wrote: We will likely want to add new fields to it in the future, so this is needed to avoid breaking ABI. --- doc/APIchanges |2 ++