Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-12-11 Thread Diego Biurrun
On Sun, Dec 11, 2016 at 12:10:19PM +0100, Alexandra Hájková wrote: > From: Alexandra Hajkova > > --- > libavcodec/hevcdsp.c | 2 + > libavcodec/hevcdsp.h | 1 + > libavcodec/ppc/Makefile | 1 + > libavcodec/ppc/hevcdsp.c

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-12-01 Thread Diego Biurrun
On Thu, Dec 01, 2016 at 09:59:20PM +0100, Alexandra Hájková wrote: > From: Alexandra Hajkova > > --- > libavcodec/hevcdsp.c | 2 + > libavcodec/hevcdsp.h | 1 + > libavcodec/ppc/Makefile | 1 + > libavcodec/ppc/hevcdsp.c

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-11 Thread Luca Barbato
On 11/11/2016 12:21, Diego Biurrun wrote: > But that type is not used in the code. I think it's an artifact of the > bit_depth_template.c inclusion, which is a mistake. If so probably it is safe to remove then. ___ libav-devel mailing list

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-11 Thread Diego Biurrun
On Fri, Nov 11, 2016 at 12:03:30PM +0100, Luca Barbato wrote: > On 11/11/2016 11:02, Diego Biurrun wrote: > > What is the undef for? > > pixel is an altivec shortcut type defined in altivec.h But that type is not used in the code. I think it's an artifact of the bit_depth_template.c inclusion,

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-11 Thread Luca Barbato
On 11/11/2016 11:02, Diego Biurrun wrote: > What is the undef for? pixel is an altivec shortcut type defined in altivec.h lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-11 Thread Diego Biurrun
On Fri, Nov 11, 2016 at 10:36:21AM +0100, Alexandra Hájková wrote: > --- /dev/null > +++ b/libavcodec/ppc/hevcdsp.c > @@ -0,0 +1,107 @@ > + > +#include "config.h" > +#if HAVE_ALTIVEC_H > +#include > +#undef pixel > +#endif What is the undef for? > +static const vector int16_t trans4[4] = { > +

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-10 Thread Diego Biurrun
On Thu, Nov 10, 2016 at 02:59:15PM +0100, Diego Biurrun wrote: > On Thu, Nov 10, 2016 at 02:41:05PM +0100, Alexandra Hájková wrote: > > --- /dev/null > > +++ b/libavcodec/ppc/hevcdsp.c > > @@ -0,0 +1,107 @@ > > +if (!PPC_ALTIVEC(av_get_cpu_flags())) > > +return; > > + > > +if

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-10 Thread Anton Khirnov
Quoting Alexandra Hájková (2016-11-05 14:32:58) > --- > Applied review comments as discussed. > Tested on both LE and BE. The patch does not apply. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-05 Thread Luca Barbato
On 05/11/2016 14:32, Alexandra Hájková wrote: > --- > Applied review comments as discussed. > Tested on both LE and BE. > > libavcodec/hevcdsp.c | 2 + > libavcodec/hevcdsp.h | 1 + > libavcodec/ppc/Makefile | 1 + > libavcodec/ppc/hevcdsp.c |

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-01 Thread Alexandra Hájková
>> +static const vector int16_t trans4[4] = { >> +{ 64, 64, 64, 64, 64, 64, 64, 64 }, >> +{ 83, 36, 83, 36, 83, 36, 83, 36 }, >> +{ 64, -64, 64, -64, 64, -64, 64, -64 }, >> +{ 36, -83, 36, -83, 36, -83, 36, -83 }, >> +}; > > This fits in int8_t, is there a reason to have it

Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-11-01 Thread Diego Biurrun
On Tue, Nov 01, 2016 at 09:37:50AM +0100, Alexandra Hájková wrote: > From: Alexandra Hajkova Your name lost some accents here.. > --- > libavcodec/hevcdsp.c | 2 + > libavcodec/hevcdsp.h | 1 + > libavcodec/ppc/Makefile |