Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix

2016-10-17 Thread Diego Biurrun
On Mon, Oct 17, 2016 at 05:57:24PM -0400, Vittorio Giovara wrote: > Rotation, aspect ratio and pure matrix export. > > Signed-off-by: Vittorio Giovara > --- > Updated according to Diego's review. > I haven't split the AR tests, I think it makes sense to have it in a

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-17 Thread Luca Barbato
On 13/10/2016 20:04, Diego Biurrun wrote: > This does not match the conditions in the .asm file. Something along those lines seems to work on x86_32 according to checkasm. Folded in my github tree. diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index 73279c2..d60ae5e

Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix

2016-10-17 Thread Diego Biurrun
Looking at this in more detail now that the first round of review is over. On Mon, Oct 17, 2016 at 11:54:04AM -0400, Vittorio Giovara wrote: > --- a/tests/fate-run.sh > +++ b/tests/fate-run.sh > @@ -76,6 +76,11 @@ probefmt(){ > > +probear(){ > +run avprobe -show_stream_entry

Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix

2016-10-17 Thread Vittorio Giovara
On Mon, Oct 17, 2016 at 1:30 PM, Diego Biurrun wrote: > Looking at this in more detail now that the first round of review is over. > > On Mon, Oct 17, 2016 at 11:54:04AM -0400, Vittorio Giovara wrote: >> --- a/tests/fate-run.sh >> +++ b/tests/fate-run.sh >> @@ -76,6 +76,11 @@

Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix

2016-10-17 Thread Diego Biurrun
On Mon, Oct 17, 2016 at 01:47:32PM -0400, Vittorio Giovara wrote: > On Mon, Oct 17, 2016 at 1:30 PM, Diego Biurrun wrote: > > Looking at this in more detail now that the first round of review is over. > > > > On Mon, Oct 17, 2016 at 11:54:04AM -0400, Vittorio Giovara wrote: > >>

[libav-devel] [PATCH 2/2] hevc: x86: Add add_residual optimizations

2016-10-17 Thread Luca Barbato
From: Pierre Edouard Lepere Initially written by Pierre Edouard Lepere , extended by James Almer . Signed-off-by: Alexandra Hájková Signed-off-by: Luca Barbato

[libav-devel] [PATCH] fate: Add tests for mov display matrix

2016-10-17 Thread Vittorio Giovara
Rotation, aspect ratio and pure matrix export. Signed-off-by: Vittorio Giovara --- Updated according to Diego's review. I haven't split the AR tests, I think it makes sense to have it in a single one, but if people strongly prefer the split version, I'll change it.

Re: [libav-devel] [PATCH] configure: Print warnings after all other output

2016-10-17 Thread Luca Barbato
On 17/10/2016 21:50, Diego Biurrun wrote: > --- > > Back in the day I would have added "10l to elenril" to the log msg. Fine even w/out that much cola. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-17 Thread Martin Storsjö
On Mon, 17 Oct 2016, Luca Barbato wrote: From: Alexandra Hájková --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files

Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-17 Thread Luca Barbato
On 17/10/2016 23:45, Martin Storsjö wrote: > So, what changed compared to the last version that Alexandra submitted > herself? Didn't we all agree that listing that is the least we can do, > when resubmitting someone (who is still active and present) else's patch > in a modified form. I changed

[libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-17 Thread Luca Barbato
From: Alexandra Hájková --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 87 insertions(+), 1 deletion(-)

Re: [libav-devel] [PATCH] vaapi_h265: Include header for slice types

2016-10-17 Thread Diego Biurrun
On Mon, Oct 17, 2016 at 01:51:53AM +0200, Luca Barbato wrote: > On 17/10/2016 01:03, Mark Thompson wrote: > > --- a/libavcodec/vaapi_encode_h265.c > > +++ b/libavcodec/vaapi_encode_h265.c > > @@ -25,7 +25,7 @@ > > > > #include "avcodec.h" > > -#include "hevc.h" > > +#include "hevcdec.h" > >

Re: [libav-devel] [PATCH] x86: videodsp: Add parentheses to expression to work around warning

2016-10-17 Thread Luca Barbato
On 17/10/2016 16:07, Diego Biurrun wrote: > Also visible only on NASM, not YASM. And should be reported to the NASM developers since seem strange. lu ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] x86: videodsp: Add parentheses to expression to work around warning

2016-10-17 Thread Diego Biurrun
libavcodec/x86/videodsp.asm:128: warning: signed dword value exceeds bounds --- Also visible only on NASM, not YASM. libavcodec/x86/videodsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/videodsp.asm b/libavcodec/x86/videodsp.asm index 53b9e82..b22e0fe

Re: [libav-devel] [PATCH] x86: Add missing colons after assembly labels

2016-10-17 Thread Diego Biurrun
On Thu, Oct 13, 2016 at 10:16:16PM +0200, Diego Biurrun wrote: > This fixes many warnings of the sort > warning: label alone on a line without a colon might be in error > --- > libavcodec/x86/audiodsp.asm| 2 +- > libavcodec/x86/dcadsp.asm | 2 +- >

Re: [libav-devel] [PATCH] x86: Add missing colons after assembly labels

2016-10-17 Thread Luca Barbato
On 17/10/2016 15:59, Diego Biurrun wrote: > On Thu, Oct 13, 2016 at 10:16:16PM +0200, Diego Biurrun wrote: >> This fixes many warnings of the sort >> warning: label alone on a line without a colon might be in error >> --- >> libavcodec/x86/audiodsp.asm| 2 +- >> libavcodec/x86/dcadsp.asm

Re: [libav-devel] [PATCH 1/3] avprobe: Add -show_stream_entry to get a single stream property

2016-10-17 Thread Vittorio Giovara
On Thu, Oct 13, 2016 at 6:23 PM, Vittorio Giovara wrote: > This is needed for improved fate testing and it is modeled after > -show_format_entry. The main behavioral difference is that when a print > function is called with an empty key, rather than discarding it, the

Re: [libav-devel] [PATCH 3/3] mov: Evaluate the movie display matrix

2016-10-17 Thread Vittorio Giovara
On Thu, Oct 13, 2016 at 6:26 PM, Vittorio Giovara wrote: > On Thu, Oct 13, 2016 at 6:23 PM, Vittorio Giovara > wrote: >> This matrix needs to be applied after all others have (currently only >> display matrix from trak), but cannot be

[libav-devel] [PATCH] fate: Add tests for mov display matrix

2016-10-17 Thread Vittorio Giovara
Rotation, aspect ratio and pure matrix export. Signed-off-by: Vittorio Giovara --- tests/fate-run.sh | 5 + tests/fate/probe.mak | 13 + tests/ref/fate/mov-ar | 2 ++ tests/ref/fate/mov-display-matrix | 9

Re: [libav-devel] [PATCH 12/12] x86/yadif-10: remove duplicate ABS macro

2016-10-17 Thread Vittorio Giovara
On Sun, Oct 16, 2016 at 2:11 PM, Janne Grunau wrote: > From: James Almer > > And use the x86util ones instead, which are optimized for mmxext/sse2. > About ~1% increase in performance on pre SSSE3 processors. Question unrelated to this patch, is there

Re: [libav-devel] [PATCH] swscale: Properly load alpha for planar rgb

2016-10-17 Thread Vittorio Giovara
On Sun, Oct 16, 2016 at 2:07 PM, Sean McGovern wrote: > Hi, > > On Oct 14, 2016 17:28, "Luca Barbato" wrote: >> >> On 14/10/2016 23:25, Vittorio Giovara wrote: >> > From: Michael Niedermayer >> > >> > Signed-off-by: Vittorio Giovara

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-17 Thread Luca Barbato
On 10/16/16 14:00, Luca Barbato wrote: On 10/13/16 16:02, Alexandra Hájková wrote: From: Pierre Edouard Lepere If nobody has a say I'd push it with the mentioned changes. lu ___ libav-devel mailing list

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-17 Thread Diego Biurrun
On Mon, Oct 17, 2016 at 09:18:19PM +0200, Luca Barbato wrote: > On 10/16/16 14:00, Luca Barbato wrote: > >On 10/13/16 16:02, Alexandra Hájková wrote: > >>From: Pierre Edouard Lepere > > If nobody has a say I'd push it with the mentioned changes. This is

[libav-devel] [PATCH] configure: Print warnings after all other output

2016-10-17 Thread Diego Biurrun
--- Back in the day I would have added "10l to elenril" to the log msg. configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 4c164da..5c224ca 100755 --- a/configure +++ b/configure @@ -5395,8 +5395,6 @@ echo "#endif /* AVUTIL_AVCONFIG_H

[libav-devel] [PATCH] aarch64: vp9: Add NEON optimizations of VP9 MC functions

2016-10-17 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. These are ported from the ARM version; it is essentially a 1:1 port with no extra added features, but with some hand tuning (especially for the plain copy/avg functions). The ARM version isn't very register starved to begin with, so there's not