Re: [libav-devel] [PATCH] avresample: check output FIFO validity before usage

2018-01-20 Thread Sean McGovern
Hi, On Jan 20, 2018 06:56, "Luca Barbato" wrote: On 20/01/2018 11:10, Luca Barbato wrote: > On 17/01/2018 23:36, Sean McGovern wrote: > >> Bug-Id: 1089 >> Cc: libav-sta...@libav.org >> --- >> libavresample/utils.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff

Re: [libav-devel] [PATCH] avresample: check output FIFO validity before usage

2018-01-20 Thread Luca Barbato
On 20/01/2018 16:21, Sean McGovern wrote: Is this patch still useful for library users? Can I apply it without the Bug-Id? I think we have to decide if it is an invalid usage of the API (and be even louder with the error message) or if it is acceptable and we should just return 0. I think

Re: [libav-devel] [PATCH] avresample: check output FIFO validity before usage

2018-01-20 Thread Luca Barbato
On 17/01/2018 23:36, Sean McGovern wrote: Bug-Id: 1089 Cc: libav-sta...@libav.org --- libavresample/utils.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavresample/utils.c b/libavresample/utils.c index bab2153..3d959c5 100644 --- a/libavresample/utils.c +++

Re: [libav-devel] [PATCH] avresample: check output FIFO validity before usage

2018-01-20 Thread Luca Barbato
On 20/01/2018 11:10, Luca Barbato wrote: On 17/01/2018 23:36, Sean McGovern wrote: Bug-Id: 1089 Cc: libav-sta...@libav.org ---   libavresample/utils.c | 5 +   1 file changed, 5 insertions(+) diff --git a/libavresample/utils.c b/libavresample/utils.c index bab2153..3d959c5 100644 ---