Re: [libav-devel] [PATCH] x86: dcadsp: Avoid SSE2 instructions in SSE functions

2015-08-01 Thread Anton Khirnov
Quoting Henrik Gramner (2015-08-01 17:10:22) --- libavcodec/x86/dcadsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm index c42ee23..c99df12 100644 --- a/libavcodec/x86/dcadsp.asm +++

Re: [libav-devel] [PATCH 2/4] drawtext: Move the strftime expansion in a separate function

2015-08-01 Thread Anton Khirnov
Quoting Luca Barbato (2015-08-01 11:22:11) --- libavfilter/vf_drawtext.c | 49 +++ 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index a4d25c2..15c994f 100644 ---

Re: [libav-devel] [PATCH] x86: dct: Disable dct32_float_sse on x86-64

2015-08-01 Thread Henrik Gramner
On Sat, Aug 1, 2015 at 8:28 PM, Anton Khirnov an...@khirnov.net wrote: Any specific reason you use ARCH_X86_64 in one file and ARCH_X86_32 in the other? I missed that there's a define for ARCH_X86_32 in asm (some other code used %if ARCH_X86_64 == 0 so I assumed it didn't). Using ARCH_X86_32 in

[libav-devel] [PATCH] asfdec: read values properly

2015-08-01 Thread Alexandra Hájková
The length of BOOL values is 16 bits in the Metadata Object but 32 bits in the Extended Content Description Object. --- libavformat/asfdec.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c

Re: [libav-devel] [PATCH] h264: Parse only the x264 info unregisterd sei

2015-08-01 Thread Luca Barbato
On 31/07/15 07:59, Anton Khirnov wrote: Quoting Luca Barbato (2015-07-29 22:51:05) And restrict the string to ascii text. CC: libav-sta...@libav.org Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavcodec/h264_sei.c | 57 ++- 1 file

[libav-devel] [PATCH] x86: dcadsp: Avoid SSE2 instructions in SSE functions

2015-08-01 Thread Henrik Gramner
--- libavcodec/x86/dcadsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm index c42ee23..c99df12 100644 --- a/libavcodec/x86/dcadsp.asm +++ b/libavcodec/x86/dcadsp.asm @@ -148,7 +148,7 @@ DECODE_HF addps m4,

Re: [libav-devel] [PATCH] asfdec: read values properly

2015-08-01 Thread Luca Barbato
On 01/08/15 14:16, Alexandra Hájková wrote: The length of BOOL values is 16 bits in the Metadata Object but 32 bits in the Extended Content Description Object. --- libavformat/asfdec.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff

[libav-devel] [PATCH 3/8] x86inc: warn when instructions incompatible with current cpuflags are used

2015-08-01 Thread Henrik Gramner
From: Anton Mitrofanov bugmas...@narod.ru Signed-off-by: Henrik Gramner hen...@gramner.com --- libavutil/x86/x86inc.asm | 587 --- 1 file changed, 299 insertions(+), 288 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm

[libav-devel] [PATCH 8/8] x86inc: Various minor backports from x264

2015-08-01 Thread Henrik Gramner
--- libavutil/x86/x86inc.asm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index d70a5f9..0e2f447 100644 --- a/libavutil/x86/x86inc.asm +++ b/libavutil/x86/x86inc.asm @@ -1,7 +1,7 @@

[libav-devel] [PATCH 1/8] x86inc: warn if XOP integer FMA instruction emulation is impossible

2015-08-01 Thread Henrik Gramner
From: Anton Mitrofanov bugmas...@narod.ru Emulation requires a temporary register if arguments 1 and 4 are the same; this doesn't obey the semantics of the original instruction, so we can't emulate that in x86inc. Also add pmacsdql emulation. Signed-off-by: Henrik Gramner hen...@gramner.com ---

[libav-devel] [PATCH 2/8] x86inc: Support arbitrary stack alignments

2015-08-01 Thread Henrik Gramner
Change ALLOC_STACK to always align the stack before allocating stack space for consistency. Previously alignment would occur either before or after allocating stack space depending on whether manual alignment was required or not. --- libavcodec/x86/h264_deblock.asm | 4 +--

[libav-devel] [PATCH 0/8] x86inc: Sync changes from x264

2015-08-01 Thread Henrik Gramner
This brings x86inc.asm in libavutil up to date with x86inc.asm in x264. They're not 100% identical but the difference is tiny compared to before. Anton Mitrofanov (2): x86inc: warn if XOP integer FMA instruction emulation is impossible x86inc: warn when instructions incompatible with current

[libav-devel] [PATCH 6/8] x86inc: Drop SECTION_TEXT macro

2015-08-01 Thread Henrik Gramner
The .text section is already 16-byte aligned by default on all supported platforms so `SECTION_TEXT` isn't any different from `SECTION .text`. --- libavcodec/x86/apedsp.asm | 2 +- libavcodec/x86/audiodsp.asm | 2 +- libavcodec/x86/bswapdsp.asm | 2 +-

[libav-devel] [PATCH 5/8] x86inc: Disable vpbroadcastq workaround in newer yasm versions

2015-08-01 Thread Henrik Gramner
The bug was fixed in 1.3.0, so only perform the workaround in earlier versions. --- libavutil/x86/x86inc.asm | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 2844fdf..d4ce68f 100644 ---

[libav-devel] [PATCH 7/8] x86inc: nasm support

2015-08-01 Thread Henrik Gramner
--- configure| 3 --- libavutil/x86/x86inc.asm | 42 +- 2 files changed, 29 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 482be43..79dd3a5 100755 --- a/configure +++ b/configure @@ -1353,7 +1353,6 @@

[libav-devel] [PATCH 4/8] x86inc: Fix instantiation of YMM registers

2015-08-01 Thread Henrik Gramner
From: Christophe Gisquet christophe.gisq...@gmail.com Signed-off-by: Henrik Gramner hen...@gramner.com --- libavutil/x86/x86inc.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 96ebe37..2844fdf 100644 ---

Re: [libav-devel] [PATCH] x86: dct: Disable dct32_float_sse on x86-64

2015-08-01 Thread Anton Khirnov
Quoting Henrik Gramner (2015-08-01 17:12:48) There is an SSE2 implementation so the SSE version is never used. The SSE version also happens to contain SSE2 instructions on x86-64. --- libavcodec/x86/dct32.asm | 3 +++ libavcodec/x86/dct_init.c | 2 ++ 2 files changed, 5 insertions(+)

[libav-devel] [PATCH] x86: dct: Disable dct32_float_sse on x86-64

2015-08-01 Thread Henrik Gramner
There is an SSE2 implementation so the SSE version is never used. The SSE version also happens to contain SSE2 instructions on x86-64. --- libavcodec/x86/dct32.asm | 3 +++ libavcodec/x86/dct_init.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/libavcodec/x86/dct32.asm

Re: [libav-devel] [PATCH] h264: Parse only the x264 info unregisterd sei

2015-08-01 Thread Anton Khirnov
Quoting Luca Barbato (2015-08-01 14:16:45) On 31/07/15 07:59, Anton Khirnov wrote: Quoting Luca Barbato (2015-07-29 22:51:05) And restrict the string to ascii text. CC: libav-sta...@libav.org Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavcodec/h264_sei.c | 57

Re: [libav-devel] [PATCH 1/4] drawtext: Drop stray guards

2015-08-01 Thread Anton Khirnov
Quoting Luca Barbato (2015-08-01 11:22:10) There is a fallback for localtime_r and it is in use already. --- libavfilter/vf_drawtext.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 97d44c6..a4d25c2

Re: [libav-devel] [PATCH] opusdec: properly handle mismatching configurations in multichannel streams

2015-08-01 Thread Anton Khirnov
Quoting Luca Barbato (2015-07-31 11:13:41) On 31/07/15 09:25, Anton Khirnov wrote: Quoting Anton Khirnov (2015-07-27 11:17:51) The substreams can have different resampling delays, so an additional level of buffering is needed to synchronize them. Bug-Id: 876 --- Ping. I

Re: [libav-devel] [PATCH] x86: dcadsp: Avoid SSE2 instructions in SSE functions

2015-08-01 Thread Henrik Gramner
On Sat, Aug 1, 2015 at 8:49 PM, James Almer jamr...@gmail.com wrote: I however think movq/sd should be used here for sse2 and above instead of movlps. That's a moot point in this case since the code in question is SSE only (and even if it wasn't I'm skeptical to the claim that it would be

Re: [libav-devel] [PATCH 3/4] drawtext: Set an explicit allocation limit

2015-08-01 Thread Luca Barbato
On 01/08/15 20:46, Anton Khirnov wrote: Quoting Luca Barbato (2015-08-01 11:22:12) And make sure to not have dangling pointers. --- libavfilter/vf_drawtext.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_drawtext.c

Re: [libav-devel] [PATCH] x86: dcadsp: Avoid SSE2 instructions in SSE functions

2015-08-01 Thread James Almer
On 01/08/15 4:11 PM, Henrik Gramner wrote: On Sat, Aug 1, 2015 at 8:49 PM, James Almer jamr...@gmail.com wrote: I however think movq/sd should be used here for sse2 and above instead of movlps. That's a moot point in this case since the code in question is SSE Ah right, i was thinking about

Re: [libav-devel] [PATCH 2/4] drawtext: Move the strftime expansion in a separate function

2015-08-01 Thread Luca Barbato
On 01/08/15 20:42, Anton Khirnov wrote: nit: I think this would look better as text = foo ? bar : baz; let see how it looks. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] x86: dcadsp: Avoid SSE2 instructions in SSE functions

2015-08-01 Thread James Almer
On 01/08/15 3:24 PM, Anton Khirnov wrote: Quoting Henrik Gramner (2015-08-01 17:10:22) --- libavcodec/x86/dcadsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm index c42ee23..c99df12 100644 ---

Re: [libav-devel] [PATCH 3/4] drawtext: Set an explicit allocation limit

2015-08-01 Thread Anton Khirnov
Quoting Luca Barbato (2015-08-01 11:22:12) And make sure to not have dangling pointers. --- libavfilter/vf_drawtext.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 15c994f..62993cf 100644

Re: [libav-devel] [PATCH] h264: Parse only the x264 info unregisterd sei

2015-08-01 Thread Luca Barbato
On 01/08/15 20:32, Anton Khirnov wrote: Quoting Luca Barbato (2015-08-01 14:16:45) On 31/07/15 07:59, Anton Khirnov wrote: Quoting Luca Barbato (2015-07-29 22:51:05) And restrict the string to ascii text. CC: libav-sta...@libav.org Signed-off-by: Luca Barbato lu_z...@gentoo.org ---

Re: [libav-devel] [PATCH 8/8] x86inc: Various minor backports from x264

2015-08-01 Thread James Almer
On 01/08/15 12:27 PM, Henrik Gramner wrote: ; cpuflags @@ -759,8 +759,8 @@ BRANCH_INSTR jz, je, jnz, jne, jl, jle, jnl, jnle, jg, jge, jng, jnge, ja, jae, %assign cpuflags_avx (111)| cpuflags_sse42 %assign cpuflags_xop (112)| cpuflags_avx %assign cpuflags_fma4 (113)|

Re: [libav-devel] [PATCH] asfdec: prevent the memory leak while reading metadata

2015-08-01 Thread Anton Khirnov
Quoting Alexandra Hájková (2015-07-31 09:53:40) --- libavformat/asfdec.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 13133b6..8306d16 100644 --- a/libavformat/asfdec.c +++

Re: [libav-devel] [PATCH 4/4] drawtext: Change the doxygen comments to normal comments

2015-08-01 Thread Anton Khirnov
Quoting Luca Barbato (2015-08-01 11:22:13) --- libavfilter/vf_drawtext.c | 92 +++ 1 file changed, 46 insertions(+), 46 deletions(-) What is the point? -- Anton Khirnov ___ libav-devel mailing list

[libav-devel] [PATCH 3/4] drawtext: Set an explicit allocation limit

2015-08-01 Thread Luca Barbato
And make sure to not have dangling pointers. --- libavfilter/vf_drawtext.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 15c994f..62993cf 100644 --- a/libavfilter/vf_drawtext.c +++

[libav-devel] [PATCH 4/4] drawtext: Change the doxygen comments to normal comments

2015-08-01 Thread Luca Barbato
--- libavfilter/vf_drawtext.c | 92 +++ 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 62993cf..2df1a15 100644 --- a/libavfilter/vf_drawtext.c +++ b/libavfilter/vf_drawtext.c

[libav-devel] [PATCH 1/4] drawtext: Drop stray guards

2015-08-01 Thread Luca Barbato
There is a fallback for localtime_r and it is in use already. --- libavfilter/vf_drawtext.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 97d44c6..a4d25c2 100644 --- a/libavfilter/vf_drawtext.c +++

[libav-devel] [PATCH 2/4] drawtext: Move the strftime expansion in a separate function

2015-08-01 Thread Luca Barbato
--- libavfilter/vf_drawtext.c | 49 +++ 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index a4d25c2..15c994f 100644 --- a/libavfilter/vf_drawtext.c +++ b/libavfilter/vf_drawtext.c