Re: [libav-devel] [PATCH 2/9] cbs: Add buffer padding when splitting fragments

2017-08-28 Thread Luca Barbato
On 28/08/2017 19:08, Mark Thompson wrote: Remove any trailing zeroes from H.26[45] NAL units at the same time. --- libavcodec/cbs_h2645.c | 11 +-- libavcodec/cbs_mpeg2.c | 3 ++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_h2645.c

Re: [libav-devel] [PATCH 5/9] cbs_h265: Fix reading of unknown parameter set extension data

2017-08-28 Thread Luca Barbato
On 28/08/2017 19:08, Mark Thompson wrote: --- Actually running on all the conformance test streams hits this. libavcodec/cbs_h265_syntax_template.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h265_syntax_template.c

Re: [libav-devel] [PATCH 7/9] cbs: Add some read/write tests

2017-08-28 Thread Mark Thompson
On 28/08/17 18:08, Mark Thompson wrote: > Use the appropriate metadata filter for each codec - in the absence of any > options to modify the stream, the output bitstream should be identical to > the input (though the output file may differ in padding). > > H.264 and H.265 tests use conformance

Re: [libav-devel] [PATCH] cpu: split flag checks per arch in av_cpu_max_align()

2017-08-28 Thread James Almer
On 8/28/2017 1:41 PM, wm4 wrote: > On Mon, 28 Aug 2017 12:53:09 -0300 > James Almer wrote: > >> On 8/28/2017 12:08 PM, wm4 wrote: >>> On Mon, 28 Aug 2017 11:52:52 -0300 >>> James Almer wrote: >>> AV_CPU_FLAG_MMX == AV_CPU_FLAG_ARMV6 ==

[libav-devel] [PATCH 8/9] mpeg12: Move finding the best frame rate to common code

2017-08-28 Thread Mark Thompson
Previously in the mpeg2_metadata filter. Also adds a test. --- libavcodec/Makefile| 1 + libavcodec/mpeg12.h| 4 ++ libavcodec/mpeg12framerate.c | 64 libavcodec/mpeg2_metadata_bsf.c| 58 +++--

[libav-devel] [PATCH 9/9] vaapi_mpeg2: Convert to use coded bitstream infrastructure

2017-08-28 Thread Mark Thompson
--- Updated to use ff_mpeg12_find_best_frame_rate(). configure | 2 +- libavcodec/vaapi_encode_mpeg2.c | 638 ++-- 2 files changed, 424 insertions(+), 216 deletions(-) diff --git a/configure b/configure index 6bbde1e74..876e6215d

[libav-devel] [PATCH 7/9] cbs: Add some read/write tests

2017-08-28 Thread Mark Thompson
Use the appropriate metadata filter for each codec - in the absence of any options to modify the stream, the output bitstream should be identical to the input (though the output file may differ in padding). H.264 and H.265 tests use conformance bitstreams to attempt to cover all header features.

[libav-devel] [PATCH 5/9] cbs_h265: Fix reading of unknown parameter set extension data

2017-08-28 Thread Mark Thompson
--- Actually running on all the conformance test streams hits this. libavcodec/cbs_h265_syntax_template.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 40fdaf8a9..8564220d5 100644 ---

[libav-devel] [PATCH 3/9] h264_metadata: Fix double-free

2017-08-28 Thread Mark Thompson
Whether the udu string should be freed depends on whether the SEI it gets added to was created internally by cbs or externally by the bsf. The current code frees it twice in the former case. --- Starting to think that refcounting everything might be a good plan... libavcodec/h264_metadata_bsf.c

[libav-devel] [PATCH 1/9] cbs: Always check for bitstream end before reading

2017-08-28 Thread Mark Thompson
--- Overreads are always errors, so it is better to check for them in advance. libavcodec/cbs.c | 6 +++ libavcodec/cbs_h2645.c | 118 - libavcodec/cbs_mpeg2.c | 5 ++- 3 files changed, 67 insertions(+), 62 deletions(-) diff --git

[libav-devel] [PATCH 2/9] cbs: Add buffer padding when splitting fragments

2017-08-28 Thread Mark Thompson
Remove any trailing zeroes from H.26[45] NAL units at the same time. --- libavcodec/cbs_h2645.c | 11 +-- libavcodec/cbs_mpeg2.c | 3 ++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index c8a13f167..50a227da7 100644 ---

[libav-devel] [PATCH 6/9] cbs_h265: Fix ranges of prediction weight offsets

2017-08-28 Thread Mark Thompson
The bracketing was wrong - '-' binds before '<<'. This would previously incorrectly reject the streams in the WP_A and WP_B conformance tests. --- libavcodec/cbs_h265_syntax_template.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[libav-devel] [PATCH 4/9] Revert "vaapi_h265: Reduce the amount of padding in the stream"

2017-08-28 Thread Mark Thompson
This reverts commit a14a12ca137bf1526452b97bedfc9f7b301d4e04. The CTU size is always 32x32; the surface size is what actually sets the desired property, and it is already correct. --- I have no idea why I thought this change was right. libavcodec/vaapi_encode_h265.c | 7 ++- 1 file

Re: [libav-devel] [PATCH] cpu: split flag checks per arch in av_cpu_max_align()

2017-08-28 Thread wm4
On Mon, 28 Aug 2017 12:53:09 -0300 James Almer wrote: > On 8/28/2017 12:08 PM, wm4 wrote: > > On Mon, 28 Aug 2017 11:52:52 -0300 > > James Almer wrote: > > > >> AV_CPU_FLAG_MMX == AV_CPU_FLAG_ARMV6 == AV_CPU_FLAG_ALTIVEC > >> AV_CPU_FLAG_3DNOWEXT ==

Re: [libav-devel] [PATCH] cpu: split flag checks per arch in av_cpu_max_align()

2017-08-28 Thread James Almer
On 8/28/2017 12:08 PM, wm4 wrote: > On Mon, 28 Aug 2017 11:52:52 -0300 > James Almer wrote: > >> AV_CPU_FLAG_MMX == AV_CPU_FLAG_ARMV6 == AV_CPU_FLAG_ALTIVEC >> AV_CPU_FLAG_3DNOWEXT == AV_CPU_FLAG_NEON >> AV_CPU_FLAG_SSE == AV_CPU_FLAG_VFP >> >> Signed-off-by: James

Re: [libav-devel] [PATCH] cpu: split flag checks per arch in av_cpu_max_align()

2017-08-28 Thread wm4
On Mon, 28 Aug 2017 11:52:52 -0300 James Almer wrote: > AV_CPU_FLAG_MMX == AV_CPU_FLAG_ARMV6 == AV_CPU_FLAG_ALTIVEC > AV_CPU_FLAG_3DNOWEXT == AV_CPU_FLAG_NEON > AV_CPU_FLAG_SSE == AV_CPU_FLAG_VFP > > Signed-off-by: James Almer > --- >

[libav-devel] [PATCH] cpu: split flag checks per arch in av_cpu_max_align()

2017-08-28 Thread James Almer
AV_CPU_FLAG_MMX == AV_CPU_FLAG_ARMV6 == AV_CPU_FLAG_ALTIVEC AV_CPU_FLAG_3DNOWEXT == AV_CPU_FLAG_NEON AV_CPU_FLAG_SSE == AV_CPU_FLAG_VFP Signed-off-by: James Almer --- libavutil/cpu.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [libav-devel] [GASPP PATCH] Support converting more instructions to their thumb equivalent

2017-08-28 Thread Martin Storsjö
On Thu, 4 May 2017, Martin Storsjo wrote: --- These are used for supporting building x264 for windows/arm with msvc/armasm (currently in the x264 sandbox repo). --- gas-preprocessor.pl | 14 ++ 1 file changed, 14 insertions(+) It seems I never got any feedback on this, but this has