Re: [libav-devel] [PATCH] rtmp: Plug leak if sending bytes read report fails.

2018-01-23 Thread Martin Storsjö
On Tue, 23 Jan 2018, Josh Allmann wrote: --- libavformat/rtmpproto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 115c33597..48c5ead74 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -2396,8

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

2018-01-23 Thread Li, Zhong
> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Tuesday, January 23, 2018 5:45 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] qsv: How about replace software parsers with > MFXVideoDECODE_DecodeHeader > > On 23/01/2018 06:05, Li, Zhong

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

2018-01-23 Thread Li, Zhong
> Its best if decoders rely as little as possible on information passed to them > externally like this. If you have extradata, you should decode that to > determine the stream properties, and not rely on information set anywhere > else. > You should always keep in mind that a user application

Re: [libav-devel] [PATCH V2] lavc/qsv: skip the packet if decoding failure.

2018-01-23 Thread Song, Ruiling
> -Original Message- > From: Song, Ruiling > Sent: Wednesday, January 24, 2018 10:36 AM > To: libav-devel@libav.org > Cc: Song, Ruiling > Subject: [PATCH V2] lavc/qsv: skip the packet if decoding failure. > > From: "Ruiling, Song" > >

[libav-devel] [PATCH V2] lavc/qsv: skip the packet if decoding failure.

2018-01-23 Thread Ruiling Song
From: "Ruiling, Song" MediaSDK may fail to decode some frame, just skip it. Otherwise, it will keep decoding the failure packet repeatedly without processing any packet afterwards. v2: switch to using av_packet_unref(). Signed-off-by: Ruiling Song

[libav-devel] [PATCH V2] lavc/qsv: skip the packet if decoding failure.

2018-01-23 Thread Ruiling Song
From: "Ruiling, Song" MediaSDK may fail to decode some frame, just skip it. Otherwise, it will keep decoding the failure packet repeatedly without processing any packet afterwards. Signed-off-by: Ruiling Song --- libavcodec/qsvdec_h2645.c | 6

Re: [libav-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

2018-01-23 Thread Song, Ruiling
> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Maxym > Dmytrychenko > Sent: Monday, January 22, 2018 6:43 PM > To: libav development > Cc: ruil...@oboro.libav.org > Subject: Re: [libav-devel] [PATCH] lavc/qsv: skip the

[libav-devel] [PATCH] rtmp: Plug leak if sending bytes read report fails.

2018-01-23 Thread Josh Allmann
--- libavformat/rtmpproto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 115c33597..48c5ead74 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -2396,8 +2396,10 @@ static int

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

2018-01-23 Thread Luca Barbato
On 23/01/2018 12:15, Mark Thompson wrote: avconv -hwaccel vaapi -hwaccel_output_format vaapi -i input.mp4 -vf 'scale_vaapi=1280:720,hwmap=derive_device=qsv,format=qsv' -c:v h264_qsv -b:v 5M output.mp4 On Windows, there is similarly: avconv -hwaccel dxva2 -hwaccel_output_format dxva2_vld -i

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

2018-01-23 Thread Mark Thompson
On 23/01/18 05:05, Li, Zhong wrote: >> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Mark >> Thompson >> Sent: Monday, January 22, 2018 9:19 PM >> To: libav-devel@libav.org >> Subject: Re: [libav-devel] qsv: How about replace software parsers with >>

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

2018-01-23 Thread wm4
On Tue, 23 Jan 2018 05:28:35 + "Li, Zhong" wrote: > > wm4 wrote: > > > > > > Appreciated for any comment. If we are agree with that, patches will > > be sent soon (about following next two weeks). > > > > > > I don't know how qsvdec works

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

2018-01-23 Thread Luca Barbato
On 23/01/2018 06:05, Li, Zhong wrote: avformat_find_stream_info() can provides some information and sw_pix_fmt can be set as NV12. These parameters can be updated after MFXVideoDECODE_DecodeHeader is called. find_stream_info may decode frames using the software decoder to extract the missing

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

2018-01-23 Thread Luca Barbato
On 22/01/2018 12:20, Li, Zhong wrote: MSDK provides an API (MFXVideoDECODE_DecodeHeader) to parse video parameters. Currently it hasn't been used. Instead, software parsers are used. It works well for h264 decoder, and basically works well for hevc decoder (some issues found by Mayxm due to