On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato wrote:
> ---
>
> +
> +if (avctx->qmin > 0)
> +enccfg.rc_min_quantizer = avctx->qmin;
> +if (avctx->qmax > 0)
> +enccfg.rc_max_quantizer = avctx->qmax;
> +
> +#if FF_API_PRIVATE_OPT
>
Hello,
On Mon, 26 Feb 2018, at 14:00, Diego Biurrun wrote:
> > Since the bitstream will be frozen soon shouldn't hurt adding it.
>
> I'd prefer if you waited until it is actually frozen.
I kind of disagree: It will take time to review.
So, it is better to merge when patch is clean, with
On 2/26/2018 2:10 AM, Luca Barbato wrote:
> ---
>
> Since the bitstream will be frozen soon shouldn't hurt adding it.
>
> configure | 1 +
> libavcodec/Makefile| 1 +
> libavcodec/allcodecs.c | 2 +-
> libavcodec/libaomenc.c | 602
>
On 26/02/2018 14:00, Diego Biurrun wrote:
On Mon, Feb 26, 2018 at 06:10:42AM +0100, Luca Barbato wrote:
---
Since the bitstream will be frozen soon shouldn't hurt adding it.
I'd prefer if you waited until it is actually frozen.
Given the amount of nits you found (and that should be
On Mon, Feb 26, 2018 at 06:10:42AM +0100, Luca Barbato wrote:
> ---
>
> Since the bitstream will be frozen soon shouldn't hurt adding it.
I'd prefer if you waited until it is actually frozen.
> configure | 1 +
> libavcodec/Makefile| 1 +
> libavcodec/allcodecs.c | 2 +-