Re: [libav-devel] [PATCH 1/1] h264/x86: sign extend int stride in deblock functions

2019-01-27 Thread Martin Storsjö
On Sun, 27 Jan 2019, Janne Grunau wrote: Fixes checkasm errors after adding the h264 deblock tests. --- libavcodec/x86/h264_deblock.asm | 8 libavcodec/x86/h264_deblock_10bit.asm | 9 + 2 files changed, 17 insertions(+) Ok with me. Yes, changing the prototypes to use

Re: [libav-devel] [PATCH 1/1] h264/x86: sign extend int stride in deblock functions

2019-01-27 Thread Janne Grunau
On 2019-01-27 11:39:13 +0100, Diego Biurrun wrote: > On Sun, Jan 27, 2019 at 11:18:41AM +0100, Janne Grunau wrote: > > Fixes checkasm errors after adding the h264 deblock tests. > > --- > > libavcodec/x86/h264_deblock.asm | 8 > > libavcodec/x86/h264_deblock_10bit.asm | 9 +

Re: [libav-devel] Using Co-authored-by instead of Signed-off-by

2019-01-27 Thread Diego Biurrun
On Wed, Jan 09, 2019 at 11:29:16AM +0200, Martin Storsjö wrote: > On Wed, 9 Jan 2019, Luca Barbato wrote: > > > Since the start of the project we used Signed-off-by to signal that a > > patch had been edited. > > I'd like to point out that you might have had this interpretation of it and > used

Re: [libav-devel] [PATCH 1/1] h264/x86: sign extend int stride in deblock functions

2019-01-27 Thread Diego Biurrun
On Sun, Jan 27, 2019 at 11:18:41AM +0100, Janne Grunau wrote: > Fixes checkasm errors after adding the h264 deblock tests. > --- > libavcodec/x86/h264_deblock.asm | 8 > libavcodec/x86/h264_deblock_10bit.asm | 9 + > 2 files changed, 17 insertions(+) Shouldn't some int

[libav-devel] [PATCH 1/1] h264/x86: sign extend int stride in deblock functions

2019-01-27 Thread Janne Grunau
Fixes checkasm errors after adding the h264 deblock tests. --- libavcodec/x86/h264_deblock.asm | 8 libavcodec/x86/h264_deblock_10bit.asm | 9 + 2 files changed, 17 insertions(+) diff --git a/libavcodec/x86/h264_deblock.asm b/libavcodec/x86/h264_deblock.asm index

Re: [libav-devel] [PATCH 2/4] checkasm/h264: add loop filter tests

2019-01-27 Thread Janne Grunau
On 2019-01-26 23:22:42 +0200, Martin Storsjö wrote: > On Tue, 1 Jan 2019, Janne Grunau wrote: > > > --- > > tests/checkasm/h264dsp.c | 124 +++ > > 1 file changed, 124 insertions(+) > > This newly added test seems to fail on macOS. I haven't debugged through it