Re: [libav-devel] [PATCH] x86: dcadsp: Avoid SSE2 instructions in SSE functions

2015-08-01 Thread James Almer
On 01/08/15 4:11 PM, Henrik Gramner wrote: On Sat, Aug 1, 2015 at 8:49 PM, James Almer jamr...@gmail.com wrote: I however think movq/sd should be used here for sse2 and above instead of movlps. That's a moot point in this case since the code in question is SSE Ah right, i was thinking about

Re: [libav-devel] [PATCH] x86: dcadsp: Avoid SSE2 instructions in SSE functions

2015-08-01 Thread James Almer
On 01/08/15 3:24 PM, Anton Khirnov wrote: Quoting Henrik Gramner (2015-08-01 17:10:22) --- libavcodec/x86/dcadsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm index c42ee23..c99df12 100644 ---

Re: [libav-devel] [PATCH 8/8] x86inc: Various minor backports from x264

2015-08-01 Thread James Almer
On 01/08/15 12:27 PM, Henrik Gramner wrote: ; cpuflags @@ -759,8 +759,8 @@ BRANCH_INSTR jz, je, jnz, jne, jl, jle, jnl, jnle, jg, jge, jng, jnge, ja, jae, %assign cpuflags_avx (111)| cpuflags_sse42 %assign cpuflags_xop (112)| cpuflags_avx %assign cpuflags_fma4 (113)|

[libav-devel] [PATCH 3/3] rtmpproto: use AVHMAC instead of a custom implementation

2015-07-28 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavformat/rtmp.h | 3 --- libavformat/rtmpproto.c | 39 ++- 2 files changed, 10 insertions(+), 32 deletions(-) diff --git a/libavformat/rtmp.h b/libavformat/rtmp.h index dc7ba5b..f3390a1 100644

Re: [libav-devel] [PATCH 1/7] blowfish: add av_blowfish_alloc()

2015-07-28 Thread James Almer
On 28/07/15 9:19 AM, Anton Khirnov wrote: Quoting James Almer (2015-07-27 23:36:26) Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15 +++ libavutil/blowfish.h | 10 ++ libavutil/version.h | 5 - 4 files

Re: [libav-devel] [PATCH 19/20] Postpone API-incompatible changes until the next bump

2015-07-28 Thread James Almer
On 28/07/15 10:30 AM, Vittorio Giovara wrote: --- libavcodec/version.h | 58 +-- libavfilter/version.h | 10 - libavformat/version.h | 6 +++--- libavutil/version.h | 8 +++ 4 files changed, 41 insertions(+), 41 deletions(-)

[libav-devel] [PATCH 2/2] fate: add test vectors for HMAC SHA and SHA-2

2015-07-28 Thread James Almer
Also replace custom tests for MD5 with those published in RFC 2202 Signed-off-by: James Almer jamr...@gmail.com --- libavutil/hmac.c| 46 -- tests/ref/fate/hmac | 20 +--- 2 files changed, 53 insertions(+), 13 deletions(-) diff

[libav-devel] [PATCH 1/2] hmac: add support for SHA-2

2015-07-28 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavutil/hmac.c | 31 ++- libavutil/hmac.h | 2 ++ 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/libavutil/hmac.c b/libavutil/hmac.c index f87728e..318174e 100644 --- a/libavutil/hmac.c +++ b

[libav-devel] [PATCH 2/4 v2] rc4: add av_rc4_alloc()

2015-07-28 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 1 + libavutil/rc4.c | 13 - libavutil/rc4.h | 25 +++-- 3 files changed, 36 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 4db1a3c..3d40ec7 100644 --- a/doc

Re: [libav-devel] [PATCH 1/2] hmac: add support for SHA-2

2015-07-28 Thread James Almer
On 28/07/15 4:02 PM, Hendrik Leppkes wrote: On Tue, Jul 28, 2015 at 8:36 PM, James Almer jamr...@gmail.com wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavutil/hmac.c | 31 ++- libavutil/hmac.h | 2 ++ 2 files changed, 28 insertions(+), 5 deletions

[libav-devel] [PATCH 4/4 v2] des: add av_des_alloc()

2015-07-28 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 1 + libavutil/des.c | 13 - libavutil/des.h | 24 ++-- 3 files changed, 35 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index be5d4cf..66c9537 100644 --- a/doc

[libav-devel] [PATCH 1/4 v2] blowfish: add av_blowfish_alloc()

2015-07-28 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15 +++ libavutil/blowfish.h | 10 ++ libavutil/version.h | 5 - 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

[libav-devel] [PATCH 3/4 v2] xtea: add av_xtea_alloc()

2015-07-28 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 1 + libavutil/xtea.c | 12 libavutil/xtea.h | 10 ++ 3 files changed, 23 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 3d40ec7..be5d4cf 100644 --- a/doc/APIchanges +++ b/doc/APIchanges

Re: [libav-devel] [PATCH 8/8] x86inc: Various minor backports from x264

2015-08-03 Thread James Almer
On 02/08/15 5:42 PM, Henrik Gramner wrote: On Sat, Aug 1, 2015 at 9:34 PM, James Almer jamr...@gmail.com wrote: The same could be done in av_parse_cpu_flags(). It doesn't affect this patch, and can be done separately. Just throwing the idea out there. Yeah, I guess. What about bmi/bmi2

[libav-devel] [PATCH] hmac: add missing version bump and APIChanges entry

2015-07-30 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- Forgot about this, my bad. doc/APIchanges | 3 +++ libavutil/version.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 4ee7f41..17a6d88 100644 --- a/doc/APIchanges +++ b/doc

[libav-devel] [PATCH 6/7] asfdec: use the new rc4/des alloc functions

2015-07-27 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavformat/asfcrypt.c | 35 --- libavformat/asfcrypt.h | 2 +- libavformat/asfdec.c | 12 3 files changed, 33 insertions(+), 16 deletions(-) diff --git a/libavformat/asfcrypt.c b/libavformat

[libav-devel] [PATCH 3/7] xtea: add av_xtea_alloc()

2015-07-27 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 1 + libavutil/xtea.c | 12 libavutil/xtea.h | 10 ++ 3 files changed, 23 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 3d40ec7..be5d4cf 100644 --- a/doc/APIchanges +++ b/doc/APIchanges

[libav-devel] [PATCH 7/7] omadec: use the new des alloc function

2015-07-27 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavformat/omadec.c | 54 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/libavformat/omadec.c b/libavformat/omadec.c index 28276d9..e57140d 100644 --- a/libavformat/omadec.c

[libav-devel] [PATCH 5/7] rtmp: use the new blowfish/rc4/xtea alloc functions

2015-07-27 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavformat/rtmpcrypt.c | 66 +++-- libavformat/rtmpcrypt.h | 5 ++-- libavformat/rtmpproto.c | 15 ++- 3 files changed, 54 insertions(+), 32 deletions(-) diff --git a/libavformat/rtmpcrypt.c b

[libav-devel] [PATCH 4/7] des: add av_des_alloc()

2015-07-27 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 1 + libavutil/des.c | 13 + libavutil/des.h | 20 3 files changed, 34 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index be5d4cf..66c9537 100644 --- a/doc/APIchanges +++ b/doc

[libav-devel] [PATCH 0/7] blowfish/dec/rc4/xtea updates

2015-07-27 Thread James Almer
or encrypted asf/oma files. They are nonetheless not needed for the time being and can be postponed until someone can properly test them if that's preferred. James Almer (7): blowfish: add av_blowfish_alloc() rc4: add av_rc4_alloc() xtea: add av_xtea_alloc() des: add av_des_alloc() rtmp

[libav-devel] [PATCH 2/7] rc4: add av_rc4_alloc()

2015-07-27 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 1 + libavutil/rc4.c | 13 + libavutil/rc4.h | 21 + 3 files changed, 35 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 4db1a3c..3d40ec7 100644 --- a/doc/APIchanges +++ b/doc

[libav-devel] [PATCH 1/7] blowfish: add av_blowfish_alloc()

2015-07-27 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/blowfish.c | 15 +++ libavutil/blowfish.h | 10 ++ libavutil/version.h | 5 - 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread James Almer
On 15/07/15 1:46 PM, Luca Barbato wrote: On 15/07/15 18:26, James Almer wrote: If this is done only for readability's sake and not because this function will be used somewhere else, then making sure the compiler always inlines this function may be a good idea. Good idea, the idea itself

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread James Almer
On 15/07/15 2:06 PM, Anton Khirnov wrote: Quoting James Almer (2015-07-15 18:26:28) On 14/07/15 7:36 AM, Luca Barbato wrote: --- Properly rebased version libavcodec/hevc_ps.c | 258 ++- 1 file changed, 131 insertions(+), 127 deletions

Re: [libav-devel] [PATCH 09/11] hevc_parser: parse and export some stream parameters

2015-07-13 Thread James Almer
On 09/07/15 3:23 PM, Anton Khirnov wrote: Particularly those that will be needed by the QSV decoder. More can be added later as necessary. --- configure| 1 + libavcodec/Makefile | 2 +- libavcodec/hevc_parser.c | 128

Re: [libav-devel] [PATCH 8/9] avconv: split creating and (re-)configuring complex filtergraphs

2015-07-20 Thread James Almer
On 16/07/15 3:56 PM, Anton Khirnov wrote: The current code is less than straightforward due to the fact that output streams can be created based on filtergraph definitions. This change should make the code simpler and more readable. It will also be useful in the future commits. This commit

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

2015-07-15 Thread James Almer
On 14/07/15 7:36 AM, Luca Barbato wrote: --- Properly rebased version libavcodec/hevc_ps.c | 258 ++- 1 file changed, 131 insertions(+), 127 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index a5a2ace..2112265

Re: [libav-devel] [PATCH 3/3] x86: ac3dsp: replace inline asm for in-decoder downmixing with standalone asm

2015-11-01 Thread James Almer
On 10/28/2015 11:38 AM, Diego Biurrun wrote: > diff --git a/libavcodec/x86/ac3dsp_downmix.asm > b/libavcodec/x86/ac3dsp_downmix.asm > new file mode 100644 > index 000..d7fd8ac > --- /dev/null > +++ b/libavcodec/x86/ac3dsp_downmix.asm > @@ -0,0 +1,199 @@ >

Re: [libav-devel] ABI compatiblity with ffmpeg

2015-09-07 Thread James Almer
On 9/6/2015 5:56 PM, Ganesh Ajjanagadde wrote: > Hi all, > > I am speaking on behalf of ffmpeg here regarding the question of ABI Speaking on behalf of the project would have at least required asking other devs if they were ok with that first. > compatibility with ffmpeg. Recent patch: >

[libav-devel] [PATCH] travis: fix dependencies

2015-09-12 Thread James Almer
bc hasn't been needed since a982c5d74fbc7ff5bd2f2f73af61ae48e9b1bcc6 Signed-off-by: James Almer <jamr...@gmail.com> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 6a9b624..2e9d301 100644 --- a/.travis.yml +++ b/.trav

Re: [libav-devel] [PATCH] lavu: add FF_CEIL_RSHIFT and use it in various places

2016-01-07 Thread James Almer
On 1/6/2016 6:13 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-01-04 16:40:23) >> From: Clément Bœsch >> >> This macro is faster when shift is constant. >> >> Signed-off-by: Vittorio Giovara >> --- >> This macro is needed by the cfhd

Re: [libav-devel] [PATCH 03/13] x86_64: int32_to_float_fmul_scalar sign extend integer length

2015-12-21 Thread James Almer
On 12/9/2015 6:54 PM, Janne Grunau wrote: > --- > libavcodec/x86/fmtconvert.asm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/x86/fmtconvert.asm b/libavcodec/x86/fmtconvert.asm > index 727daa9..b9a78a5 100644 > --- a/libavcodec/x86/fmtconvert.asm > +++

Re: [libav-devel] [PATCH] dca: remove unused decode_hf function and quant_d tables

2015-12-23 Thread James Almer
On 12/18/2015 10:54 AM, Alexandra Hájková wrote: > diff --git a/libavcodec/dcadsp.h b/libavcodec/dcadsp.h > index eac9de9..b249b4a 100644 > --- a/libavcodec/dcadsp.h > +++ b/libavcodec/dcadsp.h > @@ -32,11 +32,6 @@ typedef struct DCADSPContext { > int

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-25 Thread James Almer
On 5/25/2016 9:26 AM, Diego Biurrun wrote: > On Wed, May 25, 2016 at 03:03:08PM +0300, Martin Storsjö wrote: >> On Wed, 25 May 2016, Diego Biurrun wrote: >> >>> More seriously, can you provide (hints at) numbers? I was one of the >>> last x86_32 holdouts, but the SSD in my notebook died and won't

Re: [libav-devel] [PATCH 1/2] x86: Add missing movsxd for the int stride parameter

2016-06-11 Thread James Almer
On 6/11/2016 5:32 PM, Martin Storsjö wrote: > --- > libavcodec/x86/h264_idct.asm | 5 + > libavcodec/x86/h264_idct_10bit.asm | 4 > 2 files changed, 9 insertions(+) > > diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm > index 313791a..9abed3c 100644 > ---

Re: [libav-devel] [PATCH 1/2] x86: Add missing movsxd for the int stride parameter

2016-06-11 Thread James Almer
On 6/11/2016 5:55 PM, Martin Storsjö wrote: > On Sat, 11 Jun 2016, James Almer wrote: > >> On 6/11/2016 5:32 PM, Martin Storsjö wrote: >>> --- >>> libavcodec/x86/h264_idct.asm | 5 + >>> libavcodec/x86/h264_idct_10bit.asm | 4 >>>

Re: [libav-devel] [PATCH] configure: Use pkg-config to check for openssl

2016-01-15 Thread James Almer
On 1/15/2016 2:35 PM, Luca Barbato wrote: > On 15/01/16 18:24, Derek Buitenhuis wrote: >> On 1/15/2016 5:10 PM, Luca Barbato wrote: >>> --- >>> >>> Possibly we could drop the 3 lines above. >>> >>> configure | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Normally I'm all for

Re: [libav-devel] [PATCH 07/10] x86: Add SSSE3_SLOW CPU flag and related convenience macros

2016-01-18 Thread James Almer
On 1/18/2016 12:38 PM, Diego Biurrun wrote: > --- > libavutil/cpu.h | 1 + > libavutil/x86/cpu.h | 6 ++ Missing minor version bump. > 2 files changed, 7 insertions(+) > > diff --git a/libavutil/cpu.h b/libavutil/cpu.h > index d640e79..3a6699a 100644 > --- a/libavutil/cpu.h > +++

Re: [libav-devel] [RFC] New BSF API

2016-02-25 Thread James Almer
On 2/25/2016 12:05 PM, Anton Khirnov wrote: > Hi, > as promised, here is the new bitstream filtering API. It is rather similar to > the one I sent in 2013, except now it uses AVCodecParameters and is actually > finished and functional. > > One thing I'm not sure about is whether to allow the

[libav-devel] [PATCH 2/2] configure: add missing avx2 support check

2016-01-23 Thread James Almer
AVX2 support was introduced in Yasm 1.2.0 and NASM 2.10, and the oldest versions currently supported are Yasm 0.8.0 and NASM 2.03 Signed-off-by: James Almer <jamr...@gmail.com> --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index c5bcb78..8af0dcc

[libav-devel] [PATCH 1/2] x86/asm: add ymm_reg struct

2016-01-23 Thread James Almer
Needed to declare 32-byte long constants Signed-off-by: James Almer <jamr...@gmail.com> --- Pre-requisite for James Darnley's v210 avx2 patches. libavutil/x86/asm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/x86/asm.h b/libavutil/x86/asm.h index e30f5db..db5f3d5

Re: [libav-devel] [PATCH 2/5] lavc: Move AVPacketList to avcodec

2016-03-09 Thread James Almer
On 10/9/2014 6:21 AM, Luca Barbato wrote: > Add a private API to manipulate AVPacketLists. > --- > doc/APIchanges | 4 > libavcodec/avcodec.h | 5 + > libavcodec/avpacket.c | 56 > ++ > libavcodec/internal.h | 36

Re: [libav-devel] [PATCH 2/2] ac3dec: change logging of skipped E-AC-3 substreams.

2016-04-01 Thread James Almer
On 3/31/2016 10:22 PM, Tim Walker wrote: > Change log level from warning to debug: the E-AC-3 "core" > substream can be successfully decoded without the additional > and dependent substreams, and their presence is already > indicated via avpriv_request_sample in ff_eac3_parse_header. > --- >

Re: [libav-devel] [PATCH] Fix compilation of some test programs after the next version bump

2016-05-11 Thread James Almer
On 5/11/2016 7:48 AM, Diego Biurrun wrote: > --- > libavutil/blowfish-test.c | 5 ++--- > libavutil/xtea-test.c | 6 ++ > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/libavutil/blowfish-test.c b/libavutil/blowfish-test.c > index 4281ca2..0c1c751 100644 > ---

Re: [libav-devel] [PATCH 1/2] blowfish-test: Use struct allocation functions from the API

2016-05-17 Thread James Almer
On 5/17/2016 10:36 AM, Diego Biurrun wrote: > --- > libavutil/tests/blowfish.c | 28 +++- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/libavutil/tests/blowfish.c b/libavutil/tests/blowfish.c > index acaab70..5fa3f42 100644 > ---

Re: [libav-devel] [PATCH 1/2] hwcontext: add a dxva2 implementation

2016-05-11 Thread James Almer
On 5/3/2016 9:56 AM, Anton Khirnov wrote: > --- > libavutil/Makefile | 3 + > libavutil/hwcontext.c | 3 + > libavutil/hwcontext.h | 1 + > libavutil/hwcontext_dxva2.c| 291 > + > libavutil/hwcontext_dxva2.h| 72

Re: [libav-devel] [PATCH 1/2 v2] x86/hevc: add add_residual

2016-07-21 Thread James Almer
On 7/21/2016 9:01 AM, Anton Khirnov wrote: > Quoting Josh de Kock (2016-07-21 02:48:31) >> diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c >> index f754038..b97f4c8 100644 >> --- a/libavcodec/x86/hevcdsp_init.c >> +++ b/libavcodec/x86/hevcdsp_init.c >> @@ -78,6 +78,23 @@

Re: [libav-devel] [PATCH 2/2] av1: Add libaom decoding support

2016-07-24 Thread James Almer
On 7/24/2016 5:41 PM, James Almer wrote: > On 7/24/2016 4:17 PM, Luca Barbato wrote: >> diff --git a/libavcodec/Makefile b/libavcodec/Makefile >> index 8eb7d36..09f9c82 100644 >> --- a/libavcodec/Makefile >> +++ b/libavcodec/Makefile >> @@ -653,6 +6

Re: [libav-devel] [PATCH 2/2] av1: Add libaom decoding support

2016-07-24 Thread James Almer
On 7/24/2016 4:17 PM, Luca Barbato wrote: > Encoding support not added on purpose for now > --- > configure | 4 ++ > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/libaom.c| 79 +++ > libavcodec/libaom.h| 31

Re: [libav-devel] [PATCH 02/13] Add a compat stdatomic.h implementation based on GCC atomics

2016-07-29 Thread James Almer
On 7/29/2016 11:26 AM, Anton Khirnov wrote: > Quoting James Almer (2016-07-29 16:20:48) >> On 7/29/2016 8:52 AM, Anton Khirnov wrote: >>> Adapted from the code by Rémi Denis-Courmont from VLC >>> --- >>>

Re: [libav-devel] [PATCH 02/13] Add a compat stdatomic.h implementation based on GCC atomics

2016-07-29 Thread James Almer
On 7/29/2016 8:52 AM, Anton Khirnov wrote: > Adapted from the code by Rémi Denis-Courmont from VLC > --- > compat/atomics/gcc/stdatomic.h | 175 > + > configure | 6 ++ > 2 files changed, 181 insertions(+) > create mode 100644

Re: [libav-devel] [PATCH 01/13] configure: check for stdatomic.h

2016-07-31 Thread James Almer
On 7/29/2016 8:52 AM, Anton Khirnov wrote: > Since this is a C11 feature, it requires -std=c11. > > Not actually used for anything yet, that will be added in the following > commits. > --- > configure | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > >

Re: [libav-devel] [PATCH 03/11] lavc: align the linesize to 32 when AVX is enabled

2016-08-01 Thread James Almer
On 8/1/2016 8:19 AM, Diego Biurrun wrote: > On Sat, Jul 30, 2016 at 10:02:45PM +0200, Anton Khirnov wrote: >> --- >> configure | 6 +- >> libavcodec/utils.c | 4 +++- >> 2 files changed, 8 insertions(+), 2 deletions(-) > > OK > >> --- a/configure >> +++ b/configure >> @@ -5032,7

Re: [libav-devel] [PATCH 007/115] ea: Convert to the new bitstream reader

2016-08-13 Thread James Almer
On 6/9/2016 12:11 PM, Diego Biurrun wrote: > From: Alexandra Hájková > > --- > libavcodec/eatgq.c | 34 +- > libavcodec/eatgv.c | 23 --- > 2 files changed, 29 insertions(+), 28 deletions(-) > [...] > @@ -156,10

Re: [libav-devel] [PATCH 2/3] x86/hecv_res_add: add ff_hevc_add_residual_{8, 16, 32}_8_avx

2016-07-18 Thread James Almer
On 7/14/2016 2:25 PM, Josh de Kock wrote: > From: James Almer <jamr...@gmail.com> > > Integration to Libav by Josh de Kock . > > ~15% faster than sse2 > > Reviewed-by: Mickaël Raulet <mrau...@gmail.com> > Reviewed-by: Christophe Gisquet <christophe.gi

Re: [libav-devel] [PATCH 01/13] configure: check for stdatomic.h

2016-08-06 Thread James Almer
On 8/6/2016 9:20 AM, Anton Khirnov wrote: > Quoting James Almer (2016-08-01 06:12:08) >> On 7/29/2016 8:52 AM, Anton Khirnov wrote: >>> Since this is a C11 feature, it requires -std=c11. >>> >>> Not actually used for anything yet, that will b

Re: [libav-devel] [PATCH 13/13] lavu: remove the custom atomic API

2016-08-06 Thread James Almer
On 8/6/2016 10:41 AM, Anton Khirnov wrote: > Quoting James Almer (2016-07-29 19:40:00) >> On 7/29/2016 8:52 AM, Anton Khirnov wrote: >>> It has been replaced by C11 stdatomic.h and is now unused. >>> --- >>> libavutil/Makefile | 5 ---

Re: [libav-devel] [PATCH] av1: Add libaom decoding support

2016-08-09 Thread James Almer
On 8/9/2016 1:29 PM, Luca Barbato wrote: > +enum AVPixelFormat ff_aom_imgfmt_to_pixfmt(aom_img_fmt_t img) > +{ > +switch (img) { > +case AOM_IMG_FMT_RGB24: return AV_PIX_FMT_RGB24; > +case AOM_IMG_FMT_RGB565:return AV_PIX_FMT_RGB565BE; > +case AOM_IMG_FMT_RGB555:return

Re: [libav-devel] [PATCH 13/13] lavu: remove the custom atomic API

2016-07-29 Thread James Almer
On 7/29/2016 8:52 AM, Anton Khirnov wrote: > It has been replaced by C11 stdatomic.h and is now unused. > --- > libavutil/Makefile | 5 --- > libavutil/atomic.c | 109 > --- > libavutil/atomic.h | 79

Re: [libav-devel] [RFC] opusdec: set delay to 3840 samples

2016-07-01 Thread James Almer
On 7/1/2016 5:14 AM, Anton Khirnov wrote: > This value specifies the number of samples that must be discarded after > seeking. > While the codec spec itself does not deal with seeking at all, the > OggOpus spec mandates this to be "at least 3840 samples (80 ms)". > Matroska has a special field for

Re: [libav-devel] [PATCH 5/5] mkv: Export bounds and padding from spherical metadata

2017-02-10 Thread James Almer
On 2/10/2017 6:08 PM, Vittorio Giovara wrote: > --- > libavformat/matroskadec.c | 34 +- > 1 file changed, 33 insertions(+), 1 deletion(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index a44ceeb..ebfd414 100644 > ---

Re: [libav-devel] [PATCH 5/5] mkv: Export bounds and padding from spherical metadata

2017-02-10 Thread James Almer
On 2/10/2017 6:37 PM, James Almer wrote: > On 2/10/2017 6:08 PM, Vittorio Giovara wrote: >> --- >> libavformat/matroskadec.c | 34 +- >> 1 file changed, 33 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/matroska

[libav-devel] [PATCH 1/2] apetag: fix flag value to signal footer presence

2017-02-10 Thread James Almer
files, and the flags field was a zeroed reserved field. [1] http://wiki.hydrogenaud.io/index.php?title=Ape_Tags_Flags Signed-off-by: James Almer <jamr...@gmail.com> --- Files already created are obviously wrong, but fortunately having the flag mistakenly reporting there's no footer is ha

[libav-devel] [PATCH 2/2] apetag: account for header size if present when returning the start position

2017-02-10 Thread James Almer
The size field in the header/footer accounts for the entire APE tag structure except the 32 bytes from header, for compatibility with APEv1. Signed-off-by: James Almer <jamr...@gmail.com> --- libavformat/apetag.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [libav-devel] [PATCH 2/5] matroskadec: add support for Spherical Video elements

2017-02-15 Thread James Almer
On 2/15/2017 4:28 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2017-02-10 22:08:08) >> From: James Almer <jamr...@gmail.com> >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com&

Re: [libav-devel] [PATCHv2] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

2016-08-22 Thread James Almer
On 8/22/2016 3:46 PM, Luca Barbato wrote: > On 22/08/16 10:39, Burt P wrote: >> A new filter that provides HDCD decoding, using libhdcd. >> https://github.com/bp0/libhdcd >> >> Signed-off-by: Burt P >> --- >> configure| 3 + >> doc/filters.texi | 52

Re: [libav-devel] [PATCH 9/9] audiodsp/x86: yasmify vector_clipf_sse

2016-09-05 Thread James Almer
On 9/5/2016 10:15 AM, Henrik Gramner wrote: > On Mon, Sep 5, 2016 at 1:02 PM, Anton Khirnov wrote: >> > +cglobal vector_clipf, 3, 3, 6, dst, src, len, min, max >> > +%if ARCH_X86_32 >> > +VBROADCASTSS m0, minm >> > +VBROADCASTSS m1, maxm >> > +%else >> > +

Re: [libav-devel] [PATCH 9/9] audiodsp/x86: yasmify vector_clipf_sse

2016-09-05 Thread James Almer
On 9/5/2016 8:02 AM, Anton Khirnov wrote: > --- > libavcodec/x86/Makefile | 1 - > libavcodec/x86/audiodsp.asm | 42 +++ > libavcodec/x86/audiodsp_mmx.c | 58 > --- > 3 files changed, 42 insertions(+), 59 deletions(-) >

Re: [libav-devel] [PATCH 9/9] audiodsp/x86: yasmify vector_clipf_sse

2016-09-05 Thread James Almer
On 9/5/2016 11:40 AM, James Almer wrote: > On 9/5/2016 10:15 AM, Henrik Gramner wrote: >> On Mon, Sep 5, 2016 at 1:02 PM, Anton Khirnov <an...@khirnov.net> wrote: >>>> +cglobal vector_clipf, 3, 3, 6, dst, src, len, min, max >>>> +%if ARCH

[libav-devel] [PATCH] avconv: fix guessed channel layout being lost during stream copy

2016-09-18 Thread James Almer
The guessed layout was being stored in the decoder context, which in the case of stream copy is unused. Signed-off-by: James Almer <jamr...@gmail.com> --- Didn't run FATE after this patch, but aside from guess_input_channel_layout() nothing seemed to be using ist->dec_ctx inside t

Re: [libav-devel] [PATCHv6] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

2016-08-26 Thread James Almer
On 8/26/2016 11:09 AM, Diego Biurrun wrote: > On Fri, Aug 26, 2016 at 07:36:29AM -0500, Burt P wrote: >> --- /dev/null >> +++ b/libavfilter/af_hdcd.c >> @@ -0,0 +1,199 @@ >> + >> +#include > > Is there a hdcd_complicated.h header as well? There used to be one that exposed every internal bit and

Re: [libav-devel] [PATCHv4] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

2016-08-25 Thread James Almer
On 8/25/2016 6:53 PM, Burt P. wrote: > On Thu, Aug 25, 2016 at 8:56 AM, Diego Biurrun wrote: >> On Wed, Aug 24, 2016 at 07:34:22AM -0500, Burt P wrote: >> >> This probably deserves a mention in doc/general.texi and a version bump >> for libavfilter. >> >>> +typedef struct

Re: [libav-devel] [PATCH 1/5] av1: Add codec_id and basic demuxing support

2016-08-24 Thread James Almer
On 8/24/2016 1:28 PM, Diego Biurrun wrote: > From: Luca Barbato > > Signed-off-by: Diego Biurrun > --- > > I feel like I'm missing a version bump somewhere.. > > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 +++ >

Re: [libav-devel] [PATCH 1/5] av1: Add codec_id and basic demuxing support

2016-08-24 Thread James Almer
On 8/24/2016 3:52 PM, Luca Barbato wrote: > On 24/08/16 20:31, James Almer wrote: >> Was this tag added to the Matroska spec? Or was it at least suggested >> somewhere? > > The libaom sources. Fair enough. Doubt Matroska will end up going with something else

[libav-devel] [PATCH] avconv: fix bitstream filter option parsing

2016-10-03 Thread James Almer
Arguments for bitstream filters weren't being parsed at all, and instead checked by av_bsf_get_by_name() as if they were part of the filter's name Signed-off-by: James Almer <jamr...@gmail.com> --- This should also go into Libav 12, but i'm not CCing libav-sta...@libav.org since i assum

Re: [libav-devel] [PATCH] vaapi_encode: Add VP9 support

2016-10-01 Thread James Almer
On 10/1/2016 10:48 AM, Anton Khirnov wrote: > Quoting Mark Thompson (2016-10-01 11:26:09) >> --- >> Tested on Kaby Lake. > > Looks simple enough to be ok. I guess it also deserves a changelog > entry. > >> >> CQP (well, C q_idx) and CBR mode implemented. Some vestigial B-frame-alike >>

Re: [libav-devel] [PATCH] avconv: fix bitstream filter option parsing

2016-10-10 Thread James Almer
On 10/3/2016 4:40 PM, James Almer wrote: > Arguments for bitstream filters weren't being parsed at all, and instead > checked by av_bsf_get_by_name() as if they were part of the filter's name > > Signed-off-by: James Almer <jamr...@gmail.com> > --- > This should also g

Re: [libav-devel] [PATCH 1/2 v2] matroskaenc: fix muxing AAC streams when using aac_adtstoasc bsf

2016-11-09 Thread James Almer
On 11/9/2016 7:36 AM, Anton Khirnov wrote: > Quoting James Almer (2016-11-02 21:02:30) >> aac_adtstoasc makes the aac extradata available only after the first packet >> is filtered, and as packet side data. >> >> Assume extradata will be available

[libav-devel] [PATCH 1/2 v3] matroskaenc: fix muxing AAC streams when using aac_adtstoasc bsf

2016-11-09 Thread James Almer
for the OutputSampleRate element in the Tracks master. Signed-off-by: James Almer <jamr...@gmail.com> --- libavformat/matroskaenc.c | 80 +++ 1 file changed, 74 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index c

[libav-devel] [PATCH 2/2 v3] matroskaenc: write updated STREAMINFO metadata for FLAC streams if available

2016-11-09 Thread James Almer
FLAC streams originating from the FLAC encoder send updated and more complete STREAMINFO metadata as part of the last packet, so write that to CodecPrivate instead of the incomplete one available in extradata during init. Signed-off-by: James Almer <jamr...@gmail.com> --- libav

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread James Almer
On 11/23/2016 12:39 AM, Luca Barbato wrote: > On 22/11/2016 23:16, Vittorio Giovara wrote: >> -tmp = av_realloc_array(st->side_data, st->nb_side_data + 1, >> sizeof(*tmp)); >> +if ((unsigned) st->nb_side_data + 1 >= INT_MAX / sizeof(*st->side_data)) >> +return AVERROR(ERANGE); >>

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread James Almer
On 11/21/2016 8:49 PM, Vittorio Giovara wrote: > From: James Almer <jamr...@gmail.com> > > Functionally similar to av_packet_add_side_data(). Allows the use of an > already allocated buffer as stream side data. > > Signed-off-by: James Almer <jamr...@gmail.com> >

Re: [libav-devel] [PATCH] utils: Add av_stream_add_side_data()

2016-11-22 Thread James Almer
On 11/22/2016 5:32 PM, Vittorio Giovara wrote: > On Tue, Nov 22, 2016 at 10:04 AM, James Almer <jamr...@gmail.com> wrote: >> On 11/21/2016 8:49 PM, Vittorio Giovara wrote: >>> From: James Almer <jamr...@gmail.com> >>> >>> Functionally simi

Re: [libav-devel] [PATCH 02/14] aac_adtstoasc_bsf: convert to the new API

2016-11-24 Thread James Almer
nd not ADTS or even LATM. Deleting it unconditionally breaks passthrough use cases. The .init function should validate the extradata and let av_bsf_init() pass it down the filter chain. See the attached patch. >From 5f07937db0a12b6176bfc0414c530716cfb382e7 Mon Sep 17 00:00:00 2001 From: James Alme

[libav-devel] [PATCH] avpacket: fix leak on realloc in av_packet_add_side_data()

2016-11-19 Thread James Almer
If realloc fails, the pointer is overwritten and the previously allocated buffer is leaked, which goes against the expected functionality of keeping the packet unchanged in case of error. Signed-off-by: James Almer <jamr...@gmail.com> --- Should be backported to release/12. liba

[libav-devel] [PATCH] avpacket: use av_reallocp() in av_packet_add_side_data()

2016-11-19 Thread James Almer
Prevents leaking the previously allocated buffer, honoring the expected behavior of keeping the packet unchanged in case of error. Signed-off-by: James Almer <jamr...@gmail.com> --- Now using av_reallocp() as suggested. Should still be backported to release/12. libavcodec/avpacket

Re: [libav-devel] [PATCH] avpacket: use av_reallocp() in av_packet_add_side_data()

2016-11-19 Thread James Almer
On 11/19/2016 3:59 PM, James Almer wrote: > Prevents leaking the previously allocated buffer, honoring the expected > behavior > of keeping the packet unchanged in case of error. > > Signed-off-by: James Almer <jamr...@gmail.com> > --- > Now using av_reallocp() as sug

[libav-devel] [PATCH 1/2] matroskaenc: fix muxing AAC streams when using aac_adtstoasc bsf

2016-10-30 Thread James Almer
for the OutputSampleRate element in the Tracks master. Signed-off-by: James Almer <jamr...@gmail.com> --- Should be backported to stable branches IMO. libavformat/matroskaenc.c | 72 +++ 1 file changed, 66 insertions(+), 6 deletions(-) diff --git a/libavformat/matrosk

[libav-devel] [PATCH 2/2] matroskaenc: don't write private data for AAC streams

2016-10-30 Thread James Almer
The spec says it should be void. Signed-off-by: James Almer <jamr...@gmail.com> --- libavformat/matroskaenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index aa9d381..c3a9702 100644 --- a/libavformat/matroskaenc.c

Re: [libav-devel] [PATCH 2/2] matroskaenc: don't write private data for AAC streams

2016-10-30 Thread James Almer
On 10/30/2016 4:48 PM, Hendrik Leppkes wrote: > On Sun, Oct 30, 2016 at 8:45 PM, James Almer <jamr...@gmail.com> wrote: >> On 10/30/2016 4:20 PM, Hendrik Leppkes wrote: >>> On Sun, Oct 30, 2016 at 8:08 PM, James Almer <jamr...@gmail.com> wrote: >&g

Re: [libav-devel] [PATCH 2/2] matroskaenc: don't write private data for AAC streams

2016-10-30 Thread James Almer
On 10/30/2016 4:20 PM, Hendrik Leppkes wrote: > On Sun, Oct 30, 2016 at 8:08 PM, James Almer <jamr...@gmail.com> wrote: >> The spec says it should be void. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> libavformat/matroska

[libav-devel] [PATCH 1/2 v2] matroskaenc: fix muxing AAC streams when using aac_adtstoasc bsf

2016-11-02 Thread James Almer
for the OutputSampleRate element in the Tracks master. Signed-off-by: James Almer <jamr...@gmail.com> --- No functionality change compared to the previous versio, just some refactoring to better accommodate the following patch. libavformat/matroskaenc.c | 78 +++

[libav-devel] [PATCH 2/2] matroskaenc: write updated STREAMINFO metadata for FLAC streams if available

2016-11-02 Thread James Almer
FLAC streams originating from the FLAC encoder send updated and more complete STREAMINFO metadata as part of the last packet, so write that to CodecPrivate instead of the incomplete one available in extradata during init. Signed-off-by: James Almer <jamr...@gmail.com> --- libav

Re: [libav-devel] [PATCH] Add support for CUVID decode

2016-11-01 Thread James Almer
On 10/27/2016 8:58 AM, Ruta Gadkari wrote: > From 31f2ef09647f120f3ad245db0ad4f5339171ff57 Mon Sep 17 00:00:00 2001 > From: rgadkari_test > Date: Thu, 27 Oct 2016 16:35:59 +0530 > Subject: [PATCH 1/1] CUVID: Add support for CUVID decode > > --- > configure |

[libav-devel] [PATCH] avconv: support parsing bitstream filter options

2016-10-28 Thread James Almer
Example usage: avconv -i INPUT -bsf filter[=opt1=val1:opt2=val2] OUTPUT Signed-off-by: James Almer <jamr...@gmail.com> --- avconv.c | 15 ++- avconv.h | 1 - avconv_opt.c | 46 +- 3 files changed, 39 insertions(

[libav-devel] [PATCH] avformat/matroska: fix MatroskaVideoFieldOrder enum values

2016-10-13 Thread James Almer
coded first, top displayed first Signed-off-by: James Almer <jamr...@gmail.com> --- Should also go into libav 12. This feature is only a couple months old so it's not affecting any other stable release. A check for files created with old lavf versions in the matroska demuxer to detect wrongly

Re: [libav-devel] [PATCH] avconv: fix bitstream filter option parsing

2016-10-13 Thread James Almer
On 10/10/2016 2:23 PM, Anton Khirnov wrote: > Quoting James Almer (2016-10-03 21:40:06) >> Arguments for bitstream filters weren't being parsed at all, and instead >> checked by av_bsf_get_by_name() as if they were part of the filter's name >> >> Signed-off-by: Jam

[libav-devel] [PATCH] dump: be more verbose when printing spherical metadata information

2016-12-15 Thread James Almer
Signed-off-by: James Almer <jamr...@gmail.com> --- This prints spherical: equirectangular, yaw=0.00, pitch=0.00, roll=0.00 Instead of spherical: equirectangular (0.00/0.00/0.00) libavformat/dump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [libav-devel] [PATCH 1/5] avconv: dxva2: factorize some code that can be common with d3d11va

2016-12-15 Thread James Almer
On 12/15/2016 2:52 PM, Diego Biurrun wrote: > On Thu, Dec 15, 2016 at 06:01:42PM +0100, Steve Lhomme wrote: >> From: Steve Lhomme >> >> avconv_dxva.h has to be included and misc. typedefs have to be set to use the >> proper DXVA2 structures. >> >> initguid.h is included in

<    1   2   3   4   >