[libav-devel] [PATCH 5/5] libdav1d: unref the frame on failure

--- libavcodec/libdav1d.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 83d5c97bc..5177b884c 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -230,7 +230,7 @@ static int

[libav-devel] [PATCH 2/5] libdav1d: move the pix_fmt enum array up in the file

This is in preparation for the following commit. --- libavcodec/libdav1d.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 22fcb0df5..bb7d404e7 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@

[libav-devel] [PATCH 4/5] libdav1d: consistently use AVERROR return values

--- libavcodec/libdav1d.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 4c93e4b7c..83d5c97bc 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -185,9 +185,9 @@ static int

[libav-devel] [PATCH 1/5] libdav1d: route dav1d internal logs through av_log()

Bump the minimum required version to the first one with the logger API callback. --- configure | 2 +- libavcodec/libdav1d.c | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 26455054b..a83990e7f 100755 --- a/configure +++

[libav-devel] [PATCH 3/5] libdav1d: use a custom picture allocator

Replaces the libdav1d internal allocator. It uses an AVBufferPool to reduce the amount of allocated buffers. About 5% speed up when decoding 720p or higher streams. --- libavcodec/libdav1d.c | 60 +++ 1 file changed, 60 insertions(+) diff --git

[libav-devel] [PATCH] avcodec/libdav1d: properly free all output picture references

Dav1dPictures contain more than one buffer reference, so we're forced to use the API properly to free them all. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 69 +++ 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/libavcodec

[libav-devel] [PATCH] libdav1d: update API usage to the first stable release

on output pix_fmt. Signed-off-by: James Almer --- configure | 2 +- libavcodec/libdav1d.c | 78 +-- 2 files changed, 24 insertions(+), 56 deletions(-) diff --git a/configure b/configure index c5bafc382..26455054b 100755 --- a/configure +++ b

[libav-devel] [PATCH] libdav1d: fix build after a recent API break

Signed-off-by: James Almer --- libavcodec/libdav1d.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index ad4611fb9..3501c15e2 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -142,12 +142,18

[libav-devel] [PATCH 3/3] avcodec: libdav1d AV1 decoder wrapper.

Originally written by Ronald S. Bultje, with fixes, optimizations and improvements by James Almer. Signed-off-by: James Almer --- Changelog | 1 + configure | 4 + doc/general.texi | 12 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1

[libav-devel] [PATCH 2/3] swscale: Add GRAY10

From: Carl Eugen Hoyos Based on ab839054 by Luca Barbato. Signed-off-by: James Almer --- libswscale/input.c | 2 ++ libswscale/swscale_internal.h | 2 ++ libswscale/swscale_unscaled.c | 1 + libswscale/utils.c | 2 ++ libswscale

[libav-devel] [PATCH 0/3] libdav1d AV1 decoder wrapper

$subject Carl Eugen Hoyos (2): pixfmt: Add GRAY10 swscale: Add GRAY10 James Almer (1): avcodec: libdav1d AV1 decoder wrapper. Changelog | 1 + configure | 4 + doc/APIchanges | 3 + doc/general.texi

[libav-devel] [PATCH 1/3] pixfmt: Add GRAY10

From: Carl Eugen Hoyos Based on 7471352f by Luca Barbato. Signed-off-by: James Almer --- doc/APIchanges | 3 +++ libavutil/pixdesc.c | 22 ++ libavutil/pixfmt.h | 4 libavutil/version.h | 4 ++-- 4 files changed, 31 insertions(+), 2 deletions(-) diff --git

[libav-devel] [PATCH] libaom: remove references to yuva444p pixfmt

Support for it was apparently never in the codebase, and the enum value was recently removed from the public headers [1] [1] https://aomedia.googlesource.com/aom/+/f1570f0c2f70832dd170285f8de60bd2379c8efa Signed-off-by: James Almer --- libavcodec/libaom.c | 4 1 file changed, 4 deletions

Re: [libav-devel] [PATCH 6/9] avcodec/extract_extradata: don't uninitialize the H2645Packet on every processed packet

On 10/11/2018 7:12 AM, Luca Barbato wrote: > On 03/10/2018 21:15, Luca Barbato wrote: >> From: James Almer >> >> Based on hevc_parser code. This prevents repeated unnecessary allocations >> and frees on every packet processed by the bsf. >> >> Reviewed-by:

[libav-devel] [PATCH] avcodec/libaomenc: export the Sequence Header OBU as extradata

Signed-off-by: James Almer --- configure | 8 +++- libavcodec/libaomenc.c | 34 +- 2 files changed, 40 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 48e8536b0..2aa7eb627 100755 --- a/configure +++ b/configure @@ -4664,7

Re: [libav-devel] [PATCH 1/2] avcodec/libaomenc: export Sequence Header and Metadata OBUs as extradata

On 10/6/2018 5:43 PM, Luca Barbato wrote: > From: James Almer > > aom_codec_get_global_headers() is not implemented as of libaom 1.0.0 for AV1, > so > we're forced to extract the relevant header OBUs from the first packet and > propagate > them as packet side data.

Re: [libav-devel] [PATCH 9/9] avcodec/extract_extradata_bsf: make sure a Sequence Header was found for av1

On 10/3/2018 4:15 PM, Luca Barbato wrote: > From: James Almer > > A packet may have Metadata OBUs but no Sequence Header OBU, which is > useless as extradata. > > Signed-off-by: James Almer > Signed-off-by: Luca Barbato > --- > libavcodec/extract_extradata_bsf.c |

Re: [libav-devel] [PATCH 3/9] avcodec/extract_extradata: Zero-initialize the padding bytes in all allocated buffers

On 10/3/2018 4:15 PM, Luca Barbato wrote: > From: James Almer > > Reviewed-by: Derek Buitenhuis > Signed-off-by: James Almer > Signed-off-by: Luca Barbato > --- > libavcodec/extract_extradata_bsf.c | 6 ++ > 1 file changed, 6 insertions(+) >

Re: [libav-devel] [PATCH 7/9] avcodec: add AV1 packet split API

On 10/3/2018 4:15 PM, Luca Barbato wrote: > From: James Almer > > Signed-off-by: James Almer > Signed-off-by: Luca Barbato > --- > libavcodec/av1_parse.c | 103 > libavcodec/av1_parse.h | 126 > ++

Re: [libav-devel] [PATCH 1/3] configure: speed up flatten_extralibs_wrapper()

On 9/17/2018 3:49 PM, Diego Biurrun wrote: > On Sun, Sep 16, 2018 at 11:52:59PM -0300, James Almer wrote: >> From: Avi Halachmi >> >> x50 - x200 faster. > > The set looks very interesting. I've had some ideas on how to speed up > this part of configure already, s

[libav-devel] [PATCH 1/3] configure: speed up flatten_extralibs_wrapper()

output order. Signed-off-by: James Almer --- configure | 46 +- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/configure b/configure index 48e8536b0..be348e881 100755 --- a/configure +++ b/configure @@ -689,22 +689,37 @@ prepend(){ eval

[libav-devel] [PATCH 3/3] configure: _deps: validate, reduce sensitivity

list order automatically from the deps lists, but in this case it's probably not worth the added complexity, even if minor. Maintaining one list should be OK. Signed-off-by: James Almer --- configure | 41 + 1 file changed, 33 insertions(+), 8 deletions(-)

[libav-devel] [PATCH 2/3] configure: speed up check_deps()

before inprogress - x2 faster in 50%+ - one eval instead of several at the empty-deps early abort path. - The "actual work" part is unmodified - just its surroundings. Biggest speedups (relative and absolute) are observed with bash. Signed-off-by: James Almer --- conf

Re: [libav-devel] [PATCH] Revert "decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

On 9/13/2018 9:35 AM, Luca Barbato wrote: > On 12/09/2018 20:24, James Almer wrote: >> This reverts commit 662558f985f50834eebe82d6b6854c66f33ab320. >> >> The avcodec_parameters_to_context() call was freeing and reallocating >> AVCodecContext->extradata, essentially

[libav-devel] [PATCH] Revert "decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

ome library users like Firefox. Revert until a better solution is found to internally propagate the filtered extradata back into the decoder context. Signed-off-by: James Almer --- See https://bugzilla.mozilla.org/show_bug.cgi?id=1486080 Suggestions to work around it are very welcome, of course. Wh

[libav-devel] [PATCH 5/7] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

Signed-off-by: James Almer --- libavcodec/h264_redundant_pps_bsf.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/h264_redundant_pps_bsf.c b/libavcodec/h264_redundant_pps_bsf.c index 24b7b6730..d806427da 100644 --- a/libavcodec/h264_redundant_pps_bsf.c +++ b/libavcodec

[libav-devel] [PATCH 1/7] avcodec/bsf: add a flushing mechanism to AVBSFContext

Meant to reset the internal bsf state without the need to reinitialize it. Signed-off-by: James Almer --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 6 ++ libavcodec/bsf.c | 10 ++ libavcodec/version.h | 2 +- 4 files changed, 20 insertions(+), 1 deletion(-) diff

[libav-devel] [PATCH 4/7] avcodec/vp9_superframe_bsf: implement a AVBSFContext.flush() callback

Signed-off-by: James Almer --- libavcodec/vp9_superframe_bsf.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/vp9_superframe_bsf.c b/libavcodec/vp9_superframe_bsf.c index ad66cb599..04b158fa1 100644 --- a/libavcodec/vp9_superframe_bsf.c +++ b/libavcodec

[libav-devel] [PATCH 6/7] avcodec/decode: flush the internal bsfs instead of constantly reinitalizing them

Initialize the bsfs once when opening the codec and uninitialize them once when closing it, instead of at every codec flush/seek. Signed-off-by: James Almer --- I think i didn't miss any bsf with internal state that needs a flush() callback, but an extra pair of eyes (or more) to make sure would

[libav-devel] [PATCH 3/7] avcodec/vp9_superframe_split_bsf: implement a AVBSFContext.flush() callback

Signed-off-by: James Almer --- libavcodec/vp9_superframe_split_bsf.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/vp9_superframe_split_bsf.c b/libavcodec/vp9_superframe_split_bsf.c index 4e635a307..4e6e7ff08 100644 --- a/libavcodec/vp9_superframe_split_bsf.c +++ b

[libav-devel] [PATCH 2/7] avcodec/h264_mp4toannexb_bsf: implement a AVBSFContext.flush() callback

Signed-off-by: James Almer --- libavcodec/h264_mp4toannexb_bsf.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/h264_mp4toannexb_bsf.c b/libavcodec/h264_mp4toannexb_bsf.c index c65aaeb98..c45ecd8ce 100644 --- a/libavcodec/h264_mp4toannexb_bsf.c +++ b/libavcodec

[libav-devel] [PATCH 7/7] avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext

Certain AVCodecParameters, like the contents of the extradata, may be changed by the init() function of any of the bitstream filters in the chain. Signed-off-by: James Almer --- libavcodec/decode.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c

Re: [libav-devel] [PATCH] configure: fix inline asm checks

On 6/7/2018 6:01 PM, Diego Biurrun wrote: > On Thu, Jun 07, 2018 at 03:03:21PM +0300, Martin Storsjö wrote: >> Commit 8c893aa3cd5 removed quotes that were required to detect >> inline asm: >> >> check_insn armv5te qadd r0, r0, r0 >> .../test.c:1:34: error: expected string literal in 'asm' >> void

Re: [libav-devel] [PATCH] random_seed: use bcrypt instead of the old wincrypt API

On 4/15/2018 5:17 PM, Martin Storsjö wrote: > From: Steve Lhomme > > Remove the wincrypt API calls since we don't support XP anymore and > bcrypt is available since Vista, even on Windows Store builds. > --- > configure | 6 +++--- > libavutil/random_seed.c | 19

Re: [libav-devel] [PATCH] aac: Rework extradata parsing code

On 4/13/2018 11:43 AM, wm4 wrote: > On Fri, 13 Apr 2018 09:22:30 +0900 > Luca Barbato wrote: > >> On 13/04/2018 06:44, Vittorio Giovara wrote: >>> -if (new_extradata && 0) { >> >> Uh? > > > faa2930f191099621e03c55cca32662467d3cc15 > > flvdec: reenable extradata

[libav-devel] [PATCH] libaom: remove references to RGB pixfmts

Support for it was apparently never in the codebase, and the enum values were recently removed from the public headers [1] Fixes build with latest libaom build. [1] https://aomedia.googlesource.com/aom/+/3f29cc20e3a4c348cb41a797c68de856ddb84e12 Signed-off-by: James Almer <jamr...@gmail.

[libav-devel] [PATCH] libaom: remove references to yuv440p pixfmt

Support for it was apparently never in the codebase, and the enum values were recently removed from the public headers [1] Fixes build with latest libaom build. [1] https://aomedia.googlesource.com/aom/+/2e3cd5c5c30fa02134681cda900c32486807af3f Signed-off-by: James Almer <jamr...@gmail.

Re: [libav-devel] [PATCH] use bcrypt instead of the old wincrypt API

On 3/30/2018 3:13 PM, Martin Storsjö wrote: > On Fri, 30 Mar 2018, James Almer wrote: > >> On 3/30/2018 10:57 AM, Martin Storsjö wrote: >>> On Fri, 30 Mar 2018, Diego Biurrun wrote: >>> >>>> On Fri, Mar 30, 2018 at 10:43:27AM -0300, James Almer wrote:

Re: [libav-devel] [PATCH] use bcrypt instead of the old wincrypt API

On 3/30/2018 10:57 AM, Martin Storsjö wrote: > On Fri, 30 Mar 2018, Diego Biurrun wrote: > >> On Fri, Mar 30, 2018 at 10:43:27AM -0300, James Almer wrote: >>> On 3/30/2018 10:38 AM, Diego Biurrun wrote: >>> > On Fri, Mar 30, 2018 at 12:38:05PM +0200, Steve Lhomme

Re: [libav-devel] [PATCH] use bcrypt instead of the old wincrypt API

On 3/30/2018 10:38 AM, Diego Biurrun wrote: > On Fri, Mar 30, 2018 at 12:38:05PM +0200, Steve Lhomme wrote: >> Le 30/03/2018 à 10:46, Diego Biurrun a écrit : >>> On Fri, Mar 30, 2018 at 09:36:05AM +0200, Steve Lhomme wrote: --- a/configure +++ b/configure @@ -4581,6 +4582,7 @@

[libav-devel] [PATCH 2/2] libaomenc: fix profile setting

Main Profile is yuv420p 8 and 10 bit High Profile is yuv444p 8 and 10 bit Professional Profile is yuv422p 8, 10, and 12 bit, plus every other pixfmt at 12 bit Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/libaomenc.c | 12 ++-- 1 file changed, 6 insertions

[libav-devel] [PATCH 1/2] avcodec: rename the AV1 profiles

Use the proper names instead of numbers Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/avcodec.h | 6 +++--- libavcodec/libaomenc.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ac0915328..eb2

Re: [libav-devel] [PATCH] configure: Revert some incorrect uses of check_cc()

On 3/29/2018 4:28 AM, Diego Biurrun wrote: > --- > > Thanks to James for pointing this out. > > configure | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/configure b/configure > index 90fb6f07ca..a64f241560 100755 > --- a/configure > +++ b/configure >

Re: [libav-devel] [PATCH 1/7] configure: Document available options for the --toolchain parameter

On 3/20/2018 6:49 AM, Diego Biurrun wrote: > --- > configure | 4 > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index 78a2065208..d8c3b555cc 100755 > --- a/configure > +++ b/configure > @@ -260,6 +260,10 @@ Toolchain options: >--target-path=DIRpath

Re: [libav-devel] [PATCH 7/7] configure: Drop unused helper function test_cflags_cpp()

On 3/20/2018 6:49 AM, Diego Biurrun wrote: > --- > configure | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/configure b/configure > index 830f754412..6689858d57 100755 > --- a/configure > +++ b/configure > @@ -1042,19 +1042,6 @@ check_cpp_condition(){ >

Re: [libav-devel] [PATCH 6/7] configure: Simplify vfp_args check

On 3/20/2018 6:49 AM, Diego Biurrun wrote: > --- > configure | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/configure b/configure > index 9257b94631..830f754412 100755 > --- a/configure > +++ b/configure > @@ -4303,10 +4303,7 @@ elif enabled arm; then > elif !

Re: [libav-devel] [PATCH 5/7] configure: Simplify vararg check

On 3/20/2018 6:49 AM, Diego Biurrun wrote: > --- > configure | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index e3c5dcae1e..9257b94631 100755 > --- a/configure > +++ b/configure > @@ -4240,12 +4240,11 @@ od -t x1 $TMPO | grep -q '42 *49

Re: [libav-devel] [PATCH 3/7] configure: Use a more sensible suffix for x86 assembly tempfiles

On 3/20/2018 6:49 AM, Diego Biurrun wrote: > --- > configure | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index ce0d791c1b..dbc5759df4 100755 > --- a/configure > +++ b/configure > @@ -810,10 +810,10 @@ test_as(){ > > test_x86asm(){ >

Re: [libav-devel] [PATCH 2/7] configure: Add check_x86asm() helper function to simplify some expressions

On 3/20/2018 6:49 AM, Diego Biurrun wrote: > --- > configure | 32 > 1 file changed, 20 insertions(+), 12 deletions(-) > > diff --git a/configure b/configure > index d8c3b555cc..ce0d791c1b 100755 > --- a/configure > +++ b/configure > @@ -808,6 +808,14 @@

[libav-devel] [PATCH v2] extract_extradata: zero initalize the padding bytes in all allocated buffers

Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/extract_extradata_bsf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index 100c60d06..b5ba77dd0 100644 --- a/libavcodec/extract_extradata_bsf.c

Re: [libav-devel] [PATCH] extract_extradata: zero initalize the padding bytes in all allocated buffers

On 3/8/2018 5:25 PM, Luca Barbato wrote: > On 08/03/2018 17:08, James Almer wrote: >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >>   libavcodec/extract_extradata_bsf.c | 5 + >>   1 file changed, 5 insertions(+) >> > > Sounds good.

[libav-devel] [PATCH] extract_extradata: zero initalize the padding bytes in all allocated buffers

Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/extract_extradata_bsf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index 100c60d06..8d341cefc 100644 --- a/libavcodec/extract_extradata_bsf.c

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

On 2/26/2018 2:10 AM, Luca Barbato wrote: > --- > > Since the bitstream will be frozen soon shouldn't hurt adding it. > > configure | 1 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 +- > libavcodec/libaomenc.c | 602 >

[libav-devel] [PATCH] hvcc: zero initialize the nal buffers past the last written byte

Bug-Id: 1116 Cc: libav-sta...@libav.org Signed-off-by: James Almer <jamr...@gmail.com> --- libavformat/hevc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index f8bfeebd3..1f8a7bb3c 100644 --- a/libavformat/hevc.c +++ b/libavformat/

Re: [libav-devel] [PATCH 1/7] configure: Drop unnecessary variables, shifts, and quotes in helper functions

On 2/11/2018 4:09 PM, Diego Biurrun wrote: > --- > configure | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git a/configure b/configure > index ed930e6cd4..904131301d 100755 > --- a/configure > +++ b/configure > @@ -816,7 +816,7 @@ EOF > >

Re: [libav-devel] [PATCH 10/16] cbs: Refcount all the things!

On 2/11/2018 3:14 PM, Mark Thompson wrote: > +int ff_cbs_alloc_unit_content(CodedBitstreamContext *ctx, > + CodedBitstreamUnit *unit, > + size_t size, > + void (*free)(void *opaque, uint8_t *data)) > +{ > +

Re: [libav-devel] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 1/3/2018 7:53 PM, Sean McGovern wrote: > 2 things: > > - does this actually depend on dlopen directly, or should it be libdl, like > the entries below it? If this is Windows only as the doxy states, then LoadLibrary should be the only dep. But otherwise you're right, it should be libdl and

Re: [libav-devel] [PATCH] x264: Support version 155

On 12/26/2017 10:10 AM, Nicolas George wrote: > James Almer (2017-12-26): >>> +#if X264_BUILD >= 155 >>> +if (x4->params.i_bitdepth > 8) >>> +#else > >> Wouldn't using av_pix_fmt_desc_get(avctx->pix_fmt)->comp[0].depth here >> as w

Re: [libav-devel] [PATCH] x264: Support version 155

On 12/26/2017 11:39 AM, Luca Barbato wrote: > On 26/12/2017 13:54, James Almer wrote: >> You can still build libx264 with support for only 8 and 10 bits after >> this multibitdepth change, so ideally you'd still check for what's >> available based on X264_BIT_DEPTH and u

Re: [libav-devel] [PATCH] x264: Support version 155

On 12/26/2017 8:33 AM, Luca Barbato wrote: > It has native 8 and 10 bit support. > --- > libavcodec/libx264.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 0dec12edd2..6aadf33c94 100644 > ---

Re: [libav-devel] [PATCH] libavcodec: Don't use dllexport, only dllimport when building DLLs

On 11/17/2017 5:35 PM, Martin Storsjö wrote: > On Fri, 17 Nov 2017, James Almer wrote: > >> On 11/16/2017 5:22 AM, Martin Storsjö wrote: >>> The only purpose of dllexport (which is set while building the library >>> that exports the symbols) is to have the l

Re: [libav-devel] [PATCH] libavcodec: Don't use dllexport, only dllimport when building DLLs

On 11/16/2017 5:22 AM, Martin Storsjö wrote: > The only purpose of dllexport (which is set while building the library > that exports the symbols) is to have the linker automatically > export such symbols into a DLL without using a def file - it doesn't > affect the generated code. > > For MSVC

Re: [libav-devel] [PATCH] makedef: Pass EXTERN_PREFIX from configure to makedef

On 11/16/2017 5:00 AM, Martin Storsjö wrote: > This avoids having to use either "dumpbin -headers" to find out > the current architecture, or pass $ARCH from configure to deduce it. > > When configuring with --disable-asm, ARCH is equal to "c", which doesn't > give any indication of what symbol

Re: [libav-devel] [PATCH] configure: export extern_prefix to use with makedef

On 11/16/2017 11:17 AM, James Almer wrote: > No point in trying to guess it from within makedef when configure > already did it before. > > Fixes linking failures on x86_32 when "arch" isn't one of the values > makedef was expecting. > > Signed-off-by:

[libav-devel] [PATCH] configure: export extern_prefix to use with makedef

No point in trying to guess it from within makedef when configure already did it before. Fixes linking failures on x86_32 when "arch" isn't one of the values makedef was expecting. Signed-off-by: James Almer <jamr...@gmail.com> --- compat/wind

[libav-devel] [PATCH] configure: use subarch instead of arch to create .def files on mingw

arch is "x86" regardless of target being x86_32 or x86_64, and if configuring with asm disabled it's "c" instead. Using subarch (Always either "x86_32" or "x86_64") and adapting makedef makes sure the symbols are always detected correctly on x86_32. --- compat/windows/makedef | 2 +- configure

[libav-devel] [PATCH] Makefile: fix distclean target

It must imply clean. Regression since 7ebe7e8e7a76c0ce302f4f583ef0d14220031214. Signed-off-by: James Almer <jamr...@gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5f91294c8e..024d59f815 100644 --- a/Makefile +++ b/Ma

Re: [libav-devel] [PATCH 5/5] Drop some unnecessary config.h #includes

On 11/3/2017 1:43 PM, Diego Biurrun wrote: > --- > > Noticed while working on the previous patch, spun off into a separate commit. > > libavcodec/thread.h | 1 - > libavformat/tls.h| 4 ++-- > libavutil/aarch64/cpu.h | 1 - > libavutil/arm/cpu.h | 1 - >

Re: [libav-devel] [PATCH] configure: Simplify restrict keyword handling

On 11/10/2017 11:57 AM, Diego Biurrun wrote: > Skip a variable indirection and only redefine restrict if necessary. > --- > > Should still work on MSVC 2010 now as I don't kill the ugly workaround. > > configure | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

[libav-devel] [PATCH] configure: fix writing library dependencies to config.sh

Signed-off-by: James Almer <jamr...@gmail.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1f220c8bef..e608d26608 100755 --- a/configure +++ b/configure @@ -5405,7 +5405,7 @@ EOF for lib in $LIBRARY_LIST; do li

Re: [libav-devel] [PATCH 3/5] configure: Factorize check_64_bit()

On 11/3/2017 1:43 PM, Diego Biurrun wrote: > --- > > I'm assuming that the change for MIPS is safe. If you can't test it on a MIPS target, then it would be best to ask someone who can. It probably has its own special check for a reason. > > configure | 15 +++ > 1 file changed, 7

Re: [libav-devel] [PATCH 2/5] configure: Coalesce some arch configuration and PIC handling

On 11/3/2017 1:43 PM, Diego Biurrun wrote: > --- > configure | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/configure b/configure > index 33c52240aa..169a6fa33f 100755 > --- a/configure > +++ b/configure > @@ -2595,6 +2595,7 @@

Re: [libav-devel] [PATCH 1/5] configure: Miscellaneous minor changes

On 11/3/2017 1:43 PM, Diego Biurrun wrote: > - Move a variable closer to where it is used > - Add an explanatory comment > - Simplify a crosscompile check > - Minor SHFLAGS simplification > - Coalesce some threads tests > --- > configure | 17 - > 1 file changed, 8 insertions(+),

[libav-devel] [PATCH] vp9_superframe_bsf: cache packets by creating new references instead of moving pointers

Fixes invalid reads after free. Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/vp9_superframe_bsf.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp9_superframe_bsf.c b/libavcodec/vp9_superframe_bsf.c index 3669

Re: [libav-devel] [PATCH] avutil: make AV_NOPTS_VALUE signed negative

On 11/4/2017 6:06 AM, Rémi Denis-Courmont wrote: > libav generally uses int64_t to represent timestamps, and thus > AV_NOPTS_VALUE has to fit witin the range of int64_t. > > The current definition of AV_NOPTS_VALUE results in AV_NOPTS_VALUE > having the same type as uint64_t, since its value is

Re: [libav-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

On 11/3/2017 5:04 PM, Diego Biurrun wrote: > On Fri, Nov 03, 2017 at 04:50:56PM -0300, James Almer wrote: >> On 11/3/2017 4:42 PM, Luca Barbato wrote: >>> On 03/11/2017 19:23, Kieran Kunhya wrote: >>>> This patch fixes very high memory usage on pathological st

[libav-devel] [PATCH] h2645_parse: Allocate a single buffer per packet

From: Kieran Kunhya Drastically reduces memory usage on pathological streams. --- Fixed so it may apply cleanly, and with the memset() change removed. libavcodec/h2645_parse.c | 22 -- libavcodec/h2645_parse.h | 10 -- libavcodec/h264_parser.c | 11

Re: [libav-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

On 11/3/2017 4:42 PM, Luca Barbato wrote: > On 03/11/2017 19:23, Kieran Kunhya wrote: >> This patch fixes very high memory usage on pathological streams. > > this hunk seems spurious (and should not even compile with gcc). It does, but complains about mixed declarations and code. It's in any

Re: [libav-devel] [PATCH] matroskadec: don't warn about unknown spherical medata when none is present

On 11/2/2017 5:39 PM, Sean McGovern wrote: > Hi, > > On Nov 2, 2017 16:32, "James Almer" <jamr...@gmail.com> wrote: > > On 11/2/2017 5:12 PM, Sean McGovern wrote: >> Hi James, >> >> On Nov 2, 2017 10:03, "James Almer" <jamr...@gmail.

[libav-devel] [PATCH v2] matroskadec: don't warn about unknown spherical medata when none is present

track->video.projection.type is set to 0 (a Matroska specific "No spherical metadata present" value, with no related AVSphericalMapping) by default on files without the element. This removes bogus warnings on every single matroska file without Spherical metadata. Signed-off-by: Jame

Re: [libav-devel] [PATCH] matroskadec: don't warn about unknown spherical medata when none is present

On 11/2/2017 5:12 PM, Sean McGovern wrote: > Hi James, > > On Nov 2, 2017 10:03, "James Almer" <jamr...@gmail.com> wrote: > > track->video.projection.type is 0 by default, and is the value set by the > demuxer for files without the element. > > Si

Re: [libav-devel] [PATCH] matroskadec: don't warn about unknown spherical medata when none is present

On 11/2/2017 12:01 PM, Luca Barbato wrote: > On 02/11/2017 15:03, James Almer wrote: >> track->video.projection.type is 0 by default, and is the value set by the >> demuxer for files without the element. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >&

[libav-devel] [PATCH] matroskadec: don't warn about unknown spherical medata when none is present

track->video.projection.type is 0 by default, and is the value set by the demuxer for files without the element. Signed-off-by: James Almer <jamr...@gmail.com> --- libavformat/matroskadec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/matroskadec.c b/li

Re: [libav-devel] [PATCH 1/3] matroskadec: skip video projection parsing for non-spherical video streams

On 11/1/2017 11:10 PM, Sean McGovern wrote: > --- > libavformat/matroskadec.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index c6e1a19..3743d4d 100644 > --- a/libavformat/matroskadec.c > +++ b/libavformat/matroskadec.c >

Re: [libav-devel] [PATCH 5/9] build: Have libxvid depend on roundf() instead of providing a fallback

On 10/18/2017 1:42 AM, Diego Biurrun wrote: > On Tue, Oct 17, 2017 at 11:36:03PM -0300, James Almer wrote: >> On 10/17/2017 10:22 PM, Diego Biurrun wrote: >>> A private fallback roundf() implementation is not worth the trouble >>> for a fringe feature like libxvid encod

Re: [libav-devel] [PATCH 5/9] build: Have libxvid depend on roundf() instead of providing a fallback

On 10/17/2017 10:22 PM, Diego Biurrun wrote: > A private fallback roundf() implementation is not worth the trouble > for a fringe feature like libxvid encoding. Removing libxvid support from every MSVC <= 2012 build (and maybe also other compilers) to save six lines in an internal header seems a

Re: [libav-devel] [PATCH] configure: fix libxavs check

On 10/12/2017 2:17 PM, Diego Biurrun wrote: > On Thu, Oct 12, 2017 at 01:02:57AM -0300, James Almer wrote: >> libxavs may require pthreads and libm at link time, and without >> said ldflags available as global extralibs, the check will fail. >>

[libav-devel] [PATCH] configure: fix libxavs check

libxavs may require pthreads and libm at link time, and without said ldflags available as global extralibs, the check will fail. Regression since 7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63 Signed-off-by: James Almer <jamr...@gmail.com> --- I tried replacing the require()

Re: [libav-devel] [PATCH 01/10] configure: Drop feature for randomly disabling/enabling components

On 10/10/2017 8:07 PM, Diego Biurrun wrote: > On Tue, Oct 10, 2017 at 08:03:21PM -0300, James Almer wrote: >> On 10/10/2017 7:58 PM, Diego Biurrun wrote: >>> This feature was never used for anything. >> >> Was a fate client ever set with it? Because it's great t

Re: [libav-devel] [PATCH 01/10] configure: Drop feature for randomly disabling/enabling components

On 10/10/2017 7:58 PM, Diego Biurrun wrote: > This feature was never used for anything. Was a fate client ever set with it? Because it's great to find missing dependencies on new modules (be it configure deps, object entries in Makefile, or FATE test deps if you don't make it a build only run) by

Re: [libav-devel] [PATCH v2] cpu: split flag checks per arch in av_cpu_max_align()

On 9/15/2017 4:33 AM, Luca Barbato wrote: > On 14/09/2017 21:51, James Almer wrote: >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >>   libavutil/aarch64/cpu.c  |  9 + >>   libavutil/arm/cpu.c  |  9 + >>   libavutil/cpu.c  

Re: [libav-devel] [PATCH] avcodec/extract_extradata: return an error when buffer allocation fails

On 9/14/2017 4:51 AM, Luca Barbato wrote: > On 13/09/2017 22:07, James Almer wrote: >> ret is 0 by default. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >>   libavcodec/extract_extradata_bsf.c | 5 - >>   1 file changed, 4

Re: [libav-devel] [PATCH 1/2 v2] configure: add test_pkg_config()

On 10/3/2017 9:49 PM, Diego Biurrun wrote: > On Fri, Sep 29, 2017 at 10:56:08PM -0300, James Almer wrote: >> --- a/configure >> +++ b/configure >> @@ -1039,8 +1039,15 @@ check_pkg_config(){ >> pkg_libs=$($pkg_config --libs $pkg_config_flags $pkg) >> chec

Re: [libav-devel] [PATCH 2/2 v2] configure: use test_pkg_config() for the SDL check

On 10/2/2017 6:48 AM, Diego Biurrun wrote: > On Fri, Sep 29, 2017 at 10:56:09PM -0300, James Almer wrote: >> --- a/configure >> +++ b/configure >> @@ -4873,10 +4873,7 @@ fi >> >> # SDL is "special" and adds some CFLAGS that should not pollu

Re: [libav-devel] [PATCH 1/2 v2] configure: add test_pkg_config()

On 10/2/2017 6:49 AM, Diego Biurrun wrote: > On Fri, Sep 29, 2017 at 10:56:08PM -0300, James Almer wrote: >> --- a/configure >> +++ b/configure >> @@ -1025,8 +1025,8 @@ check_lib(){ >> >> -check_pkg_config(){ >> -log check_pkg_config "$@" &

[libav-devel] [PATCH 1/2 v2] configure: add test_pkg_config()

This helper is split off check_pkg_config(), setting only the pkg cflags and extralibs. This is useful for checks that don't require setting global cflags, or don't benefit from it. Signed-off-by: James Almer <jamr...@gmail.com> --- Now setting the correct name for the package's _

[libav-devel] [PATCH 2/2 v2] configure: use test_pkg_config() for the SDL check

Removes the extra code to preserve global cflags and extralibs. Signed-off-by: James Almer <jamr...@gmail.com> --- Removed the bogus avplay_extralibs line. It's added automatically as sdl is listed as a dependency of avplay. configure | 5 + 1 file changed, 1 insertion(+), 4 del

Re: [libav-devel] [PATCH 1/2] configure: add test_pkg_config()

On 9/29/2017 2:46 PM, James Almer wrote: > This helper is split off check_pkg_config(), setting pkg but not global > cflags and extralibs. This is useful for checks that don't require or > benefit from setting the latter. > > Signed-off-by: James Almer <jamr...@gmail.com> &g

[libav-devel] [PATCH 1/2] configure: add test_pkg_config()

This helper is split off check_pkg_config(), setting pkg but not global cflags and extralibs. This is useful for checks that don't require or benefit from setting the latter. Signed-off-by: James Almer <jamr...@gmail.com> --- configure | 16 1 file changed, 12 insertions

[libav-devel] [PATCH 2/2] configure: use test_pkg_config() for the SDL check

Removes the extra code to preserve global cflags and extralibs. Signed-off-by: James Almer <jamr...@gmail.com> --- configure | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/configure b/configure index b9b243362..36e2ca661 100755 --- a/configure +++ b/con

  1   2   3   4   >