Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-03-12 Thread Luca Barbato
On 12/03/2018 14:00, Diego Biurrun wrote: On Mon, Mar 12, 2018 at 12:11:22PM +0100, Luca Barbato wrote: --- /dev/null +++ b/libavcodec/libaomenc.c @@ -0,0 +1,583 @@ +// provide dummy value to initialize wrapper, values will be updated each _encode() +aom_img_wrap(>rawimg,

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-03-12 Thread Diego Biurrun
On Mon, Mar 12, 2018 at 12:11:22PM +0100, Luca Barbato wrote: > --- /dev/null > +++ b/libavcodec/libaomenc.c > @@ -0,0 +1,583 @@ > +// provide dummy value to initialize wrapper, values will be updated > each _encode() > +aom_img_wrap(>rawimg, ff_aom_pixfmt_to_imgfmt(avctx->pix_fmt), > +

[libav-devel] [PATCH] Support AV1 encoding using libaom

2018-03-12 Thread Luca Barbato
--- configure | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 +- libavcodec/avcodec.h | 4 + libavcodec/libaomenc.c | 583 + 5 files changed, 590 insertions(+), 1 deletion(-) create mode 100644

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-27 Thread Luca Barbato
On 27/02/2018 16:13, Vittorio Giovara wrote: On Tue, Feb 27, 2018 at 5:25 AM, Luca Barbato wrote: On 26/02/2018 18:21, Vittorio Giovara wrote: On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato wrote: --- + +if (avctx->qmin > 0) +

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-27 Thread Vittorio Giovara
On Tue, Feb 27, 2018 at 5:25 AM, Luca Barbato wrote: > On 26/02/2018 18:21, Vittorio Giovara wrote: > >> On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato >> wrote: >> >> --- >>> >>> + >>> +if (avctx->qmin > 0) >>> +enccfg.rc_min_quantizer =

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-27 Thread Luca Barbato
On 26/02/2018 18:21, Vittorio Giovara wrote: On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato wrote: --- + +if (avctx->qmin > 0) +enccfg.rc_min_quantizer = avctx->qmin; +if (avctx->qmax > 0) +enccfg.rc_max_quantizer = avctx->qmax; + +#if

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-26 Thread Vittorio Giovara
On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato wrote: > --- > > + > +if (avctx->qmin > 0) > +enccfg.rc_min_quantizer = avctx->qmin; > +if (avctx->qmax > 0) > +enccfg.rc_max_quantizer = avctx->qmax; > + > +#if FF_API_PRIVATE_OPT >

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-26 Thread Jean-Baptiste Kempf
Hello, On Mon, 26 Feb 2018, at 14:00, Diego Biurrun wrote: > > Since the bitstream will be frozen soon shouldn't hurt adding it. > > I'd prefer if you waited until it is actually frozen. I kind of disagree: It will take time to review. So, it is better to merge when patch is clean, with

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-26 Thread James Almer
On 2/26/2018 2:10 AM, Luca Barbato wrote: > --- > > Since the bitstream will be frozen soon shouldn't hurt adding it. > > configure | 1 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 +- > libavcodec/libaomenc.c | 602 >

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-26 Thread Luca Barbato
On 26/02/2018 14:00, Diego Biurrun wrote: On Mon, Feb 26, 2018 at 06:10:42AM +0100, Luca Barbato wrote: --- Since the bitstream will be frozen soon shouldn't hurt adding it. I'd prefer if you waited until it is actually frozen. Given the amount of nits you found (and that should be

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-26 Thread Diego Biurrun
On Mon, Feb 26, 2018 at 06:10:42AM +0100, Luca Barbato wrote: > --- > > Since the bitstream will be frozen soon shouldn't hurt adding it. I'd prefer if you waited until it is actually frozen. > configure | 1 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 +-

[libav-devel] [PATCH] Support AV1 encoding using libaom

2018-02-25 Thread Luca Barbato
--- Since the bitstream will be frozen soon shouldn't hurt adding it. configure | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 +- libavcodec/libaomenc.c | 602 + 4 files changed, 605 insertions(+), 1