Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-31 Thread Li, Zhong
> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Mark > Thompson > Sent: Wednesday, January 31, 2018 6:17 AM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure > issue > > On 30/01/18 03

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-30 Thread Mark Thompson
On 30/01/18 03:35, Song, Ruiling wrote: >> -Original Message- >> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of wm4 >> Sent: Friday, January 26, 2018 5:15 PM >> To: libav-devel@libav.org >> Subject: Re: [libav-devel] [PATCH] hwcontext

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-29 Thread Luca Barbato
On 30/01/2018 04:33, Song, Ruiling wrote: -Original Message- From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca Barbato Sent: Friday, January 26, 2018 9:26 PM To: libav-devel@libav.org Subject: Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-29 Thread Song, Ruiling
> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of wm4 > Sent: Friday, January 26, 2018 5:15 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure > issue > > On F

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-29 Thread Song, Ruiling
> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Friday, January 26, 2018 9:26 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure > issue >

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-26 Thread Luca Barbato
On 26/01/2018 12:04, Mark Thompson wrote: Thoughts? I can send the set again if that would be helpful. Please do :) I'm still afraid that we should add yet another call to query the number of surfaces needed by each component and then call the setup with the actual value once we have it...

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-26 Thread wm4
evel-boun...@libav.org] On Behalf Of > >>> Ruiling Song > >>> Sent: Friday, January 26, 2018 9:17 AM > >>> To: libav-devel@libav.org > >>> Subject: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure > >>> issue > >>> >

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-26 Thread Mark Thompson
AM >>> To: libav-devel@libav.org >>> Subject: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue >>> >>> From: "Ruiling, Song" <ruiling.s...@intel.com> >>> >>> 1.) the initial_pool_size need to be set instead of zer

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-26 Thread wm4
On Fri, 26 Jan 2018 05:56:46 + "Li, Zhong" <zhong...@intel.com> wrote: > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > > Ruiling Song > > Sent: Friday, January 26, 2018 9:17 AM > > To: libav-devel@libav.org > > Subject

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-26 Thread Maxym Dmytrychenko
+ as sort of default value is 32 I would check why frames_ctx->initial_pool_size or NumFrameSuggested cannot be used log message as a warning is a good idea. On Fri, Jan 26, 2018 at 9:42 AM, Luca Barbato wrote: > On 26/01/2018 02:16, Ruiling Song wrote: > >> +

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-26 Thread Luca Barbato
On 26/01/2018 02:16, Ruiling Song wrote: +ctx->initial_pool_size = 64; Maybe 64 could be defined with a self descriptive name or you might write a comment on why 64 is picked. The best solution would be adding the ability to query components before assembling the transcoding chain

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-25 Thread Li, Zhong
> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Ruiling Song > Sent: Friday, January 26, 2018 9:17 AM > To: libav-devel@libav.org > Subject: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue > > From: "Ruiling, Song"

[libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

2018-01-25 Thread Ruiling Song
From: "Ruiling, Song" 1.) the initial_pool_size need to be set instead of zero. 2.) the PicStruct is required by MediaSDK, so give a default value. A simple command to reproduce the issue: avconv -i INPUT -init_hw_device qsv=foo -filter_hw_device foo -vf