Re: [libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-12 Thread Hendrik Leppkes
On Sat, Aug 12, 2017 at 10:51 AM, Diego Biurrun wrote: > On Fri, Aug 11, 2017 at 12:37:00AM +0100, Mark Thompson wrote: >> --- /dev/null >> +++ b/libavcodec/h264_metadata_bsf.c >> @@ -0,0 +1,511 @@ >> + >> +typedef struct H264MetadataContext { >> +const AVClass *class; > >

Re: [libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:00AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/h264_metadata_bsf.c > @@ -0,0 +1,511 @@ > + > +typedef struct H264MetadataContext { > +const AVClass *class; Isn't the class member unused? Or did I just miss where this is used for logging?

[libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-10 Thread Mark Thompson
This is able to modify some header metadata found in the SPS/VUI, and can also add/remove AUDs and insert user data in SEI NAL units. --- The frame_rate option is renamed tick_rate to be more consistent with what is actually in the stream. Crop unit has been changed to pixels rather than the