Re: [libav-devel] [PATCH 1/6] avcodec/h264_slice: Also copy x264_build in ff_h264_update_thread_context()

[Anton Khirnov]

Quoting Vittorio Giovara (2017-06-16 00:56:11)
> From: Michael Niedermayer 
> 
> Fixes fate-h264-lossless
> 
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/h264_slice.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
> index c9f1dbb86f..0ce4127a1d 100644
> --- a/libavcodec/h264_slice.c
> +++ b/libavcodec/h264_slice.c
> @@ -408,6 +408,7 @@ int ff_h264_update_thread_context(AVCodecContext *dst,
>  // extradata/NAL handling
>  h->is_avc = h1->is_avc;
>  h->nal_length_size = h1->nal_length_size;
> +h->sei.unregistered.x264_build = h1->sei.unregistered.x264_build;
>  
>  memcpy(>poc,>poc,sizeof(h->poc));
>  
> -- 
> 2.13.1

This (and the following patch) is the wrong way to do it. H264SEI should
store the content of the last parsed SEI, other code should not mess
with it.

The right thing to do is maintain a copy of x264_build in H264Context.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 1/6] avcodec/h264_slice: Also copy x264_build in ff_h264_update_thread_context()

[Vittorio Giovara]

From: Michael Niedermayer 

Fixes fate-h264-lossless

Signed-off-by: Michael Niedermayer 
---
 libavcodec/h264_slice.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index c9f1dbb86f..0ce4127a1d 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -408,6 +408,7 @@ int ff_h264_update_thread_context(AVCodecContext *dst,
 // extradata/NAL handling
 h->is_avc = h1->is_avc;
 h->nal_length_size = h1->nal_length_size;
+h->sei.unregistered.x264_build = h1->sei.unregistered.x264_build;
 
 memcpy(>poc,>poc,sizeof(h->poc));
 
-- 
2.13.1

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel