Re: [libav-devel] [PATCH 5/9] build: Have libxvid depend on roundf() instead of providing a fallback

2017-10-18 Thread Luca Barbato
On 18/10/2017 03:22, Diego Biurrun wrote: A private fallback roundf() implementation is not worth the trouble for a fringe feature like libxvid encoding. --- configure| 2 +- libavutil/libm.h | 7 --- 2 files changed, 1 insertion(+), 8 deletions(-) I'd wait a little more for

Re: [libav-devel] [PATCH 5/9] build: Have libxvid depend on roundf() instead of providing a fallback

2017-10-17 Thread James Almer
On 10/18/2017 1:42 AM, Diego Biurrun wrote: > On Tue, Oct 17, 2017 at 11:36:03PM -0300, James Almer wrote: >> On 10/17/2017 10:22 PM, Diego Biurrun wrote: >>> A private fallback roundf() implementation is not worth the trouble >>> for a fringe feature like libxvid encoding. >> >> Removing libxvid

Re: [libav-devel] [PATCH 5/9] build: Have libxvid depend on roundf() instead of providing a fallback

2017-10-17 Thread Diego Biurrun
On Tue, Oct 17, 2017 at 11:36:03PM -0300, James Almer wrote: > On 10/17/2017 10:22 PM, Diego Biurrun wrote: > > A private fallback roundf() implementation is not worth the trouble > > for a fringe feature like libxvid encoding. > > Removing libxvid support from every MSVC <= 2012 build (and maybe

Re: [libav-devel] [PATCH 5/9] build: Have libxvid depend on roundf() instead of providing a fallback

2017-10-17 Thread James Almer
On 10/17/2017 10:22 PM, Diego Biurrun wrote: > A private fallback roundf() implementation is not worth the trouble > for a fringe feature like libxvid encoding. Removing libxvid support from every MSVC <= 2012 build (and maybe also other compilers) to save six lines in an internal header seems a

[libav-devel] [PATCH 5/9] build: Have libxvid depend on roundf() instead of providing a fallback

2017-10-17 Thread Diego Biurrun
A private fallback roundf() implementation is not worth the trouble for a fringe feature like libxvid encoding. --- configure| 2 +- libavutil/libm.h | 7 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/configure b/configure index 2008083617..2477086799 100755 ---