Re: [libav-devel] [RFC] Getting rid of the global log callback

2017-12-17 Thread Luca Barbato
On 17/12/2017 15:17, Rémi Denis-Courmont wrote: user_context may need a user_free(), Why oh why? For consistency and to avoid some ugly corner cases. There should be a point when the libavcodec user application can safely assume that the callback will no longer be used - e.g. when the

Re: [libav-devel] [RFC] Getting rid of the global log callback

2017-12-17 Thread wm4
On Sun, 17 Dec 2017 16:17:47 +0200 Rémi Denis-Courmont wrote: > Le sunnuntaina 17. joulukuuta 2017, 14.35.13 EET Luca Barbato a écrit : > > On 11/12/2017 14:48, wm4 wrote: > > > The log callback, set with av_log_set_callback(), is global mutable > > > state, and as such not

Re: [libav-devel] [RFC] Getting rid of the global log callback

2017-12-17 Thread Luca Barbato
On 11/12/2017 14:48, wm4 wrote: The log callback, set with av_log_set_callback(), is global mutable state, and as such not something we want in Libav, at all. but getting rid of it is very complicated, because in most cases, av_log() does not have enough context available to find per-context log

[libav-devel] [RFC] Getting rid of the global log callback

2017-12-11 Thread wm4
The log callback, set with av_log_set_callback(), is global mutable state, and as such not something we want in Libav, at all. but getting rid of it is very complicated, because in most cases, av_log() does not have enough context available to find per-context log callbacks. av_log() has a